Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website

2016-11-22 Thread kaputtnik
merged and committed. Thanks for the review :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/sitemap/+merge/310261 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands

2016-11-22 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544 This moves couple of seafaring

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building into lp:widelands

2016-11-22 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818 --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building into lp:widelands

2016-11-22 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_scaling into lp:widelands

2016-11-22 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/animation_scaling into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718 -- Your team Widelands Developers is subscribed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_scaling into lp:widelands

2016-11-22 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/animation_scaling. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building into lp:widelands

2016-11-22 Thread SirVer
Review: Approve lgtm. minor nits inlined. Diff comments: > > === modified file 'src/logic/map_objects/immovable.cc' > --- src/logic/map_objects/immovable.cc2016-11-03 07:37:58 + > +++ src/logic/map_objects/immovable.cc2016-11-17 08:29:59 + > @@ -340,8 +344,9 @@ >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website

2016-11-22 Thread SirVer
Review: Approve code lgtm. not tested. Diff comments: > > === added file 'sitemap_urls.py' > --- sitemap_urls.py 1970-01-01 00:00:00 + > +++ sitemap_urls.py 2016-11-18 15:44:53 + > @@ -0,0 +1,28 @@ > +from django.conf.urls import * > + > +from mainpage.views import mainpage >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_scaling into lp:widelands

2016-11-22 Thread SirVer
Review: Approve height(): ack. the other answered inline. Diff comments: > > === modified file 'src/graphic/animation.h' > --- src/graphic/animation.h 2016-10-25 08:14:28 + > +++ src/graphic/animation.h 2016-11-18 17:52:33 + > @@ -57,8 +58,17 @@ > } > > /// The

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/merge-b19-packaging into lp:widelands

2016-11-22 Thread GunChleoc
get-orig-source target: to obtain the most recent version of the original source package from an upstream archive. (Optional) More detailed description: https://wiki.debian.org/onlyjob/get-orig-source The appdata file is now necessary for the software centers - applications that don't have

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar_cleanup into lp:widelands

2016-11-22 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/toolbar_cleanup into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/toolbar_cleanup/+merge/35 -- Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar_cleanup into lp:widelands

2016-11-22 Thread GunChleoc
I'm not really sure at this point in time if there will be a general toolbar object at all - in the end, interactive_base will be the only object who has one, if I can turn the other potential toolbars into dropdown menus instead. I have started working on a draft mockup in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/animation_scaling into lp:widelands

2016-11-22 Thread GunChleoc
Yep, I'm not really happy with it either, but I don't have a better idea. I added 2 replies to your comment, please have a look. Diff comments: > > === modified file 'src/graphic/animation.h' > --- src/graphic/animation.h 2016-10-25 08:14:28 + > +++ src/graphic/animation.h 2016-11-18