[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands

2018-03-02 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow/+merge/339493 -- Your team

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-03-02 Thread GunChleoc
Regarding worker names, I came across "Brickmaker" on Wikipedia. Or maybe we can call him "Clay Mixer"? I think Brickmaker sound better though. -- https://code.launchpad.net/~widelands-dev/widelands/frisians/+merge/336910 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-pwd-security into lp:widelands

2018-03-02 Thread GunChleoc
Review: Approve 2 little nits, LGTM otherwise. Which algorithm would sou recommend instead of sha-1? If it's available on Django, we should consider changing the website too. Diff comments: > === modified file 'src/network/internet_gaming.cc' > --- src/network/internet_gaming.cc2018-02-04

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-02 Thread GunChleoc
Since we now have the same code repeated three times, how about having a function: BuildingHints::get_ai_limit(Widelands::AiType) const; And stick the limits in a std::map? -- https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands

2018-03-02 Thread GunChleoc
This is now blocking me, because I can't even see which file it is when I'm having a problem. So, I'll just merge it. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow/+merge/339493 Your team Widelands Developers is requested to review the

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-02 Thread bunnybot
Continuous integration builds have changed state: Travis build 3267. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/348424027. Appveyor build 3076. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_2_new_h

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-pwd-security into lp:widelands

2018-03-02 Thread bunnybot
Continuous integration builds have changed state: Travis build 3266. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/348394484. Appveyor build 3075. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_net_pwd_s

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands

2018-03-02 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/ai_2_new_hints into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_2_new_hints/+merge/340548 Brings two new ai hints like: normal_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-pwd-security into lp:widelands

2018-03-02 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/net-pwd-security into lp:widelands. Commit message: Increasing password security by no longer storing and transmitting it in plaintext. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_201802 into lp:widelands

2018-03-02 Thread bunnybot
Continuous integration builds have changed state: Travis build 3262. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/348112516. Appveyor build 3071. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_compiler_wa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-03-02 Thread hessenfarmer
thanks for doing all the hard work. I was watching a lot of AI vs AI games in the meantime and I have some suggestions for better AI Behaviour with the frisians, but this should not stop merging as we can easily tune this later as well. However the frisians need a lot of barley, much reed and m

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unlink_test_richtext into lp:widelands

2018-03-02 Thread bunnybot
Continuous integration builds have changed state: Travis build 3261. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/348111566. Appveyor build 3070. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_unlink_tes

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-03-02 Thread Benedikt Straub
Sorry for not responding earlier, it was a busy week. I changed the scenarios according to the comments, fixed the bug in collectors, and changed the buildcosts for the armor smithies so the upgrade is now a bit cheaper than a new small one. I renamed the brick burners house to brick kiln. There

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-03-02 Thread R M
Kiln would be a better description for the building, brick maker might also be better for the worker. On an associated item the clay pit worker is also a clay burner, I was of the opinion that he was at one time a clay digger. With the claypit having water as an input, together with the ground

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/frisians into lp:widelands

2018-03-02 Thread GunChleoc
I'm working on translating the glossary entries and came across a common word: "brick kiln". I'm in favor of renaming the brick burner's house. -- https://code.launchpad.net/~widelands-dev/widelands/frisians/+merge/336910 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/w