[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4418. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/485117314. Appveyor build 4208. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18115

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread kaputtnik
Oh, thanks for the hint regarding broadcast(), just forgot it. About coroutines.lua: I do not know which function is NOT used for all players at the same time. I guess those functions are the functions called when a particular user action is triggered, and i think that are all the functions in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread Notabilis
I haven't tested it but the code is looking good, thanks. Regarding the documentation: Please update the documentation of win_condition_functions::broadcast() since it no longer waits for roadbuilding. Also, could you add a comment in coroutines.lua (similar to ui.lua)? In multiplayer, these met

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread Toni Förster
Review: Approve proof reading -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread kaputtnik
I have removed the link to bug 1721126, because of https://bugs.launchpad.net/widelands/+bug/1721126/comments/27 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands

2019-01-27 Thread kaputtnik
Review: Approve code review LGTM :-) Approve this, but i want to have GunChleoc to take a look at my glorious English wording ;) Of course some one else with knowledge of English can do this also. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge