Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I agree that the warnings are annoying, but I don't know how to fix them - there are no obvious encoding errors. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Thanks :-) But i think we should keep this in mind if there is some trouble with String related things and i believe it's nevertheless a bad thing. F.e. i got some errors/warnings when installing in archlinux from the Archlinux user Respository (AUR). These errors/warnings are shown when a

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/revised_maps into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 -- Your team Widelands Developers is subscribed to bra

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

> Where does this ALTGR+SHIFT+n - apostroph comes from? It comes from your guideline to use proper typography in UI strings that I introduced 2 years ago. I am generating the characters with LibreOffice, so there is no reason why they shouldn't be a legal typographical apostrophe or closing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I believe it's the apostroph ' vs. ’ (ALTGR+SHIFT+n) Part from the original String from elemental file. This contains the ALTGR+SHIFT+n - apostroph: >>> "For centuries, you’ve lived peacefully side by side".decode('ascii') Traceback (most recent call last): File "", line 1, in

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Continuous integration builds have changed state: Travis build 909. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/119327477. Appveyor build 741. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

ASCII is a subset of Utf-8. I am unsure what bunny it keeps complaining about here :/. > Am 29.03.2016 um 18:26 schrieb kaputtnik : > > I don't know why but most files are encoded in ASCII Text and one file > contains obviously a bad character. > > I will try to find it. > >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

But there are a mix of encodings. Go to your folder where current trunk /data/maps is stored and run: find -name "elemental" -exec file {} \; The output is something like: ./The_Far_North.wmf/elemental: UTF-8 Unicode text, with very long lines

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Everything should be UTF-8, so we can use curly quotes etc. The culprit is probably Archipelago_Sea. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I think i have found it already: The elemental file of "Islands_at_War" contains at column 27 an apostrophe (') and the file is encoded in UTF8. Loading this map into the editor and open the map options the apostrophe is converted to ’ (on linux with ALTGR+SHIFT+n) instead of the one on the key

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I don't know why but most files are encoded in ASCII Text and one file contains obviously a bad character. I will try to find it. Is it normal to have a mix of ASCII and UTF8 encoded files? File edited by me are UTF8, this is normal for a linux BS, but all files created by widelands are

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Bunnybot encountered an error while working on this merge proposal: 'ascii' codec can't decode byte 0xe2 in position 27: ordinal not in range(128) -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Bunnybot encountered an error while working on this merge proposal: 'ascii' codec can't decode byte 0xe2 in position 27: ordinal not in range(128) -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I agree, let's merge this. This will give us a higher chance that somebody will encounter any bugs. I also tested Trident of Fire, which is working fine :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Review: Approve playing OK, I tried (got tired) of the nile, I think we should merrge this now. Next time we should do this for single maps only. I check some code, but not all, as I have no Idea what to check for. So lets get his merged so we can check for single problems/bugs later. If there

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

You didn't work on the scenarios in this branch, so no need to worry about them here. The only scenario still untested is Trident of Fire - tree growth could be compared in single player mode (= without the scenario scripts). The scenario scripts themselves need to be tested in multiplayer

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Klaus, i don't know what your intend to doing... If a shipped map is loaded in Game or Editor, the changes of this branch does not take any effect anymore. The only exception are maybe the scenarios (but i don't understand them at all :-( ). --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Archipelago works for Atlanters, so it should work for pretty every tribe. Ill try another Map the next days. One of the three AIs was able to develop at least a bit. You will need horses (ochsen, donkeys) in the long term however --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Mhh, I found #1562332 again, but this is yet another other Issue, can someone elese reproduce this? -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Found a crash after playing archipelago for quite a while, the game crashed when I quit, but I had not time to check yesterday. But that should not be related to this branch, I think. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Review: Approve Looking good :) -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Thanks! Yes, it would be better if the localization tags were written - it's not triviel though. Time for a wishlist bug? -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I just saw that einstein wrotes the suggested teams in the "Uploader comment" of the website. I add the information to the shipped maps. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

> The Nile has lost its suggested teams - is that on purpose? We should ask einstein if the old suggested teams are still valid for the new map. Thanks for proofreading and the fixes :-) Shouldn't the localization macro not be set automatically when saving a map? --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

I am done proofreading. I also made sure that all the maps will load in a singleplayer game without errors. The Nile has lost its suggested teams - is that on purpose? Next time, please use bzr mv to rename directories, this is very hard to diff. There might be more that I have missed. I am

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Continuous integration builds have changed state: Travis build 882. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/117677456. Appveyor build 716. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Bunnybot encountered an error while working on this merge proposal: HTTP Error 500: Internal Server Error -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Review: Resubmit Should all be fine now. I would ask someone else to test the scenario maps because i am not familiar with those. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Continuous integration builds have changed state: Travis build 880. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/117543177. Appveyor build 714. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

Review: Needs Fixing Hm, i have to go over some maps again, because Map options -> Author is meant to be smart and replaces "," with "&". So something like "Nasenbaer, edited by king_of_nowhere" gets "Nasenbaer & edited by king_of_nowhere" :-( I have to recheck the scenario maps also. --