Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-13 Thread toptopple
Btw, is the C++ system applied for Widelands using garbage collection? I looked through some code in defaultai.cc and didn't find any free-memory operations so far, e.g. after local list creations. -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Wide

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-13 Thread toptopple
I tested my proposed logic on a "one-world" island and it turned out the expedition found portspaces in secondary access although it doesn't per-se perform secondary island circling. This is because the map is a torus and the ship is reflected only onto the island again under various angles and

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-12 Thread TiborB
I see you had posted new map (nice one) and I hope you tested this branch on this map and found it better than current implementation in trunk... I see two border scenarios 1. Multiple islands with one port on each of them 2. One land = one sea - with multiple ports on them (here I am not sure

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread toptopple
@Tibor The solution currently implemented leads to retardment of exploration; ships over and over again explore the already explored islands. This is something AI cannot afford on larger maps with many and/or far away islands, it already harbours a tendency to be very late with sea expeditions.

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread GunChleoc
@Tibor: no worries, you don't have to. Your advice will get us there :) -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the proposed merge of lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. __

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread bunnybot
Bunnybot encountered an error while working on this merge proposal: Running 'git pull' failed. Output: fatal: No remote repository specified. Please, specify either a URL or a remote name from which new revisions should be fetched. -- https://code.launchpad.net/~7010622-q/widelands/topple-seaf

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread TiborB
@Gun I am not that eager to work on this now :(, but I am willing to support toptopple :) re: "You can aid the reformation by adding another call to "expedition_management()" in the case where both holds true: a) ship sails in modus "circle island", b) ship hits a spot which has been noted as "

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread GunChleoc
toptopple, if you change the branch owner ("Change branch Details" link on the top left) wo widelands-dev, you can both work on the branch together :) -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the prop

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread TiborB
iterating over existing portspaces makes sense, because: - the ship does not pick first portspace it finds, but picks good one with some randomness, next time it visit the portspace it can decide to build a port there - When all existing portspaces are know, the ship can still pick one of them to

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-11 Thread toptopple
It does a job though! :) >Well, current logic was that if known portspace is found, the ship with >probability of 50% search for open sea and if found it sails this direction. >Otherwise it sail (keep on sailing) around the current land. One of the points is that this procedure is also activate

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
Well, current logic was that if known portspace is found, the ship with probability of 50% search for open sea and if found it sails this direction. Otherwise it sail (keep on sailing) around the current land. I was afraid that ship can end up in a kind of ping-pong between two ports - but this

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
and yes, current expedition logic is really very primitive -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the proposed merge of lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. ___

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 1587. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/174511687. Appveyor build 1425. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_7010622_q_widelands_topple_seafari

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread toptopple
repeat_island_prob is a repetition probability polled when a ship hits an island at a spot which was encountered before. So it is quaranteed that an island is at least circled once (when being found). repeat_island_prob is not a cessation probability, which it would have to be to justify your c

Re: [Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread TiborB
in regard to repeat_island_prob - so once the ship is on a coast of he will circle around it forever and never leave it to search for other lands/islands? -- https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Your team Widelands Developers is requested to review the

[Widelands-dev] [Merge] lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands

2016-11-09 Thread toptopple
toptopple has proposed merging lp:~7010622-q/widelands/topple-seafaring-1 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436 Expedition strategy is quite weak at pre