Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2016-01-06 Thread GunChleoc
I have created a bug for the packages that we should look at: https://bugs.launchpad.net/widelands/+bug/1531463 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1526903. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2016-01-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1526903 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2016-01-05 Thread TiborB
I believe that I can merge it @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1526903. ___ Mailing list: https://la

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2016-01-04 Thread GunChleoc
> But there is another issue with the number of players: Open editor, open "set > players", set number of players to two but place only one player to the map. > Save the map and after reload the map the "set player" window will always show > two players. If you try to start a game with this map, a

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-30 Thread TiborB
>Fatal exception: Widelands could not start the game, because player 2 has no >starting position. You can manually add a starting position with the Widelands Editor to fix this problem. For me this is "unfinished map" not a "bug". -- https://code.launchpad.net/~widelands-dev/widelands/bug-15269

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-30 Thread TiborB
> Could you go through the map saver and have a look at other packets that we > don't need? There is couple of sections we can discuss, or perhaps can be ommited for saving in editor: log("Writing Flag Data ... "); log("Writing Road Data ... "); log("Writing Map Objects ... "); - this is probab

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-30 Thread kaputtnik
Review: Approve I couldn't trigger any of the errors described in the related bug reports anymore :-) The file "allowed_building_types" is never been created. So for this it seems to be fixed and i give approve for testing. But there is another issue with the number of players: Open editor, op

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-30 Thread kaputtnik
We should check the player directory... but i am unsure if it is needed for scritping. Maybe wl_zocker could tell us. I will test this branch... -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 Your team Widelands Developers is requested to review the proposed mer

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-30 Thread GunChleoc
Could you go through the map saver and have a look at other packets that we don't need? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1526903 into lp:wid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-29 Thread TiborB
The diff looks bit complex, but really only thing that was added is: if (is_a(Game, &m_egbase)) { } -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-152

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526903 into lp:widelands

2015-12-29 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1526903 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1526514 in widelands: "player 2 in "" section [player_2] not found" https://bugs.launchpad.net/widelands/+bug/1526514 Bug #1526