The proposal to merge lp:~widelands-dev/widelands/bug-better-syncstreams into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
--
Your team Widelands Develop
Looks good to me, let's have it!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-better-syncstreams.
I have done some similar testing. I'd like to see a few changes:
1. WLApplication:cleanup_replays() does not clean up old wse files
2. There are no instructions in the Python script.
I'd like to at least see a usage hint when it's called without parameters.
--
I tested(?) it by enforcing a desync (modifying player.cc and using std::rand()
as ID for new economies, then changing economy targets ingame). The new *.wse
files were created and could be parsed by the python script. No idea what else
can be tested.
--
Review: Approve
Code LGTM, not tested
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-better-syncstreams.
___
Mailing
As far as I am concerned, this branch is ready for review and merge now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-better-syncstreams
The proposal to merge lp:~widelands-dev/widelands/bug-better-syncstreams into
lp:widelands has been updated.
Description changed to:
[Ready for review and merge]
Since I am not really able to get useful information out of the existing
syncstream files, this branch adds further information
The proposal to merge lp:~widelands-dev/widelands/bug-better-syncstreams into
lp:widelands has been updated.
Commit message changed to:
Print more information in syncstreams. Create additional smaller syncstream
files containing the last few seconds leading to a desync.
For more details, see
// u32 bob serial
> + // s16 position x
> + // s16 position y
> + constexpr uint8_t BobSetPosition = 0xB8;
> +}
> +
> class Player;
> class MapLoader;
> class PlayerCommand;
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstream
attle = 0xA8;
> + // bob.cc Bob::set_position()
> + // u32 bob serial
> + // s16 position x
> + // s16 position y
> + constexpr uint8_t BobSetPosition = 0xB8;
> +}
> +
> class Player;
> class MapLoader;
> class PlayerCommand;
-
er = struct.unpack(' + if playernumber < 0:
> + print(" as client")
> + else:
> + print(" as host, desynced client = %i" % playernumber)
> + byte = f.read(1)
> + while byte:
> + # Parse byte
> +
/_widelands_dev_widelands_bug_better_syncstreams-4201.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-better-syncstreams into lp:widelands
/_widelands_dev_widelands_bug_better_syncstreams-4200.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-better-syncstreams into lp:widelands
-better-syncstreams/+merge/361922
Not ready for review and merge yet, only starting merge request for Windows
builds.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-better-syncstreams into lp:widelands.
=== modified file 'data/tribes
14 matches
Mail list logo
