The proposal to merge lp:~widelands-dev/widelands/gcc531 into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
--
Your team Widelands Developers is subscribed to branch
lp:~wideland
All clear :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list: https://launchpad.net/~widelands-dev
Review: Approve
OK, for me with _my_ change, but gcc may complain again?
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing
Continuous integration builds have changed state:
Travis build 1078. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/127169362.
Appveyor build 909. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_gcc531-909.
I didn't check the datatype ;)
Diff comments:
>
> === modified file 'src/map_io/map_players_view_packet.cc'
> --- src/map_io/map_players_view_packet.cc 2016-02-16 10:27:23 +
> +++ src/map_io/map_players_view_packet.cc 2016-05-01 10:05:57 +
> @@ -991,12 +991,12 @@
>
Replied to a diff comment.
Diff comments:
>
> === modified file 'src/map_io/map_players_view_packet.cc'
> --- src/map_io/map_players_view_packet.cc 2016-02-16 10:27:23 +
> +++ src/map_io/map_players_view_packet.cc 2016-05-01 10:05:57 +
> @@ -991,12 +991,12 @@
>
Might be Ubuntu-sepecific numbering.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list: https://launchpad.net/~widelan
That's what my gcc --version says.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list: https://launchpad.net/~widelands
GCC 5.3.1 ?
It is not listed on https://gcc.gnu.org/ ...
--
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc531.
___
Mailing list: https://la
Replied to the comments.
Diff comments:
> === modified file 'src/logic/queue_cmd_factory.cc'
> --- src/logic/queue_cmd_factory.cc2016-01-18 05:12:51 +
> +++ src/logic/queue_cmd_factory.cc2016-05-01 10:05:57 +
> @@ -112,7 +112,7 @@
> case QueueCommandTypes::kReplaySyncRead:
>
Continuous integration builds have changed state:
Travis build 1072. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/127005091.
Appveyor build 903. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_gcc531-903.
Review: Needs Information codereview, compile
I now get some (new?) clang warning, see inline comments.
Shall I commit the change?
Diff comments:
> === modified file 'src/logic/queue_cmd_factory.cc'
> --- src/logic/queue_cmd_factory.cc2016-01-18 05:12:51 +
> +++ src/logic/queue_cmd_facto
GunChleoc has proposed merging lp:~widelands-dev/widelands/gcc531 into
lp:widelands.
Commit message:
Fixed some compiler warnings with gcc 5.3.1.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/29
13 matches
Mail list logo
