[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/lua-driven-help into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 -- Your team Widelands Developers is subscri

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Thanks for testing again and for the suggestion :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Review: Approve testing I couldn't trigger the error anymore by open several programs/images and afterwards start this branch. So i think Miroslav has found and fixed the error :-) All looks good now and this would be a really great enhancement to widelands. There is only one small thing:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Review: Resubmit All the points that you raised should be fixed now :) -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

I didn't have time yesterday to merge the new trunk, so anything that was fixed in the about branch is still not fixed in this branch. What I'm primarily interested in right now is that the crash is gone - I'll merge trunk and work on splitting up the "general" entries to make the general help

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Seems like bunnybot don't like one of the new maps :-D I am looking into this but currently i don't know what causes this bunnybot bug (except my guess on the apostrophe). Some things which should be fixed with the "about" branch are still in this branch (r7906). F.e. "C: Shows Census" in

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Bunnybot encountered an error while working on this merge proposal: 'ascii' codec can't decode byte 0xe2 in position 27: ordinal not in range(128) -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Thanks! I have merged the fix now. Is this ready to go in? -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Fix in lp:~widelands-dev/widelands/luatable-stack-fix. -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mailing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

OK, updating eris doesn't help - the bug is somewhere else. -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Updating eris will invalidate all savegames Most likely though. > Am 28.03.2016 um 12:55 schrieb GunChleoc : > > Yes, we could try that. Good idea :) > -- > https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 > You are subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Yes, we could try that. Good idea :) -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

What about bug 1543001 (update eris)? Is it sure that this bug isn't already in trunk somewhere? -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

The problem is triggered in the line std::unique_ptr table(lua_->run_script(entry.script_path)); and the crash happens somewhere in eris. I have no idea why. I tried all kinds of things, and I'm out of ideas. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

As i understand the "double free or corruption (!prev)" failure happens because of trying to free memory which is already been freed former. And i have the feeling that the crash is mostly triggered when much memory (RAM) is consumed/newly assigned through some other programs. So i tried to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

> This is really strange i restarted widelands about 25 times without any > crash until my last post. So the first crashes i encountered was kind of > "luck" :-D Is there a possibility to have a bashscript to make automatic > tests? Not easily - first, we would need to add a test to the test

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

> I got different segfaults... so i think it's not related not this branch. On > the other side i had no trouble with other programs, so i think it's not my > computer which causes such segfaults. Annoying was that the segfaults are > irreproducable, sometimes there was no segfault. Because there

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

This is really strange i restarted widelands about 25 times without any crash until my last post. So the first crashes i encountered was kind of "luck" :-D Is there a possibility to have a bashscript to make automatic tests? --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Sorry, i got a crash now on my Laptop after some restarts of widelands: *** Error in `./widelands': double free or corruption (!prev): 0x06a0dd90 *** I do always start widelands, open editor, click help. No crash -> leave widelands and start again. There is definitely something wrong

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

I got different segfaults... so i think it's not related not this branch. On the other side i had no trouble with other programs, so i think it's not my computer which causes such segfaults. Annoying was that the segfaults are irreproducable, sometimes there was no segfault. Because there is no

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

I did get some segfaults while developing this branch, but I thought I had sqashed them all. This one looks completely different though. Since your crash won't reproduce anymore, do you think that this branch is good to go now? --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

No crash here -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Hm... i compiled this branch on another mashine and couldn't trigger such segfaults anymore. Maybe there was a malfunction on my other maschine used yesterday? Next Monday evening i could test on the faulty computer again and will approve when i found no such segfaults anymore :-) --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Review: Needs Fixing During compiling i got some hints about too long lines. On first run i choosed "Editor" and pressing the Help button the editor segfaults: *** Error in `./widelands': double free or corruption (!prev): 0x0452cfc0 *** A Backtrace from widelands (not gdb) could be

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Thanks! When you have some time, could you have a look at the "About" branch too? It has already been tested. I am thinking of creating a new text domain for the editor help, I might still do that in the other branch. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Review: Approve Looks nice, though I am not able to understand all the code; also I see you added regression tests - great Anyway, somebody should compile and test it... Approving the code -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/lua-driven-help into lp:widelands. === added file 'data/scripting/editor/editor_help.lua' --- data/scripting/editor/editor_help.lua 1970-01-01 00:00:00 + +++ data/scripting/editor/editor_help.lua 2016