The proposal to merge lp:~widelands-dev/widelands/map_compatibility into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
--
Your team Widelands Developers is subscribed t
gonna merge this now - has been sitting for a while without code review and I
have confirmation that it works on tests. Travis did not run the latest
revision - which is green on my system.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Y
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
The read operation timed out
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
_
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
The read operation timed out
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
_
Awesome! Thanks for testing. I am waiting on a code review before submitting.
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
_
Travis is failing due to this bug:
https://github.com/travis-ci/packer-templates/issues/220
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
__
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
___
Review: Approve testing
Sorry i didn't noticed that you have updated the branch. The crashs are gone :-)
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_compatibility.
_
Review: Needs Fixing
I got a crash with this branch when trying to save a game:
1. Start a normal game and trying to save:
Fatal exception: ZipFilesystem::open_for_unzip: not a .zip file:
/home/kaputtnik/.widelands/save/campvis
Game: Writing Preload Data ... GameSaver::save() took 3ms
SaveHandle
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Continuous integration builds have changed state:
Travis build 1262. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/152100138.
Appveyor build 1104. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_map_compati
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
Bunnybot encountered an error while working on this merge proposal:
''
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/302869
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:wideland
The proposal to merge lp:~widelands-dev/widelands/map_compatibility into
lp:widelands has been updated.
Commit Message changed to:
Fixes loading of old maps.
- Do not load objective data in the editor. Objectives are now only used in
savegames, so no need to try loading it into the editor.
- I
SirVer has proposed merging lp:~widelands-dev/widelands/map_compatibility into
lp:widelands.
Commit message:
Fixes loading of old maps.
- Do not load objective data in the editor. Objectives are now only used in
savegames, so no need to try loading it into the editor.
- In the old days, we requ
The proposal to merge lp:~widelands-dev/widelands/map_compatibility into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
--
Your team Widelands Developers is subscribed
We have updated Together We're Strong because of the artifacts, so you will
need to grab the map from Build 18.
I actually want to take a different approach to this: Rather than putting the
compatibility code back in, only load needed packages in the editor. So, this
branch is now only sitting
Review: Needs Information
Is there a way I can trigger the bug this is trying to fix in trunk? Together
we're strong loaded just fine in the editor for me and so did every other
shipped map I tried.
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team
Bunnybot encountered an error while working on this merge proposal:
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:widelands.
Bunnybot encountered an error while working on this merge proposal:
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map_compatibility into lp:widelands.
I agree - the code control flow is a bit complex though, so I have to find out
how to pull this off. I think that this sill probably best done in a fresh
branch.
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team Widelands Developers is requested to
So this fix is to allow editing of old maps? And all what is needed to edit
them is to remove some directory from wmf archive? Then I would not reintroduce
logic that was removed, but just left it unfixed or put an info in error test
saying what should be done to make the map loadable in editor
Yes, I would like that - you obviously know a lot more about the map loading
code than I do. Would you like to take this on?
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team Widelands Developers is requested to review the proposed merge of
lp:~wide
Hi GunChleoc,
okay, I see the problem - in this case it's the files below "player" in the map
directory. Which aren't loaded when starting a game anyways - that's why the
error is triggered in the editor, but not when starting a new game.
Speaking of "Together we're strong" - for some reason I
Hi Nasenbaer,
the history here is that I recently removed all savegame compatibility code. I
assumed te same thing that you do, thet maps would not know about buildings,
workers etc. Turns out they do, so we get cpmpatibility problems with maps. I
think one of he problematic maps was Together W
Hi GunChleoc,
Looking at the changes, I was wondering what kind of problems were faced - I
wasn't monitoring the project for roughly 1,5 years, so I am a not that up to
date, sorry.
Is there one or more bug reports explaining the problem?
Is this merge request about savegames or about maps? I a
GunChleoc has proposed merging lp:~widelands-dev/widelands/map_compatibility
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
There is a problem with loading ol
53 matches
Mail list logo
