The proposal to merge lp:~widelands-dev/widelands/test-ngettext into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
--
Your team Widelands Developers is subscribed to branch
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Mailing list: https://launchpad.net/~widel
Review: Approve compile / regression / review / check f1-help
Fine for me.
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Mailing list: https://launchpad.net/~widelan
Review: Resubmit
Done :)
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Mailing list: https://launchpad.net/~wide
The proposal to merge lp:~widelands-dev/widelands/test-ngettext into
lp:widelands has been updated.
Commit Message changed to:
Revised Lua ngettext to allow only unsigned integers. Created test for lua
gettext functions.
For more details, see:
https://code.launchpad.net/~widelands-dev/wideland
Ok, sounds good to me.
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
___
Mailing list: https://launchpad.net/~widelan
Because the units appear in a longer sentence, I am in favour of having long
unit names rather than symbols. Let's disallow the float and remove the
placeholders. I can do that in his branch.
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands D
I fully agree with GunChleoc regarding Klaus' post. In Slovak we would say
"twenty-five whole (ones) (and) six tenths of a second" and write "25,6
sekundy", where "sekundy" is the genitive case form of the word second. That's
why a special plural form is needed.
As for the merge request, I will
> > Floating point numbers can also become integers
> I don't see how that is relevant, what's it in response to?
Let's say the value is currently 25.5 - then you would need to translate "%d
seconds" with the floating point translation in Slovak. If the value changes to
25, you would need to cha
Natural Languages normally have no idea about floating point numbers. But they
can use fractions (will be ready in half a minute, can be done in a quarte of
an hour). Some progress messages use phrases like "less then 5 seconds
remaining" or "estimating 20 min for the Installation".
So we shoul
> Floating point numbers can also become integers
I don't see how that is relevant, what's it in response to?
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/test-ngettext.
_
Floating point numbers can also become integers - how about we extend the %s
second(s) translations to the actual numbers? On the other hand, we also have a
translation memory with fuzzy matches now, so pulling similar strings from the
Suggestions tab in Transifex shouldn't take that long...
--
> Maybe we could write a wrapper that will map floating point numbers to the
> appropriate integer numbers for the languages in our list, and then use those
> integers to call ngettext?
That wouldn't work for Slovak, because floats need their own, different form.
There is nothing to map to.
> Th
The actual rule for Scottish Gaelic is to discard everything after the .,
because we say "x seconds point y" for x.y seconds.
Not having things correct for Slovak doesn't please me though.
Maybe we could write a wrapper that will map floating point numbers to the
appropriate integer numbers for
According to the gettext manual, "a simple gettext call with a form suitable
for all values will do"[1] -- something like http://pastebin.com/raw/R2tGW9XH.
The CLDR tables[2] clearly disprove this rule being universal, though.
Flooring produces incorrect results for Slovak and I bet a lot of oth
An example:
"If the food supply is steady, this mine can produce iron ore in %s on average."
%s is replaced by "%d second(s)", and %d can become floating point.
The floor is what we have always had implicitly (and it also happens to be what
my particular language does), so there is no change in
Review: Approve compile, regressiontest.py +/-
Having more tests is always good and the code looks OK for me.
test-ngettext klaus$ ./regression_test.py -b ./widelands
OTOH Miroslav question is valid, where or when do we need to show someting like
"You have 3.145972 Item(plurals) in you Inventory
Continuous integration builds have changed state:
Travis build 1000. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/122450845.
Appveyor build 833. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_test_ngette
I'm not a fan of flooring the number in our C++ code. Passing a non-integer
value to ngettext from Lua should result in an error (no idea what crashes
you're talking about), IMO.
Where do we need to pass floats?
--
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/+merge/291587
GunChleoc has proposed merging lp:~widelands-dev/widelands/test-ngettext into
lp:widelands.
Commit message:
Created test for lua gettext functions.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/test-ngettext/
21 matches
Mail list logo
