https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #69 from Daniel Kinzler 2012-08-27
13:17:20 UTC ---
Possibly related (may cause premature commits, though I don't see how it could
trigger this exact problem): I80faf2ed
To avoid the issue of premature commits and general transact
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #68 from Jarry1250 2012-07-23 08:50:05 UTC ---
Did we apply a fix retrospectively in the end?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You ar
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Aaron Schulz changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #67 from Aaron Schulz 2012-07-21 18:42:44
UTC ---
I've fixed DATA_FOR_UPDATE loading in
https://gerrit.wikimedia.org/r/#/c/16228/.
I've replaced the 'forupdate' loading with 'fromdbmaster' in EditPage in
https://gerrit.wikimedia.o
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #66 from Platonides 2012-07-12 07:31:26 UTC
---
That's the exception added by Aaron. It's better to throw such exception than
producing this bug.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #65 from Liangent 2012-07-12 05:28:59 UTC ---
It seems the isolation between different edits or actions which creates
revision has been removed, and this introduces another (maybe more severe) bug:
if two such requests are sent simu
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #64 from Alexandre Emsenhuber [IAlex]
2012-07-11 18:35:09 UTC ---
So first my apologies to have caused this bug with Gerrit changeset #6079. I
did already mentioned MySQL's "consistent read" feature there, but I did not
see that pr
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #63 from christ...@quelltextlich.at 2012-07-11 17:53:28 UTC ---
Seems Aaron provided a hotfix while I prepared the logs for uploading
in the previous comments :D
But towards his order of a "more ideal solution" ...
it seems the culp
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #62 from Aaron Schulz 2012-07-10 00:03:16
UTC ---
Note that an exception is now thrown per comment 56. This should not be
occurring anymore. A more ideal solution is still in order.
--
Configure bugmail: https://bugzilla.wikimedi
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #61 from christ...@quelltextlich.at 2012-07-09 23:54:07 UTC ---
Created attachment 10836
--> https://bugzilla.wikimedia.org/attachment.cgi?id=10836
SQL logs taken, while the bug occurs
--
Configure bugmail: https://bugzilla.wikim
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
christ...@quelltextlich.at changed:
What|Removed |Added
CC||christ...@quelltextlich.at
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Ariel T. Glenn changed:
What|Removed |Added
CC||ar...@wikimedia.org
--- Comment #58 f
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #57 from Liangent 2012-07-07 05:48:01 UTC ---
(In reply to comment #56)
> I did some more live debug logging.
>
But why is doEdit() called more than once? per previous comments, this also
happens to bot edits.
--
Configure bugma
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #56 from Aaron Schulz 2012-07-06 22:19:17
UTC ---
I did some more live debug logging.
I see things like:
2012-07-06 22:05:50 mw69 frwiki: Could not load rev 80557024 for Bargen (Berne)
[208044].
2012-07-06 22:02:57 mw68 itwiki: Co
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #55 from lex ein 2012-07-01 06:06:27 UTC ---
(In reply to comment #54)
> ... the title of this bug is misleading ...
I see the title was nicely expanded. Thx.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Platonides changed:
What|Removed |Added
Summary|Several history entries for |Several history entries for
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #54 from lex ein 2012-06-30 20:56:45 UTC ---
(In reply to comment #50)
> Bumping down priority to "high". This problem is annoying,
This bug is more than merely annoying, it's needlessly alarming to editors. Bug
38086 - a reported
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
duplicate...@googlemail.com changed:
What|Removed |Added
Priority|High|Highest
C
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
duplicate...@googlemail.com changed:
What|Removed |Added
CC||lexei...@yahoo.com
--- Co
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
duplicate...@googlemail.com changed:
What|Removed |Added
CC||k...@ktchan.info
--- Comm
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Rob Lanphier changed:
What|Removed |Added
Priority|Highest |High
--- Comment #50 from Rob Lanphier
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #49 from Platonides 2012-06-25 15:33:26 UTC
---
1.20wmf4 was deployed on 2012-05-28, but for testwiki and mediawikiwiki only.
enwiki waited until June 4.
srv187 and srv188 were apaches, so they wouldn't affect page revisions.
Per
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #48 from Richard Guk 2012-06-25 09:23:38
UTC ---
Thanks for running those queries and making the data available.
Apologies for the typo. Also, I shouldn't have included "rc_new_len>0" within
the WHERE condition of trcmin (it defea
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
MZMcBride changed:
What|Removed |Added
CC||b...@mzmcbride.com
--- Comment #47 from MZ
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #46 from Marcin Cieślak 2012-06-24
23:50:42 UTC ---
Results of
http://toolserver.org/~saper/bug37225/query.sh
from plwiki_p are here:
http://toolserver.org/~saper/bug37225/20120624.txt
I suspect bug 37919 describes one specifi
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Nemo_bis changed:
What|Removed |Added
CC||marcin.cies...@gmail.com
--- Comment #45 fr
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #44 from Richard Guk 2012-06-24 00:34:40
UTC ---
I've no idea which server log items might be relevant, but we could narrow down
the timeframe.
If you have not already done so, could you extract the relevant recentchanges
entries
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #43 from Aaron Schulz 2012-06-23 17:16:51
UTC ---
(In reply to comment #39)
> Have you identified any software changes that coincided with the initial
> flurry
> of reports on 2012-05-30?
You can check http://wikitech.wikimedia.o
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
duplicate...@googlemail.com changed:
What|Removed |Added
CC||jas...@jasperswebsite.co.c
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
duplicate...@googlemail.com changed:
What|Removed |Added
CC||mas...@gmail.com
--- Comm
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #40 from Aaron Schulz 2012-06-23 03:00:30
UTC ---
None of those examples match the logging, so there is clearly a third
independent cause of this bug. So the first was fixed already, the second is
awaiting reviewing in gerrit (http
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #39 from Richard Guk 2012-06-22 19:23:33
UTC ---
(In reply to comment #38)
> Thanks. Do we have a list of instances that came up (like a user subpage or
> something)? I added some more logging and would like to see if it correspond
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #38 from Aaron Schulz 2012-06-22 18:43:32
UTC ---
(In reply to comment #32)
> A current example from enwiki:
>
> Duplicate edits of [[Wilhering Abbey]] by [[User:193.171.131.230]]:
> * 2012-06-21T12:51:53 UTC (+9 bytes)
> * 2012-0
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Liangent changed:
What|Removed |Added
CC||liang...@gmail.com
--- Comment #37 from Lia
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #36 from Aaron Schulz 2012-06-22 16:45:34
UTC ---
Logging confirms a second bug that can cause this. In doEdit(), "$changed = (
strcmp( $text, $oldtext ) != 0 );" doesn't account for the rtrim() call on the
text in the Revision con
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #35 from Aaron Schulz 2012-06-22 03:42:53
UTC ---
(In reply to comment #34)
> Gah, spoke too soon. Servers 190, 206, 266, 281 are not reachable. They are
> all
> still in the apache pybal group, and thus are receiving requests. It
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #34 from Aaron Schulz 2012-06-22 03:26:37
UTC ---
(In reply to comment #33)
> Using ddsh, I can see that all servers are using the same version of
> WikiPage.php, so it can't be servers with stale code.
Gah, spoke too soon. Server
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #33 from Aaron Schulz 2012-06-22 03:21:47
UTC ---
Using ddsh, I can see that all servers are using the same version of
WikiPage.php, so it can't be servers with stale code.
--
Configure bugmail: https://bugzilla.wikimedia.org/use
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #32 from Richard Guk 2012-06-21 13:25:20
UTC ---
A current example from enwiki:
Duplicate edits of [[Wilhering Abbey]] by [[User:193.171.131.230]]:
* 2012-06-21T12:51:53 UTC (+9 bytes)
* 2012-06-21T12:51:55 UTC (+19,493 bytes) = a
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #31 from Supertoff 2012-06-21 04:56:39
UTC ---
(In reply to comment #30)
> (In reply to comment #29)
> > (In reply to comment #28)
> > > What are some examples of duplicate edits on 6/19/12 or later?
> >
> > That ?
> >
> > http:/
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #30 from Aaron Schulz 2012-06-21 04:50:15
UTC ---
(In reply to comment #29)
> (In reply to comment #28)
> > What are some examples of duplicate edits on 6/19/12 or later?
>
> That ?
>
> http://fr.wikipedia.org/w/index.php?title=N
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Supertoff changed:
What|Removed |Added
CC||supertoff4...@hotmail.fr
--- Comment #29 f
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #28 from Aaron Schulz 2012-06-21 03:07:53
UTC ---
What are some examples of duplicate edits on 6/19/12 or later?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail bec
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #27 from Richard Guk 2012-06-19 12:56:51
UTC ---
Even freakier, enwiki:VPT allowed a NON-null edit conflict 6 hours ago.
The history tab gives the following details:
First, an archive bot correctly removed several sections:
* 20
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #26 from Aaron Schulz 2012-06-19 05:58:23
UTC ---
>From the logging, I suspect that there is a parallel bug somewhere that also
causes this problem. Only one cause has been fixed.
--
Configure bugmail: https://bugzilla.wikimedia.
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #25 from Richard Guk 2012-06-18 21:22:31
UTC ---
I can now confirm that the wmf5 rollout on enwiki has NOT prevented new
duplicate entries (saved null edits).
There are 4 consecutive identical edits to [[Croatia national football
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #24 from Platonides 2012-06-18 20:22:49 UTC
---
The watchlist gets the length diff from the recentchanges table, so it will
show the same values (correct or invalid).
Then, the values stored at recentchanges were copied on edit. Re
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #23 from Richard Guk 2012-06-18 19:38:20
UTC ---
(In reply to comment #22)
> 1.20wmf4 was rolled out to the English Wikipedia on the 4th. Today 1.20wmf5
> was
> rolled out to that wiki. ...
Sorry, "wmf4" was my typo (in both plac
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #22 from Krenair 2012-06-18 19:12:56 UTC ---
(In reply to comment #21)
> My guess is that the 1.20wmf4 rollout in the past few hours may have corrected
> the byte-difference in the history page but has failed to correct the
> differ
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #21 from Richard Guk 2012-06-18 19:08:26
UTC ---
Example null-change edit to [[Belfast]]:
http://en.wikipedia.org/w/index.php?title=Belfast&diff=498122258&oldid=498122204
The above edit was made 2012-06-18T04:03:02 (UTC), duplic
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Rob Lanphier changed:
What|Removed |Added
CC||ro...@wikimedia.org
AssignedTo|
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #19 from Dereckson 2012-06-13 23:15:19
UTC ---
Some spaces where the issue is discussed:
Two consecutives days on the French village pump:
*
http://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro/5_juin_2012#Modification_vide_.3F
*
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #18 from Aaron Schulz 2012-06-13 20:18:18
UTC ---
(In reply to comment #11)
> It looks like WikiPage::loadPageData(), which calls loadFromRow(), does not
> clear mLastRevision, which includes a process cache of the revision text. S
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Dereckson changed:
What|Removed |Added
Priority|Unprioritized |Highest
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #16 from Tim Starling 2012-06-13 01:32:19
UTC ---
(In reply to comment #14)
> As a side note: I think it would be helpful to put all database actions needed
> when saving a page into SqlUpdate objects, and then perform all updates
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Jarry1250 changed:
What|Removed |Added
CC||jarry1...@gmail.com
--- Comment #15 from J
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #14 from Daniel Kinzler 2012-06-09
20:37:22 UTC ---
As a side note: I think it would be helpful to put all database actions needed
when saving a page into SqlUpdate objects, and then perform all updates using a
single call to DataU
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Platonides changed:
What|Removed |Added
CC||daniel.kinz...@wikimedia.de
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Platonides changed:
What|Removed |Added
CC||en.wp.s...@gmail.com
--- Comment #12 from
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #11 from Aaron Schulz 2012-06-07 22:02:14
UTC ---
It looks like WikiPage::loadPageData(), which calls loadFromRow(), does not
clear mLastRevision, which includes a process cache of the revision text. So,
AFAIK, if I do something li
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #10 from Richard Guk 2012-06-07 21:01:23
UTC ---
This still seems to be a frequent occurrence, given the continuing reports at
enwiki:VPT.
Would a database query help by identifying the precise time on 2012-05-30 that
these duplic
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Ningauble changed:
What|Removed |Added
CC||ningau...@earthlink.net
--- Comment #9 fro
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Richard Guk changed:
What|Removed |Added
CC||richardg...@yahoo.com
--- Comment #8 fro
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #7 from Platonides 2012-06-05 22:43:45 UTC
---
Those trasnsaction-breaking begins...
But I don't think it matters. You enter into updateRevisionOn(), which is
passed $oldid and used as WHERE page_latest=$oldid, so if another proce
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #6 from Aaron Schulz 2012-06-05 21:33:11
UTC ---
I see the line:
$this->loadPageData( 'fromdbmaster' );
...before the text is loaded in WikiPage::doEdit(). It will the page_latest
field from the master to get the revision/text.
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
Tim Starling changed:
What|Removed |Added
CC||aschulz4...@gmail.com,
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #4 from Platonides 2012-05-31 08:27:09 UTC
---
Fair, but you can't create two edits for the same content either (ignoring log
actions as moves, protect...).
I tried to reproduce the race with maintenance/edit.php but had no luck s
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #3 from Tim Starling 2012-05-31 05:17:30
UTC ---
You can't get an edit conflict with yourself, the subsequent edit just
overwrites the previous edit. This allows the user to click "back" after a save
to return to the edit form, in
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #2 from Platonides 2012-05-30 21:53:35 UTC
---
We seem to have a good number of these double-entries, usually by the same user
(even by bots!).
Find a sample below:
https://en.wikipedia.org/w/index.php?diff=495195923&oldid=4951958
https://bugzilla.wikimedia.org/show_bug.cgi?id=37225
--- Comment #1 from Platonides 2012-05-30 18:02:49 UTC
---
I don't think ChronologyProtector is involved here or that the script[1] could
cause it by itself. We should dig into EditPage/Article for this race
condition.
1- http://fr.wikipedia.
70 matches
Mail list logo
