https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Summary|Malformed hlist rendering |Malformed hlist rendering
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Blocks||40062
--
You are receiving this mail b
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
kevi...@sympatico.ca changed:
What|Removed |Added
CC||kevi...@sympatico.ca
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #10 from Erwin Dokter ---
OK, that means my patch can go in the bin. It's not clear to me why
'\n' would not work; it seems to be the standard way in PHP strings to
include linebreaks. I wish someone would go in and terminate all cl
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Brad Jorsch changed:
What|Removed |Added
CC||bjor...@wikimedia.org
--- Comment #11 fr
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Andre Klapper changed:
What|Removed |Added
Target Milestone|1.22.0 release |1.22.x release
--- Comment #46 from An
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Bartosz Dziewoński changed:
What|Removed |Added
Target Milestone|1.22.x release |1.22.0 release
--- Comment #47 fr
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #12 from Erwin Dokter ---
Working on a patch, but my local repository seems to be broken; I get over a
year old files when rebasing. I do hate GIT with a passion.
--
You are receiving this mail because:
You are the assignee for th
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gerrit Notification Bot changed:
What|Removed |Added
Status|REOPENED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #13 from Gerrit Notification Bot ---
Change 90696 had a related patch set uploaded by Gerrit Patch Uploader:
Have list items occupy their own line
https://gerrit.wikimedia.org/r/90696
--
You are receiving this mail because:
You a
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Target Milestone|--- |1.22.0 release
--- Comment #14 from Erw
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #15 from Gerrit Notification Bot ---
Change 90696 merged by jenkins-bot:
Have list items occupy their own line
https://gerrit.wikimedia.org/r/90696
--
You are receiving this mail because:
You are the assignee for the bug.
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Brad Jorsch changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #16 from Brad Jorsch ---
Change merged. It should be deployed to WMF wikis with 1.23wmf1 (unless we
decide to have 1.22wmf23 instead), see
https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.
--
You are receivin
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gabriel Wicke changed:
What|Removed |Added
CC||gwi...@wikimedia.org
--- Comment #17 f
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #18 from Gabriel Wicke ---
Examples:
// force single line, but space cannot be avoided as it is in the DOM
http://jsfiddle.net/dT3Qg/
// Without a space in the DOM, both single-line and break-on-li behavior are
possible. Break-on-
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gabriel Wicke changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
ssas...@wikimedia.org changed:
What|Removed |Added
CC||ssas...@wikimedia.org
--- Comme
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
C. Scott Ananian changed:
What|Removed |Added
CC||canan...@wikimedia.org
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gabriel Wicke changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gerrit Notification Bot changed:
What|Removed |Added
Status|REOPENED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #24 from Gerrit Notification Bot ---
Change 94443 had a related patch set uploaded by Cscott:
Revert "Have list items occupy their own line"
https://gerrit.wikimedia.org/r/94443
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #25 from Gabriel Wicke ---
Relevant tidy bug for avoiding newline insertion:
https://sourceforge.net/p/tidy/bugs/945/
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #26 from Erwin Dokter ---
"white-space: inline-block" is nonsense; it only causes white-space to revert
to 'normal', which is NOT desired. Also, the posted Tidy bug hardly seems
relevant.
--
You are receiving this mail because:
Yo
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #27 from Bartosz Dziewoński ---
The Tidy bug is what caused hlists to work in the first place, according to
what you're saying :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Bartosz Dziewoński changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
C. Scott Ananian changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #30 from C. Scott Ananian ---
And just recapping the objections to the current patch:
1) it changes longstanding parser behavior, possibility of unintended
consequences is high
2) it breaks a number of extensions using the parsert
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #31 from Helder ---
(In reply to comment #29)
And the other (important) part from bug 56809 comment 10 is:
> Any suggested changes will break one or more testcases.
--
You are receiving this mail because:
You are the assignee for
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #32 from C. Scott Ananian ---
That's why we write testcases, Helder. Fixes aren't committed until/unless
they pass them. I thought that was obvious.
--
You are receiving this mail because:
You are the assignee for the bug.
You a
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #33 from C. Scott Ananian ---
In https://bugzilla.wikimedia.org/show_bug.cgi?id=56809#c14 Erwin writes:
> That is a scoping problem; Tidy should simply not touch anything that comes
> out
of GeSHi (pre & code). This is simply two
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #34 from Bartosz Dziewoński ---
(I think thaat comment was about bug 260 and bug 38800.)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #35 from Erwin Dokter ---
(It was. Tidy/GeSHi conflict is not about hlist. I got a collision when posting
that.)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #36 from Erwin Dokter ---
If extensions rely on "long standing parser output", it means the parser can
never be changed or improved. I once got admonished by a bot operator because I
dared to change the output of a template, throwin
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #37 from Gabriel Wicke ---
(In reply to comment #26)
> "white-space: inline-block" is nonsense; it only causes white-space to revert
> to 'normal', which is NOT desired. Also, the posted Tidy bug hardly seems
> relevant.
Please act
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #38 from Gabriel Wicke ---
(And apologies for the typo in #17 that probably threw you off.)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #39 from Erwin Dokter ---
I have seen it. I have tested it in my sandbox on test.wikipeida.org.
display+inline-block causes malformed lists; nested lists become unwilling to
wrap, regargless of white-space setting.
I have tested ev
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #40 from Gabriel Wicke ---
I have created a simple nested list test case at
https://test.wikipedia.org/wiki/User:GWicke/sandbox
The wrapping seems to work as expected, only the margins / padding still needs
some tweaking. And the i
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #41 from Erwin Dokter ---
I'm sorry, but it does not wrap as expected. It wraps between foo and bar
(beginning of sublist) where it should not. Inline-block somehow overrides
white-space:normal, making it act as nowrap.
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #42 from Gabriel Wicke ---
So you would like it *not* to wrap between a list and its first sub-list item,
but then wrap between additional sub-list items?
--
You are receiving this mail because:
You are the assignee for the bug.
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #43 from Gabriel Wicke ---
I think I figured out what you meant by creating a sublist with a lot more list
items. The break happened first between foo and bar rather than the nested list
items, at least in some screen widths.
I hav
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #44 from Erwin Dokter ---
Having the sublist use display:inline produces the same problem that caused me
te submit this patch in the first place; the entire sublist won't wrap if the
list items are glued together (no linebreak or TI
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #45 from Brad Jorsch ---
gwicke's example linked in Comment 43 produces an odd display here:
Item Item Item Item Item Item Item Item Item Item
Item Item Item Item Item Item
Item
That last Item shouldn't be on a new line. And if
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #48 from Erwin Dokter ---
Regarding hlist, the wrapping problem has been resolved by means of disabling
nowrap alltogether. But it still has the potential of malfunctioning if nowrap
is applied locally (ie. in a template).
With tha
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #49 from Gabriel Wicke ---
Sorry for bringing this up this late, but can you describe the use case for
rendering nested lists as a flat structure? Can those lists be a flat DOM
structure instead?
--
You are receiving this mail bec
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #50 from Erwin Dokter ---
No, hlist must work just like regular HTML lists because they must be
sematically the same. Anything breaking that behaviour negates the entire
purpose of hlist.
--
You are receiving this mail because:
Yo
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #51 from Gabriel Wicke ---
I don't think that this answers my question though. Why can't those lists just
be flat if they are intended to render as a flat structure?
--
You are receiving this mail because:
You are the assignee for
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #52 from Erwin Dokter ---
Accessibility. They only render flat visually, but its structure must be
maintained to ensure they are accessable as regular HTML lists for
screenreaders.
--
You are receiving this mail because:
You are t
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #53 from Gabriel Wicke ---
That points out why they should be a list, which we don't disagree on. Can you
describe why they have to be *nested* lists?
--
You are receiving this mail because:
You are the assignee for the bug.
You a
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #54 from Erwin Dokter ---
That is entirely up to the user constructing the list. hlist only allows you to
have nested lists, because HTML/wikimarkup allows you to have nested lists. I
couldn't 'unnest' the lists even if I wanted to.
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #55 from Gabriel Wicke ---
I'm still trying to figure out why you have the requirement to render *nested*
lists as a flat structure.
So far it seems that the only reason to support this is that lists *can*
generally be nested, not
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #56 from Phillip Patriakeas ---
The use cases are exactly the same as the use cases of nesting lists when just
using HTML lists: anywhere you would potentially want to nest HTML lists is
where you would also potentially want to nest
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #57 from Gabriel Wicke ---
(In reply to Phillip Patriakeas from comment #56)
> The use cases are exactly the same as the use cases of nesting lists when
> just using HTML lists: anywhere you would potentially want to nest HTML
> lis
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Gerrit Notification Bot changed:
What|Removed |Added
Status|RESOLVED|PATCH_TO_REVIEW
Reso
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #59 from Gerrit Notification Bot ---
Change 134380 had a related patch set uploaded by GWicke:
Update list item newline handling to follow Parsoid's model
https://gerrit.wikimedia.org/r/134380
--
You are receiving this mail becau
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #60 from Gerrit Notification Bot ---
Change 134380 merged by jenkins-bot:
Update list item newline handling to follow Parsoid's model
https://gerrit.wikimedia.org/r/134380
--
You are receiving this mail because:
You are the assig
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #61 from Gerrit Notification Bot ---
Change 94443 abandoned by Cscott:
Revert "Have list items occupy their own line".
Reason:
Abandoned in favor of Ib7aa9449bbd994cb23b83b3f23cff944b1cddadf
https://gerrit.wikimedia.org/r/94443
-
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Mark A. Hershberger changed:
What|Removed |Added
CC||m...@everybody.org
Target Mile
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
Erwin Dokter changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #64 from Helder ---
Thanks!
However, after I updated the code in
https://pt.wikipedia.org/w/index.php?diff=39195928&oldid=37160137
I still noticed differences between [[pt:MediaWiki:Recentchangestext]] and
[[pt:Special:RecentChang
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #65 from Erwin Dokter ---
This is also caused by (the absence of) Tidy. Unless the HTML parser (and
Parsoid) strip leading and trailing spaces, they will be visible.
You may want to ping the parsoid team to see if they want to fix
63 matches
Mail list logo
