https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Mark A. Hershberger m...@everybody.org changed:
What|Removed |Added
Target Milestone|1.21.x release |---
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #17 from Marcin Cieślak marcin.cies...@gmail.com ---
Sorry for talking to myself, but the abovementioned fix repairs test failures
I've had with SiteSQLStore, so I kind of believe the fix is kind of good, but
the tests are broken.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #18 from Marcin Cieślak marcin.cies...@gmail.com ---
(In reply to comment #17)
Sorry for talking to myself, but the abovementioned fix repairs test failures
I've had with SiteSQLStore, so I kind of believe the fix is kind of good,
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #20 from Marcin Cieślak marcin.cies...@gmail.com ---
... bug 37061 ...
er, bug 37601...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #19 from Marcin Cieślak marcin.cies...@gmail.com ---
... bug 37061 ...
er, bug 37061...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #21 from Marcin Cieślak marcin.cies...@gmail.com ---
... bug 37061 ...
er, bug 37601...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Marcin Cieślak marcin.cies...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #16 from Marcin Cieślak marcin.cies...@gmail.com ---
*** Bug 43458 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords|patch-in-gerrit |
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #14 from Andre Klapper aklap...@wikimedia.org ---
(In reply to comment #11)
Found Gerrit change #58422, maybe fixed now?
overlordq: Ping - did your patch by any chance fix this bug report?
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #13 from Andre Klapper aklap...@wikimedia.org ---
(In reply to comment #11)
Found Gerrit change #58422, maybe fixed now?
overlordq: Ping - did your patch by any chance fix this bug report?
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Nemo federicol...@tiscali.it changed:
What|Removed |Added
Target Milestone|1.21.0 release |1.21.x release
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #12 from Andre Klapper aklap...@wikimedia.org ---
(In reply to comment #11)
Found Gerrit change #58422, maybe fixed now?
overlordq: Ping - did your patch by any chance fix this bug report?
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #11 from db duplicate...@googlemail.com ---
Found gerrit 58422, maybe fixed now?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #9 from Andre Klapper aklap...@wikimedia.org ---
Tim / Aude: Is this fixed, or is some more work needed?
Not clear (see last comment)...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #10 from OverlordQ overlo...@gmail.com ---
I tried running the PHPUnit tests but still running into lingering cases of:
12) ORMTableTest::testIgnoreErrorsOverride
DatabasePostgres::reportQueryError: No transaction to rollback,
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #8 from db duplicate...@googlemail.com ---
gerrit 41020 merged, gerrit 41181 abandoned - bug maybe fixed
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Michelle Lee Kosik kosi...@mail.com changed:
What|Removed |Added
CC||kosi...@mail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Antoine hashar Musso has...@free.fr changed:
What|Removed |Added
CC|has...@free.fr |
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords||patch-in-gerrit
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #2 from Marcin Cieślak marcin.cies...@gmail.com ---
I think that if someone aims at the ORM layer one should handle sequences
properly. Your solution with using the default is correct given that table
definition includes the default
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #3 from Aude aude.w...@gmail.com ---
an additional issue is that ORMRow uses Database::insertID() but mLatestId
never gets set and is null.
$this-setField( 'id', $dbw-insertId() );
Now, PostgreSQL supports ' RETURNING id' as part
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #4 from Tim Landscheidt t...@tim-landscheidt.de ---
(In reply to comment #2)
I think that if someone aims at the ORM layer one should handle sequences
properly. Your solution with using the default is correct given that table
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #5 from Tim Landscheidt t...@tim-landscheidt.de ---
(In reply to comment #3)
an additional issue is that ORMRow uses Database::insertID() but mLatestId
never gets set and is null.
$this-setField( 'id', $dbw-insertId() );
Now,
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #6 from Aude aude.w...@gmail.com ---
https://gerrit.wikimedia.org/r/#/c/41181/ is an attempt to make setting the id
work.
Okay with naming the option insertid and other suggestions.
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=43475
--- Comment #1 from Tim Landscheidt t...@tim-landscheidt.de ---
Gerrit change #41020, tested on MySQL, PostgreSQL (for the most part) and
SQLite for:
| tests/phpunit/includes/db/TestORMRowTest.php
|
28 matches
Mail list logo
