https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #1 from Nemo ---
To be precise, the example in screenshot was not a rollback but a simple
revert. Rollback *must* suppress notifications, while other revert systems may
need some more work. I suppose, however, that you already have
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #2 from Ryan Kaldari ---
Right now we are just mirroring the behavior of the existing talk page
notification system. While I agree it would probably be better to suppress
notifications about rolledback edits, I would consider this a
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #3 from Nemo ---
(In reply to comment #2)
> Right now we are just mirroring the behavior of the existing talk page
> notification system.
I'm not sure, what notification system are you talking about? The new messages
bar collates
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Terry Chay changed:
What|Removed |Added
CC||tc...@wikimedia.org
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Nemo changed:
What|Removed |Added
See Also||https://bugzilla.wikimedia.
|
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Ryan Kaldari changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia. |nischay...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #5 from Nischay Nahata ---
I think some users may be against this. You don't want to see it if its spam,
what if its not?
Hiding details like this is not always appreciated.
Also how should this be done? when we detect a revert we
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #6 from Terry Chay ---
> I think some users may be against this. You don't want to see it if its spam,
what if its not?
The goal is not to suppress the notification, it's that one event is generating
two notifications (one for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #7 from Nischay Nahata ---
(In reply to comment #6)
> Ask kaldari on #wikimedia-ee for information on merging multiple redundant
> notifications in Echo. There is a system in place for doing this, it just
> needs
> to be hooked up f
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #8 from Ryan Kaldari ---
Probably the way this would be implemented is in EchoHooks::onRollbackComplete
take the ID of the rev that was rolled back and look for any echo events in the
database related to this rev and delete them. Ju
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #9 from Nischay Nahata ---
(In reply to comment #8)
> take the ID of the rev that was rolled back and look for any echo events in
> the
> database related to this rev and delete them. Just be sure to do this before
> the rollback (e
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #10 from Ryan Kaldari ---
Oh yeah, looks like you're right. We may want to add revision as it's own
column in that case.
--
You are receiving this mail because:
You are on the CC list for the bug.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #11 from Nischay Nahata ---
(In reply to comment #10)
> Oh yeah, looks like you're right. We may want to add revision as it's own
> column in that case.
Does the design team have a say on this? or can we just add the column?
I thin
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #12 from Ryan Kaldari ---
We can just add the column, but I'd like to make sure Benny thinks it's a good
idea since he's handling the back-end components.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #13 from Terry Chay ---
Adding Luke since this will affect Redis mailbox.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #14 from bs...@wikimedia.org ---
It wouldn't help if we add a revision column + extra index to event table.
Upon each event is created, web + email notifications would be either created
immediately or a job would be scheduled right
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Nischay Nahata changed:
What|Removed |Added
See Also||https://bugzilla.wikimedia.
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #15 from Ryan Kaldari ---
>The fast and easy way is just to check request variables: wpUndidRevision
>exists or action == rollback before creating a talk page notification, if the
>author of the rollback revision exists and is the s
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #16 from Ryan Kaldari ---
Actually I guess this bug might be about both cases, but I'm not sure from the
bug's initial description.
@Nemo: In the case that JarJar vandalizes Kirk's userpage, and BuckRogers
reverts JarJar, should Ki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #17 from Ryan Kaldari ---
Either way, we wouldn't want to suppress the notification about the rollback
unless we also suppressed the notification about the vandal edit that was
rolled back, so if there is no solution for the latter,
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #18 from Luke Welling ---
Attempting to address this would take significant work and depending on the
exact timing and user settings its behaviour could be very mysterious to users.
With a similar degree of effort to that taken to
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #19 from Nemo ---
(In reply to comment #16)
> @Nemo: In the case that JarJar vandalizes Kirk's userpage, and BuckRogers
> reverts JarJar, should Kirk receive one notification about the rollback or
> none
> at all?
Ideally none (the
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Nemo changed:
What|Removed |Added
See Also||https://bugzilla.wikimedia.
|
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
Quiddity changed:
What|Removed |Added
CC||pandiculat...@gmail.com
--- Comment #20 fro
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #21 from Nemo ---
(In reply to comment #20)
> Possibly related to the very old Bug 2939 ('"You've got new message" is
> displayed even after a revert')
Well, it's related in the sense that Echo probably makes that bug disappear,
bu
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #22 from sp...@wikimedia.org ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/198
--
You are receiving this mail because:
You are on the CC list for the b
https://bugzilla.wikimedia.org/show_bug.cgi?id=46689
--- Comment #23 from Andre Klapper ---
Is Nischay still working on this, or should the assignee be reset to default?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
W
27 matches
Mail list logo
