https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
Dan Garry changed:
What|Removed |Added
Summary|Popups not visible for |Hovercards: cards not
|l
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #2 from Dan Garry ---
I reproduced this by resizing my window so that the word "samurai" is near the
bottom of the screen. The card appears to still be actually generated and
displayed, it's just that it's being displayed in a non-v
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #3 from Vibha Bamba ---
Agree, We just need to address the issue for 'link is too close to the fold'
for now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #4 from Prateek Saxena ---
I can think of two possible solutions:
1. Flip the popup–show it above the link
2. Auto-scroll the page (ewww)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the C
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #5 from Vibha Bamba ---
Tempting as it is, Autoscroll cannot be our option, we are better than that.
Its jarring for the reader and significantly changes read behavior.
--
You are receiving this mail because:
You are the assignee
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #6 from Prateek Saxena ---
So (1) from comment #4? Any other ideas?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
Prateek Saxena changed:
What|Removed |Added
Priority|Unprioritized |Normal
--
You are receiving this mai
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
kipod changed:
What|Removed |Added
CC||fur.hew...@gmail.com
--- Comment #7 from kipod
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #8 from Vibha Bamba ---
Created attachment 15059
--> https://bugzilla.wikimedia.org/attachment.cgi?id=15059&action=edit
Proposed Solution for cards with images
If the link is close to the fold, the popup can horizontally flip.
-
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #9 from Vibha Bamba ---
Created attachment 15060
--> https://bugzilla.wikimedia.org/attachment.cgi?id=15060&action=edit
Proposed Solution for cards without images
Popups can horizontally flip.
We can define a margin if the link a
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #10 from Vibha Bamba ---
Prateek, I discussed some alternate solutions with Jared.
We think that the proposals attached to this bug are better suited to solving
the problem. I'm assigning this bug to you so you can comment on compl
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
Vibha Bamba changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia. |psax...@wikimedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #11 from Gerrit Notification Bot ---
Change 130585 had a related patch set uploaded by Prtksxna:
Flip popups on X and Y axis so that they don't render below the fold
https://gerrit.wikimedia.org/r/130585
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #12 from kipod ---
(In reply to Gerrit Notification Bot from comment #11)
> Change 130585 had a related patch set uploaded by Prtksxna:
> Flip popups on X and Y axis so that they don't render below the fold
>
> https://gerrit.wikim
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #13 from Prateek Saxena ---
(In reply to kipod from comment #12)
> clearly, this is an error: we should look at $window.height(), not width.
Fixed.
> more concise, simpler and clearer (and, of course, more correct, by virtue
> of
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #14 from kipod ---
(In reply to Prateek Saxena from comment #13)
> Thanks for the review kipod! Could you please review and/or +1 the patch on
> Gerrit too?
unfortunately, though i have a gerrit account, i did not yet learn to actu
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #15 from Andre Klapper ---
(In reply to kipod from comment #14)
> unfortunately, though i have a gerrit account, i did not yet learn to
> actually use it. tried a couple of times, but did not persist. i am probably
> doing something
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #16 from Gerrit Notification Bot ---
Change 130585 merged by jenkins-bot:
render.article: Flip popups on X and Y axis so that they don't render outside
the viewport
https://gerrit.wikimedia.org/r/130585
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #17 from kipod ---
(In reply to Gerrit Notification Bot from comment #16)
> Change 130585 merged by jenkins-bot:
> render.article: Flip popups on X and Y axis so that they don't render
> outside the viewport
>
> https://gerrit.wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
Prateek Saxena changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #19 from kipod ---
please see bug 65433 for a demonstration of the effect i was referring to:
calculating "top" can be slightly off. when flippedY is true, it is much better
to use "bottom".
peace.
--
You are receiving this mail
22 matches
Mail list logo
