[Wikidata-bugs] [Maniphest] [Commented On] T162539: Deploy schema change for adding term_full_entity_id column to wb_terms table

2017-04-25 Thread Marostegui
Marostegui added a comment. db1071 and db1063 are done: root@neodymium:~# mysql --skip-ssl -hdb1071 wikidatawiki -e "show create table wb_terms\G" | egrep "term_full_entity_id|term_search_full" `term_full_entity_id` varbinary(32) DEFAULT NULL, KEY `term_full_entity` (`term_full_entity_id`),

[Wikidata-bugs] [Maniphest] [Commented On] T163548: Drop the useless wb_terms keys "wb_terms_entity_type" and "wb_terms_type" on "wb_terms" table

2017-04-25 Thread Marostegui
Marostegui added a comment. db1071 and db1063 are done: root@neodymium:~# mysql --skip-ssl -hdb1071 wikidatawiki -e "show create table wb_terms\G" | egrep "wb_terms_entity_type|wb_terms_type" root@neodymium:~# mysql --skip-ssl -hdb1063 wikidatawiki -e "show create table wb_terms\G" | egrep

[Wikidata] Sitelink removal in Wikidata

2017-04-25 Thread Amir Ladsgroup
Hey, One common form of vandalism in Wikidata is removing sitelinks (we already have an abuse filter flagging them). One of my friends in Persian Wikipedia (who is not a wikidata editor and only cares about Persian Wikipedia) asked me to write a tool that lists all Persian Wikipedia sitelink

[Wikidata-bugs] [Maniphest] [Commented On] T163774: The query services seems to have a problem with the new geoshape datatype

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. It is not there because the RDF mapping is still missing. (Was also in the announcement ;-))TASK DETAILhttps://phabricator.wikimedia.org/T163774EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc:

[Wikidata-bugs] [Maniphest] [Merged] T163774: The query services seems to have a problem with the new geoshape datatype

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as a duplicate of T160535: [Task] Provide RDF mapping for geoshape data type.. TASK DETAILhttps://phabricator.wikimedia.org/T163774EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] [Closed] T161543: Enable geoshape datatype on Wikidata

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Backlog to Done on the Wikidata-Sprint board.Lydia_Pintscher claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T161543WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T57549: [Story] Add a new datatype for geoshapes

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher closed subtask T161543: Enable geoshape datatype on Wikidata as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T57549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Lydia_PintscherCc: Lokal_Profil, WMDE-leszek, Pasleim,

[Wikidata-bugs] [Maniphest] [Commented On] T163475: Populate the page_props table on Wikidata with wb-identifiers

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Yeah in that case let's just run the bot.TASK DETAILhttps://phabricator.wikimedia.org/T163475EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: daniel, Lydia_Pintscher, Ladsgroup, Aklapper, Multichill, QZanden,

[Wikidata-bugs] [Maniphest] [Commented On] T54136: [Epic] Redesign Item UI for Wikidata repo

2017-04-25 Thread Danwe
Danwe added a comment. May I ask why you are acting like you are still an active member of the team? @thiemowmde I am foremost a sometimes active, sometimes not so active member of the wider WM, MW, Wikidata etc. community (and have proudly been so since 2007 when I have first started coding for

[Wikidata-bugs] [Maniphest] [Commented On] T163475: Populate the page_props table on Wikidata with wb-identifiers

2017-04-25 Thread Multichill
Multichill added a comment. In T163475#3208210, @daniel wrote: Makes sense, and should be fine. However, purging all these pages is quite expensive. We could calculate the number and write it to page_props directly. That's a little bit hackish, but a lot faster, and not too horrible. It does

[Wikidata-bugs] [Maniphest] [Created] T163815: Lua error: "The ID entered is unknown to the system. Please use a valid entity ID." with valid q-code

2017-04-25 Thread Jarekt
Jarekt created this task.Jarekt added projects: Wikidata, MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper. TASK DESCRIPTIONLately I completed T89597 and rolled out on Commons [[Module:Creator]] that mimics [[Template:Creator]] but can also fetch any field from Wikidata if

[Wikidata-bugs] [Maniphest] [Claimed] T158430: [Spike] Use suggested properties to get signal for completeness

2017-04-25 Thread Halfak
Halfak claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T158430EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HalfakCc: Sjoerddebruin, Ladsgroup, Glorian_Yapinus, Sumit, Ricordisamoa, Aklapper, StudiesWorld, Lydia_Pintscher, samuwmde,

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable "save" button until server responds

2017-04-25 Thread Danwe
Danwe added a comment. The behavior you are describing means the user can smash the return key very early, and will entirely miss the preview that is shown after the input was parsed and formatted. Might make sense to decline this if you want to hold the average user's hand rather than satisfy

[Wikidata-bugs] [Maniphest] [Edited] T163720: Wrong label shown in watchlist on Wikipedia for a Wikidata change on some items

2017-04-25 Thread Quiddity
Quiddity edited the task description. (Show Details) EDIT DETAILS...I've searched for "property" and "wikidata" in both those enwiki articles, with no results. - Quick links: * https://www.wikidata.org/wiki/Q255 ** https://en.wikipedia.org/wiki/Ludwig_van_Beethoven *

[Wikidata-bugs] [Maniphest] [Claimed] T162788: [Story] basic non-editable list of Grammatical Features of a Form

2017-04-25 Thread Aleksey_WMDE
Aleksey_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T162788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aklapper, Lydia_Pintscher, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah,

[Wikidata-bugs] [Maniphest] [Lowered Priority] T140876: In SqlEntityInfoBuilder, replace the usage of wb_entity_per_page with using the page and redirect tables

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint.WMDE-leszek lowered the priority of this task from "High" to "Normal". TASK DETAILhttps://phabricator.wikimedia.org/T140876EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Zppix, Aklapper, hoo,

[Wikidata-bugs] [Maniphest] [Lowered Priority] T140877: In PropertyInfoTableBuilder, replace the usage of wb_entity_per_page with using the page and redirect tables

2017-04-25 Thread WMDE-leszek
WMDE-leszek lowered the priority of this task from "High" to "Normal".WMDE-leszek added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T140877EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, hoo, gerritbot,

[Wikidata-bugs] [Maniphest] [Triaged] T162198: [Bug] Input expert extender is not re-positioned after input position on page has changed

2017-04-25 Thread WMDE-leszek
WMDE-leszek triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T162198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: aude, Jonas, Aklapper, Jrbranaa, QZanden, Izno, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Updated] T163723: [Story] non-persistently editable statements on a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T163723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, Lydia_Pintscher, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah,

[Wikidata-bugs] [Maniphest] [Updated] T162797: [Story] Grammatical Forms look like faked statements

2017-04-25 Thread daniel
daniel added a comment. See T163785: [Story] UX design for a Form's list of grammatical features TASK DETAILhttps://phabricator.wikimedia.org/T162797EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jan_Dittrich, daniel, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Edited] T163785: [Story] UX design for a Form's list of grammatical features

2017-04-25 Thread daniel
daniel edited the task description. (Show Details) EDIT DETAILS...Both the function and the representation of a form's grammatical features is similar to the function and representation a lexeme's class and language. For this reason, presentation and manipulation of these things should work in a

[Wikidata-bugs] [Maniphest] [Commented On] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 350229 had a related patch set uploaded (by Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Move setServices in specials to constructor params https://gerrit.wikimedia.org/r/350229TASK DETAILhttps://phabricator.wikimedia.org/T162540EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T162540EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, daniel, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Updated] T163722: [Story] viewable statements on a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T163722EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, Lydia_Pintscher, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah,

[Wikidata-bugs] [Maniphest] [Updated] T160526: [Story] List of Statements for a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek removed a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T160526EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, Jonas, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah,

[Wikidata-bugs] [Maniphest] [Updated] T160526: [Story] List of Statements for a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T160526EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, Jonas, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah,

[Wikidata-bugs] [Maniphest] [Triaged] T163551: Huge number of duplicate rows in wb_terms

2017-04-25 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority.WMDE-leszek added a project: Wikidata-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: aude, Aklapper, hoo, QZanden, Izno,

[Wikidata-bugs] [Maniphest] [Triaged] T157466: See meta name="description" on article placeholders

2017-04-25 Thread WMDE-leszek
WMDE-leszek triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T157466EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: Ladsgroup, Aklapper, Lydia_Pintscher, Lucie, daniel, hoo, QZanden, Izno,

[Wikidata-bugs] [Maniphest] [Updated] T162790: [Story] basic editable list of Grammatical Features of a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint.WMDE-leszek edited the task description. (Show Details) EDIT DETAILS...* I can only select existing items as grammatical features. Note: Entered data is not supposed to be persisted. After page reload, all changes will be gone,TASK

[Wikidata-bugs] [Maniphest] [Updated] T162788: [Story] basic non-editable list of Grammatical Features of a Form

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a project: Wikidata-Sprint.WMDE-leszek edited the task description. (Show Details) EDIT DETAILS...* The grammatical features do not need to be editable yet. Note: Data displayed is not supposed to be coming from database, or any other storage layer. It would be just "fake" data

[Wikidata-bugs] [Maniphest] [Commented On] T162797: [Story] Grammatical Forms look like faked statements

2017-04-25 Thread daniel
daniel added a comment. For the record: by closing this as invalid, I don't mean to say "we will not use this solution". I'm just saying that the UI design should be discussed some more, and alternatives considered.TASK DETAILhttps://phabricator.wikimedia.org/T162797EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T52202: Diffing between different content models throws a fatal error

2017-04-25 Thread matej_suchanek
matej_suchanek removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T52202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: thiemowmde, hoo, aude, Addshore, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm,

[Wikidata-bugs] [Maniphest] [Block] T160525: [Story] Grammatical Feature of a Form

2017-04-25 Thread daniel
daniel created subtask T163785: [Story] UX design for a Form's list of grammatical features . TASK DETAILhttps://phabricator.wikimedia.org/T160525EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Jonas, QZanden, Izno, Wikidata-bugs, aude,

[Wikidata-bugs] [Maniphest] [Created] T163785: [Story] UX design for a Form's list of grammatical features

2017-04-25 Thread daniel
daniel created this task.daniel added projects: Story, Wikidata, Lexicographical data. TASK DESCRIPTIONA form's grammatical features are given by a (possibly empty) list of Item Ids. Their purpose is similar to the purpose of descriptions: they disambiguate the form, and specify in which context

[Wikidata-bugs] [Maniphest] [Commented On] T162673: Adjust code reading from wb_terms table to use full entity ID

2017-04-25 Thread daniel
daniel added a comment. @Ladsgroup so, I think both options are nasty in their own way :) Since you have to write it, I'll leave it to you to decide which kind of mess you prefer!TASK DETAILhttps://phabricator.wikimedia.org/T162673EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T162797: [Story] Grammatical Forms look like faked statements

2017-04-25 Thread Jan_Dittrich
Jan_Dittrich added a comment. To work on it I would need some insight in how we assume the proposed/existing UI would impair the use (in some sort of realistic scenario, like "When a user wants to do… they assume … because currently … this leads to…")TASK

[Wikidata-bugs] [Maniphest] [Closed] T162797: [Story] Grammatical Forms look like faked statements

2017-04-25 Thread daniel
daniel closed this task as "Invalid".daniel added a comment. After a conversation with Lydia yesterday, it seems like treating grammatical features "kind of like" statements is not useful: features have no ranks, no novalue/somevalue, no qualifiers, and no sources. features act as a

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T162797: [Story] Grammatical Forms look like faked statements

2017-04-25 Thread Jan_Dittrich
Jan_Dittrich added subscribers: daniel, Jan_Dittrich.Jan_Dittrich added a comment. @Lydia_Pintscher @daniel : The title says "Grammatical Forms look like faked statements" – does that summarize the problem or goal here? From what was said in the engineering time it seems to be a problem; From

[Wikidata-bugs] [Maniphest] [Unblock] T160525: [Story] Grammatical Feature of a Form

2017-04-25 Thread daniel
daniel closed subtask T162797: [Story] Grammatical Forms look like faked statements as "Invalid". TASK DETAILhttps://phabricator.wikimedia.org/T160525EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Jonas, QZanden, Izno, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Claimed] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE moved this task from incoming to in current sprint on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T162540WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread thiemowmde
thiemowmde added a comment. This sound overly complicated. Just look at the existing icons, take a screenshot, and start drawing on it. There is no standard applied on the existing icons. It's just that some look very big, and are scaled down a bit to look better when close to other icons that

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable "save" button until server responds

2017-04-25 Thread thiemowmde
thiemowmde added a comment. "Ad-hoc parsing" in this context means that, for example, a time value is stored exactly as the user has entered it, and only parsed when a machine-readable value is needed. All this would happen server-side. There are no plans to implement something like this. The

[Wikidata-bugs] [Maniphest] [Commented On] T163048: Showing wrong colors in the Wikidata logo

2017-04-25 Thread abian
abian added a comment. I have downloaded the right logo (3015 bytes) and optimized it (2098 bytes) using optipng. $ optipng -o7 wikidatawiki.png ** Processing: wikidatawiki.png 156x110 pixels, 4x8 bits/pixel, RGB+alpha Input IDAT size = 2940 bytes Input file size = 3015 bytes Trying: zc = 9

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Jan_Dittrich
Jan_Dittrich added a comment. So the problem is that the icons should have some build-into-the-image padding and we don't know what the padding specifically is, so we need to review existing icons to approximate some distance? If that is the problem we might want to talk to frontend

[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error

2017-04-25 Thread thiemowmde
thiemowmde added a comment. I do not plan to invest more time on this right now. Everything you said is fine. But even considering all this I think my patch https://gerrit.wikimedia.org/r/349878 is acceptable and does not interfere with one of the possible future solutions you proposed.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread thiemowmde
thiemowmde added a comment. While I was working on T142104#2618898 I remember some frustration because the full-res Wikidata logo barely fits into the space the Echo extension gives us, and becomes fuzzy and blurry almost all the time. So I agree it's a very good idea to use the simplified favicon

[Wikidata-bugs] [Maniphest] [Updated] T109836: Try replacing Wikibase usages with API usages

2017-04-25 Thread NHarateh_WMF
NHarateh_WMF added a project: Reading-Infrastructure-Team-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T109836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NHarateh_WMFCc: RobLa-WMF, Anomie, Jdlrobson, hoo, Aklapper, JanZerebecki, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Charlie_WMDE
Charlie_WMDE added a comment. Hey @thiemowmde I didn't know about the padding issues etc. I didn't even know there were any. Mentioning this would have probably been helpful in avoiding this. How to resolve this: I still think we need to use a favicon because of the aforementioned reasons. If I

[Wikidata-bugs] [Maniphest] [Commented On] T162673: Adjust code reading from wb_terms table to use full entity ID

2017-04-25 Thread daniel
daniel added a comment. In T162673#3209337, @Ladsgroup wrote: I mean it will be messy without a flag. Yea... but I think it will be just as messy with a flag. Maybe even worth.TASK DETAILhttps://phabricator.wikimedia.org/T162673EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread thiemowmde
thiemowmde added a comment. Uhm, pals. I already went through all this when I created T142104#2618898. It makes me sad to see multiple (!) people going through all the same already solved issues again. Don't you think it would be worth it to avoid this somehow? There is a 30px by 30px canvas for

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Charlie_WMDE
Charlie_WMDE added a comment. Per CSS, it's 30px by 30px: then I say let's stick with the favicon :)TASK DETAILhttps://phabricator.wikimedia.org/T142104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Charlie_WMDECc: WMDE-leszek, gerritbot, Ladsgroup, Izno,

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Charlie_WMDE
Charlie_WMDE added a comment. @Ladsgroup If it is that large (I'd say starting from 50x50px) we can safely use @thiemowmde 's version. No need for a favicon in that case. If it will gbe shown smaller on smaller screens I suggest sticking with the favicon. For the 3rd party installations I've

[Wikidata-bugs] [Maniphest] [Updated] T149456: Wikidata description change doesn't trigger mobile-sections update

2017-04-25 Thread NHarateh_WMF
NHarateh_WMF added a project: Reading-Infrastructure-Team-Backlog. TASK DETAILhttps://phabricator.wikimedia.org/T149456EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, NHarateh_WMFCc: GWicke, Niedzielski, mobrovac, daniel, aude, hoo, Pchelolo,

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Ladsgroup
Ladsgroup added a comment. Per CSS, it's 30px by 30px: .mw-echo-ui-notificationItemWidget-icon img { height: 30px; width: 30px; }TASK DETAILhttps://phabricator.wikimedia.org/T142104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc:

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Charlie_WMDE
Charlie_WMDE added a comment. @Ladsgroup do you know how many pixels are dedicated to the icon? or what range (depending ons screensize)? It seems larger than I thought.TASK DETAILhttps://phabricator.wikimedia.org/T142104EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Ladsgroup
Ladsgroup added a comment. It will look like this when implemented: F7752588: pasted_file (I used inspect to get this working, no backend magic)TASK DETAILhttps://phabricator.wikimedia.org/T142104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc:

[Wikidata-bugs] [Maniphest] [Commented On] T162673: Adjust code reading from wb_terms table to use full entity ID

2017-04-25 Thread Ladsgroup
Ladsgroup added a comment. I mean it will be messy without a flag.TASK DETAILhttps://phabricator.wikimedia.org/T162673EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, Aklapper, gerritbot, aude, WMDE-leszek, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T162673: Adjust code reading from wb_terms table to use full entity ID

2017-04-25 Thread daniel
daniel added a comment. @Ladsgroup Is it going to be less messy with the feature flag? You still need conditionals in the same places, plus you have to inject the flag...TASK DETAILhttps://phabricator.wikimedia.org/T162673EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error

2017-04-25 Thread daniel
daniel added a comment. @thiemowmde Whether the diff view code for EntityContent is called or not depends on which way you ask for the diff. When comparing two different kinds of content, it's unclear which diff code to use - that's exactly the reason the exception is thrown. The real solution to

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable "save" button until server responds

2017-04-25 Thread Danwe
Danwe added a comment. I don't think it's broken per se. In any case, supporting saving of unparsed values (i.e. ad-hoc parsing) is quite some new feature which would require a lot of work. By “ad-hoc parsing” do you mean client side parsing of the values on the front-end? We did this before and

[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo

2017-04-25 Thread daniel
daniel added a comment. My 2¢ on this: ChangeFactory should be split into a general factory in lib (defining the newForChangeType methods), and a RepoChangeFactory in the repo component, that has knowledge about EntityContent, Revision, etc. Any code that needs services or knowledge about repo

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Charlie_WMDE
Charlie_WMDE added a comment. hey @thiemowmde and @Ladsgroup thanks for your work on the icon. Lydia and I had discussed to use the favicon instead of the full Wikidata logo since on a small scale it starts looking kinda fuzzy with all the tiny lines. Using only blue is a good idea I think

[Wikidata-bugs] [Maniphest] [Commented On] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread daniel
daniel added a comment. A newFromGlobalState method isn't needed. We use this in classes that have or represent "static entry points", e.g. hook handlers. You are right that for a special page, this can be done by the factory class (or wiring file).TASK

[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo

2017-04-25 Thread thiemowmde
thiemowmde added a comment. @Aleksey_WMDE, the problem is this line: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Changes/EntityChange.php;52253d5b116df36849b2c44f787cbe3f256fedd2$201 This is code in lib, but it type hints against EntityContent and calls

[Wikidata-bugs] [Maniphest] [Commented On] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. So instead of the setXyzServices call in the constructor, the constructor should accept the services as parameters. Should a newFromGlobalState function also be added to the pages, which would do roughly what the constructor does now? That’s what I’ve seen

[Wikidata-bugs] [Maniphest] [Unblock] T103261: [Story] Improve UI on Special Page Constraint Report

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T102755: [Task] Sort table in Special Page (status AND claim) as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T103261EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Closed] T102755: [Task] Sort table in Special Page (status AND claim)

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from DOING to DONE on the Wikibase-Quality board. TASK DETAILhttps://phabricator.wikimedia.org/T102755WORKBOARDhttps://phabricator.wikimedia.org/project/board/989/EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo

2017-04-25 Thread Aleksey_WMDE
Aleksey_WMDE added a comment. Seems like task has incomplete description. I cannot understand what the problem is and also what needs to be changed and how. Can anyone provide more info?TASK DETAILhttps://phabricator.wikimedia.org/T75643EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T102755: [Task] Sort table in Special Page (status AND claim)

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 350132 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Further sort constraint report https://gerrit.wikimedia.org/r/350132TASK DETAILhttps://phabricator.wikimedia.org/T102755EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T163775: [Task] Release DataValues Geo 2.0.0

2017-04-25 Thread thiemowmde
thiemowmde closed subtask T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T163775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo,

[Wikidata-bugs] [Maniphest] [Closed] T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting.

2017-04-25 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde removed a project: Patch-For-Review.thiemowmde edited the task description. (Show Details) EDIT DETAILS...* [ ] Update Geo release notes * [ ] Tag Geo release * [ ] Possibly make Wikibase.git use it, if not pulled in automaticallyT163775TASK

[Wikidata-bugs] [Maniphest] [Triaged] T163775: [Task] Release DataValues Geo 2.0.0

2017-04-25 Thread thiemowmde
thiemowmde added a project: Patch-For-Review.thiemowmde triaged this task as "Normal" priority.thiemowmde moved this task from incoming to in current sprint on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T163775WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T163775: [Task] Release DataValues Geo 2.0.0

2017-04-25 Thread thiemowmde
thiemowmde added a subtask: T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting.. TASK DETAILhttps://phabricator.wikimedia.org/T163775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, Lydia_Pintscher, aude,

[Wikidata-bugs] [Maniphest] [Commented On] T162540: Edit entity special pages are too interwoven making it impossible to properly inject dependencies.

2017-04-25 Thread daniel
daniel added a comment. FTR, the setXyzServices() methods were introduced to allow services to be overwritten for testing, before proper injection was possible for SpecialPages. They can and indeed should be replaced by proper constructor injection now.TASK

[Wikidata-bugs] [Maniphest] [Updated] T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting.

2017-04-25 Thread thiemowmde
thiemowmde added a parent task: T163775: [Task] Release DataValues Geo 2.0.0. TASK DETAILhttps://phabricator.wikimedia.org/T161231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, JeroenDeDauw, Aleksey_WMDE, thiemowmde, gerritbot,

[Wikidata-bugs] [Maniphest] [Created] T163775: [Task] Release DataValues Geo 2.0.0

2017-04-25 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, DataValues, Wikidata-Sprint, Patch-For-Review.Herald added a subscriber: Aklapper.Herald removed a project: Patch-For-Review. TASK DESCRIPTIONWith T161231 we changed the GlobeCoordinateValue hashing, which technically is a breaking

[Wikidata-bugs] [Maniphest] [Updated] T102760: [Task] Hooks to keep constraint table up to date.

2017-04-25 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T102760EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, abian, Ricordisamoa, Andreasburmeister, Aklapper, Jonaskeutel, Adik2382, Th3d3v1ls,

[Wikidata-bugs] [Maniphest] [Commented On] T102760: [Task] Hooks to keep constraint table up to date.

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 349894 had a related patch set uploaded (by Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Import constraints from statements on properties https://gerrit.wikimedia.org/r/349894TASK

[Wikidata-bugs] [Maniphest] [Lowered Priority] T102763: [Task] Hooks to keep violations table up to date.

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE lowered the priority of this task from "High" to "Normal".Lucas_Werkmeister_WMDE moved this task from TODO to Backlog on the Wikibase-Quality board.Lucas_Werkmeister_WMDE added a comment. As far as I’m aware, WikibaseQualityConstraints currently does not save constraint

[Wikidata-bugs] [Maniphest] [Commented On] T141866: Provide a way to filter Wikidata's recent changes for language-dependent content in specific languages

2017-04-25 Thread ChristianKl
ChristianKl added a comment. From a privacy standpoint, I don't see why the language of an editor should be a secret. It's valuable information that helps other users to connect with the user. If I review language-agnostic content from users with whom I share no common language, my only choice is

[Wikidata-bugs] [Maniphest] [Claimed] T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting.

2017-04-25 Thread thiemowmde
thiemowmde claimed this task.thiemowmde added projects: DataValues, MediaWiki-extensions-WikibaseRepository.thiemowmde edited the task description. (Show Details) EDIT DETAILS...#patch-for-review: * [ * [x] https://gerrit.wikimedia.org/r/36 * [x] https://gerrit.wikimedia.org/r/344383 * [x]

[Wikidata-bugs] [Maniphest] [Created] T163774: The query services seems to have a problem with the new geoshape datatype

2017-04-25 Thread ChristianKl
ChristianKl created this task.ChristianKl added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIf I go to https://www.wikidata.org/wiki/Property_talk:P3896 and click on "Current Usage" the query finds no data, even though at least Q11299 uses the new property.TASK

Re: [Wikidata] Joining May 29, National Plan Open Science meeting in Delft, The Netherlands

2017-04-25 Thread Arne Wossink
Hi Egon, Thank you for taking on the role of coordinator! I'm happy to present anything if necessary, but that depends on the format of the day, I guess. Keep us informed if you need any additional information, or once you have new information to share with us! Best, Arne Wossink

[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Change 348080 adds a user script that shows a violation indicator, similar to Jan’s mockup. Here’s what it looks like: F7750910: image.png (The particular constraints here are not very meaningful, just added for testing. Also, the extension currently

[Wikidata-bugs] [Maniphest] [Commented On] T157974: [Task] rework "term box" and header for Lexeme

2017-04-25 Thread Jan_Dittrich
Jan_Dittrich added a comment. …we possibly could also have a "add different spelling" button in every Lexeme, but only show the table if we actually have different spellings.TASK DETAILhttps://phabricator.wikimedia.org/T157974EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T157974: [Task] rework "term box" and header for Lexeme

2017-04-25 Thread Jan_Dittrich
Jan_Dittrich added a comment. @Lydia_Pintscher This ticket includes the mockup you asked for. We would need to check how many words (lexemes) have multiple spellings (in which case we need the table)TASK DETAILhttps://phabricator.wikimedia.org/T157974EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 348080 had a related patch set uploaded (by Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add user script to include reports on item pages https://gerrit.wikimedia.org/r/348080TASK

[Wikidata-bugs] [Maniphest] [Updated] T97018: [Story] Integrate violations into Wikidata UI

2017-04-25 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer,

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. {icon thumbs-up}TASK DETAILhttps://phabricator.wikimedia.org/T142104EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, gerritbot, Ladsgroup, Izno, thiemowmde, Jan_Dittrich, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] [Claimed] T102755: [Task] Sort table in Special Page (status AND claim)

2017-04-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE moved this task from WBQC Backlog to DOING on the Wikibase-Quality board.Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T142104: Decide on a nice logo for Echo notifications

2017-04-25 Thread thiemowmde
thiemowmde added a comment. @Ladsgroup: Here is a blue Wikidata logo using the #36c color from the current Wikimedia style guide. Extracted from what I posted in T142104#2618898. Made to be pixel perfect in 30 by 30 pixels. Already optimized using SVGOMG. F7750606: Wikidata Echo notification icon

[Wikidata-bugs] [Maniphest] [Commented On] T102755: [Task] Sort table in Special Page (status AND claim)

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 350132 had a related patch set uploaded (by Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Further sort constraint report https://gerrit.wikimedia.org/r/350132TASK DETAILhttps://phabricator.wikimedia.org/T102755EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T102755: [Task] Sort table in Special Page (status AND claim)

2017-04-25 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T102755EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Jonaskeutel, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99,

[Wikidata-bugs] [Maniphest] [Closed] T163205: De-deploy the PagePreviews extension on Wikidata and Wiktionary

2017-04-25 Thread phuedx
phuedx closed this task as "Resolved".phuedx added a comment. I don't see the Popups extension listed on https://www.wikidata.org/wiki/Special:Version nor https://en.wiktionary.org/wiki/Special:Version.TASK DETAILhttps://phabricator.wikimedia.org/T163205EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting.

2017-04-25 Thread WMDE-leszek
WMDE-leszek added a comment. All patches mentioned in the task description have been either merged or dropped. That means now the new release of DataValues/Geo is needed, and that would be it? Or is there anything else here, which was not mentioned so far?TASK

Re: [Wikidata] Bogous cookie header in federated query

2017-04-25 Thread Neubert, Joachim
Hi Stas, You are right, the header should be correct. There seems to be a long-lasting issue in Apache HttpClient (https://issues.apache.org/jira/browse/HTTPCLIENT-923), dating back to a disambiguity in an old Netcape cookie spec. Sorry, I've to address this to the Apache guys. Cheers,

[Wikidata-bugs] [Maniphest] [Commented On] T162673: Adjust code reading from wb_terms table to use full entity ID

2017-04-25 Thread Ladsgroup
Ladsgroup added a comment. I checked the codebase and it seems it's not easily doable to do it without a feature flag. The code and queries will become complex and messy and I'm not sure if we want that. There are three places that depend on 'term_entity_id': TermSqlIndex,

[Wikidata-bugs] [Maniphest] [Closed] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-25 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, LadsgroupCc: gerritbot, thiemowmde, daniel, Aklapper, Ladsgroup, Adik2382, Th3d3v1ls, Ramalepe, Liugev6,

[Wikidata-bugs] [Maniphest] [Unblock] T160524: [Story] Add Form to list of Forms

2017-04-25 Thread Ladsgroup
Ladsgroup closed subtask T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T160524EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Aleksey_WMDE, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T161789: [Task] Introduce HTML templates infrastructure for Wikibase Lexeme

2017-04-25 Thread gerritbot
gerritbot added a comment. Change 347337 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Remove subclassing and unused code from LexemeTemplateFactory https://gerrit.wikimedia.org/r/347337TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL

  1   2   >