[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518349 **merged** by jenkins-bot: [mediawiki/services/recommendation-api@master] Temporarily disable flaky tests https://gerrit.wikimedia.org/r/518349 TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Smalyshev, MSantos, Aklapper, Mholloway, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518349 had a related patch set uploaded (by Bmansurov; owner: Bmansurov): [mediawiki/services/recommendation-api@master] Temporarily disable flaky tests https://gerrit.wikimedia.org/r/518349 TASK DETAIL https://phabricator.wikimedia.org/T226264

[Wikidata-bugs] [Maniphest] [Declined] T170788: Provide a more direct way to access an item's ID

2019-06-21 Thread Smalyshev
Smalyshev closed this task as "Declined". Smalyshev added a comment. Restricted Application added a subscriber: Liuxinyu970226. `STRAFTER( STR( ?item ), STR( wd: ) )` looks like sensible solution for this. TASK DETAIL https://phabricator.wikimedia.org/T170788 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T226285: Mobileview cache not cleared after wikidata edits

2019-06-21 Thread Addshore
Addshore added a project: Wikidata. Addshore added a comment. Did the desktop view of the article have its cache cleared? Which cache are we talking about here? varnish cache or parser cache? TASK DETAIL https://phabricator.wikimedia.org/T226285 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Triaged] T226292: Remove all tracking except for format usage from wmde-analytics-scripts apiLogScanner.php script

2019-06-21 Thread Addshore
Addshore moved this task from Incoming to Ready to go on the Wikidata-Campsite board. Addshore triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T226292 WORKBOARD https://phabricator.wikimedia.org/project/board/3402/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T226292: Remove all tracking except for format usage from wmde-analytics-scripts apiLogScanner.php script

2019-06-21 Thread Addshore
Addshore created this task. Addshore added projects: WMDE-Analytics-Engineering, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION The Wikidata api dashboard has been stripped back to only show the format

[Wikidata-bugs] [Maniphest] [Updated] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-06-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T222449 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: WMDE-leszek, hoo, Ladsgroup, Michael, darthmon_wmde, alaa_wmde, Nandana,

[Wikidata-bugs] [Maniphest] [Updated] T219366: Consider using CombinedEntitySearchHelper with EntitySearchElastic and EntityIdSearchHelper for wikidata.org

2019-06-21 Thread Smalyshev
Smalyshev added a comment. I think this is what 2385879c4d64e027a4122aee20655e365628f6ef in WikibaseCirrusSearch did? TASK DETAIL https://phabricator.wikimedia.org/T219366 EMAIL PREFERENCES

[Wikidata] question about the status of wikidata statement sources

2019-06-21 Thread Heather Ford
I have a question about the status of unreferenced statements in Wikidata. I just looked at the live stats [1] and it looks like about two thirds of statements are now referenced. That's a great achievement from 2016 when it was the opposite, right? I was wondering how this was achieved? I know

[Wikidata-bugs] [Maniphest] [Updated] T153866: Wikibase hacks prevent AbuseFilter from inserting revision ids

2019-06-21 Thread Addshore
Addshore added a project: AbuseFilter. TASK DETAIL https://phabricator.wikimedia.org/T153866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, matej_suchanek, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Daimona,

[Wikidata-bugs] [Maniphest] [Commented On] T153866: Wikibase hacks prevent AbuseFilter from inserting revision ids

2019-06-21 Thread Addshore
Addshore added a comment. So, Wikibase does not run PageContentSaveComplete itself, this is done within core. This is now done in PageUpdater.php (i just updated the mw.org docs)

[Wikidata-bugs] [Maniphest] [Updated] T224905: Move wikiba.se tests from php56 to php72

2019-06-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T224905 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: hashar, Dzahn, Ladsgroup, WMDE-leszek, Jdforrester-WMF, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T226218: snak hashes should not appear in AbuseFilter text for Wikibase

2019-06-21 Thread Addshore
Addshore added a project: Performance. TASK DETAIL https://phabricator.wikimedia.org/T226218 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Sjoerddebruin, matej_suchanek, Aklapper, alaa_wmde, Addshore, darthmon_wmde, Nandana, Lahi,

Re: [Wikidata] Scaling Wikidata Query Service

2019-06-21 Thread Thibaut DEVERAUX
Dear, I've seen this suggestion on Quora : https://www.quora.com/Wouldnt-a-mix-database-system-that-handle-both-JSON-documents-and-graph-functions-like-ArangoDB-provide-a-better-scalability-to-enormous-knowledge-graphs-like-Wikidata-than-a-classical-quadstore I'm not qualified enough to know

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Mahir256
Mahir256 added subscribers: Lsj, Mahir256. Mahir256 added a comment. The bug, if there is any, is in GeoNames or in wherever else @Lsj's bot obtains its geographic information. Ultimately it must be corrected there or there is still a risk of reintroducing it to Wikidata. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Addshore
Addshore added a comment. > Magnus ran into this and this is very confusing and inconsistent. The longer we wait with fixing this, the more effort it will cost. Totally agree there, we have already put this off for years. It's a pretty breaking change though. But with the correct

[Wikidata-bugs] [Maniphest] [Commented On] T222159: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON

2019-06-21 Thread Addshore
Addshore added a comment. Would be great to get this fixed by the #structureddataoncommons team, should be pretty trivial! TASK DETAIL https://phabricator.wikimedia.org/T222159 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Edited] T226152: Add WikibaseSchema extension to wikibase-docker bundle image

2019-06-21 Thread Addshore
Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T226152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lydia_Pintscher, Addshore, Aklapper, Jelabra, darthmon_wmde, pdehaye, Michael, Nandana, Lahi,

[Wikidata-bugs] [Maniphest] [Retitled] T226152: Add WikibaseSchema extension to wikibase-docker bundle image

2019-06-21 Thread Addshore
Addshore renamed this task from "Add WikibaseSchema extension to wikibase-docker" to "Add WikibaseSchema extension to wikibase-docker bundle image". TASK DETAIL https://phabricator.wikimedia.org/T226152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Triaged] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread Addshore
Addshore triaged this task as "Low" priority. Addshore moved this task from Backlog to Campsite Candidates on the Wikidata Tech Debt Exploration board. TASK DETAIL https://phabricator.wikimedia.org/T226254 WORKBOARD https://phabricator.wikimedia.org/project/board/4106/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218901: Track number of Wikidata edits by namespace

2019-06-21 Thread Addshore
Addshore added a comment. This dashboard panel should probably use the time range selected for the dashboard as a whole. This will allow users of the dashboard to easily look at different ranges of data for the panel without needing someone to actually edit the dashboard. I'm aware

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment. Hmm, now that I'm digging, I see that the batching was just introduced: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/9603d4282492103eecc0b1646ea2911138c848af%5E%21/lib/article.creation.translation.js TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment. Sure. The specific URL that the flaky test is hitting is https://de.wikipedia.org/api/rest_v1/data/recommendation/article/creation/translation/en. Under the hood, the service is querying WDQS with this up to 10 times in rapid succession, for a batched set of

[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26). TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, ReleaseTaggerBot Cc: alaa_wmde, hashar, noarave, Daimona,

[Wikidata] Clean up of Mediawiki:Common.css

2019-06-21 Thread Amir Sarabadani
Hey, With introduction of TemplateStyles [1], there is no need to put CSS of all templates like Navbox in Common.css [2] anymore, You can simply put them in a page like [3] and inject those into DOM when needed (that makes lots of sense for templates with limited usage because Common.css is loaded

[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518310 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [wikidata/query/blazegraph@master] Fix writing JSON result literals https://gerrit.wikimedia.org/r/518310 TASK DETAIL https://phabricator.wikimedia.org/T225996 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T225996 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, Lucas_Werkmeister_WMDE,

Re: [Wikidata] Result format change for WDQS JSON query output

2019-06-21 Thread Stas Malyshev
Hi! > from 2014, so I will research which form is more correct. But for now I > would recommend to update the tools to recognize that these literals now > may have type. If I discover that the standards or accepted practices > recommend otherwise, I'll update further. You can also watch >

[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment. OK, I did a survey of existing SPARQL endpoints and looks like they all omit datatypes on plain literals on JSON. So I'll fix WDQS to do the same. TASK DETAIL https://phabricator.wikimedia.org/T225996 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment. This: https://issues.apache.org/jira/browse/JENA-1077 suggests JENA also thinks types should be omitted on output for plain/language literals. TASK DETAIL https://phabricator.wikimedia.org/T225996 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment. > The rules for the XML and JSON results formats are that the implicit datatype of langtagged literals is omitted. The problem is I haven't see this codified in any standard. JSON result standard predates RDF 1.1 so I can't be sure whether it's just out of

[Wikidata-bugs] [Maniphest] [Closed] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Jdforrester-WMF
Jdforrester-WMF removed a project: Patch-For-Review. Jdforrester-WMF closed this task as "Resolved". Jdforrester-WMF assigned this task to alaa_wmde. Jdforrester-WMF added a comment. Thank you for fixing this. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518236 **merged** by Jforrester: [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on WikibaseLexeme and make pass https://gerrit.wikimedia.org/r/518236 TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Smalyshev
Smalyshev added a comment. Could you give some details on what recommendation API is actually doing there? Maybe post a link to the relevant code and probably explanation of which queries it is running and how often? Generally 429 means it is sending too many queries too often. Which

[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

2019-06-21 Thread Keegan
Keegan added a comment. I should have some sort of update on Monday relating to this. TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Keegan Cc: Keegan, Jheald, Mike_Peel, Cparle, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518249 abandoned by Jforrester: Temporarily suppress phan checks to unbreak build. Reason: Squashed into parent. https://gerrit.wikimedia.org/r/518249 TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226152: Add WikibaseSchema extension to wikibase-docker

2019-06-21 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. In T226152#5272025 , @Addshore wrote: > The one thing to be decided here is should this be in the base image or the bundle? > I'm personally leaning toward the bundle, and keeping the base image as

[Wikidata-bugs] [Maniphest] [Unblock] T208489: [Story] Create LilyPond datatype

2019-06-21 Thread alaa_wmde
alaa_wmde closed subtask T218191: Long score overlaps with statement box and edit button as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T208489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, alaa_wmde Cc: alaa_wmde,

[Wikidata-bugs] [Maniphest] [Closed] T218191: Long score overlaps with statement box and edit button

2019-06-21 Thread alaa_wmde
alaa_wmde moved this task from Stalled/Waiting to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. alaa_wmde closed this task as "Resolved". alaa_wmde added a comment. T226269 is to cover the issue we encountered with bumping up

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a comment. https://commons.wikimedia.org/wiki/File:Wikidata_statement.svg might be useful for the relation between a claim and a statement. TASK DETAIL https://phabricator.wikimedia.org/T149410 EMAIL PREFERENCES

Re: [Wikidata] Overload of query.wikidata.org (Guillaume Lederrey)

2019-06-21 Thread Imre Samu
good news :) - the issue has been fixed in the 0.6.7 release - and it is working again! https://github.com/nichtich/wikidata-taxonomy/commit/97abd4158b3c4ba9cd2c53503ca6b8b2ca29bc2a Imre Stas Malyshev ezt írta (időpont: 2019. jún. 19., Sze, 0:22): > Hi! > > On 6/18/19 2:29 PM, Tim Finin

[Wikidata-bugs] [Maniphest] [Retitled] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway renamed this task from "CI testing is flaky due to frequent 429s from Wikidata Query Service" to "Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service". TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T226264: CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway created this task. Mholloway added projects: Recommendation-API, Wikidata-Query-Service. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION The recommendation API CI tests frequently fail due to a 429 response from

[Wikidata-bugs] [Maniphest] [Unblock] T46529: Wikidata search problems (tracking)

2019-06-21 Thread debt
debt closed subtask T55652: Special:Search doesnt use labels and descriptions for suggestions but just the item ID as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T46529 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: debt Cc:

[Wikidata-bugs] [Maniphest] [Closed] T55652: Special:Search doesn't use labels and descriptions for suggestions but just the item ID

2019-06-21 Thread debt
debt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T55652 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, debt Cc: Lea_Lacroix_WMDE, gerritbot, Smalyshev, Wikidata-bugs, Yair_rand, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Closed] T206256: Un-redirected items should be instant-indexed

2019-06-21 Thread debt
debt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T206256 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, debt Cc: Aklapper, Sjoerddebruin, Smalyshev, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Closed] T221832: Create Cookbook to restart WDQS

2019-06-21 Thread debt
debt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T221832 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mathew.onipe, debt Cc: Lucas_Werkmeister_WMDE, Smalyshev, Mathew.onipe, Gehel, Aklapper, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Closed] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T225935 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Lucas_Werkmeister_WMDE Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Unblock] T225938: Implement Testing Environment

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T225948: 1.- Research Webpack + RL as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T225938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] [Closed] T225948: 1.- Research Webpack + RL

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T225948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE Cc: Michael, Matthias_Geisler_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Unblock] T225937: Implement Bridge Setup

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T225935: Implement Feature Flag for Mediawiki as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T225937 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T225952: 4.- Linting

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518246 abandoned by Lucas Werkmeister (WMDE): bridge: also apply eslint to own config file Reason: squashed into parent change https://gerrit.wikimedia.org/r/518246 TASK DETAIL https://phabricator.wikimedia.org/T225952 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518041 abandoned by Pablo Grass (WMDE): reset css: ability to replace some selectors Reason: This does work somewhat but is costly (as in "not clear") and still does not resolve the task at hand completely as the use of the :not pseudo-selector

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment. > Ah, I haven't been clear. Extensions *should* override the default config, e.g. to define additional dependencies (many extensions do that). But it's vital that the default config is first included, then overridden for the necessary part. What happened for

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. In T226244#5273866 , @alaa_wmde wrote: > @Daimona understood. I also think the clean-up work is necessary. I'm not such a fan of statements of the sort "extensions must use mediawiki config rather than

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518248 **merged** by jenkins-bot: [wikibase/termbox@master] Re-add padding to externally styled `.external` link https://gerrit.wikimedia.org/r/518248 TASK DETAIL https://phabricator.wikimedia.org/T221835 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment. @Daimona understood. I also think the clean-up work is necessary. I'm not such a fan of statements of the sort "extensions must use mediawiki config rather than overriding/changing them" but that's a separate topic anyway. > At this point, I'd like to fix all

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. In T226244#5273853 , @alaa_wmde wrote: > In T226244#5273849 , @gerritbot wrote: > > > Change 518256 had a related patch set uploaded (by Daimona Eaytoy;

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment. In T226244#5273849 , @gerritbot wrote: > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): > [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup config https://gerrit.wikimedia.org/r/518256 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T225935 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Maintenance_bot Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Commented On] T225930: Implement Link Counter

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518255 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Implement basic link counter in typescript https://gerrit.wikimedia.org/r/518255 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26). TASK DETAIL https://phabricator.wikimedia.org/T225935 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, ReleaseTaggerBot Cc: Aklapper, darthmon_wmde, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Edited] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T226254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Created] T226255: Log and count occurances of save attempts of alises containing pipes

2019-06-21 Thread noarave
noarave created this task. noarave added projects: Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Based on the result of T223270 , we would like to know how often users attempt to save aliases

[Wikidata-bugs] [Maniphest] [Edited] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T226254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Created] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added projects: Wikidata Tech Debt Exploration, Wikidata, phan. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION From Lexeme's `.phan/config.php`: 'suppress_issue_types' => [ // ... //

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518249 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/WikibaseLexeme@master] Temporarily suppress phan checks to unbreak build. https://gerrit.wikimedia.org/r/518249 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518248 had a related patch set uploaded (by Jakob; owner: Jakob): [wikibase/termbox@master] Re-add padding to externally styled `.external` link https://gerrit.wikimedia.org/r/518248 TASK DETAIL https://phabricator.wikimedia.org/T221835 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 517657 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Add feature flag to enable Wikidata bridge https://gerrit.wikimedia.org/r/517657 TASK DETAIL https://phabricator.wikimedia.org/T225935 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T225952: 4.- Linting

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518246 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: also apply eslint to own config file https://gerrit.wikimedia.org/r/518246 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment. Another possible source? WikibaseLexeme `.phan/config.php` looks different from Wikibase one. For example, one reported error on Lexeme build: 12:37:08 12:37:08 12:37:08 Looking in Lexemes phan config, `PhanUnreferencedUseNormal`

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. @noarave It actually did. It's just that phan completed its analysis and found several errors. Of note, you should also add a phan config file - I can amend your patch, although I don't know if I'll have time to fix all the errors. @hashar Actually, it's not

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread hashar
hashar added a comment. That did cause the container to trigger the installation of phan 1.3.4 instead of the outdated 0.8.0 fallback. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/518236/ now fails because of new Phan reported errors. I guess the easiest is

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread noarave
noarave added a comment. @Daimona unfortunately requiring phan config 0.6.1 in composer.json did not seem to have an effect. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc:

[Wikidata-bugs] [Maniphest] [Updated] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T225212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518239 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Specify $wgWBRepoSettings['conceptBaseUri'] again https://gerrit.wikimedia.org/r/518239 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518048 abandoned by Jakob: reset css: ability to replace some selectors https://gerrit.wikimedia.org/r/518048 TASK DETAIL https://phabricator.wikimedia.org/T221835 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment. No I have not explained it well then. Try to think of it in terms of postal districts or voting districts. As a town grows, generally neighboring villages are annexed, but they do not lose their postal codes or voting district names. This is just as true for the

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread jjkoehorst
jjkoehorst added a comment. So if I understand it correctly, Q33512910 is the historical entity of Wageningen and Q1305 is the current city of Wageningen? What exactly is meant by historical? 100 years, 10 years? ... Also can we not report in the current wageningen historical changes using

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment. Yes sorry if the statements seem so ambiguous, this is just one of many cases where such things occur. One is a historic city and one is a current city. The problem probably arises because there is so little left of the original historic center in today's city, due

[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518236 had a related patch set uploaded (by Noa wmde; owner: Noa wmde): [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on WikibaseLexeme https://gerrit.wikimedia.org/r/518236 TASK DETAIL https://phabricator.wikimedia.org/T226244

[Wikidata-bugs] [Maniphest] [Commented On] T223372: Constraint was removed from property but still displayed on Lexeme

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Note: after the fix is deployed, we should also run `extensions/WikibaseQualityConstraints/maintenance/ImportConstraintStatements.php` to fix the constraints for all current properties without having to wait for the next constraint statements edit.

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. AIUI, only the last mentioned patch is culprit. The dependency on Wikibase should only be used to tell what MW extensions to install before testing Lexeme, but that shouldn't be related to the phan version to use. What happened, instead, is that IMHO phan72 jobs

[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana,

[Wikidata-bugs] [Maniphest] [Triaged] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T226244 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, Sadisticturd,

[Wikidata-bugs] [Maniphest] [Created] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael created this task. Michael added projects: Wikidata-Campsite, User-Michael, Continuous-Integration-Config, phan. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Currently, all Lexeme builds fail with an error in

[Wikidata-bugs] [Maniphest] [Updated] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag added a comment. In T226238#5273387 , @Jane023 wrote: > I am back and after checking, happy to report I was right. One is the town, and the other is the municipality. They are not the same and should not be merged.

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment. The message you received was correct. There is a help page for this: https://www.wikidata.org/wiki/Help:Merge TASK DETAIL https://phabricator.wikimedia.org/T226238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jane023

[Wikidata-bugs] [Maniphest] [Commented On] T225950: 3.- Jest unit test + CI

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518228 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] tests: allow jest watch inside container https://gerrit.wikimedia.org/r/518228 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag added a comment. In T226238#5273312 , @Aklapper wrote: > @Andrawaag: What is "Merge Wizard"? Where to find / see Merge Wizard? Is this on wikidata.org ? Please include steps to reproduce and set a project tag, if possible, so

[Wikidata-bugs] [Maniphest] [Edited] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T226238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Andrawaag Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a subscriber: Bene. Multichill added a comment. Serialization: - https://github.com/wmde/WikibaseDataModelSerialization/blob/master/src/Serializers/ItemSerializer.php#L127 -

[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment. I am back and after checking, happy to report I was right. One is the town, and the other is the municipality. They are not the same and should not be merged. TASK DETAIL https://phabricator.wikimedia.org/T226238 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T222159: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T222159 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, JKSTNK,

[Wikidata-bugs] [Maniphest] [Updated] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a subscriber: Lucas_Werkmeister_WMDE. Multichill added a comment. Another inconsistency pointed out by @Lucas_Werkmeister_WMDE is at T222159 TASK DETAIL https://phabricator.wikimedia.org/T149410 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Reedy
Reedy added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T226238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a comment. Magnus ran into this and this is very confusing and inconsistent. The longer we wait with fixing this, the more effort it will cost. Example https://commons.wikimedia.org/w/api.php?action=wbgetentities=M27401711 uses "statements" as the key, but we expect

  1   2   >