[Wikidata-bugs] [Maniphest] [Commented On] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision

2019-05-29 Thread gerritbot
gerritbot added a comment. Change 513092 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/EntitySchema@master] Fix Exception by forcing default diff engine and renderer https://gerrit.wikimedia.org/r/513092 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision

2019-05-29 Thread Michael
Michael added a comment. yeah, I'm just about to create a patch. We need to both create that renderer ourselves and force the default DiffEngine, because InlineDifferenceEngine doesn't expect a diff body made of table rows :/ TASK DETAIL https://phabricator.wikimedia.org/T224545 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision

2019-05-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. MobileFrontend hooks into `GetDifferenceEngine` to return an `InlineDifferenceEngine` on Special:MobileFrontend; `ContentHandler::getSlotDiffRenderer` then returns a `DifferenceEngineSlotDiffRenderer` instead of the `TextSlotDiffRenderer` we expect

[Wikidata-bugs] [Maniphest] [Claimed] T224548: Make (yellow) warning background wider than rest of content

2019-05-29 Thread Jakob_WMDE
Jakob_WMDE claimed this task. Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-16 board. TASK DETAIL https://phabricator.wikimedia.org/T224548 WORKBOARD https://phabricator.wikimedia.org/project/board/4057/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Claimed] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision

2019-05-29 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T224545 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Claimed] T224540: Polish checkbox

2019-05-29 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T224540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE Cc: Aklapper, Pablo-WMDE, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john,

[Wikidata-bugs] [Maniphest] [Updated] T223542: Focus modal CTAs instead of publish button

2019-05-29 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T223542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Maintenance_bot Cc: Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE, Lea_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T224504: Implement database-based PropertyTermStore

2019-05-29 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T224504 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T223985: Use checkbox in AnonEditWarning

2019-05-29 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T223985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, gerritbot Cc: Aklapper, Pablo-WMDE, E.S.A-Sheild, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Commented On] T223985: Use checkbox in AnonEditWarning

2019-05-29 Thread gerritbot
gerritbot added a comment. Change 513075 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] termbox: messages to permanently dismiss AnonEditWarning https://gerrit.wikimedia.org/r/513075 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T224504: Implement database-based PropertyTermStore

2019-05-29 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04). TASK DETAIL https://phabricator.wikimedia.org/T224504 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: alaa_wmde, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T224504: Implement database-based PropertyTermStore

2019-05-29 Thread gerritbot
gerritbot added a comment. Change 512739 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add DatabasePropertyTermStore https://gerrit.wikimedia.org/r/512739 TASK DETAIL https://phabricator.wikimedia.org/T224504 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223542: Focus modal CTAs instead of publish button

2019-05-29 Thread gerritbot
gerritbot added a comment. Change 512927 **merged** by jenkins-bot: [wikibase/termbox@master] AnonEditWarning: focus before buttons https://gerrit.wikimedia.org/r/512927 TASK DETAIL https://phabricator.wikimedia.org/T223542 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T224548: Make (yellow) warning background wider than rest of content

2019-05-29 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION See figma, the yellow stretches further left & right than the rest of the overlay content. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

2019-05-29 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE added a comment. As yesterday here the short summery of how we go on with the font-size question: OOUI defines the default font-size of 0.875em (===14px)[1]. The only exception is for screen-width-sizes of 320px-960px[2], there the font-size is 1em. After checking

[Wikidata-bugs] [Maniphest] [Unblock] T208381: mediawiki - node SSR HTTP request follow-up [2*2h]

2019-05-29 Thread Tarrow
Tarrow closed subtask T215921: Configure helm chart as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T208381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: WMDE-leszek, Addshore, Aklapper, Jakob_WMDE, Pablo-WMDE, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Closed] T215921: Configure helm chart

2019-05-29 Thread Tarrow
Tarrow closed this task as "Resolved". Tarrow claimed this task. Tarrow added a comment. Looks like SRE did this for us as part of T220402 :) TASK DETAIL https://phabricator.wikimedia.org/T215921 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unassigned] T224533: WD within WP watchlists: Allow hiding changes to descriptions used in other languages

2019-05-29 Thread Aklapper
Aklapper removed Ladsgroup as the assignee of this task. Aklapper added a subscriber: Ladsgroup. Aklapper removed a project: User-Ladsgroup. Aklapper added a comment. @Doc_James: Please do not assign tasks to someone else without their explicit agreement.

[Wikidata-bugs] [Maniphest] [Unassigned] T224532: WD within WP watchlists: Allow hiding new language versions of articles

2019-05-29 Thread Aklapper
Aklapper removed Ladsgroup as the assignee of this task. Aklapper added a subscriber: Ladsgroup. Aklapper removed a project: User-Ladsgroup. Aklapper added a comment. @Doc_James: Please do not assign tasks to someone else without their explicit agreement.

[Wikidata-bugs] [Maniphest] [Created] T224545: UnexpectedValueException when looking at a Special:MobileDiff for an EntitySchema Revision

2019-05-29 Thread Michael
Michael created this task. Michael added projects: Wikimedia-production-error, Wikidata, Wikidata-Campsite, Shape Expressions. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request URL: https://www.wikidata.org/wiki/Special:MobileDiff/951170414

[Wikidata-bugs] [Maniphest] [Edited] T224537: Merge EntitySchemas

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T224537 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Triaged] T224536: Add EntitySchema in the license footage

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite. Lydia_Pintscher triaged this task as "High" priority. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T224536 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Raised Priority] T214884: linking Schemas in statements

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher raised the priority of this task from "Normal" to "High". TASK DETAIL https://phabricator.wikimedia.org/T214884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Updated] T214884: linking Schemas in statements

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T214884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, darthmon_wmde, Premeditated, pdehaye, Michael,

[Wikidata-bugs] [Maniphest] [Updated] T224537: Merge EntitySchemas

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T224537 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Closed] T221706: Implement PropertyTermStore wikibase-term-store using MW DBAL

2019-05-29 Thread alaa_wmde
alaa_wmde closed this task as "Invalid". alaa_wmde added a comment. Duplicate of T224504 TASK DETAIL https://phabricator.wikimedia.org/T221706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde

[Wikidata-bugs] [Maniphest] [Created] T224544: Update Wikibase terms lookup/search logic to use ItemTermStore

2019-05-29 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata. TASK DESCRIPTION - ItemTermStore should be used to **lookup** terms of Items (starting from item id) that are below the upper-bound configured in T224542

[Wikidata-bugs] [Maniphest] [Created] T224543: Update Wikibase terms lookup/search logic to use PropertTermStore

2019-05-29 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata. TASK DESCRIPTION PropertyTermStore should be used to lookup/search terms of Properties once properties migration is switched to `read new ` phase TASK DETAIL

[Wikidata-bugs] [Maniphest] [Created] T224542: Update Wikibase entity saving logic to use ItemTermStore

2019-05-29 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata. TASK DESCRIPTION ItemStermStore should be used when migration of item terms is switched to the mode `write one`. The upper-bound item id that is written to new schema is determined as part of this

[Wikidata-bugs] [Maniphest] [Commented On] T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again

2019-05-29 Thread Michael
Michael added a comment. It is at least //still// the known situation, see https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-WikibaseLexeme/284/artifact/log/shows-Forms-header.png For the other failures it is hard to tell apart if there was a 500 error or genuine

[Wikidata-bugs] [Maniphest] [Created] T224541: Update Wikibase entity saving logic to use PropertyTermStore

2019-05-29 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata. TASK DESCRIPTION PropertyTermStore should be used when migration is switched to `write new` mode. TASK DETAIL https://phabricator.wikimedia.org/T224541 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Urbanecm
Urbanecm added a comment. @Etonkovidova Hi, I can see "Wikidata edits" in your second screenshot. However, in the screenshot from task's description (F29258444 ), there's nothing saying "Wikidata". I understand that the filters understands

[Wikidata-bugs] [Maniphest] [Updated] T224540: Polish checkbox

2019-05-29 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T224540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Pablo-WMDE, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD,

[Wikidata-bugs] [Maniphest] [Commented On] T224540: Polish checkbox

2019-05-29 Thread gerritbot
gerritbot added a comment. Change 513036 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [wikibase/termbox@master] Checkbox: allow inline use and fix collapsing image https://gerrit.wikimedia.org/r/513036 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Closed] T221713: Implement lookup logic in mediawiki-term-store

2019-05-29 Thread alaa_wmde
alaa_wmde closed this task as "Invalid". alaa_wmde added a comment. Covered by T224504 and T224527 TASK DETAIL https://phabricator.wikimedia.org/T221713 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T221710: [Story] Develop Lookup functionality

2019-05-29 Thread alaa_wmde
alaa_wmde closed subtask T221713: Implement lookup logic in mediawiki-term-store as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T221710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Updated] T224504: Implement database-based PropertyTermStore

2019-05-29 Thread alaa_wmde
alaa_wmde added a parent task: T221710: [Story] Develop Lookup functionality. TASK DETAIL https://phabricator.wikimedia.org/T224504 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, alaa_wmde Cc: alaa_wmde, Aklapper,

[Wikidata-bugs] [Maniphest] [Unblock] T219123: [Checkpoint 6] Migrate item terms

2019-05-29 Thread alaa_wmde
alaa_wmde closed subtask T221715: Implement ItemTermStore in mediawiki dbal lib as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T219123 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Closed] T221711: Create abstract lookup classes/methods in wikibase-term-store

2019-05-29 Thread alaa_wmde
alaa_wmde closed this task as "Invalid". alaa_wmde added a comment. Not needed TASK DETAIL https://phabricator.wikimedia.org/T221711 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Closed] T221715: Implement ItemTermStore in mediawiki dbal lib

2019-05-29 Thread alaa_wmde
alaa_wmde closed this task as "Invalid". alaa_wmde added a comment. Duplicate of T224527 TASK DETAIL https://phabricator.wikimedia.org/T221715 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde

[Wikidata-bugs] [Maniphest] [Unblock] T221710: [Story] Develop Lookup functionality

2019-05-29 Thread alaa_wmde
alaa_wmde closed subtask T221711: Create abstract lookup classes/methods in wikibase-term-store as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T221710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde,

[Wikidata-bugs] [Maniphest] [Updated] T221710: [Story] Develop Lookup functionality

2019-05-29 Thread alaa_wmde
alaa_wmde added a subtask: T224504: Implement database-based PropertyTermStore. TASK DETAIL https://phabricator.wikimedia.org/T221710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T224525: Error when running a clean wikibase-docker image: Config.getConfig is not a function

2019-05-29 Thread Lydia_Pintscher
Lydia_Pintscher added subscribers: Tarrow, Addshore, Lydia_Pintscher. Lydia_Pintscher added a comment. @Tarrow @Addshore: Could you have a quick look? TASK DETAIL https://phabricator.wikimedia.org/T224525 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T224540: Polish checkbox

2019-05-29 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION When first using the checkbox in AnonEditWarning if found a few rough edges which need polishing. Please find

[Wikidata-bugs] [Maniphest] [Unblock] T203337: Fix wbeditentity API ignoring setting aliases to an empty set

2019-05-29 Thread WMDE-leszek
WMDE-leszek closed subtask T223300: On beta enable bugfix for wbeditentity setting aliases to empty array as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T203337 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Michael,

[Wikidata-bugs] [Maniphest] [Closed] T223300: On beta enable bugfix for wbeditentity setting aliases to empty array

2019-05-29 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T223300 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, WMDE-leszek Cc: Lea_Lacroix_WMDE, WMDE-leszek, Michael, darthmon_wmde, Premeditated,

[Wikidata-bugs] [Maniphest] [Commented On] T224303: Wikibase Repo prevents page moves in NS 0 on Commons

2019-05-29 Thread Reedy
Reedy added a comment. $entityNamespaces = self::buildEntityNamespaceConfigurations( $settings ); Hooks::run( 'WikibaseRepoEntityNamespaces', [ &$entityNamespaces ] ); > var_dump( Wikibase\WikibaseSettings::getRepoSettings() );

[Wikidata-bugs] [Maniphest] [Commented On] T224303: Wikibase Repo prevents page moves in NS 0 on Commons

2019-05-29 Thread WMDE-leszek
WMDE-leszek added a comment. @Abit Reallistically not sooner than next week, sorry. This requires some code change, we'll try targeting the next deployment train. TASK DETAIL https://phabricator.wikimedia.org/T224303 EMAIL PREFERENCES

<    1   2