[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema

2024-05-21 Thread Krinkle
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board. Krinkle added a comment. Might be a good candidate for a "structure" test with PHPUnit. This would be similar to what we do with autoloader, config artefacts, and other generated files in core. T

[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema

2024-05-21 Thread Krinkle
Krinkle triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T317180 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benja

[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema

2024-05-21 Thread Krinkle
Krinkle renamed this task from "Consistently generate schema (change) files in Wikibase" to "Auto-verify in CI the SQL files generated by Rdbms abstract schema". Krinkle added a project: MediaWiki-Core-Tests. Krinkle updated the task description. TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context

2024-05-14 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle assigned this task to ArthurTaylor. TASK DETAIL https://phabricator.wikimedia.org/T363797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Krinkle Cc: Aklapper, Ar

[Wikidata-bugs] [Maniphest] T361190: [REPO][CLIENT] Split PHPUnit test suite for wmf-quibble-vendor-mysql-php74-docker

2024-05-14 Thread Krinkle
Krinkle closed subtask T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T361190 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context

2024-05-14 Thread Krinkle
Krinkle added a parent task: T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel. TASK DETAIL https://phabricator.wikimedia.org/T363797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, ArthurTaylor

[Wikidata-bugs] [Maniphest] T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages

2024-04-29 Thread Krinkle
Krinkle added a comment. Still happening, got it on https://commons.wikimedia.org/wiki/File:MediaWiki_1.41.0_database_schema.png just now. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6

2024-04-22 Thread Krinkle
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board. Restricted Application added a project: Moderator-Tools-Team. TASK DETAIL https://phabricator.wikimedia.org/T353076 WORKBOARD https://phabricator.wikimedia.org/project/board/274/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph

2024-04-17 Thread Krinkle
Krinkle added a comment. FYI: Periodic updates about this topic appear to be posted to https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/WDQS_backend_update#Current_status, including several updates since the filing of this task, and the last one was a few days ago. TASK DETAIL

[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph

2024-04-17 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T330525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daniel_Mietchen, tfmorris, diegodlh, Sj, Gehel, Aklapper, Danny_Benjafield_WMDE, S8321414

[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph

2024-04-17 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T330525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daniel_Mietchen, tfmorris, diegodlh, Sj, Gehel, Aklapper, Danny_Benjafield_WMDE, S8321414

[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6

2024-03-19 Thread Krinkle
Krinkle added a project: MediaWiki-ResourceLoader. Krinkle added a comment. Restricted Application added a project: MediaWiki-Platform-Team. > mw.Map is an ES3-compatible re-implementation of Map from ES6. It is not. The naming similarity between `mw.Map` and ES6 Map is a coincide

[Wikidata-bugs] [Maniphest] T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround

2024-02-13 Thread Krinkle
Krinkle added a comment. In T356402#9536675 <https://phabricator.wikimedia.org/T356402#9536675>, @hashar wrote: > `$wgLocalisationCacheConf['store'] = 'array';` that is the format used to store the cache. […] it gets the localization cache from Memcached: > >

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2024-01-09 Thread Krinkle
Krinkle added a comment. With the last patch merged, feel free to close it. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek

[Wikidata-bugs] [Maniphest] T255706: [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

2023-12-21 Thread Krinkle
Krinkle added a comment. In T255706#9415091 <https://phabricator.wikimedia.org/T255706#9415091>, @Lucas_Werkmeister_WMDE wrote: > […] I’m also not entirely sure if mwdebug ensures that jobs queued by it only run on mwdebug as well; […] Not only do we not ensure this, jobs

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-12-18 Thread Krinkle
Krinkle added a comment. @DAlangi_WMF The problematic hook that initiated this task (via the parent task) is `onPageContentLanguage()` which is called by Title->getPageViewLanguage(), but not directly. The hook call resides in `ContentHandler::getPageViewLanguage() -> ContentH

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-12-13 Thread Krinkle
Krinkle edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: xSavitar, Tgr, WMDE

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-12-13 Thread Krinkle
Krinkle removed a project: User-xSavitar. Krinkle reassigned this task from xSavitar to DAlangi_WMF. Krinkle added a subscriber: xSavitar. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-12-13 Thread Krinkle
Krinkle assigned this task to xSavitar. Restricted Application added a project: User-xSavitar. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: xSavitar, Krinkle Cc: Tgr, WMDE-leszek, Michael

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-11-13 Thread Krinkle
Krinkle triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabella

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

2023-11-08 Thread Krinkle
Krinkle created this task. Krinkle added projects: MediaWiki-Platform-Team (Radar), Data-Engineering, Wikidata, MediaWiki-extensions-WikibaseRepository, Structured Data Engineering, CommonsMetadata, DiscussionTools, MediaWiki-extensions-Scribunto. Restricted Application added a subscriber

[Wikidata-bugs] [Maniphest] T349118: Migrate node-based services in production to node18

2023-10-17 Thread Krinkle
Krinkle edited projects, added MediaWiki-Engineering; removed MediaWiki-Platform-Team. Krinkle added a comment. > Platform: > > mediawiki/services/example-node-api > mediawiki/services/image-suggestion-api > mediawiki/services/restbase > mediawiki/service

[Wikidata-bugs] [Maniphest] T174022: Implement multi-content revisions

2023-09-20 Thread Krinkle
Krinkle closed subtask T324910: Slot-aware action raw as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T174022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Magol, Lokal_Profil, AfroThundr3007730, Agabi10, Liuxinyu970226

[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter

2023-08-28 Thread Krinkle
Krinkle removed a project: MediaWiki-Core-Hooks. TASK DETAIL https://phabricator.wikimedia.org/T25 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daimona, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot

[Wikidata-bugs] [Maniphest] T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked

2023-08-24 Thread Krinkle
Krinkle assigned this task to hoo. Krinkle closed this task as "Resolved". Krinkle added a comment. No mathces on Logstash mediawiki-errors dashboard for `message:"Referenced entity id lookup failed."` in the past 30 days. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T267848: ResourceLoader duplicate registration warning. Another module has already been registered as wikibase.Site

2023-08-18 Thread Krinkle
Krinkle removed a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T267848 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: toan, RShigapov, Addshore, Aklapper, Danny_Benjafield_WMDE, Jon.b.amar

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

2023-08-18 Thread Krinkle
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T204792: [20h] Why is the url key undefined in language objects for categories?

2023-08-17 Thread Krinkle
Krinkle removed a project: Platform Team Workboards (MW Expedition). TASK DETAIL https://phabricator.wikimedia.org/T204792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, daniel, AMooney, Tonina_Zhelyazkova_WMDE, noarave

[Wikidata-bugs] [Maniphest] T226976: Convert linkitem module away from jQuery UI

2023-08-06 Thread Krinkle
Krinkle removed a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T226976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: ItamarWMDE, Sarai-WMDE, Michael, stjn, Pablo-WMDE, WMDE-leszek, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T324318: Update Wikibase code bases to WebdriverIO v8

2023-08-02 Thread Krinkle
Krinkle added a subtask: T293080: Refactor Wikibase WebdriverIO tests from sync to async mode. TASK DETAIL https://phabricator.wikimedia.org/T324318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T293080: Refactor Wikibase WebdriverIO tests from sync to async mode

2023-08-02 Thread Krinkle
Krinkle added a parent task: T324318: Update Wikibase code bases to WebdriverIO v8. TASK DETAIL https://phabricator.wikimedia.org/T293080 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: vaughnwalters, Krinkle Cc: Aklapper, zeljkofilipin

[Wikidata-bugs] [Maniphest] T293080: Refactor Wikibase WebdriverIO tests from sync to async mode

2023-08-02 Thread Krinkle
Krinkle added a parent task: T324685: Upgrade WebdriverIO to v8 in all repositories. TASK DETAIL https://phabricator.wikimedia.org/T293080 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: vaughnwalters, Krinkle Cc: Aklapper, zeljkofilipin

[Wikidata-bugs] [Maniphest] T279585: Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)

2023-06-08 Thread Krinkle
Krinkle removed projects: Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T279585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, Addshore, Krinkle, RhinosF1

[Wikidata-bugs] [Maniphest] T328144: Drop PNG fallback for SVG icons / etc. across all Wikimedia products

2023-06-05 Thread Krinkle
Krinkle removed a project: ArticleFeedbackv5. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Nikerabbit, Nikki, jhsoby, Michael, Volker_E

[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)

2023-03-23 Thread Krinkle
Krinkle added a comment. The Wikibase code is using `IDatabase::unionQueries()`. It seems the Rdbms library currently doesn't offer any other way to run union queries. TASK DETAIL https://phabricator.wikimedia.org/T332941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)

2023-03-23 Thread Krinkle
Krinkle added a parent task: T326181: Stop doing regex on SQL in Database. TASK DETAIL https://phabricator.wikimedia.org/T332941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Aklapper, Krinkle, ItamarWMDE, Akuckartz

[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)

2023-03-23 Thread Krinkle
Krinkle created this task. Krinkle added projects: Performance-Team (Radar), MediaWiki-extensions-WikibaseClient. TASK DESCRIPTION The immediate reason for the warning is that it is calling `query()` without indication of whether it is a write query or not, thus requiring Rdbms to perform

[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages

2023-03-18 Thread Krinkle
Krinkle reopened this task as "Open". Krinkle added projects: Wikimedia-production-error, SDC General. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Tacsipacsi, md

[Wikidata-bugs] [Maniphest] T332305: Error “View mediainfoview does not exist” on SDC pages

2023-03-18 Thread Krinkle
Krinkle closed this task as a duplicate of T321532: [commons-wmf.6] Console error - Error: View mediainfoview does not exist on File pages. TASK DETAIL https://phabricator.wikimedia.org/T332305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

2023-02-27 Thread Krinkle
Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board. Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T328497 WORKBOARD https://phabricator.wikimedia.org/project/board/1212

[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system

2022-12-12 Thread Krinkle
Krinkle removed projects: Performance-Team, MediaWiki-ResourceLoader. TASK DETAIL https://phabricator.wikimedia.org/T324991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, StudiesWorld, Jdforrester-WMF, Aklapper

[Wikidata-bugs] [Maniphest] T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges

2022-10-03 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. Krinkle added a comment. In general when WANCache/getWithSet and purge is used, it works correctly both for single-DC and multi-DC. Using raw sets or deletes to local memcached has been discouraged for a while now,

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-09-04 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T316487 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aaron, Krinkle Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Astuthiodit_1, kar

[Wikidata-bugs] [Maniphest] T316853: ResourcesTest::testUnsatisfiableDependencies: The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true

2022-09-02 Thread Krinkle
Krinkle removed projects: MediaWiki-ResourceLoader, Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T316853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Krinkle Cc: Physikerwelt, Stegmujo, Jakob_WMDE, Silvan_WMDE

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread Krinkle
Krinkle moved this task from Inbox to Backlog: Maintenance on the Performance-Team board. Krinkle assigned this task to aaron. Krinkle added a comment. Thanks. We'll review the patch and backport to stable REL branches. TASK DETAIL https://phabricator.wikimedia.org/T316487 WORKBOARD

[Wikidata-bugs] [Maniphest] T315350: Beta cluster Error: 502, Next Hop Connection Failed

2022-08-18 Thread Krinkle
Krinkle renamed this task from "Known, Beta cluster Error: 502, Next Hop Connection Failed" to "Beta cluster Error: 502, Next Hop Connection Failed". TASK DETAIL https://phabricator.wikimedia.org/T315350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] T251286: Investigate restricting the ability to create sql queries with bad patterns in mediawiki

2022-07-28 Thread Krinkle
Krinkle added a comment. See also: T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) <https://phabricator.wikimedia.org/T210206> TASK DETAIL https://phabricator.wikimedia.org/T251286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges

2022-06-06 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar), Sustainability (MediaWiki-MultiDC); removed Performance Issue. TASK DETAIL https://phabricator.wikimedia.org/T93142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, aaron

[Wikidata-bugs] [Maniphest] T309770: TimedText namespace appearing on Wikidata

2022-06-02 Thread Krinkle
Krinkle added a comment. In T309770#7976506 <https://phabricator.wikimedia.org/T309770#7976506>, @TheDJ wrote: > In T309770#7976419 <https://phabricator.wikimedia.org/T309770#7976419>, @Jdforrester-WMF wrote: > >> Let's gate it on `wgEnableUploads` instead?

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

2022-04-13 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter, Krinkle Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael

[Wikidata-bugs] [Maniphest] T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run

2022-04-09 Thread Krinkle
Krinkle edited projects, added Slow-DB-Query; removed Wikimedia-database-issue. TASK DETAIL https://phabricator.wikimedia.org/T238199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: SilentSpike, WMDE-leszek, ArielGlenn, Lea_Lacroix_WMDE

[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array

2022-03-29 Thread Krinkle
Krinkle added a comment. In T304515#7804508 <https://phabricator.wikimedia.org/T304515#7804508>, @Krinkle wrote: > […] > While I don't have a root cause answer to this error. I do know the immediate cause of it. It seems these errors are only happening on PO

[Wikidata-bugs] [Maniphest] T185211: Generate coverage report for Wikidata extensions

2022-03-26 Thread Krinkle
Krinkle added a project: CoverMe. Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T185211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek, gerritbot, hashar, Addshore, Legoktm

[Wikidata-bugs] [Maniphest] T258822: Wikibase extensions do not declare extension.json dependency on Wikibase

2022-03-26 Thread Krinkle
Krinkle renamed this task from "Wikibase extensions do not declare extension.json dependancy on Wikibase" to "Wikibase extensions do not declare extension.json dependency on Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T258822 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist

2022-03-26 Thread Krinkle
Krinkle assigned this task to Lucas_Werkmeister_WMDE. Krinkle closed this task as "Resolved". Krinkle added a comment. Confirmed via the ApiSandbox example in the task description. However, it now produces a different fatal error that still counts as the same severity produc

[Wikidata-bugs] [Maniphest] T207683: Wikibase Repo api modules and special pages should be conditionally loaded based on entity types enabled and local, or only accept loaded local entities (or at lea

2022-03-26 Thread Krinkle
Krinkle closed subtask T242959: Error from NameTableStore::loadTable: Table commonswiki.wbt_type doesnt exist as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T207683 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jarekt

[Wikidata-bugs] [Maniphest] T304625: CI failing with IndexPager::buildQueryInfo error: 'wikidb.unittest_globaluser.gu_id' isn't in GROUP BY

2022-03-24 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T304625 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Krinkle Cc: Krinkle, Reedy, aaron, Majavah, DLynch, Zabe, Aklapper, Lucas_Werkme

[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array

2022-03-24 Thread Krinkle
Krinkle added a project: VisualEditor. Krinkle added a subscriber: Esanders. Krinkle added a comment. The current assumption around how php-opcache gets corrupted in prod is that there is a race condition when the main php-fpm process detects that opcache is full (e.g. due to files having

[Wikidata-bugs] [Maniphest] T304625: CI failing with IndexPager::buildQueryInfo error: 'wikidb.unittest_globaluser.gu_id' isn't in GROUP BY

2022-03-24 Thread Krinkle
Krinkle added subscribers: aaron, Reedy, Krinkle. Krinkle assigned this task to Reedy. Krinkle added a comment. Thanks @Reedy. \cc @aaron Looks like there's some things that weren't under strict yet that now were after our change. Looks like the failing tests may have in common

[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array

2022-03-23 Thread Krinkle
Krinkle added a comment. This seems to sporadically come up and is limited to the shared WMF-extension gate job, when Wikibase is installed. P22994 (An Untitled Masterwork) <https://phabricator.wikimedia.org/P22994> There appears to be a situation in which something is c

[Wikidata-bugs] [Maniphest] T289046: Use core QueryBuilder for DB queries in Wikibase

2022-03-04 Thread Krinkle
Krinkle renamed this task from "Use core's Query Builder for DB queries" to "Use core QueryBuilder for DB queries in Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T289046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

2022-02-25 Thread Krinkle
Krinkle changed the task status from "Stalled" to "Open". Krinkle assigned this task to Lucas_Werkmeister_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T265091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeis

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

2022-02-22 Thread Krinkle
Krinkle added a comment. Still seen at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764445 (build 137348 <https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/137348/console>. Please consider disabling this test. TASK DETAIL

[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist

2022-02-21 Thread Krinkle
Krinkle added a comment. There are a number of side-effect errors in production that suggest NameTableStore is not only failing to execute its query but also leaves the underlying connection in a dirty state for other code paths: Caller from MediaWiki\User\TalkPageNotificationManager

[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist

2022-02-21 Thread Krinkle
Krinkle renamed this task from "NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist" to "Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist". TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL

[Wikidata-bugs] [Maniphest] T242959: NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist

2022-02-21 Thread Krinkle
Krinkle renamed this task from "A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist" to "NameTableStore:

[Wikidata-bugs] [Maniphest] T242959: A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loa

2022-02-21 Thread Krinkle
Krinkle merged a task: T293921: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1146] Table commonswiki.wbt_type doesnt exist (db1142). Krinkle added a subscriber: cjming. TASK

[Wikidata-bugs] [Maniphest] T293921: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1

2022-02-21 Thread Krinkle
Krinkle closed this task as a duplicate of T242959: A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loadTableError: 1146 Table commonswiki.wbt_type doesnt exist. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release

2022-02-10 Thread Krinkle
Krinkle added a comment. Not classes, class, singular. I acknowledge `messagebox` is different as it was added misguidedly more recently without realizing it to be a localwiki concept (or without sufficient research and migration toward adopting a central style or new name). In T299625

[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release

2022-02-09 Thread Krinkle
Krinkle added a comment. In T300306#7698162 <https://phabricator.wikimedia.org/T300306#7698162>, @Jdlrobson wrote: > We plan to remove the old classes April at the latest, […] anything that's not changed by that date will degrade regular unstyled HTML. If I understand

[Wikidata-bugs] [Maniphest] T44063: [Epic] Provide a plain linked data interface for accessing entities

2022-01-27 Thread Krinkle
Krinkle added a project: Purtle. TASK DETAIL https://phabricator.wikimedia.org/T44063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: ahmad, Smalyshev, Lea_Lacroix_WMDE, Realworldobject, Eroux108, Multichill, thiemowmde, Tpt

[Wikidata-bugs] [Maniphest] T267129: Purtle issue truncating TTL export

2022-01-27 Thread Krinkle
Krinkle added a project: Purtle. TASK DETAIL https://phabricator.wikimedia.org/T267129 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, despens, Invadibot, maantietaja, Samantha_Alipio_WMDE

[Wikidata-bugs] [Maniphest] T254631: Schema.org metadata is in the rather than the

2022-01-26 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T254631 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Demian, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Volker_E, Niedzielski

[Wikidata-bugs] [Maniphest] T254631: Schema.org metadata is in the rather than the

2022-01-24 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). Krinkle added a comment. As I understand it, the JSON-LD scripg block was added in 2020 as part T209306 <https://phabricator.wikimedia.org/T209306>. Testing with Google's own tools (example <https://search.google.com/test/ric

[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle

2022-01-22 Thread Krinkle
Krinkle removed projects: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-InputBox, MediaWiki-extensions-Graph. Krinkle updated the task description

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-19 Thread Krinkle
Krinkle added a comment. In T298509#7609799 <https://phabricator.wikimedia.org/T298509#7609799>, @cscott wrote: > In my personal opinion, rMW1d7221d066c0 <https://phabricator.wikimedia.org/rMW1d7221d066c01c3fa6fb3e539cebd9fe7a91550f> was a mistake: as a MediaWiki develo

[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')

2022-01-15 Thread Krinkle
Krinkle closed this task as "Declined". Krinkle added a comment. Thanks for confirming it isn't an issue with the software. > Around 140 errors over the past 12 hours, all in wikidata This error (`stack_trace:"HTMLDocument.altLabels"`) now has about 60 matches

[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')

2022-01-11 Thread Krinkle
Krinkle added a comment. Seems like a problem with the altLabels user script, not with Wikibase's own scripts. TASK DETAIL https://phabricator.wikimedia.org/T298975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, bwang

[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')

2022-01-11 Thread Krinkle
Krinkle renamed this task from "TypeError: Cannot read properties of null (reading 'labels')" to "wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T29897

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2021-12-16 Thread Krinkle
Krinkle added a parent task: T277788: Save Timing improvements (2021). TASK DETAIL https://phabricator.wikimedia.org/T269960 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: karapayneWMDE, Michael, wkandek, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] T285987: Do not generate full html parser output at the end of Wikibase edit requests

2021-12-16 Thread Krinkle
Krinkle added a parent task: T277788: Save Timing improvements (2021). TASK DETAIL https://phabricator.wikimedia.org/T285987 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: danshick-wmde, RShigapov, Kormat, Marostegui

[Wikidata-bugs] [Maniphest] T294862: t.message is not a function (from wikibase.termbox)

2021-12-03 Thread Krinkle
Krinkle added a comment. @Michael The error seems to be a logic problem in the client-side JavaScript code about an undefined function. If I understand correctly, you suspect this is a (normal?) side-effect in the Termbox JS code when it receives bad data or an error from the server

[Wikidata-bugs] [Maniphest] T294862: t.message is not a function (from wikibase.termbox)

2021-12-03 Thread Krinkle
Krinkle renamed this task from "t.message is not a function" to "t.message is not a function (from wikibase.termbox)". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T294862 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist

2021-11-30 Thread Krinkle
Krinkle added a comment. In T296712#7539644 <https://phabricator.wikimedia.org/T296712#7539644>, @Tgr wrote: > Wikibase's own documentation also says <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/be728a4541dd9382218edd006781d0ce3c3e406d/docs/topics/opt

[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist

2021-11-30 Thread Krinkle
Krinkle edited projects, added Notifications, Performance-Team (Radar); removed MediaWiki-ResourceLoader, Performance-Team. Krinkle added a comment. Restricted Application added a project: Growth-Team. According to Codesearch, this path is set in wmf-config as `wmgWikibaseClientEchoIcon

[Wikidata-bugs] [Maniphest] T195792: Add support for setting individual query timeout in wikimedia/rdbms

2021-11-17 Thread Krinkle
Krinkle added a parent task: T293530: Improve slow read query handling. TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CDanis, Kormat, dpifke, danshick-wmde, Aklapper, Legoktm

[Wikidata-bugs] [Maniphest] T195792: Add support for setting individual query timeout in wikimedia/rdbms

2021-11-09 Thread Krinkle
Krinkle renamed this task from "Create Mediawiki DB abstraction for individual query timeouts" to "Add support for setting individual query timeout in wikimedia/rdbms". TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T195792: Create Mediawiki DB abstraction for individual query timeouts

2021-11-09 Thread Krinkle
Krinkle added a parent task: T129093: SHOW SLAVE STATUS as a health check should have a low timeout. TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CDanis, Kormat, dpifke, danshick

[Wikidata-bugs] [Maniphest] T294862: t.message is not a function

2021-11-03 Thread Krinkle
Krinkle added projects: MediaWiki-extensions-WikibaseRepository, wdwb-tech. Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board. TASK DETAIL https://phabricator.wikimedia.org/T294862 WORKBOARD https://phabricator.wikimedia.org/project/board/1055

[Wikidata-bugs] [Maniphest] T283198: Database deadlock in Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster query

2021-10-27 Thread Krinkle
Krinkle renamed this task from "Wikimedia\Rdbms\DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transaction (db1104) Function: Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster Query: INSERT I

[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention

2021-10-22 Thread Krinkle
Krinkle added a comment. It's not documented to my knowledge, but it is a pattern that is followed quite consistently throughout our software and elsewhere in the industry as relating to how StatsD, Graphite and Prometheus are used. Metrics follow a left-to-right hierarchy

[Wikidata-bugs] [Maniphest] T255706: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

2021-10-15 Thread Krinkle
Krinkle removed a project: Wikimedia-Rdbms. TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, Ladsgroup, Krinkle, eprodromou, aaron, Michael, Addshore, Aklapper

[Wikidata-bugs] [Maniphest] T279585: Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)

2021-10-10 Thread Krinkle
Krinkle renamed this task from "Error on wmf.38 when parsing edit summary via API: Content serialization failed: Failed to decode as application/json" to "Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)".

[Wikidata-bugs] [Maniphest] T292446: Change Dispatching should not stumble over mowiki redirecting to rowiki

2021-10-07 Thread Krinkle
Krinkle added a comment. `mowiki` is a deleted wiki, which is no longer recognised or served anywhere from the MW side. See also https://noc.wikimedia.org/conf/highlight.php?file=dblists/deleted.dblist. `huwikinews` is a closed wiki, which are fully functional and publicly served

[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention

2021-10-05 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T292601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Akuckartz, lucamauri, Vali.matei, _jensen, Wikidata-bugs

[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention

2021-10-05 Thread Krinkle
Krinkle created this task. Krinkle added projects: MediaWiki-extensions-WikibaseClient, Wikibase-Lua, Performance-Team (Radar). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The stats from LuaFunctionCallTracker are perhaps a bit too deep and integrated into the global

[Wikidata-bugs] [Maniphest] T68025: [Story] Monitor size of some Wikidata database tables

2021-09-28 Thread Krinkle
Krinkle assigned this task to Addshore. Krinkle added a comment. Restricted Application added a project: User-Addshore. Is this task considered resolved, or is there more? I'm triaging the oldest open incident follow-ups, and this appears done. I've seen the Grafana: Wikidata reliability

[Wikidata-bugs] [Maniphest] T287206: Add link to add interwiki links back to the sidebar

2021-08-20 Thread Krinkle
Krinkle added a comment. I ran into a New Vector wiki while logged-out, and noticed this doesn't seem to look quite right: https://pt.wikipedia.org/wiki/Algoritmo F34611515: Screenshot 2021-08-20 at 16.20.25.png <https://phabricator.wikimedia.org/F34611515> It has th

[Wikidata-bugs] [Maniphest] T112243: Overwriting a redirect using wbeditentity causes an exception

2021-08-18 Thread Krinkle
Krinkle added a project: Wikimedia-production-error. Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T112243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Lydia_Pintscher, Studies

[Wikidata-bugs] [Maniphest] T112243: Overwriting a redirect using wbeditentity causes an exception

2021-08-18 Thread Krinkle
Krinkle added a comment. Searching over the last 90 days in Logstash for `message:*UnresolvedRedirectException` on the mediawiki-errors dashboard, I find only entries like "Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q..", and those s

  1   2   3   4   5   6   7   8   9   10   >