[Wikidata-bugs] [Maniphest] [Merged] T245295: A malformed(?) production error corrupted the error channels, with the message field being over-written with `class@anonymous`

2020-03-06 Thread Tarrow
Tarrow merged a task: T246980: class@anonymous. TASK DETAIL https://phabricator.wikimedia.org/T245295 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, LarsWirzenius, Addshore, Agusbou2015, Krinkle, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Merged] T246980: class@anonymous

2020-03-06 Thread Tarrow
Tarrow closed this task as a duplicate of T245295: A malformed(?) production error corrupted the error channels, with the message field being over-written with `class@anonymous`. TASK DETAIL https://phabricator.wikimedia.org/T246980 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T246980: class@anonymous

2020-03-06 Thread Tarrow
Tarrow added a comment. I think this can be merged into T245295 <https://phabricator.wikimedia.org/T245295>. In my opinion this ticket shows a symptom of at least 3 separate problems: - T245295 <https://phabricator.wikimedia.org/T245295> : Production logging of th

[Wikidata-bugs] [Maniphest] [Created] T247057: CachingFallbackLabelDescriptionLookup attempts to cache entries for invalid Term Languages

2020-03-06 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As seen in T246980 <https://phabricator.wikimedia.org/T246

[Wikidata-bugs] [Maniphest] [Claimed] T246980: class@anonymous

2020-03-05 Thread Tarrow
Tarrow claimed this task. Tarrow added a comment. I'll be looking at this today TASK DETAIL https://phabricator.wikimedia.org/T246980 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Liuxinyu970226, Aklapper, LarsWirz

[Wikidata-bugs] [Maniphest] [Claimed] T245869: Undeleting of an entry (NS=0) is no longer possible in de.wiktionary

2020-03-04 Thread Tarrow
Tarrow added subscribers: Ladsgroup, Tarrow. Tarrow claimed this task. Tarrow added a comment. Hope it's ok but I'm taking this over in the attempt to finish what we started rather than picking up new work TASK DETAIL https://phabricator.wikimedia.org/T245869 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Edited] T245865: Remove legacy Wikibase service containers

2020-03-03 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Commented On] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-03-02 Thread Tarrow
Tarrow added a comment. We were going to backport this in SWAT but we decided not due to the risk of of some problem. This is due to the fact that during sync each file happens separately and by changing the signature of \Wikibase\DataAccess\SingleEntitySourceServices we'd be sure to c

[Wikidata-bugs] [Maniphest] [Commented On] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-03-02 Thread Tarrow
Tarrow added a comment. Checked on beta and doesn't throw any more, just returns `nil nil` TASK DETAIL https://phabricator.wikimedia.org/T246152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Lydia_Pintscher, Bugreporter, Tacsi

[Wikidata-bugs] [Maniphest] [Commented On] T246600: mw.wikibase.getLabelWithLang with form or sense ID results in InvalidArgumentException

2020-03-02 Thread Tarrow
Tarrow added a comment. Thanks for reporting! I've merged this into a previous report TASK DETAIL https://phabricator.wikimedia.org/T246600 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Bugreporter, darthmon_wmde, Na

[Wikidata-bugs] [Maniphest] [Updated] T246600: mw.wikibase.getLabelWithLang with form or sense ID results in InvalidArgumentException

2020-03-02 Thread Tarrow
Tarrow closed this task as a duplicate of T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local). Restricted Application removed a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Merged] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-03-02 Thread Tarrow
Tarrow merged a task: T246600: mw.wikibase.getLabelWithLang with form or sense ID results in InvalidArgumentException. Tarrow added a subscriber: Bugreporter. TASK DETAIL https://phabricator.wikimedia.org/T246152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-02-27 Thread Tarrow
Tarrow added a comment. So, I was a little mislead and thought this was mostly about turning on entity federation. After doing a poor-man's bisect through history it was actually broken by: 8edefdbde63e20329e8fe6fe8ab94c99ed713f8a <https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-02-27 Thread Tarrow
Tarrow added a comment. Stack trace locally looks like: WikiPageEntityMetaDataLookup.php:206, Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->assertCanHandleEntityId() WikiPageEntityMetaDataLookup.php:200, Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLoo

[Wikidata-bugs] [Maniphest] [Claimed] T246152: "InvalidArgumentException" for some Property talk pages on Wikidata (Could not load data from the database of entity source: local)

2020-02-26 Thread Tarrow
Tarrow claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T246152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Thibaut120094, Sylvain_WMFr, Jakob_WMDE, Liuxinyu970226, Addshore, Lucas_Werkmeister_WMDE, Fnielsen, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-02-26 Thread Tarrow
Tarrow added a comment. In T245396#5912675 <https://phabricator.wikimedia.org/T245396#5912675>, @Jdforrester-WMF wrote: > New handful of errors in prod: > > class@anonymous /srv/mediawiki/php-1.35.0-wmf.20/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.ph

[Wikidata-bugs] [Maniphest] [Created] T246207: Track down unusual callers to SimpleCacheWithBagOfStuff

2020-02-26 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION It seems that despite adding more careful filtering of languages before using them as cache keys we are

[Wikidata-bugs] [Maniphest] [Commented On] T243969: An incomplete message shown when adding a sitelink to a page whose item uses the current page

2020-02-26 Thread Tarrow
Tarrow added a comment. https://gerrit.wikimedia.org/r/c/wikibase/javascript-api/+/573628 adds support for unknown errors that contain no more localisable information (e.g. the only thing we have is the error code). I quickly asked @Lydia_Pintscher about that in the daily and we think

[Wikidata-bugs] [Maniphest] [Edited] T245740: LUA getLabelWithLang calls result in many db queries to terms storage with spikey and unpredictable patterns

2020-02-20 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245740 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Tarrow Cc: Aklapper, Ladsgroup, Tarrow, Addshore, Beast1978, Un1tY, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Commented On] T244115: Investigate & Fix holes for aliases in new term tables (take 3)

2020-02-19 Thread Tarrow
Tarrow added a comment. I'm just doing the rebase of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/570996 TASK DETAIL https://phabricator.wikimedia.org/T244115 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, T

[Wikidata-bugs] [Maniphest] [Edited] T244001: Investigate reminding people to update `npm audit`

2020-02-19 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244001 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: WMDE-leszek, Aklapper, Tarrow, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma

[Wikidata-bugs] [Maniphest] [Changed Project Column] T244562: Internal error on beta Commons Special:RecentChanges: Cache key contains characters that are not allowed

2020-02-19 Thread Tarrow
Tarrow moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Tarrow added a comment. As far as I can see the one patch needing review in this ticket is blocked on T245396 <https://phabricator.wikimedia.org/T245396>; so I&#

[Wikidata-bugs] [Maniphest] [Commented On] T245540: InvalidArgumentException during Wikibase initialization on Beta Wikidata

2020-02-18 Thread Tarrow
Tarrow added a comment. Just to add to the documentation of this incident: did this only break beta in some subtle way? I saw there was a 5 hour-ish gap between the patch being +2 and us reverting. What was the impact of this breakage? All of beta wikidata down? Or just entity pages

[Wikidata-bugs] [Maniphest] [Updated] T245540: InvalidArgumentException during Wikibase initialization on Beta Wikidata

2020-02-18 Thread Tarrow
Tarrow added a comment. It appears (to me) to have been resolved by: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/572921/2 Which was reverting https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/569204 Which is connected to: T242087 <ht

[Wikidata-bugs] [Maniphest] [Updated] T244001: Investigate reminding people to update `npm audit`

2020-02-17 Thread Tarrow
Tarrow added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Tarrow added a comment. Restricted Application added a project: Wikidata. Moving to camp as we closed the hike! TASK DETAIL https://phabricator.wikimedia.org/T244001 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T244722: increase factor for query service that is taken into account for maxlag

2020-02-17 Thread Tarrow
Tarrow added a comment. In T244722#528 <https://phabricator.wikimedia.org/T244722#528>, @Addshore wrote: > The issue seems to be somewhere in the update process and query service itself rather than the wikidata edit rate (although of course the edit rate has so

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Tarrow
Tarrow added a subscriber: Rosalie_WMDE. Tarrow added a comment. So we (@Jakob_WMDE and @Rosalie_WMDE and me) looked at this in some detail. We came to the following conclusions (chip in if I misrepresented anything) The ideal solution is for us to fix \Wikibase\Lib

[Wikidata-bugs] [Maniphest] [Claimed] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Tarrow
Tarrow claimed this task. Tarrow added a comment. We (the wikidata campsite) will pick this up and have a look this morning. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow

[Wikidata-bugs] [Maniphest] [Commented On] T244981: Upgrade to wdio 5 for Wikibase repo browser tests

2020-02-13 Thread Tarrow
Tarrow added a comment. Github PR is in. Still presumably needs a release (probably with a major version bump). Don't want to tread on toes so I didn't start cutting one TASK DETAIL https://phabricator.wikimedia.org/T244981 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T244722: increase factor for query service that is taken into account for maxlag

2020-02-13 Thread Tarrow
Tarrow added a comment. Is this now doing what we want? I think it's doing what we discussed in the storytime and making the frequency of the oscillations higher. However in addition to that it is increasing the amplitude and thus now actually triggering low edit volume alerts

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-12 Thread Tarrow
Tarrow added a comment. I'm also probably adding un thought through ideas to this but... If TermStores can't read is having them in lib the right place? Wouldn't we be smarter to lock them up in repo? TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREF

[Wikidata-bugs] [Maniphest] [Changed Project Column] T238403: Create Grafana boards

2020-02-12 Thread Tarrow
Tarrow moved this task from Doing to Test (Product Review) on the Wikidata-Tainted-References-Sprint10 board. Tarrow added a comment. as far as I could see it was already on there under daily. The data actually arrives live and is then aggregated into daily chunks for display. I moved it

[Wikidata-bugs] [Maniphest] [Claimed] T238403: Create Grafana boards

2020-02-12 Thread Tarrow
Tarrow claimed this task. Tarrow moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint10 board. TASK DETAIL https://phabricator.wikimedia.org/T238403 WORKBOARD https://phabricator.wikimedia.org/project/board/4537/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T227083: Termbox should hide non-supported languages

2020-02-11 Thread Tarrow
Tarrow added a comment. I saw this revert patch come up; it's a great idea to clean up if not needed. I see the ticket is closed but as far as I can see unsupported language can still appear in the termbox in various cases. See for example https://wikidata.beta.wmflabs.org/wiki

[Wikidata-bugs] [Maniphest] [Edited] T227083: Termbox should hide non-supported languages

2020-02-11 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T227083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Tarrow Cc: alaa_wmde, Aklapper, Hanna_Petruschat_WMDE, Lea_WMDE, WMDE-leszek, gerritbot, Pablo

[Wikidata-bugs] [Maniphest] [Closed] T244721: Clients are reading from wb_terms that now has holes

2020-02-11 Thread Tarrow
Tarrow closed this task as "Invalid". Tarrow added a comment. I'm very happy to say I agree! TASK DETAIL https://phabricator.wikimedia.org/T244721 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Ladsgroup, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow added a comment. Not sure about if test would have had unmigrated item terms TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Edited] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Edited] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Edited] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Edited] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Commented On] T244721: Clients are reading from wb_terms that now has holes

2020-02-10 Thread Tarrow
Tarrow added a comment. Current theory is that WRITE_NEW is actually still writing both but writing to the new store first not the old one. This is "good" becuase hopefully we don't have any holes but a little confusing. we're just confirming that's the

[Wikidata-bugs] [Maniphest] [Triaged] T244721: Clients are reading from wb_terms that now has holes

2020-02-10 Thread Tarrow
Tarrow triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T244721 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Created] T244721: Clients are reading from wb_terms that now has holes

2020-02-10 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION It seems that another side effect of T244697 <ht

[Wikidata-bugs] [Maniphest] [Retitled] T244697: Typo in wmf-config for tmpItemTermsMigrationStages name

2020-02-10 Thread Tarrow
Tarrow renamed this task from "Typo in config for tmpItemTermsMigrationStages name" to "Typo in wmf-config for tmpItemTermsMigrationStages name". Tarrow added projects: Wikidata-Campsite, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T244697 EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T244529: mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18

2020-02-08 Thread Tarrow
Tarrow claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T244529 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Michael, Tarrow, WMDE-leszek, Dipsacus_fullonum, Paucabot, Robin_van_der_Vliet, Ladsgroup, Addshore, Mike_Peel

[Wikidata-bugs] [Maniphest] [Commented On] T244529: mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18

2020-02-07 Thread Tarrow
Tarrow added a comment. We're rolling back to wmf.16 on all wikis. We hope this will resolve the issues but of course some bad data may now be cached. We'll look at this again on Monday. TASK DETAIL https://phabricator.wikimedia.org/T244529 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T234789: Step 2: confirm existing reference when edit doesn't influence it

2020-02-04 Thread Tarrow
Tarrow added a comment. Hey @Sarai-WMDE, Just written a patch that isn't yet merged so you won't yet see the effects on beta 1. I think I've identified that the line-height wasn't being correctly propagated down to the button label 2. I've adjusted the h

[Wikidata-bugs] [Maniphest] [Claimed] T234789: Step 2: confirm existing reference when edit doesn't influence it

2020-02-03 Thread Tarrow
Tarrow moved this task from Test (Product Review) to Doing on the Wikidata-Tainted-References-Sprint10 board. Tarrow claimed this task. Tarrow added a subscriber: hoo. TASK DETAIL https://phabricator.wikimedia.org/T234789 WORKBOARD https://phabricator.wikimedia.org/project/board/4537

[Wikidata-bugs] [Maniphest] [Commented On] T235612: [4h] Share build and test script from package.json

2020-02-03 Thread Tarrow
Tarrow added a comment. Seems there isn't an obvious off the shelf solution for this. This closest thing I found was perhaps: https://github.com/smikula/webpack-bundle-diff or even https://github.com/mixer/webpack-bundle-compare but these are not at all for diffing to find any differ

[Wikidata-bugs] [Maniphest] [Updated] T241989: Enable Tainted References on www.wikidata.org

2020-02-03 Thread Tarrow
Tarrow edited projects, added Wikidata-Tainted-References-Sprint9; removed Wikidata Tainted References. TASK DETAIL https://phabricator.wikimedia.org/T241989 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Lydia_Pintscher, Aklapper, WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T241989: Enable Tainted References on www.wikidata.org

2020-02-03 Thread Tarrow
Tarrow claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T241989 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Lydia_Pintscher, Aklapper, WMDE-leszek, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400

[Wikidata-bugs] [Maniphest] [Claimed] T235612: [4h] Share build and test script from package.json

2020-01-29 Thread Tarrow
Tarrow claimed this task. Tarrow edited projects, added Wikidata-Tainted-References-Sprint9; removed Wikidata Tainted References. TASK DETAIL https://phabricator.wikimedia.org/T235612 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc

[Wikidata-bugs] [Maniphest] [Assigned] T243817: Browsertest for showing tainted icon after cancelling edit

2020-01-29 Thread Tarrow
Tarrow assigned this task to Rosalie_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T243817 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Aklapper, Tarrow, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T243817: Browsertest for showing tainted icon after cancelling edit

2020-01-28 Thread Tarrow
Tarrow created this task. Tarrow added projects: Wikidata, Wikidata-Tainted-References-Sprint9. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T243817 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T243396: Security updates

2020-01-22 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata Tainted References. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Make sure NPM is regularly updated to avoid security warnings for packages we used. TASK

[Wikidata-bugs] [Maniphest] [Created] T243392: Move storybook to doc.wikimedia.org

2020-01-22 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata Tainted References. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION We should host our storybook alongside the others. Hints can probably be found by looking

[Wikidata-bugs] [Maniphest] [Edited] T235612: Share build and test script from package.json

2020-01-22 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235612 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Edited] T243291: Update Story book version

2020-01-22 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T243291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Rosalie_WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Claimed] T242119: StopEditing Hook should dispatch STOP_EDIT action

2020-01-22 Thread Tarrow
Tarrow moved this task from Peer Review to Doing on the Wikidata-Tainted-References-Sprint9 board. Tarrow claimed this task. Tarrow added a subscriber: hoo. TASK DETAIL https://phabricator.wikimedia.org/T242119 WORKBOARD https://phabricator.wikimedia.org/project/board/4516/ EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2020-01-21 Thread Tarrow
Tarrow added a project: Wikidata Tainted References. TASK DETAIL https://phabricator.wikimedia.org/T231731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Aklapper, Lydia_Pintscher, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T238403: Create Grafana boards

2020-01-21 Thread Tarrow
Tarrow edited projects, added Wikidata Tainted References; removed Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6. TASK DETAIL https://phabricator.wikimedia.org/T238403 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2020-01-21 Thread Tarrow
Tarrow removed projects: Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6. TASK DETAIL https://phabricator.wikimedia.org/T231731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T236134: Step 2: Add statement context to the popper text

2020-01-21 Thread Tarrow
Tarrow added a comment. @Lydia_Pintscher We talked about this. We definitely aren't saying that it's a "hard" task but it is at least 8 story points no matter how we try to cut it. Hope that helps you with prioritisation. For what it is worth we actually wanted

[Wikidata-bugs] [Maniphest] [Claimed] T242212: Close button alignment and sizing

2020-01-21 Thread Tarrow
Tarrow claimed this task. Tarrow edited projects, added Wikidata-Tainted-References-Sprint9; removed Wikidata Tainted References. TASK DETAIL https://phabricator.wikimedia.org/T242212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc

[Wikidata-bugs] [Maniphest] [Commented On] T242119: Cancel hook handler should set taintState to false

2020-01-20 Thread Tarrow
Tarrow added a comment. I was looking through this task. As far as I can tell to achieve what we need for the story we do not want to have the stopEditingHook set the TaintedState to false. Indeed, the story is about keeping a statement tainted after cancelling. I think we should

[Wikidata-bugs] [Maniphest] [Unblock] T234790: Step 2: show tainted icon after canceling editing if icon was shown before

2020-01-17 Thread Tarrow
Tarrow closed subtask T242118: Change save hook to set taintState to false as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Rosalie_WMDE, Aklapper, Lydia_Pintsc

[Wikidata-bugs] [Maniphest] [Closed] T242118: Change save hook to set taintState to false

2020-01-17 Thread Tarrow
Tarrow moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint8 board. Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T242118 WORKBOARD https://phabricator.wikimedia.org/project/board/4461/ EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Unblock] T234790: Step 2: show tainted icon after canceling editing if icon was shown before

2020-01-16 Thread Tarrow
Tarrow closed subtask T242117: Test that icon shows only when taintedState is true and editState is false as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Ro

[Wikidata-bugs] [Maniphest] [Closed] T242117: Test that icon shows only when taintedState is true and editState is false

2020-01-16 Thread Tarrow
Tarrow closed this task as "Resolved". Tarrow moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint8 board. Tarrow added a comment. Indeed, I think this is done :) TASK DETAIL https://phabricator.wikimedia.org/T242117 WORKBOA

[Wikidata-bugs] [Maniphest] [Unblock] T234790: Step 2: show tainted icon after canceling editing if icon was shown before

2020-01-14 Thread Tarrow
Tarrow closed subtask T242116: Add an editstate to Store as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Rosalie_WMDE, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Closed] T242116: Add an editstate to Store

2020-01-14 Thread Tarrow
Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T242116 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, Hook696,

[Wikidata-bugs] [Maniphest] [Closed] T242123: change showing taintedIcon rules

2020-01-14 Thread Tarrow
Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T242123 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, Hook696,

[Wikidata-bugs] [Maniphest] [Unblock] T234790: Step 2: show tainted icon after canceling editing if icon was shown before

2020-01-14 Thread Tarrow
Tarrow closed subtask T242123: change showing taintedIcon rules as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Rosalie_WMDE, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Unassigned] T242117: Test that icon shows only when taintedState is true and editState is false

2020-01-14 Thread Tarrow
Tarrow added subscribers: hoo, Tarrow. Tarrow removed hoo as the assignee of this task. Tarrow moved this task from Doing to To Do on the Wikidata-Tainted-References-Sprint8 board. Tarrow added a comment. We heard in the daily that @hoo is of the office for a couple of days apparently so I

[Wikidata-bugs] [Maniphest] [Closed] T242121: Add Cancel hook

2020-01-13 Thread Tarrow
Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T242121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Tarrow Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] [Unblock] T234790: Step 2: show tainted icon after canceling editing if icon was shown before

2020-01-13 Thread Tarrow
Tarrow closed subtask T242121: Add Cancel hook as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Rosalie_WMDE, Aklapper, Lydia_Pintscher, Sarai-WMDE, dar

[Wikidata-bugs] [Maniphest] [Closed] T239621: Enable Tainted Refs on test.wikidata.org

2020-01-10 Thread Tarrow
Tarrow closed this task as "Resolved". Tarrow claimed this task. Tarrow added a comment. Config patch is up and we intend to SWAT it today (2020-01-08) at 1200UTC TASK DETAIL https://phabricator.wikimedia.org/T239621 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Assigned] T242123: change showing taintedIcon rules

2020-01-10 Thread Tarrow
Tarrow assigned this task to Rosalie_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T242123 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Assigned] T242116: Add an editstate to Store

2020-01-08 Thread Tarrow
Tarrow assigned this task to Rosalie_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T242116 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Unblock] T231729: Step 1: Click on warning icon and get an explanation of what is wrong

2020-01-07 Thread Tarrow
Tarrow closed subtask T239902: Finish Styling Popper as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Sarai-WMDE, Tarrow, WMDE-leszek, Jan_Dittrich, Erdinc_C

[Wikidata-bugs] [Maniphest] [Closed] T239902: Finish Styling Popper

2020-01-07 Thread Tarrow
Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Sarai-WMDE, Aklapper, Tarrow, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] [Edited] T234789: Step 2: confirm existing reference when edit doesn't influence it

2020-01-06 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T234789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, Tarrow Cc: Tarrow, Sarai-WMDE, WMDE-leszek, Jan_Dittrich, Erdinc_Ciftci_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

2019-12-23 Thread Tarrow
Tarrow added a comment. Put up one more which hopefully gets us bang on the spec apart form these odd artefacts (a little tiny vertical line by the help link) that I don't understand. If anyone has any idea then I'd be happy to know about it: F31486469: image.

[Wikidata-bugs] [Maniphest] [Unblock] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2019-12-19 Thread Tarrow
Tarrow closed subtask T238401: Add tracking code relating to statement changes as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Aklapper, Lydia_Pintsc

[Wikidata-bugs] [Maniphest] [Closed] T238401: Add tracking code relating to statement changes

2019-12-19 Thread Tarrow
Tarrow closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T238401 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: noarave, Aklapper, Tarrow, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Assigned] T234789: Step 2: confirm existing reference when edit doesn't influence it

2019-12-19 Thread Tarrow
Tarrow assigned this task to Sarai-WMDE. Tarrow added a comment. Can you add the mockup details here TASK DETAIL https://phabricator.wikimedia.org/T234789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, Tarrow Cc: Tarrow, Sarai-WMDE

[Wikidata-bugs] [Maniphest] [Edited] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2019-12-18 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Aklapper, Lydia_Pintscher, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T240466: Measure the impact of Tainted References Wikidata feature

2019-12-18 Thread Tarrow
Tarrow added a comment. We opened T231731 <https://phabricator.wikimedia.org/T231731> as a means to count future tainted-refs triggering and some related data. What I'm not clear on about all the above discussion is exactly what data we're trying to collect. It seem

[Wikidata-bugs] [Maniphest] [Commented On] T240838: Change Help link

2019-12-16 Thread Tarrow
Tarrow added a comment. Estimated in storytime TASK DETAIL https://phabricator.wikimedia.org/T240838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, Lydia_Pintscher, Lea_Lacroix_WMDE, Sarai-WMDE, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T240838: Change Help link

2019-12-16 Thread Tarrow
Tarrow set the point value for this task to "2". TASK DETAIL https://phabricator.wikimedia.org/T240838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, Lydia_Pintscher, Lea_Lacroix_WMDE, Sarai-WMDE, darthmon_wmd

[Wikidata-bugs] [Maniphest] [Edited] T239902: Finish Styling Popper

2019-12-16 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Tarrow Cc: Lydia_Pintscher, Sarai-WMDE, Aklapper, Tarrow, Hook696, Daryl-TTMG, RomaAmorRoma

[Wikidata-bugs] [Maniphest] [Edited] T231729: Step 1: Click on warning icon and get an explanation of what is wrong

2019-12-16 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T231729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Sarai-WMDE, Tarrow, WMDE-leszek, Jan_Dittrich, Erdinc_Ciftci_WMDE, Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Created] T240855: Upgrade dockerized npm versions

2019-12-16 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION To avoid https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli we should upgrade versions of npm we install to at least 6.13.4 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Created] T240838: Change Help link

2019-12-16 Thread Tarrow
Tarrow created this task. Tarrow added a project: Wikidata Tainted References. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION >> @Lea_Lacroix_WMDE > > Hello people! UX and I would like to change the link

[Wikidata-bugs] [Maniphest] [Claimed] T238401: Add tracking code relating to statement changes

2019-12-11 Thread Tarrow
Tarrow claimed this task. Tarrow added a subscriber: noarave. TASK DETAIL https://phabricator.wikimedia.org/T238401 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: noarave, Aklapper, Tarrow, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma

[Wikidata-bugs] [Maniphest] [Created] T239902: Finish Styling Popper

2019-12-05 Thread Tarrow
Tarrow created this task. Tarrow added projects: Wikidata, Wikidata-Tainted-References-Sprint4, Wikidata-Tainted-References-Sprint6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION We decided we will style the popper according to option B from: https://www.figma.com/file

[Wikidata-bugs] [Maniphest] [Commented On] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2019-12-05 Thread Tarrow
Tarrow added a comment. As per daily: @Lydia_Pintscher says leaving as is is fine :) TASK DETAIL https://phabricator.wikimedia.org/T231731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Aklapper, Lydia_Pintscher, Sarai-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T236407: Share ESLint config

2019-12-05 Thread Tarrow
Tarrow added a comment. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/554479 - like a fool I forgot the `Bug:` but I shan't burden CI with amending the commit message TASK DETAIL https://phabricator.wikimedia.org/T236407 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T231731: Step 1: count how many tainted reference warnings are being triggered and opened

2019-12-04 Thread Tarrow
Tarrow added a comment. Here are some examples for how we interpret this ticket: All references changed statistics should be fired in the the following examples: name=Case 1 BEFORE Main Statement: Population -> 1000 References: - Book A on page 3 - Book B

<    1   2   3   4   5   6   7   8   9   10   >