[Wikidata-bugs] [Maniphest] [Commented On] T216692: Security review for WikibaseSchema

2019-02-26 Thread Tarrow
Tarrow added a comment. > Unrelated to the actual security review... But in the selenium stuff.. There's a mix of ES6 and non ES6 lambdas > > For one thing, it's not consistent... Secondly, do we allow this ES6 type JS? PhpStorm doesn't like it much, but that&#x

[Wikidata-bugs] [Maniphest] [Commented On] T216956: deploy WikibaseSchema to test

2019-02-25 Thread Tarrow
Tarrow added a comment. @Ifygal3 - thanks for your offer of help :) Unfortunately, this issue is not one that can be just picked up. It's really being used as a "todo" task for the team at WMDE working on shape expressions for Wikidata. It doesn't really requ

[Wikidata-bugs] [Maniphest] [Unassigned] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-02-25 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T215393 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Addshore, gerritbot, Lydia_Pintscher, Tarrow, Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Unassigned] T215394: Remove main “edit” tab from schema pages

2019-02-25 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T215394 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: gerritbot, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, CucyNoiD

[Wikidata-bugs] [Maniphest] [Unassigned] T215395: Remove label/description/aliases from main schema edit page

2019-02-25 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T215395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: gerritbot, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, CucyNoiD

[Wikidata-bugs] [Maniphest] [Commented On] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-02-24 Thread Tarrow
Tarrow added a comment. Great! I personally like the new one :). Shex hikers: new patch up is the "more modern" oojs style one TASK DETAIL https://phabricator.wikimedia.org/T215393 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-02-22 Thread Tarrow
Tarrow added a comment. Great! I noticed while I was trying to do this without depending on wikibase that wikibase now uses an old version of the oojs-ui icons. This is how it looks on wikidata: F28263621: image.png <https://phabricator.wikimedia.org/F28263621> This is how it

[Wikidata-bugs] [Maniphest] [Edited] T216692: Security review for WikibaseSchema

2019-02-21 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T216692 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, RazShuty, WMDE-leszek, Michael, noarave, Lydia_Pintscher, Lucas_Werkmeister_WMDE, pdehaye

[Wikidata-bugs] [Maniphest] [Edited] T216692: Security review for WikibaseSchema

2019-02-21 Thread Tarrow
Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T216692 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, RazShuty, WMDE-leszek, Michael, noarave, Lydia_Pintscher, Lucas_Werkmeister_WMDE, pdehaye

[Wikidata-bugs] [Maniphest] [Claimed] T215395: Remove label/description/aliases from main schema edit page

2019-02-20 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T215395EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-02-20 Thread Tarrow
Tarrow added a subscriber: Lydia_Pintscher.Tarrow added a comment. @Lydia_Pintscher Any thoughts where the edit links should go? Should it be to the right? and read 'edit'?TASK DETAILhttps://phabricator.wikimedia.org/T215393EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Claimed] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-02-20 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T215393EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Claimed] T215394: Remove main “edit” tab from schema pages

2019-02-20 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T215394EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Claimed] T215516: Implement SchemaWriter to replace current repository

2019-02-12 Thread Tarrow
Tarrow triaged this task as "Normal" priority.Tarrow claimed this task.Tarrow added a comment. Claiming this to implement an updateSchema methodTASK DETAILhttps://phabricator.wikimedia.org/T215516EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Commented On] T207132: Fulltext/ElasticSearch does not work

2019-02-11 Thread Tarrow
Tarrow added a comment. Which version of the docker images are you running? e.g. 1.31/1.32...?TASK DETAILhttps://phabricator.wikimedia.org/T207132EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, dbs, WMDE-leszek, CennoxX, Tarrow, Aklapper

[Wikidata-bugs] [Maniphest] [Claimed] T215528: remove schema object from create schema user story

2019-02-08 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T215528EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Tarrow, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] [Assigned] T215516: Implement SchemaUpdater to replace current repository

2019-02-08 Thread Tarrow
Tarrow assigned this task to noarave.Restricted Application added a project: User-Noarave. TASK DETAILhttps://phabricator.wikimedia.org/T215516EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: noarave, TarrowCc: Aklapper, noarave, Michael, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Closed] T215029: Refactor to use UseCases

2019-02-07 Thread Tarrow
Tarrow moved this task from Doing to Done on the Shape Expressions Sprint 1 board.Tarrow closed this task as "Resolved".Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T215029WORKBOARDhttps://phabricator.wikimedia.org/project/board/3833/EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Reassigned] T215029: Refactor to use UseCases

2019-02-07 Thread Tarrow
Tarrow reassigned this task from Tarrow to Michael. TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, TarrowCc: gerritbot, RazShuty, JeroenDeDauw, hoo, Tarrow, Lucas_Werkmeister_WMDE, noarave

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-07 Thread Tarrow
Tarrow added a comment. Looks like maybe this is now "done"? given that we have a single user case for creation and we think we don't need others?TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferenc

[Wikidata-bugs] [Maniphest] [Unassigned] T214915: Add “restore” for Schemas

2019-02-07 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task.Tarrow moved this task from Doing to Backlog on the Shape Expressions Sprint 1 board.Tarrow added a comment. back to ToDo since it looks like the undo chain will be v. differentTASK DETAILhttps://phabricator.wikimedia.org/T214915WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Commented On] T215296: Extract AutoCommentFormatter and SummaryFormatter into a new Library

2019-02-06 Thread Tarrow
Tarrow added a comment. +1 mediawiki/TranslatableCommentsTASK DETAILhttps://phabricator.wikimedia.org/T215296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Lucas_Werkmeister_WMDE, Tarrow, Aklapper, Lydia_Pintscher, Michael, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Unassigned] T205606: Quickstatements should work out of the box in wikibase docker image

2019-02-04 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T205606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: johl, dbs, thisismattmiller, Addshore, Lydia_Pintscher, Aklapper, Tarrow, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T214917: Investigate how to add translatable edit comment for creating a schema

2019-02-01 Thread Tarrow
Tarrow added a comment. I was initially drawn towards just leaving the Wikibase thing and using the hook in our own way. (Option 1 from @Michael) However, I can see this could be a useful package to exist separately although it is some more work. I guess the plan would be something like: a new

[Wikidata-bugs] [Maniphest] [Claimed] T214915: Add “restore” for Schemas

2019-01-30 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from Backlog to Doing on the Shape Expressions Sprint 1 board. TASK DETAILhttps://phabricator.wikimedia.org/T214915WORKBOARDhttps://phabricator.wikimedia.org/project/board/3833/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T214399: Revert to previous version of a shape expression

2019-01-29 Thread Tarrow
Tarrow added a comment. For restore: The restore link in the item history take you to a diff page (nicely formatted) There is a publish changes button This takes you back to the view item page message in history looks like: Restore revision 424510 by 10.68.16.199TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T214399: Revert to previous version of a shape expression

2019-01-29 Thread Tarrow
Tarrow added a comment. To get some more details I tested on https://test.wikidata.org/w/index.php?title=Q177525 For UNDO: In the history of an item there is an undo link Clicking it takes you to a diff page (nicely formatted with a section for "description") There is a summary box

[Wikidata-bugs] [Maniphest] [Edited] T213726: Register Schema: namespace

2019-01-29 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONSo that we don't clash in the future with other extension we should register our namespace. See [mw.org](https://www.mediawiki.org/wiki/Manual:Using_custom_namespaces#In_extensions) for instructions. Also add

[Wikidata-bugs] [Maniphest] [Commented On] T213726: Register Schema: namespace

2019-01-29 Thread Tarrow
Tarrow added a comment. While we're in this very early development perhaps we can even just nuke the DB's and start clean without the legacy update stuff?TASK DETAILhttps://phabricator.wikimedia.org/T213726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref

[Wikidata-bugs] [Maniphest] [Edited] T214385: Allow saving of Schemas to Wikidata

2019-01-24 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...WHERE there is a text box form to paste a shape _expression_ into THEN you adjust the shape _expression_AND the schema uses relative URIs to reflecterence the ID ofshapes in the pageschema AND a button to save...TASK

[Wikidata-bugs] [Maniphest] [Retitled] T214385: Allow saving of Schemas to Wikidata

2019-01-24 Thread Tarrow
Tarrow renamed this task from "Allow saving of shape expressions to Wikidata" to "Allow saving of Schemas to Wikidata". TASK DETAILhttps://phabricator.wikimedia.org/T214385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritb

[Wikidata-bugs] [Maniphest] [Edited] T214385: Allow saving of shape expressions to Wikidata

2019-01-24 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONAmy wants to save a shape _expression_ to Wikidataschema to Wikidata. This will consist of multiple shape expressions. GIVEN a user has permission to do so...WHERE there is a text box form to paste a shape _expression_

[Wikidata-bugs] [Maniphest] [Commented On] T214395: Display recent changes for a shape expression

2019-01-23 Thread Tarrow
Tarrow added a comment. Entry in RC leads you to a diff page Also entry has to be formatted in some way. I.e. not just O1232345 but something human readableTASK DETAILhttps://phabricator.wikimedia.org/T214395EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Commented On] T214393: Allow editing of shape expressions

2019-01-23 Thread Tarrow
Tarrow added a comment. So, after talking to Lydia clicking to a different page to edit isn't really acceptable. This is because it breaks the user experience that people are used to e.g. with visual editor / normal entity editing on wikidataTASK DETAILhttps://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T214385: Allow saving of shape expressions to Wikidata

2019-01-23 Thread Tarrow
Tarrow added a comment. They need to know the id first because otherwise they can't know what to paste into the box because the shape _expression_ needs the idTASK DETAILhttps://phabricator.wikimedia.org/T214385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferenc

[Wikidata-bugs] [Maniphest] [Edited] T205606: Quickstatements should work out of the box in wikibase docker image

2019-01-23 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Adapt the QS entrypoint script to read the values from the file if it is present **Hints** User will need still need an email set at some point User will need the correct permissions to manage OAuth consumers

[Wikidata-bugs] [Maniphest] [Created] T214484: Backport OAuth maintenance scripts

2019-01-23 Thread Tarrow
Tarrow created this task.Tarrow triaged this task as "Normal" priority.Tarrow added projects: Wikibase-Containers, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTIONIn order to use the new maintenance scripts in our docker images they need to be backported t

[Wikidata-bugs] [Maniphest] [Commented On] T214387: Allow commenting on shape expressions

2019-01-22 Thread Tarrow
Tarrow added a comment. Is it a human-readable discussion? If yes why not use talk page? We are experimenting with writing our user stories in a way that is more decoupled from the implementation details that before. After discussing it we might well decide that using talk pages is what we want

[Wikidata-bugs] [Maniphest] [Commented On] T213815: Run ArticlePlaceholder tests as part of Wikibase CI

2019-01-22 Thread Tarrow
Tarrow added a comment. Patches are up; needs review and then possible deploymentTASK DETAILhttps://phabricator.wikimedia.org/T213815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritbot, Jdforrester-WMF, Addshore, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T213815: Run ArticlePlaceholder tests as part of Wikibase CI

2019-01-22 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T213815WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Fix Javascript errors stopping Wikidata Tours loading

2019-01-21 Thread Tarrow
Tarrow added a comment. No problem. So the 'only' issue is that the boxes aren't correctly pegged to the field you should be working on when doing the tour? Or does it also break more in some way at some point?TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL P

[Wikidata-bugs] [Maniphest] [Commented On] T213704: Fix Javascript errors stopping Wikidata Tours loading

2019-01-21 Thread Tarrow
Tarrow added a comment. I could replicate the 'failure to attach' behaviour. In the ticket title and description you mention JS errors. I didn't see any in the console. If you got any could you paste them in?TASK DETAILhttps://phabricator.wikimedia.org/T213704EMAIL P

[Wikidata-bugs] [Maniphest] [Claimed] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2019-01-21 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T211120WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Claimed] T211038: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities

2019-01-21 Thread Tarrow
Tarrow moved this task from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T211038WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T214016: Wikibase CI failing due to phan

2019-01-17 Thread Tarrow
Tarrow added a comment. Mostly fixed but still some failures: https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/19248/consoleTASK DETAILhttps://phabricator.wikimedia.org/T214016EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T214016: Wikibase CI failing due to phan

2019-01-17 Thread Tarrow
Tarrow added a comment. Teh patches are there because From IRC: purple phan got updated after 3 years? 9:59 AM how about skipping the phan check for now, and trying to figure our what happens? 9:59 AM tests/phan/config.php and suppress_issue_types section out thereTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Triaged] T214016: Wikibase CI failing due to phan

2019-01-17 Thread Tarrow
Tarrow triaged this task as "Unbreak Now!" priority.Tarrow added a comment.Restricted Application added subscribers: Liuxinyu970226, TerraCodes. CI blocked hence UBN :(TASK DETAILhttps://phabricator.wikimedia.org/T214016EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Created] T214016: Wikibase CI failing due to phan

2019-01-17 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikidata, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONExample of no-op change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/484985 Example of failure: https://integration.wikimedia.org/ci

[Wikidata-bugs] [Maniphest] [Claimed] T211297: Make Wikibase 1.32 base and bundle image

2019-01-16 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from Stalled to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Tarrow added a comment. This is now unstalled since 1.32 is available at https://wikidata-shex.wmflabs.org PR just needs a tiny poke for ULS etc..TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Edited] T213913: Retire or update wikidata-dev/wikibase-lexeme trusty cloud VPS instance

2019-01-16 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONDue to Trusty no longer getting security updates in April 2-19 we will need to retire this instance (wikidata-dev/wikibase-lexeme) or update it. See: https://wikitechphabricator.wikimedia.org/wiki/News

[Wikidata-bugs] [Maniphest] [Created] T213913: Retire or update wikidata-dev/wikibase-lexeme trusty cloud VPS instance

2019-01-16 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikidata-Campsite, Wikidata.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONDue to Trusty no longer getting security updates in April 2-19 we will need to retire this instance (wikidata-dev/wikibase-lexeme) or update it. https

[Wikidata-bugs] [Maniphest] [Claimed] T205606: Quickstatements should work out of the box in wikibase docker image

2019-01-16 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T205606WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T211568: Create Maintentance Script(s) to produce OAuth Consumers

2019-01-14 Thread Tarrow
Tarrow added a comment. In T211568#4873003, @Addshore wrote: In their current state the patches enable the creation and approval of an OAuth consumer. However the user needs to be allowed to "mwoauthproposeconsumer" and "mwoauthmanageconsumer". @Tarrow do you think that is

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2019-01-09 Thread Tarrow
Tarrow added a comment. @Addshore From wmf-config/InitialiseSettings.php: 'wgWBQualityConstraintsTypeCheckMaxEntities' => [ 'default' => 1000, 'wikidatawiki' => 100, ], I can bump to 150 as a similar 50% increase to what you suggested.TASK DETAILhttps:/

[Wikidata-bugs] [Maniphest] [Created] T213170: Merge EntityPrefetcher and EntityMetaDataAccessor

2019-01-08 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikidata, Technical-Debt.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONLooks like most places we use an EntityMetaDataAccessor in place of an EntityPrefetcher. We could consider merging these to simplify code. Example from Per

[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode

2019-01-08 Thread Tarrow
Tarrow added a comment. It does not appear that deploying this patch without parser cache invalidation will cause cause frontend JS breakages. I tested this locally by: un-setting my value of $wgParserCacheType = CACHE_NONE. so $wgParserCacheType defaults to CACHE_ANYTHING loading current

[Wikidata-bugs] [Maniphest] [Claimed] T209931: Glosses: display the language name also in edit mode

2019-01-08 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T209931WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T212564: create Schema entity

2019-01-07 Thread Tarrow
Tarrow added a comment. The recent changes entry should be as similar as possible to the "New Item" one. i.e. include the label in the language used for the creationTASK DETAILhttps://phabricator.wikimedia.org/T212564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Edited] T212564: create Schema entity

2019-01-07 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[] a new entry is added to Recent changes [] blocked users are not able to create a new schema **Open questions:**...TASK DETAILhttps://phabricator.wikimedia.org/T212564EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T212564: create Schema entity

2019-01-07 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* What's the name of the namespace? * What's the entity ID format? * What's the text for the Recent changes entry?TASK DETAILhttps://phabricator.wikimedia.org/T212564EMAIL PREFERENCEShttps://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T212562: expanded SpecialPage for creating a new Schema

2019-01-07 Thread Tarrow
Tarrow added a comment. For clarification in this case 'Create' does nothingTASK DETAILhttps://phabricator.wikimedia.org/T212562EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, abian, Aklapper, Lydia_Pintscher, Nandana,

[Wikidata-bugs] [Maniphest] [Commented On] T212561: basic SpecialPage for creating a new Schema

2019-01-07 Thread Tarrow
Tarrow added a comment. Where in Special:AllPages should it go? i.e under which heading? Wikibase? Perhaps also think about the Wikibase Quality HeadingTASK DETAILhttps://phabricator.wikimedia.org/T212561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Unassigned] T209931: Glosses: display the language name also in edit mode

2019-01-03 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Liuxinyu970226, gerritbot, Lea_Lacroix_WMDE, Lydia_Pintscher, CucyNoiD, Nandana

[Wikidata-bugs] [Maniphest] [Updated] T212427: No namespace configured for entity type `form`

2019-01-02 Thread Tarrow
Tarrow edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: greg, Stashbot, Tarrow, Jakob_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow
Tarrow added a comment. In T212427#4838130, @daniel wrote: For the record, the revert should be temporary, on the deployment branch, not on master. This is exposing a problem in the calling code, which needs to be addressed. The revert is not a proper fix, just a stop-gap. Cool. From IRC

[Wikidata-bugs] [Maniphest] [Claimed] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel, WMDE-leszek, Cparle, Addshore, TerraCodes

[Wikidata-bugs] [Maniphest] [Commented On] T212427: No namespace configured for entity type `form`

2018-12-20 Thread Tarrow
Tarrow added a comment. The plan is to revert 479419. See: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/480978 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/480966TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Triaged] T212208: Add CLDR to Wikibase docker bundle image

2018-12-18 Thread Tarrow
Tarrow triaged this task as "Normal" priority.Tarrow moved this task from Incoming to Ready to go on the Wikidata-Campsite board. TASK DETAILhttps://phabricator.wikimedia.org/T212208WORKBOARDhttps://phabricator.wikimedia.org/project/board/3402/EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Created] T212208: Add CLDR to Wikibase docker bundle image

2018-12-18 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikibase-Containers, Wikidata, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWe want CLDR in the wikibase docker images. WikibaseLexeme takes advantage of it for Term display. https://www.mediawiki.org/wiki

[Wikidata-bugs] [Maniphest] [Edited] T212195: Add ULS to Wikibase bundle docker images

2018-12-18 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONTBA descriptiponWe want ULS in the wikibase docker images. Not only does it allow users to easily choose their language but wikibase takes advantage of it for Term display. See https://www.mediawiki.org/wiki

[Wikidata-bugs] [Maniphest] [Commented On] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-17 Thread Tarrow
Tarrow added a comment. Thank you sir! Tips are always greatly appreciated :)TASK DETAILhttps://phabricator.wikimedia.org/T211120EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, abian

[Wikidata-bugs] [Maniphest] [Claimed] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-17 Thread Tarrow
Tarrow claimed this task.Tarrow added a comment. Since Lucas is away for the holiday's I'll pick up the last bit of thisTASK DETAILhttps://phabricator.wikimedia.org/T211120EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow,

[Wikidata-bugs] [Maniphest] [Claimed] T211038: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities

2018-12-17 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T211038WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Unassigned] T211749: Invalidate parser cache when Lexeme templates are updated

2018-12-14 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task.Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Obviously we don't want to cause a massive spike in load so we only want to do it for necessary pages. In this case it should only be when the Lexeme frontend

[Wikidata-bugs] [Maniphest] [Created] T211867: Lexeme jasmine tests should include upstream wikibase dependencies

2018-12-13 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikidata, Wikidata-Campsite, Technical-Debt.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONWithout having these present it is not possible to properly test components that rely on wikibase derived things like entityselector and

[Wikidata-bugs] [Maniphest] [Created] T211866: LanguageAndLexicalCategoryWidget Vue Test and Prod Template are not in sync

2018-12-13 Thread Tarrow
Tarrow created this task.Tarrow added projects: Wikidata, Wikidata-Campsite, Technical-Debt.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONDue to T198455 the versions on the templates in tests/jasmine/LanguageAndLexicalCategoryWidget.spec.js and LexemeView.php have become out

[Wikidata-bugs] [Maniphest] [Updated] T209931: Glosses: display the language name also in edit mode

2018-12-12 Thread Tarrow
Tarrow added a comment. As you can see in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/477790 attempting to complete this task by just wrapping the same widget we use for monolingual text had a few issues. Attempting to follow the pattern for ItemSelectorWrapper which is

[Wikidata-bugs] [Maniphest] [Updated] T211749: Invalidate parser cache when Lexeme templates are updated

2018-12-12 Thread Tarrow
Tarrow added a comment. This is one possible solution to T197228TASK DETAILhttps://phabricator.wikimedia.org/T211749EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Lydia_Pintscher, Lea_Lacroix_WMDE, Tarrow, Nandana, Mringgaard, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T211749: Invalidate parser cache when Lexeme templates are updated

2018-12-12 Thread Tarrow
Tarrow created this task.Tarrow triaged this task as "Normal" priority.Tarrow added projects: Wikidata, Lexicographical data, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DESCRIPTIONWe need to invalidate the cache otherwise each page needs to be purged manually and often the f

[Wikidata-bugs] [Maniphest] [Unassigned] T205606: Quickstatements should work out of the box in wikibase docker image

2018-12-11 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T205606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: johl, dbs, thisismattmiller, Addshore, Lydia_Pintscher, Aklapper, Tarrow, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Edited] T205606: Quickstatements should work out of the box in wikibase docker image

2018-12-10 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Create a maintenance script for OAuth to generate a new consumer (see separate ticket TT211568)...TASK DETAILhttps://phabricator.wikimedia.org/T205606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Created] T211568: Create Maintentance Script(s) to produce OAuth Consumers

2018-12-10 Thread Tarrow
Tarrow created this task.Tarrow triaged this task as "Normal" priority.Tarrow added projects: Wikibase-Containers, Wikidata, Wikidata-Campsite, MediaWiki-extensions-OAuth. TASK DESCRIPTIONOne (or more) mediawiki maintenance scripts. I think in an ideal world this would be part of

[Wikidata-bugs] [Maniphest] [Triaged] T205606: Quickstatements should work out of the box in wikibase docker image

2018-12-06 Thread Tarrow
Tarrow triaged this task as "Normal" priority.Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONTBA details by @tarrow & or @Lydia_PintscherWe should have quickstatements working as it does on wikidata.org out of the box. Currently we rely on us

[Wikidata-bugs] [Maniphest] [Created] T211297: Make Wikibase 1.32 base and bundle image

2018-12-06 Thread Tarrow
Tarrow created this task.Tarrow added a project: Wikibase-Containers.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata. TASK DESCRIPTIONTASK DETAILhttps://phabricator.wikimedia.org/T211297WORKBOARDhttps://phabricator.wikimedia.org/project/board

[Wikidata-bugs] [Maniphest] [Closed] T210965: Increase datamodel version in PropertySuggester to version 9

2018-12-02 Thread Tarrow
Tarrow closed this task as "Invalid".Tarrow added a comment. Err... apparently notTASK DETAILhttps://phabricator.wikimedia.org/T210965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Addshore, Aklapper, Tarrow, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Created] T210965: Increase datamodel version in PropertySuggester to version 9

2018-12-02 Thread Tarrow
Tarrow created this task.Tarrow added a project: Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.Restricted Application added a project: Wikidata. TASK DESCRIPTIONCurrently propertysuggester causes my dev setup to fail because it requires a conflicting version of wikibase

[Wikidata-bugs] [Maniphest] [Commented On] T209931: Glosses: display the language name also in edit mode

2018-11-25 Thread Tarrow
Tarrow added a comment. extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.languagesuggester.js is what we want to useTASK DETAILhttps://phabricator.wikimedia.org/T209931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To

[Wikidata-bugs] [Maniphest] [Claimed] T209931: Glosses: display the language name also in edit mode

2018-11-21 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T209931WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Changed Project Column] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-20 Thread Tarrow
Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Tarrow added a comment. TASK DETAILhttps://phabricator.wikimedia.org/T209368WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-20 Thread Tarrow
Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - mismatching types **Conclusions** For values that look like entityids the datavalue type should be wikibase-entityid * Everything works to plan when the value is an entityid and matching datatype is supplied

[Wikidata-bugs] [Maniphest] [Commented On] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-20 Thread Tarrow
Tarrow added a comment. "Perfect" links are only returned for forms when the datatype is explicit specified as such and the id is valid e.g. value: L10-F3 and type: wikibase-form {"result":" A perfect link is also displayed when wikibase-form is passed as the datatype wi

[Wikidata-bugs] [Maniphest] [Commented On] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-20 Thread Tarrow
Tarrow added a comment. The pattern of success but with generic links for all but property and item also occurs with datatype parameter set to the following: monolingualtext quantity string time external-id TASK DETAILhttps://phabricator.wikimedia.org/T209368EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-20 Thread Tarrow
Tarrow added a comment. I've tested various combinations of the possible entries in the "datavalue" parameter. i.e. varying the specified type and the id string datavalue=={"type":"$TYPE", "value": {"id":"$VALUE"}} while keeping th

[Wikidata-bugs] [Maniphest] [Claimed] T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type

2018-11-19 Thread Tarrow
Tarrow claimed this task.Tarrow moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAILhttps://phabricator.wikimedia.org/T209368WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T209039: Update Wikibase Submodule to Include the required javascript api changes

2018-11-14 Thread Tarrow
Tarrow added a comment. 3.1.0 Should have been brought in by: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/473169TASK DETAILhttps://phabricator.wikimedia.org/T209039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper

[Wikidata-bugs] [Maniphest] [Claimed] T154660: Increase length limit for external identifier, string and URL datatype

2018-11-14 Thread Tarrow
Tarrow claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Lucas_Werkmeister_WMDE, Marsupium, Wostr, Addshore, Jheald, Daniel_Mietchen, Arbnos, Cirdan, Liuxinyu970226, daniel

[Wikidata-bugs] [Maniphest] [Commented On] T209201: WDQS server/updater performance issues

2018-11-14 Thread Tarrow
Tarrow added a comment. Could it be related to this report: https://lists.wikimedia.org/pipermail/wikidata/2018-November/012610.html ?TASK DETAILhttps://phabricator.wikimedia.org/T209201EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Krenair

[Wikidata-bugs] [Maniphest] [Commented On] T209043: Make changes to Lexeme to not make edits if a logged in user gets logged out

2018-11-13 Thread Tarrow
Tarrow added a comment. Looks like the tests needs more pokingTASK DETAILhttps://phabricator.wikimedia.org/T209043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritbot, Tarrow, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo

[Wikidata-bugs] [Maniphest] [Commented On] T209039: Update Wikibase Submodule to Include the required javascript api changes

2018-11-13 Thread Tarrow
Tarrow added a comment. yes! :DTASK DETAILhttps://phabricator.wikimedia.org/T209039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Aklapper, Addshore, Lucas_Werkmeister_WMDE, Tarrow, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345

[Wikidata-bugs] [Maniphest] [Unassigned] T204039: Lexeme pages broken with debug=true enabled

2018-11-13 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task.Tarrow edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).Tarrow added a comment. Attempting to have lexeme's ControllerViewFactory depend on "jquery.wikibase.sen

<    3   4   5   6   7   8   9   10   11   >