gerritbot added a comment.
Change 382758 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 045f94babc293704f10a98c8fdced0216fec7feb:
https://gerrit.wikimedia.org/r/382758TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL
Lucas_Werkmeister_WMDE added a comment.
Dropdown menus show left alignment (it may be valid for "tools", as tools have Latin names, and wrong for "help")
Also, I assume for the “Help” menu, the order of question mark icon, “help” text, and dropdown arrow should be reversed in rtl locales? (The
Lucas_Werkmeister_WMDE added a comment.
X of the query helper should float left not right
float: inline-end is the magical CSS that does the right thing in both locales… and which is currently only supported by Firefox :(TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL
Lucas_Werkmeister_WMDE added a comment.
It may be more correct to have the arrow icon mirrored in RTL
Hm, I’m not sure about that… on https://mideastunes.com/, the arrow points to the right in both the English and the Arabic version. And on YouTube with language set to Arabic, the play button
eranroz added a comment.
In T171564#3660992, @Jonas wrote:
Is this how it should be?
F10018211: image.png
More or less yes. The most basic aliveness for it is having LTR for the code area/line numbers/cursor, and it looks like once Lucas patch is deployed it will be use-able in RTL languages.
gerritbot added a comment.
Change 382402 merged by jenkins-bot:
[wikidata/query/gui@master] Force query editor and hints left-to-right
https://gerrit.wikimedia.org/r/382402TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL
Jonas added a comment.
Is this how it should be?
F10018211: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz,
gerritbot added a comment.
Change 382402 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Force query editor and hints left-to-right
https://gerrit.wikimedia.org/r/382402TASK
eranroz added a comment.
BTW it is so broken that it would be better to de-feature it for now.TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper,
