gerritbot added a comment.
Change 448022 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make wikibase-entityid catch EntityIdParsingExceptions
https://gerrit.wikimedia.org/r/448022TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
gerritbot added a comment.
Change 448022 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Make wikibase-entityid catch EntityIdParsingExceptions
https://gerrit.wikimedia.org/r/448022TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
gerritbot added a comment.
Change 447840 abandoned by Addshore:
Catch EntityIdParsingException in SetClaim
https://gerrit.wikimedia.org/r/447840TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore,
Addshore added a comment.
DataValueDeserializer::__construct docs should be updated to say what types of exceptions the builders can throw.
A better fix (than the current gerrit patch) might actually be to catch the EntityIdParsingException in the closure in WikibaseRepo and return another
Addshore added a comment.
Reproduction on test wikidata wiki:
https://test.wikidata.org/wiki/Special:ApiSandbox#action="">TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, Addshore,
gerritbot added a comment.
Change 447840 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Catch EntityIdParsingException in SetClaim
https://gerrit.wikimedia.org/r/447840TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
Addshore added a comment.
The issue is caused when the closure for 'wikibase-entityid' is called as provided by WikibasRepo::getDataValueDeserializer
This is called by DataValueDeserializer::getDeserialization which catches InvalidArgumentException but not EntityIdParsingExceptions which is
Pablo-WMDE added a comment.
@Addshore Given that the API end point did not change and the parser threw the exceptions all along it's probably valid to assume it's just the requests that changed - does that warrant this ticket to be downgraded?TASK
Addshore added a comment.
The SetClaim API module should catch the exception and report a nice error message instead of spamming the exception logs and sending the exception to the client..TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
Addshore added a comment.
I looked at one of the stacktraces and it looks like this is coming from the API, so it could just be a client providing bad data:
#0 /srv/mediawiki/php-1.32.0-wmf.13/extensions/Wikibase/repo/includes/WikibaseRepo.php(1459):
zeljkofilipin added a comment.
In T200340#4450574, @Ladsgroup wrote:
It's probably a new version that got released but not updated in the vendor I think.
Is there a way to quickly fix this? Or is there a workaround? I need an estimate on when this could be resolved, since it's blocking the
zeljkofilipin added a comment.
I have rolled back group 1 from .14 to .13, but now I see the same error for .13
[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of
Ladsgroup added a comment.
It's probably a new version that got released but not updated in the vendor I think.TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, Krinkle,
gerritbot added a comment.
Change 447815 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "group1 wikis to 1.32.0-wmf.14"
https://gerrit.wikimedia.org/r/447815TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
gerritbot added a comment.
Change 447815 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[operations/mediawiki-config@master] Revert "group1 wikis to 1.32.0-wmf.14"
https://gerrit.wikimedia.org/r/447815TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
15 matches
Mail list logo
