[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot
gerritbot added a comment. Change 541225 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeResult: guard against mTitle being null https://gerrit.wikimedia.org/r/541225 TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot
gerritbot added a comment. Change 541223 **merged** by jenkins-bot: [mediawiki/core@master] searchResult: Fix docs for mTitle https://gerrit.wikimedia.org/r/541223 TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot
gerritbot added a comment. Change 541225 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeResult: guard against mTitle being null https://gerrit.wikimedia.org/r/541225 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot
gerritbot added a comment. Change 541223 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy): [mediawiki/core@master] searchResult: Fix docs for mTitle https://gerrit.wikimedia.org/r/541223 TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. In T233763#5551443 , @Daimona wrote: > AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ Uh, actually, not

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ IMHO, it's pretty sad that: - This wasn't spotted when updating the class; - Nothing triggered (PHPUnit) tests

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. Curiously, PHPUnit is failing on the WikibaseLexemeCirrusSearch repo with "Call to a member function setFragment() on null". I don't know if it's exactly the same error, but oh well... TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES