[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-06-26 Thread gerritbot
gerritbot added a comment. Change 607878 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] [DNM] Also prefetch data from cache https://gerrit.wikimedia.org/r/607878 TASK DETAIL https://phabricator.wikimedia.org/T247196

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-05-20 Thread gerritbot
gerritbot added a comment. Change 594459 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Improve documentation of PrefetchingTermLookup implementations https://gerrit.wikimedia.org/r/594459 TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAIL PREFERENCES h

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-05-05 Thread gerritbot
gerritbot added a comment. Change 594450 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Only use CachingPrefetchingTermLookup when we have a cache. https://gerrit.wikimedia.org/r/594450 TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAIL PREFERENCES http

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-05-05 Thread gerritbot
gerritbot added a comment. Change 594459 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Improve documentation of PrefetchingTermLookup implementations https://gerrit.wikimedia.org/r/594459 TASK DETAIL https://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-05-05 Thread gerritbot
gerritbot added a comment. Change 594450 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Only use CachingPrefetchingTermLookup when we have a cache. https://gerrit.wikimedia.org/r/594450 TASK DETAIL https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-05-05 Thread gerritbot
gerritbot added a comment. Change 579030 abandoned by Addshore: [WIP] Add internal caching to CachingPrefetchingTermLookup Reason: I'm going to submit a patch with another approach https://gerrit.wikimedia.org/r/579030 TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAI

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-29 Thread CXuesong
CXuesong added a comment. I've applied patch r/578298 and it seems the problem has been mitigated. Thanks in advance! TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, CXuesong Cc: da

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-19 Thread Addshore
Addshore added a comment. So we just had a little discussion and determined that 2 issues have now been identified here: 1. as described in this ticket, CachingPrefetchingTermLookup does not work with getLocalServerObjectCache returns an EmptyBagOStuff, as the Lookup expects to be able

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-11 Thread gerritbot
gerritbot added a comment. Change 579030 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] [WIP] Add internal caching to CachingPrefetchingTermLookup https://gerrit.wikimedia.org/r/579030 TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-10 Thread Jakob_WMDE
Jakob_WMDE added a comment. Yeah, the `CachingPrefetchingTermLookup` definitely doesn't work without a functioning cache, i.e. won't work with `EmptyBagOStuff`. I'm a bit surprised that `PrefetchingTermLookup` should fall back to making lookups when prefetched terms are unavailable. My under

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-09 Thread gerritbot
gerritbot added a comment. Change 578298 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Do not try to load terms from cache in getPrefetched*() https://gerrit.wikimedia.org/r/578298 TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Commented On] T247196: Wikibase property names are missing when renders

2020-03-08 Thread CXuesong
CXuesong added a comment. Yes, I have. And actually the Property labels can be fetched from DB successfully. It just gets lost when storing the labels to the cache, i.e. `EmptyBagOStuff`. TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAIL PREFERENCES https://phabricator.wik