gerritbot added a comment.
Change 285630 had a related patch set uploaded (by Adrian Heine):
Use new EntityIdValue serialization in JS
https://gerrit.wikimedia.org/r/285630
TASK DETAIL
https://phabricator.wikimedia.org/T93172
EMAIL PREFERENCES
https://phabricator.wikimedia.org/sett
adrianheine added a comment.
https://github.com/wmde/WikibaseDataModelJavaScript/pull/63
TASK DETAIL
https://phabricator.wikimedia.org/T93172
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot, Ricordisamoa, adrianheine, dan
gerritbot added a comment.
Change 300015 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix mistake in ViewFactory.js
https://gerrit.wikimedia.org/r/300015TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferen
thiemowmde added a comment.
I had an other look and as far as I can tell the _javascript_ implementation called EntityId was never used. Nowhere.
Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.
Item and Property are using strings, not EntityIds.
So I sugges
Tobi_WMDE_SW added a comment.
@thiemowmde sound great, thx!
Does that mean we need to do in the following order:
Use DataModel 6.1 everywhere
Merge https://github.com/wmde/WikibaseDataModelJavaScript/pull/63 and a release a new version of DataModelJavaScript
Merge https://gerrit.wikimedia.org/
thiemowmde added a comment.
Yes, except:
Make sure everything is at least compatible with DataModel 6.1. Since the _javascript_ code in question is not used anywhere in our code base, this is to make sure external users (e.g. gadgets) can still deserialize the JSON blobs we provide. The JSON mus
gerritbot added a comment.
Change 300015 merged by jenkins-bot:
Fix mistake in ViewFactory.js
https://gerrit.wikimedia.org/r/300015TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, gerritbotCc: Tob
gerritbot added a comment.
Change 285630 merged by jenkins-bot:
Use new EntityIdValue serialization in JS
https://gerrit.wikimedia.org/r/285630TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, gerr
