[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

amy_rc closed this task as "Resolved". amy_rc added a comment. 💃 TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, amy_rc Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pi

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Ladsgroup added a comment. In T268982#6787430 , @Michael wrote: > I don't have a great overview yet of what has been done in the last days, but it would seem that this PR still needs to be merged: https://github.com/wmde/query-builder/p

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a comment. that's the one i tried out. i thought it said 38x37.x when i tested it but now it says 38x32.8 which i think is fine. can be merged then from my side! TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/s

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Michael added a comment. I don't have a great overview yet of what has been done in the last days, but it would seem that this PR still needs to be merged: https://github.com/wmde/query-builder/pull/157 ? TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://ph

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a comment. i seem to still have the same problem. maybe it's my browser? TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Charlie_WMDE Cc: amy_rc, Michael, Charlie_WM

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

amy_rc added a comment. @Charlie_WMDE Lydia and me tested and it looks good. Can you check this from design perceptive and then resolve the ticket? TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Ladsgroup moved this task from ❌ Blocked to Test (Verification) on the Wikidata Query Builder board. Ladsgroup added a comment. The icon size should be now deployed. TASK DETAIL https://phabricator.wikimedia.org/T268982 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMA

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE closed subtask T272053: (MS 2) Make the last condition removable as well as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Charlie_WMDE Cc: Michael, Charlie_WMDE

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to ❌ Blocked on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata Query Builder (Wikidata Query Builder - sprint 6). TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

amy_rc triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, amy_rc Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, La

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Michael claimed this task. Michael added a comment. Restricted Application added a project: User-Michael. I'll look into the icon size TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher moved this task from Test (Verification) to To Do on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Lydia_Pintscher added a comment. Moving back to todo for adressing Charlie's last point about the icon size. TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a subtask: T272053: Make the last condition removable as well. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintsche

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a comment. After discussing this topic with Lydia, we agreed to make following change in this ticket: > - size of the icon only component should be M. in firefox the measurements seem to be a bit off. should be 38x32px but appears as 38x33.4px (in chrome it's 38x32.89

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a comment. Removing or disabling the trashcan is an inconsistent behavior. we'd rather have to find arguments for why we *should* remove or disable it. I couldn't find any. if there's no good reason (preventing the user to make an error for example) to disable/remove the

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher added a comment. In T268982#6728955 , @Charlie_WMDE wrote: > regarding this ticket, the specs were, as amir mentioned, outdated. that's on me. my question to @Lydia_Pintscher is, how do we proceed. base the verification

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE added a comment. regarding this ticket, the specs were, as amir mentioned, outdated. that's on me. my question to @Lydia_Pintscher is, how do we proceed. base the verification off of the old specs and create a separate ticket? changes that would have to me made are: -

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 5 to Wikidata Query Builder - sprint 6 on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder (Wikidata Query Builde

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher closed subtask T268658: Create Quiet icon-only button component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Charlie_WMDE, Ladsgroup, Aklapper

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher closed subtask T271093: Extract RemoveCondition component that wraps the DS Button as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher closed subtask T270707: Implement Remove Condition logic as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, Akuckartz, Nandana, La

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, Akuckartz, Nandana, La

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

guergana.tzatchkova moved this task from Ready to pick up to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board. guergana.tzatchkova edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder. TASK DETAIL https://phabric

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Ladsgroup added a comment. These specs seem to be rather old. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandan

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher closed subtask T268397: (MS 2) concatenate multiple query blocks/conditions with AND as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Charlie_WMDE

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher added a subscriber: Charlie_WMDE. Lydia_Pintscher added a comment. @Ladsgroup See https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=1367%3A22573 for general idea. Not sure about the exact specs. @Charlie_WMDE will have those. TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Ladsgroup added a comment. This doesn't a design spec attached to it. Am I missing something? (I was thinking of implementing it without design system for now, with less than optimal look) but can't find any design to get some inspiration from :D TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilov

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZan

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher added a subtask: T268658: Create Quiet icon-only button component. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher added a subtask: T268397: (MS 2) concatenate multiple query blocks/conditions with AND. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintsche

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

Lydia_Pintscher created this task. Lydia_Pintscher added a project: Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As an editor I want to be able to remove query conditions I added to my visual quer