[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE added a comment. The log warnings are gone since wmf.18 (logstash

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Addshore Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo,

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. After wmf.18 is deployed, we can verify that the warning doesn’t get logged anymore, and/or that the expensive

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE added a comment. (I don’t think backporting this change is worth the effort, it touches too many files.) TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeiste

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705680 **merged** by jenkins-bot: [mediawiki/extensions/ArticlePlaceholder@master] Remove empty array check before SiteLinkLookup call https://gerrit.wikimedia.org/r/705680 TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26). TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeis

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705649 **abandoned** by Lucas Werkmeister (WMDE): [mediawiki/extensions/Wikibase@master] Check for empty array in ImplicitDescriptionUsageLookup Reason: I1572fa4d23 was done instead https://gerrit.wikimedia.org/r/705649 TASK DETAIL https

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705668 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use null to mark no conditions in SiteLinkLookup https://gerrit.wikimedia.org/r/705668 TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore added a comment. In T276762#7232173 , @Lucas_Werkmeister_WMDE wrote: > In T276762#7232048 , @gerritbot wrote: > >> Change 705652 **merged** by jenkins-bot: >> >> [mediaw

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE added a comment. Well, since the logging was deployed, we can at least look at it in Logstash: F34574570: Screenshot 2021-08-03 at 11-28-35 mediawiki-warnings - Elastic.png That’s 7006 events over the past 7 days. T

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE added a comment. In T276762#7232048 , @gerritbot wrote: > Change 705652 **merged** by jenkins-bot: > > [mediawiki/extensions/Wikibase@master] Log warning when querying for all links of sites > > https://ger

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26). TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Michael, Lucas_Werkmeister_

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705652 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Log warning when querying for all links of sites https://gerrit.wikimedia.org/r/705652 TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. Guess I should claim this if I already worked on it. Disclaimer: especially for the first change (“Check for empty array in ImplicitDescriptionUsageLookup”), I’m only assuming that this is where the bad cal

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcr

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcrespo, Biggs6

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcres

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Michael, Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcrespo,

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705680 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/ArticlePlaceholder@master] Remove empty array check before SiteLinkLookup call https://gerrit.wikimedia.org/r/705680 TASK

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lucas_Werkmeister_WMDE added a comment. Alright, I uploaded two separate patch sets: - check for empty array in caller + log warning in class fixes the `getLinks()` usage and warns if the function seems to b

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705668 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Use null to mark no conditions in SiteLinkLookup https://gerrit.wikimedia.org/r/705668 TASK DETAIL htt

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705652 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Log warning when querying for all links of sites https://gerrit.wikimedia.org/r/705652 TASK DETAIL htt

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, LSobanski, Addshore, Marostegui, hoo, Aklapper, jcrespo, Biggs657

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

gerritbot added a comment. Change 705649 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Check for empty array in ImplicitDescriptionUsageLookup https://gerrit.wikimedia.org/r/705649 TASK DETAI

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore added a comment. Replied off ticket :) TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Marostegui, hoo, Aklapper, jcrespo, maantietaja, Akuckartz, darthmon_wmde

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

jcrespo added a comment. Offtopic- and feel free to PM in private. What is a good way to report database-related issues to wikidata development team? I am a bit intimidated by the amount of tags and dashboards (which will probably reflect your internal organization, but I am not too familia

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Addshore moved this task from legacy-backlog to To Prioritize on the wdwb-tech-focus board. Addshore edited projects, added wdwb-tech-focus; removed wdwb-tech-focus (legacy-backlog). TASK DETAIL https://phabricator.wikimedia.org/T276762 WORKBOARD https://phabricator.wikimedia.org/project/bo

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

Lydia_Pintscher added a project: wdwb-tech-focus (backlog). Lydia_Pintscher added a subscriber: Addshore. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Addshore, Marostegui, h

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

jcrespo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T276762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jcrespo Cc: Marostegui, hoo, Aklapper, jcrespo, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Go

[Wikidata-bugs] [Maniphest] T276762: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks can take over a minute to execute

jcrespo created this task. jcrespo added projects: Wikidata, Wikibase. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This weekend, while an ongoing incident was being handled, I checked and saw several badly performing queries running. These didn't have (I believe) any