[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg added a comment. Hi all, I am going to close this ticket as the acceptance criteria has been met. But I have created a new ticket here to remove the pop-up altogether: T326960 TASK

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added a comment. @Arian_Bozorg Ok let's go with changing it to a button only and go with "Query Builder" as the copy. Can you create a new ticket for that? TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added a comment. I guess we could also stick to Query Builder for the button. Adding the "visual" I thought might help a bit in understanding what's behind the button but no strong feeling either way. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Sarai-WMDE added a comment. Thanks Arian, Lucas and Lydia! Given the existence of the banner mentioned by Lucas (which I wasn't aware of when providing suggestions) I think that just keeping the current button and removing the popup makes sense. Regarding renaming, I feel cautious about

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Arian_Bozorg added a comment. Lydia and I have discussed a **fourth** option: Removing the pop-up altogether and renaming the button "Visual Query Builder". We think the //first// option recreates the banner which seems like doubling up. The //second// option buries the Query

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lucas_Werkmeister_WMDE added a comment. Personally, I like approach 2. I’ll also point out that we’re still showing this banner to all first-time visitors, which kind of covers approach 1: F35993907: image.png TASK DETAIL

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Sarai-WMDE added a comment. > The suggestions aren't implemented, so I don't see how it justifies closing the ticket. It looks like the scope of the original task was adjusted, as explained in the second comment linked above (https://phabricator.wikimedia.org/T296135#7549054). I see

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Abbe98 added a comment. > Hey, @Abbe98. Charlie justified the changes done to the original ticket description in the following comments: https://phabricator.wikimedia.org/T296135#7548801, https://phabricator.wikimedia.org/T296135#7549054 The suggestions aren't implemented, so I don't

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Sarai-WMDE added a comment. Hey, @Abbe98. Charlie justified the changes done to the original ticket description in the following comments: https://phabricator.wikimedia.org/T296135#7548801, https://phabricator.wikimedia.org/T296135#7549054 If, as you mention, the popup still intrusive,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Abbe98 reopened this task as "Open". Abbe98 added a comment. I'm not sure what happened here, the original description is gone and the solution isn't even related. The popup is still intrusive in the same exact way as before even for people requesting reduced motion.

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Lydia_Pintscher Cc: Arian_Bozorg, Tagishsimon, Sarai-WMDE, ItamarWMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Arian_Bozorg added a comment. Looks good to me \o/ TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Arian_Bozorg Cc: Arian_Bozorg, Tagishsimon, Sarai-WMDE, ItamarWMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Maintenance_bot Cc: Tagishsimon, Sarai-WMDE, ItamarWMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

gerritbot added a comment. Change 865584 **merged** by Lucas Werkmeister (WMDE): [wikidata/query/gui-deploy@production] Merging from 319bd6f39d3482a25fe01bdde766df7f1cc92f40 https://gerrit.wikimedia.org/r/865584 TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

gerritbot added a comment. Change 865584 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query/gui-deploy@production] Merging from 319bd6f39d3482a25fe01bdde766df7f1cc92f40 https://gerrit.wikimedia.org/r/865584 TASK DETAIL

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

gerritbot added a comment. Change 865051 **merged** by jenkins-bot: [wikidata/query/gui@master] Adjust query builder button and its popup https://gerrit.wikimedia.org/r/865051 TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, gerritbot Cc: Tagishsimon, Sarai-WMDE, ItamarWMDE, Lydia_Pintscher, Charlie_WMDE, Nikki,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

gerritbot added a comment. Change 865051 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [wikidata/query/gui@master] Remove GIF and adjust styles on Query Builder popup https://gerrit.wikimedia.org/r/865051 TASK DETAIL https://phabricator.wikimedia.org/T296135

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Sarai-WMDE added a comment. Thanks for the clear feedback @Tagishsimon. Looks like we should not only limit the size of the dropdown menu, but maybe also we could reorder the buttons to get the popup further out of the way: F35840582: Screenshot 2022-12-06 at 10.37.49.png

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Tagishsimon added a comment. Smaller is better. Three short sentences, no graphical distraction. The failure mode for users who just want to use WDQS and not the Query Builder, is that when moving the mouse from the top of the screen down towards a target in the query, accidently

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added a comment. That'd also be ok for me. No strong preference either way. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Lydia_Pintscher Cc: Sarai-WMDE, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Sarai-WMDE added a comment. Yes, definitely the width should be adjusted to make the content readable. We could simply change the min-width of the dropdown menu to 25em (It's generally a good idea to use relative units to size text containers, although I think fonts in that page are

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

noarave added a subscriber: Sarai-WMDE. noarave added a comment. @Sarai-WMDE Once the GIF is removed, the popup becomes more narrow, it ends up looking kind of cramped, imo. What do you think? F35838059: query-builder-popup.png TASK DETAIL

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

noarave claimed this task. Restricted Application added a project: User-Noarave. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: ItamarWMDE, Lydia_Pintscher, Charlie_WMDE, Nikki,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

noarave edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: ItamarWMDE, Lydia_Pintscher, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added a project: Wikidata Dev Team. Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: ItamarWMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: ItamarWMDE, Lydia_Pintscher, Charlie_WMDE, Nikki, VIGNERON, Abbe98,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added a project: good first task. Lydia_Pintscher added a subscriber: ItamarWMDE. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: ItamarWMDE,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Charlie_WMDE added a comment. After talking with Lydia, we decided that as a first step we will remove the gif part of the popover and leave the descriptive text as a sort of extended tooltip to try to marry the interests of both user groups. Let's see if that is perceived as less

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Charlie_WMDE added a comment. Hey @Abbe98, thanks for creating this ticket. Your point makes a lot of sense and I've been thinking on how to improve the situation. Your first suggestion, disabling the popup for people who prefer reduced motion makes a lot of sense. Maybe we could

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Lydia_Pintscher added subscribers: Charlie_WMDE, Lydia_Pintscher. Lydia_Pintscher added projects: Wikidata-Campsite, Wikidata Query Builder. Lydia_Pintscher added a comment. Yeah I've noticed this being irritating as well. Let's do something about this. TASK DETAIL

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Mahir256 renamed this task from "Make the Query builder popup less intrusive " to "Make the Query builder popup less intrusive". TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mahir256 Cc:

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Nikki added a comment. I think it would be more consistent to not have a popup on hover at all. None of the other menus/buttons do that. But yes, please do //something// about this. I've hidden the popup entirely for myself (`.dropdown-menu.query-builder { display: none !important; }`

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: VIGNERON, Abbe98, Aklapper, Invadibot, MPhamWMF, maantietaja, CBogen, Akuckartz,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Abbe98 updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T296135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Abbe98 Cc: VIGNERON, Abbe98, Aklapper, MPhamWMF, CBogen, Namenlos314, Gq86, Lucas_Werkmeister_WMDE, Mahir256,

[Wikidata-bugs] [Maniphest] T296135: Make the Query builder popup less intrusive

Abbe98 created this task. Abbe98 added a project: Wikidata Query UI. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Current behavior: When hovering the Query Builder button its popup displays instantaneous even if an user is only hovering for a very short period of