[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

ItamarWMDE closed subtask T305535: Let wbgetclaims return best-rank statements as Declined. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, ItamarWMDE Cc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher moved this task from Test (Verification) to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 6) board. Lydia_Pintscher claimed this task. Lydia_Pintscher added a comment. \o/ TASK DETAIL

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE closed subtask T305542: WriteUse Action to actually make the language code Inference work as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

karapayneWMDE moved this task from Special:NewLexeme revival - sprint 5 to Special:NewLexeme revival - sprint 6 on the Special:NewLexeme revival board. karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 6); removed Special:NewLexeme revival

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE closed subtask T306170: Support wikis without configured $wgLexemeLanguageCodePropertyId as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE closed subtask T305546: Add i18n warning message for invalid language code to WikibaseLexeme.git as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a comment. Doh! Yes ;-) TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, Michael, noarave, ItamarWMDE, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE added a comment. I forgot that the task description already has the message copy – “This Item has an unrecognized language code. Please select one below.” should work for both cases, I think. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a comment. Ok let's go with what you proposed then. As for the message: We can keep the error message something generic like "We could not read the statement for the language code from the Item foo" and then link the statement? TASK DETAIL

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE added a comment. @Michael and I were thinking that it might make sense to treat `novalue` like a missing statement, but `somevalue` like an invalid language code (e.g. `P218=foobarbaz`), so the latter would show the spelling variant selector but also an error message.

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a comment.  I was indeed wondering  Can we treat it as if no statement was present? So in essence show the spelling variant selector. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE added a comment. @Lydia_Pintscher What should happen if the best-rank `P218` statement has unknown value, or no value? (Currently, there are 11 items with novalue P218

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE closed subtask T305578: Pass down the wgLexemeLanguageCodePropertyId to the new-lexeme-special-page application via the config as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Michael closed subtask T305539: Retrieve language code property data from the API as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lucas_Werkmeister_WMDE, Michael,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lucas_Werkmeister_WMDE added a comment. > If the `P218` statement includes more than one value, the application will use the first best ranked value (@Lydia_Pintscher does that chime correctly?). The current implementation almost uses the first best-rank statement, except that it falls

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

ItamarWMDE added subscribers: guergana.tzatchkova, ItamarWMDE, noarave, Michael, Lucas_Werkmeister_WMDE. ItamarWMDE added a comment. **(Some background) possible language code scenarios** - Valid language code → No spelling variant lookup, no warning message. - Invalid language code

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

karapayneWMDE moved this task from milestone 1 to Special:NewLexeme revival - sprint 5 on the Special:NewLexeme revival board. karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 5); removed Special:NewLexeme revival. TASK DETAIL

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

karapayneWMDE updated the task description. karapayneWMDE set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Erdinc_Ciftci_WMDE,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a comment. TODO Lydia: think through which Property to use some more. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Erdinc_Ciftci_WMDE, Bugreporter,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a subscriber: Erdinc_Ciftci_WMDE. Lydia_Pintscher added a comment. @Erdinc_Ciftci_WMDE can you have a look at the copy of the warning message? TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Bugreporter, Mahir256, Nikki, Aklapper, Lydia_Pintscher, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Bugreporter added a comment. We should also consider no matter what property we use, the values are not always language codes supported by Wikidata. See T209282: Error when creating lexemes in languages which have an unsupported ISO 639-1 code

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Bugreporter added a comment. In T298142#7585471 , @Mahir256 wrote: > I'd like to suggest a change to infer the spelling variants from P‌220 or P3‌05 per T284882 . The dedicated property

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Lydia_Pintscher added a comment. Thanks. Poked Daniel and Denny there for input as I seem to remember they had good reasons for the current state but can't quite puzzle it together anymore. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Mahir256 added subscribers: Nikki, Mahir256. Mahir256 added a comment. I'd like to suggest a change to infer the spelling variants from P‌220 or P3‌05 per T284882 . TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298142: Spelling variant of the Lemma - infer the spelling variant from the language

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T298142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86,