[MediaWiki-CodeReview] [MediaWiki r85324]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r85324. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85324#c18796 Commit summary: Styling for revdel'd revision links for oversighters/admins: make the links still be greyed out, but still active and with underline-on-hover. Com

[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c18797 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so le

[MediaWiki-CodeReview] [MediaWiki r88738]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r88738. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88738#c0 Commit summary: (bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget(). _

[MediaWiki-CodeReview] [MediaWiki r86335]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r86335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86335#c18798 Commit summary: (bug 28583) chase down and beat to death external calls of functions marked /*private*/, and make those declarations actually binding. Patch by yu

[MediaWiki-CodeReview] [MediaWiki r86044]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r86044. Old Status: fixme New Status: new User "Happy-melon" also posted a comment on MediaWiki.r86044. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86044#c18799 Commit summary: Follow-up r 86041 per CR and IRC: * Article cons

[MediaWiki-CodeReview] [MediaWiki r90868]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90868. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90868#c0 Commit summary: switching from instanceof Array to jquery.isArray() ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r90806]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90806. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90806#c0 Commit summary: switching to blue hearts per discussion ___ MediaWiki-CodeReview m

[MediaWiki-CodeReview] [MediaWiki r90807]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90807. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90807#c0 Commit summary: improvements to css, messages, and default config ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r90808]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90808#c0 Commit summary: removing outdated image files, adding red hearts for back-up ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r90810]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90810. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90810#c0 Commit summary: disabling jquery.elastic for now - buggy in firefox ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r90813]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90813. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90813#c0 Commit summary: Fix svn:mime-type for 2 images in folder ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90820]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90820. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90820#c0 Commit summary: reverting r90817 per discussion with jorm ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90821]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90821. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90821#c0 Commit summary: disambiguting file name ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r90822]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90822. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90822#c0 Commit summary: switching back to red icons per popular demand ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [MediaWiki r90823]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90823. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90823#c0 Commit summary: mw.util.wikiUrlencode is not meant for encoding entire URLs, or if it is, its too agressive. For example, it encodes t

[MediaWiki-CodeReview] [MediaWiki r90842]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90842. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90842#c0 Commit summary: removing wgServer since it isnt necessary (also should be called with mw.config.get anyway) _

[MediaWiki-CodeReview] [MediaWiki r90746]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90746. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90746#c0 Commit summary: button icons only supported by vector currently ___ MediaWiki-CodeReview m

[MediaWiki-CodeReview] [MediaWiki r90677]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90677. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90677#c0 Commit summary: updating jQuery elastic plugin ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r90621]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90621#c0 Commit summary: fixing bad path in r90567 ___ MediaWiki-CodeReview mailing list mediawiki-

[MediaWiki-CodeReview] [MediaWiki r90567]: New comment added

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" posted a comment on MediaWiki.r90567. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90567#c18800 Commit summary: making message field configurable in preparation for welcome templates, disabling email for barnstars for now (per Howie and Alolita), making label

[MediaWiki-CodeReview] [MediaWiki r90567]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90567. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90567#c0 Commit summary: making message field configurable in preparation for welcome templates, disabling email for barnstars for now (p

[MediaWiki-CodeReview] [MediaWiki r90220]: New comment added

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" posted a comment on MediaWiki.r90220. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90220#c18801 Commit summary: include localized prefix per comments at r90191 Comment: This is broken as the closing bracket in the end is incorrect... wgFormattedNamespaces[6]

[Wikitech-l] Reproducing localurl by python urllib.quote()

2011-06-27 Thread Alex Brollo
I found a number of troubles when trying to replicate localurl: parser function by python urllib.quote(), with a number of annoying bugs. Is this correct-complete? "/wiki/"+urllib.quote(name-of-page.replace(" ","_"),"/!,;:.-_") where name-of-page is utf-8 encoded. Thanks! I apologyze for so a ba

[MediaWiki-CodeReview] [MediaWiki r90220]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r90220. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90220#c0 Commit summary: include localized prefix per comments at r90191 ___ MediaWiki-CodeRe

[MediaWiki-CodeReview] [MediaWiki r88773]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r88773. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88773#c0 Commit summary: adding simple method for building galleries from an array of images ___ Me

[MediaWiki-CodeReview] [MediaWiki r88358]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r88358. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88358#c0 Commit summary: refactored to depend less on templates, you can now build most items with just an image and text

[MediaWiki-CodeReview] [MediaWiki r88216]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r88216. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88216#c0 Commit summary: setting tabindex to 0 ___ MediaWiki-CodeReview mailing list mediawiki-code

[MediaWiki-CodeReview] [MediaWiki r87949]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r87949. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87949#c0 Commit summary: a couple css tweaks and fixing circle image so that numbers are properly centered ___

[MediaWiki-CodeReview] [MediaWiki r87761]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r87761. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87761#c0 Commit summary: Added in icons; modified js to use barnstar icon ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r87059]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "JanPaul123" changed the status of MediaWiki.r87059. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87059#c0 Commit summary: initial files for WikiLove ext ___ MediaWiki-CodeReview mailing list media

Re: [Wikitech-l] MediaWiki 1.17.0 released

2011-06-27 Thread Sumana Harihareswara
On Tue, Jun 21, 2011 at 10:24 PM, Erik Moeller wrote: > \o/ > > Congratulations, everyone! :-) It's been a long road -- great to see > all the hard work that's gone into the new installer, ResourceLoader, > and the tons of accumulated fixes and enhancements get out there. > > -- > Erik Möller > D

[MediaWiki-CodeReview] [MediaWiki r85322]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r85322. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85322#c0 Commit summary: Add the revision-info and revision-info-current messages directly to the page, don't stick them in the content sub

[MediaWiki-CodeReview] [MediaWiki r90877]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r90877. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90877#c18802 Commit summary: Follow-up r86044 CR (correct subtitle message for action=credits), and some documentation. Comment: What do you think strtolower( 'creditspage' )

[MediaWiki-CodeReview] [MediaWiki r90877]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r90877. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90877#c0 Commit summary: Follow-up r86044 CR (correct subtitle message for action=credits), and some documentation. __

[MediaWiki-CodeReview] [MediaWiki r90866]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r90866. Old Status: new New Status: ok User "Hashar" also posted a comment on MediaWiki.r90866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90866#c18803 Commit summary: Tweaked r90766 messages. Still awkward. Also, this still need

[MediaWiki-CodeReview] [MediaWiki r90885]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r90885. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90885#c0 Commit summary: Follow-up r90877: spot the copy-and-pasted code... :D ___ MediaWiki-CodeRe

[MediaWiki-CodeReview] [MediaWiki r86490]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c18804 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-c

[MediaWiki-CodeReview] [MediaWiki r86490]: New comment added

2011-06-27 Thread MediaWiki Mail
User "OverlordQ" posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c18805 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cab

[MediaWiki-CodeReview] [MediaWiki r86490]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r86490. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c0 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap',

[MediaWiki-CodeReview] [MediaWiki r81087]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r81087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81087#c18806 Commit summary: Added a warning so non-mediawiki-developers understand that they are getting a snapshot from trunk and not something that has been tested to be compatibl

[MediaWiki-CodeReview] [MediaWiki r70095]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r70095. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70095#c0 Commit summary: Restructured upload-by-url: * In ApiUpload: moved stuff that is checking instead of actual uploading out of performUpload m

[MediaWiki-CodeReview] [MediaWiki r72475]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r72475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72475#c0 Commit summary: Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to

[MediaWiki-CodeReview] [MediaWiki r78179]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r78179. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78179#c0 Commit summary: Fix regression in r70657. Misplaced else condition was causing cache misses to try to load the message text and cache

[MediaWiki-CodeReview] [MediaWiki r89583]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89583. Old Status: new New Status: resolved User "Brion VIBBER" also posted a comment on MediaWiki.r89583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89583#c18807 Commit summary: fundraising specific code - mostly for auto

[MediaWiki-CodeReview] [MediaWiki r90892]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90892. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90892#c0 Commit summary: removing debugging call, follow-up to r89583 ___ MediaWiki-CodeReview ma

[MediaWiki-CodeReview] [MediaWiki r78926]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r78926. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78926#c0 Commit summary: (bug 26399) Preload module info for all modules in startup module, to prevent lots of individual queries. Also improve prel

[MediaWiki-CodeReview] [MediaWiki r90680]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90680. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90680#c0 Commit summary: making fundraising interface dependant on wgNoticeEnableFundraising global var _

[MediaWiki-CodeReview] [MediaWiki r89279]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89279. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r89279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89279#c18808 Commit summary: better function names Comment: Updates to moder

[MediaWiki-CodeReview] [MediaWiki r81087]: New comment added

2011-06-27 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r81087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81087#c18809 Commit summary: Added a warning so non-mediawiki-developers understand that they are getting a snapshot from trunk and not something that has been tested to be compatib

[MediaWiki-CodeReview] [MediaWiki r89284]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89284. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r89284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89284#c18810 Commit summary: changing some var names to reflect current naming

[MediaWiki-CodeReview] [MediaWiki r89286]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89286. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89286#c0 Commit summary: add static method for looking up campaign name ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r90326]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90326. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90326#c0 Commit summary: using better function name, adding function documentation ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r90327]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90327. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90327#c0 Commit summary: consistant formatting for list ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r90890]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90890. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90890#c0 Commit summary: Remove commented out "live" code which we don't use now ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r90889]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90889#c0 Commit summary: Followup r86490, remove spurious r ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r90328]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90328. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r90328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90328#c18811 Commit summary: adding php unit testing (with a simple test for t

[MediaWiki-CodeReview] [MediaWiki r90886]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90886#c0 Commit summary: Removed unused call to variable ___ MediaWiki-CodeReview mailing list mediawik

[MediaWiki-CodeReview] [MediaWiki r90891]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90891. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90891#c0 Commit summary: Kill unused css as of r90890 ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r88515]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r88515. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88515#c0 Commit summary: fix to make page work on wikis that use a db table prefix ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r90893]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90893. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90893#c0 Commit summary: Follow-up r86490 CR: localise strings and synchronise CSS styles. ___ MediaWik

[MediaWiki-CodeReview] [MediaWiki r87224]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87224. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87224#c0 Commit summary: Message 'centralnotice-multiple' was used in two different contexts. Now there is a message for each context. _

[MediaWiki-CodeReview] [MediaWiki r85832]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r85832. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85832#c0 Commit summary: we want all supported languages even if they dont have customized system messages _

[MediaWiki-CodeReview] [MediaWiki r83746]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83746. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r83746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c18812 Commit summary: Load SpecialNoticeTemplate class also on non-i

[MediaWiki-CodeReview] [MediaWiki r83745]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83745. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r83745. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83745#c18813 Commit summary: Fix fatal error when running without CentralAuth

[MediaWiki-CodeReview] [MediaWiki r90874]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90874. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90874#c0 Commit summary: Follow-up r88738: this check is no longer needed since r88750. ___ Media

[MediaWiki-CodeReview] [MediaWiki r88738]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r88738. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88738#c0 Commit summary: (bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget(). _

[MediaWiki-CodeReview] [MediaWiki r83744]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83744. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r83744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83744#c18814 Commit summary: Followup to r83715: use internal HTTP client,

[MediaWiki-CodeReview] [MediaWiki r83718]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83718. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83718#c0 Commit summary: Fix PHP Parse error from r83715, use $wgExtensionAssetsPath * $wgScriptPath/extensions -> $wgExtensionAssetsPath * F

[MediaWiki-CodeReview] [MediaWiki r83715]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83715. Old Status: new New Status: resolved User "Brion VIBBER" also posted a comment on MediaWiki.r83715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83715#c18815 Commit summary: Improve fetching of the donation amount, re

[MediaWiki-CodeReview] [MediaWiki r83744]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83744. Old Status: fixme New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r83744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83744#c18816 Commit summary: Followup to r83715: use internal HTTP client, h

[MediaWiki-CodeReview] [MediaWiki r90490]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r90490. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90490#c0 Commit summary: * (bug 29278) server error 500 when attempting to add text to a page via redirect (redirect poin

[MediaWiki-CodeReview] [MediaWiki r90895]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90895#c0 Commit summary: (bug 29511) block dropdown reasons should be in wiki content language. _

[MediaWiki-CodeReview] [MediaWiki r89779]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r89779. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89779#c18817 Commit summary: Fix messages on Special:ArticleFeedback per Howie Comment: No, it's not "70% or (more low) ratings" where (more low) == (lowe

[MediaWiki-CodeReview] [MediaWiki r89779]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r89779. Old Status: fixme New Status: new User "Aaron Schulz" also posted a comment on MediaWiki.r89779. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89779#c18818 Commit summary: Fix messages on Speci

[MediaWiki-CodeReview] [MediaWiki r83746]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r83746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c18819 Commit summary: Load SpecialNoticeTemplate class also on non-infrastructure wikis. PHP Fatal error: Class 'SpecialNoticeTemplate' not found in CentralNotice/SpecialB

[MediaWiki-CodeReview] [MediaWiki r90897]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r90897. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r90897. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90897#c18820 Commit summary: follow-up to r83746 - move static method into DB

[MediaWiki-CodeReview] [MediaWiki r83746]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r83746. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c0 Commit summary: Load SpecialNoticeTemplate class also on non-infrastructure wikis. PHP Fatal error: Class 'SpecialNoticeTem

[MediaWiki-CodeReview] [MediaWiki r85288]: New comment added, and revision status changed

2011-06-27 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r85288. Old Status: fixme New Status: reverted User "Happy-melon" also posted a comment on MediaWiki.r85288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85288#c18821 Commit summary: Implement magic accessors for RequestContex

[MediaWiki-CodeReview] [MediaWiki r90899]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90899. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90899#c0 Commit summary: Revert r85288 (magic accessors for RequestContext); much more trouble than they're worth. _

[MediaWiki-CodeReview] [MediaWiki r90901]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r90901. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c0 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. ___

[MediaWiki-CodeReview] [MediaWiki r90508]: New comment added

2011-06-27 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r90508. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90508#c18822 Commit summary: create images with orientation (had to use exiv2 hack, imagemagick not helpful) Comment: You added a fixme to this, could you describe what you want don

[MediaWiki-CodeReview] [MediaWiki r86347]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r86347. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86347#c0 Commit summary: Cleanup in SpecialPage.php: * Enforce private access for member variables suggested since at least 1.4. Didn'

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18823 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Would ContextSourceInterface be a

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18824 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: I think so IMO. __

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18825 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: INameOfInterface is the .NET way of na

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18826 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Whatever we end up with, it shoul

[MediaWiki-CodeReview] [MediaWiki r86044]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r86044. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86044#c0 Commit summary: Follow-up r 86041 per CR and IRC: * Article constructor needs to be called with zero as second parameter * Run styliz

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18827 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Generally you can think of inte

Re: [Wikitech-l] WMF XML dump title case problem

2011-06-27 Thread Platonides
Emmanuel Engelhart wrote: > > Hi > > Titles should be stored in the table "page" with a first letter uppercased. > http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_%28technical_restrictions%29#Lower_case_first_letter > > Unfortunately, it seems that we have XML dumps (and consequently > mw

[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18828 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: But what if you want both an inte

[MediaWiki-CodeReview] [MediaWiki r85886]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c0 Commit summary: No need to quote just to avoid the prefixes. ___ MediaWiki-CodeReview ma

[Wikitech-l] should we join the Unicode Constortium?

2011-06-27 Thread Ryan Kaldari
I'm not sure who would be in charge of this, but I think it would be useful if the WMF was a liaison member of the Unicode Constortium: http://unicode.org/consortium/memblogo.html This body makes all sorts of important decisions about the Unicode standard—decisions that affects many aspects of o

[MediaWiki-CodeReview] [MediaWiki r90508]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r90508. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90508#c18829 Commit summary: create images with orientation (had to use exiv2 hack, imagemagick not helpful) Comment: You are using an undefined variable. They are usually defi

[MediaWiki-CodeReview] [MediaWiki r90866]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r90866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90866#c18830 Commit summary: Tweaked r90766 messages. Still awkward. Also, this still needs JS to disable the check if "all" is selected, to be less confusing. Comment: : ''Also,

Re: [Wikitech-l] should we join the Unicode Constortium?

2011-06-27 Thread Platonides
Ryan Kaldari wrote: > I'm not sure who would be in charge of this, but I think it would be > useful if the WMF was a liaison member of the Unicode Constortium: > http://unicode.org/consortium/memblogo.html > > This body makes all sorts of important decisions about the Unicode > standard—decisions t

[MediaWiki-CodeReview] [MediaWiki r85884]: New comment added

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r85884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85884#c18831 Commit summary: Abstract tableName() by adding new function isQuotedIdentifier() to databases. This fixes bug in DatabaseOracle.php tableName() on line 671 and all

[MediaWiki-CodeReview] [MediaWiki r85293]: Revision status changed

2011-06-27 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r85293. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85293#c0 Commit summary: Clean out some globals from SpecialPage.php ___ MediaWiki-CodeReview mai

Re: [Wikitech-l] Reproducing localurl by python urllib.quote()

2011-06-27 Thread Platonides
Alex Brollo wrote: > I found a number of troubles when trying to replicate localurl: parser > function by python urllib.quote(), with a number of annoying bugs. > > Is this correct-complete? > > "/wiki/"+urllib.quote(name-of-page.replace(" ","_"),"/!,;:.-_") > where name-of-page is utf-8 encoded.

Re: [Wikitech-l] should we join the Unicode Constortium?

2011-06-27 Thread Brion Vibber
On Mon, Jun 27, 2011 at 1:53 PM, Ryan Kaldari wrote: > I'm not sure who would be in charge of this, but I think it would be > useful if the WMF was a liaison member of the Unicode Constortium: > http://unicode.org/consortium/memblogo.html > > This body makes all sorts of important decisions about

Re: [Wikitech-l] Question regarding reverting a certain own version in SVN; and asking you to update two MW pages with such how-to information

2011-06-27 Thread Platonides
Ashar Voultoiz wrote: > On 24/06/11 08:33, Thomas Gries wrote: >> When I think that a version committed by myself r90650 (marked as new) >> is fully obsolete and >> already replaced in my other commit r90684 (marked as fixed) > > I would say, if it is reverted, mark it reverted :) > Or maybe resol

  1   2   >