User Reedy changed the status of MediaWiki.r93157.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93157#c0
Commit summary:
Followup r93132, misplaced ) caused 'dirname() expects exactly 1 parameter, 3
given' error.
User Reedy changed the status of MediaWiki.r93162.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93162#c0
Commit summary:
Followup r93157, missing another one of the stray )'s.
___
MediaWiki-CodeReview
User Reedy posted a comment on MediaWiki.r93153.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93153#c20145
Commit summary:
Adding my USERINFO file
Comment:
Missing svn:eol-style native here, but noticed on your extension imports they
are set, so I don't really need to poke
User Reedy changed the status of MediaWiki.r91654.
Old Status: fixme
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91654#c0
Commit summary:
Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it more
portable (not all wikis do headItems
User Reedy changed the status of MediaWiki.r93172.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93172#c0
Commit summary:
Adding my USERINFO file.
___
MediaWiki-CodeReview mailing list
User Reedy changed the status of MediaWiki.r93171.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93171#c0
Commit summary:
Proper URL to main userpage on one of the Wikimedia projects
___
User Reedy changed the status of MediaWiki.r93153.
Old Status: new
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93153#c0
Commit summary:
Adding my USERINFO file
___
MediaWiki-CodeReview mailing list
Thank you all for the nice welcome.:) I started to work with Mark this week
and could already bring a couple Squid servers back up today.
On Tue, Jul 26, 2011 at 3:00 AM, Arthur Richards aricha...@wikimedia.orgwrote:
Welcome - I'm looking forward to working with you both!
--
--
Daniel Zahn
User Reedy posted a comment on MediaWiki.r93192.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93192#c20146
Commit summary:
Migrated js loading to ResourceLoader; Changed NULL to null
Comment:
You've got mixed tabs/spaces in CollabWatchlist.php
User Raymond posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20147
Commit summary:
* Ignore any nowiki or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between [[Category:
User Hashar changed the status of MediaWiki.r91843.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91843#c0
Commit summary:
Centralize QUnit customizations for MediaWiki:
- Rename 'awesome.js' to 'defineTestCallback.js' (more descriptive)
- Move
User Hashar changed the status of MediaWiki.r91387.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91387#c0
Commit summary:
Adding tests for expected reponse when passing invalid values to Map.get
* These are currently @broken
* Map.get should (as
User Jlemley posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20148
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
This looks great - thanks for your
User DieBuche changed the status of MediaWiki.r93090.
Old Status: fixme
New Status: new
User DieBuche also posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20149
Commit summary:
* Ignore any nowiki or comment sections
* More natural
User Raymond posted a comment on MediaWiki.r93196.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93196#c20150
Commit summary:
r93090 : Make summaries more modular, Siebrand says there'll be problems with
translation otherwise.
Comment:
Thanks. But it was me, not Siebrand :P
User Jack Phoenix posted a comment on MediaWiki.r93192.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93192#c20151
Commit summary:
Migrated js loading to ResourceLoader; Changed NULL to null
Comment:
pre
+ 'position' = 'top',
/pre
Does this work? From what I understood,
User Reedy posted a comment on MediaWiki.r93192.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93192#c20152
Commit summary:
Migrated js loading to ResourceLoader; Changed NULL to null
Comment:
I'm pretty sure you're right...
___
User Reedy posted a comment on MediaWiki.r93205.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93205#c20153
Commit summary:
(bug 28553) Set ar_parent_id on deletion
Comment:
RELEASE-NOTES?
___
MediaWiki-CodeReview mailing list
User Aaron Schulz posted a comment on MediaWiki.r93205.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93205#c20154
Commit summary:
(bug 28553) Set ar_parent_id on deletion
Comment:
I don't know if it's worth it. Add it if you want though.
User Catrope posted a comment on MediaWiki.r93192.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93192#c20155
Commit summary:
Migrated js loading to ResourceLoader; Changed NULL to null
Comment:
Nope, you're wrong, see r85616.
User Platonides changed the status of MediaWiki.r93199.
Old Status: new
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93199#c0
Commit summary:
comment
___
MediaWiki-CodeReview mailing list
User MaxSem changed the status of MediaWiki.r93213.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93213#c0
Commit summary:
Apparently MaxSem cares about SQLite ;)
r93211
Fix a bit of alignment
___
User ^demon changed the status of MediaWiki.r93173.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93173#c0
Commit summary:
Props for r93153
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r93215.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93215#c0
Commit summary:
Add basic USERINFO for binasher
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r93216.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93216#c0
Commit summary:
Fine
r93215
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r93220.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93220#c0
Commit summary:
Add irc nick for asher
___
MediaWiki-CodeReview mailing list
User Nikerabbit changed the status of MediaWiki.r93174.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20156
Commit summary:
Followup r93154: Tweak extension credits and message
User Raymond posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20157
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
Not tested.
User ^demon posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20158
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
The e-mail sent to mediawiki-l on the
User ^demon changed the status of MediaWiki.r91914.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91914#c0
Commit summary:
Followup to r91608: reduce impact of bug 29784 (high jsmin+ memory usage during
parsing) by skipping JS validation on
User ^demon changed the status of MediaWiki.r92493.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92493#c0
Commit summary:
Add RELEASE-NOTES-1.18.old into RELEASE-NOTES-1.18
Needs svn copy in REL1_18
User ^demon changed the status of MediaWiki.r92487.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92487#c0
Commit summary:
Move current RELEASE-NOTES-1.18 to RELEASE-NOTES-1.18.old
Moved RELEASE-NOTES-1.19 to RELEASE-NOTES-1.18
Wipe
User Nikerabbit changed the status of MediaWiki.r93181.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r93181.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93181#c20159
Commit summary:
renaming EditSchema to PS_EditSchema.php
Comment:
User Nikerabbit changed the status of MediaWiki.r93182.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r93182.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93182#c20160
Commit summary:
renaming GeneratePages.php to PS_GeneratePages.php
User ^demon changed the status of MediaWiki.r92387.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92387#c0
Commit summary:
* Expanded documentation, added GPL header and changed the @author tag to use
my real name
* Made RequestContext implement
User Nikerabbit posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20161
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
Is that going to be fixed soon?
User ^demon posted a comment on MediaWiki.r91949.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c20162
Commit summary:
Revert r91942, r91943 reimplement. wgActions doesn't contain all possible
actions!
Comment:
Suggest reversion of this and related revs until we have a
User ^demon changed the status of MediaWiki.r91931.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91931#c0
Commit summary:
Added $wgAutopromoteOnceLogInRC variable (bug 29655)
___
MediaWiki-CodeReview
User ^demon posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20163
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
Heck if I know :)
User ^demon changed the status of MediaWiki.r92389.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92389#c0
Commit summary:
Fix for r92388: that was the wrong method
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r93229.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93229#c0
Commit summary:
Fixed broken explode() call
___
MediaWiki-CodeReview mailing list
User Afeldman posted a comment on MediaWiki.r93214.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93214#c20164
Commit summary:
Remove buffer overflow due to unchecked substring_length
Changed sprintf to memcpy since the latter should be slightly more efficient.
Comment:
This
User Happy-melon changed the status of MediaWiki.r85025.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85025.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85025#c20165
Commit summary:
(bug 23408) give admins a warning before letting
Yesterday I came across this feature request, which I promptly
mis-understood:
https://bugzilla.wikimedia.org/30018
Option to make access to specific user rights or user groups
dependent on having a verified email address
The requester clarified the request today:
There's
- Original Message -
From: Mark A. Hershberger mhershber...@wikimedia.org
So for example if the user removes the email address, or replaces it
with another but doesn't verify it, the user rights associated with
their user group are automatically suspended, until a verified email
User Happy-melon changed the status of MediaWiki.r85951.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85951.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85951#c20166
Commit summary:
Implement user-is-blocked and wiki-is-read-only as
User Happy-melon changed the status of MediaWiki.r85994.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85994.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85994#c20167
Commit summary:
Unbundle OutputPage::showErrorPage() in
User ^demon changed the status of MediaWiki.r93235.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93235#c0
Commit summary:
Removed error_reporting() call. This was mostly left in for debugging and some
callers won't be able to tolerate error
User ^demon changed the status of MediaWiki.r93230.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93230#c0
Commit summary:
Updates from live version:
* $wgDBname was moved down to be set where it always used to be. It can't be
above the
User Awjrichards changed the status of MediaWiki.r93080.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93080#c0
Commit summary:
more concurrency fixes. These functions are only called when using the
CentralNotice admin interface, so they shouldnt
User ^demon changed the status of MediaWiki.r93240.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93240#c0
Commit summary:
Made setSiteInfoForMaintenance() support arguments of the form script.php
dbname (lots of stuff still using this format in
User ^demon changed the status of MediaWiki.r93236.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93236#c0
Commit summary:
Made setSiteInfoForMaintenance() support --wiki dbname format
___
User ^demon changed the status of MediaWiki.r93218.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93218#c0
Commit summary:
Merged updates
___
MediaWiki-CodeReview mailing list
User ^demon changed the status of MediaWiki.r92692.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92692#c0
Commit summary:
Fixed r92660: output cache dir needs to be versioned
___
MediaWiki-CodeReview
User ^demon changed the status of MediaWiki.r91741.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91741#c0
Commit summary:
r91740: Updating module name in extensions
___
MediaWiki-CodeReview mailing
User ^demon changed the status of MediaWiki.r91740.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91740#c0
Commit summary:
Moving skins/common/diff.css to mediawiki.action.history.diff.css and updating
some old comments in the process. Also moved
User ^demon changed the status of MediaWiki.r91867.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91867#c0
Commit summary:
Followup r91750 oncemore: action.edit.js depends on byteLimit, which is not
loaded when going manually through
User ^demon changed the status of MediaWiki.r91750.
Old Status: new
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91750#c0
Commit summary:
r86603 : Updatin last call to mediawiki.legacy.edit and removing the module
User ^demon changed the status of MediaWiki.r86603.
Old Status: old
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86603#c0
Commit summary:
Move edit.js stuff to mediawiki.action.edit.js, and remove wikibits dependency.
Wrap publicly accessible functions
User Aaron Schulz posted a comment on MediaWiki.r93242.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93242#c20168
Commit summary:
merged more updates. Ugly class_exists() won't be there forever, but
require_once() didn't work right.
Comment:
Probably can get rid of this file
All,
While spending the past few days/weeks in CodeReview, it has become
abundantly clear to me that we absolutely must get away from this idea
of doing huge refactorings in our working copies and landing them in trunk
without any warning. The examples I'm going to use here are the
Also, with some coordination, branches could be merged at a time when:
* Reviewers will looking at it and testing it *right* after the merge (in
addition to any branch review)
* The author is around to make fixes as it gets final review
People should try to be available after any large changes
On 11-07-26 01:27 PM, Chad wrote:
All,
While spending the past few days/weeks in CodeReview, it has become
abundantly clear to me that we absolutely must get away from this idea
of doing huge refactorings in our working copies and landing them in trunk
without any warning. The examples I'm
User ^demon changed the status of MediaWiki.r92977.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92977#c0
Commit summary:
* Version ExtensionMessages.php
* Fixed error msg wording (it's the .dat file we read)
http://design.greplin.com/
Maybe we should add a judge to the panel. Jorm?
Ryan Kaldari
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
User Siebrand posted a comment on MediaWiki.r93246.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93246#c20169
Commit summary:
(bug 15641) prevent blocked administrators from accessing deleted revisions.
Comment:
This fix looks pretty crazy. Adding tens of similar checks to
User Aaron Schulz posted a comment on MediaWiki.r93246.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93246#c20170
Commit summary:
(bug 15641) prevent blocked administrators from accessing deleted revisions.
Comment:
Recommend revert.
User Siebrand posted a comment on MediaWiki.r93246.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93246#c20171
Commit summary:
(bug 15641) prevent blocked administrators from accessing deleted revisions.
Comment:
Reason?
___
The requester clarified the request today:
So for example if the user removes the email address, or replaces it
with another but doesn't verify it, the user rights associated with
their user group are automatically suspended, until a verified email
address is provided,
User ^demon changed the status of MediaWiki.r93248.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93248#c0
Commit summary:
Release notes for r93247.
___
MediaWiki-CodeReview mailing list
+1 I completely agree.
Dantman is right in that such has to be accompanied by promptly reviews.
First problem is, people has to read the RFC. Searching the archive for
'RFC' I don't find it announced to the mailing list.
A RFC could be just text, have some sample code, or a full
implementation
On Tue, Jul 26, 2011 at 4:42 PM, Platonides platoni...@gmail.com wrote:
If the author considers it ready to merge and there has been no
opposition in a week, then merge it.
That would solve the rotting problem. I don't think it would be hard to
keep a branch up to date for a week (at least
User Hashar changed the status of MediaWiki.r93253.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93253#c0
Commit summary:
Mark 2 tests as requiring a DB...since they do :)
___
MediaWiki-CodeReview
On Tue, Jul 26, 2011 at 2:08 PM, Daniel Friesen
li...@nadir-seen-fire.com wrote:
RequestContext WAS an RFC.
No one commented on it...
An e-mail to the list announcing the RfC would've been nice ;-) Also
waiting for more than 1 other person to edit it would've been nice too.
If you're not
2011/7/26 Platonides platoni...@gmail.com
The requester clarified the request today:
So for example if the user removes the email address, or replaces it
with another but doesn't verify it, the user rights associated with
their user group are automatically suspended, until
On Wed, Jul 27, 2011 at 11:48 AM, Jelle Zijlstra
jelle.zijls...@gmail.com wrote:
That would not necessarily be a good idea. Enwiki has some adminbots that
only perform deletions/protections/whatever and don't make any edits. They'd
never get autoconfirmed, unless the bot owner would do some
User Jlemley posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20173
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
This extension does not currently
User Peachey88 posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20174
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
Nikerabbit, why did you fixme this?
User Nikerabbit posted a comment on MediaWiki.r93174.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20175
Commit summary:
Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki
Comment:
Because we should wait until this
79 matches
Mail list logo
