[MediaWiki-CodeReview] [MediaWiki r93495]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r93495. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93495#c0 Commit summary: fixing right to left issues for arabic wikipedia ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r93512]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r93512. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93512#c20295 Commit summary: * Changed wikiversions.dat/wikiversions.cdb file to allow for making wikis use there own caches (like i18n). This can be done by adding the dbname

Re: [Wikitech-l] page moved from one pageid to another

2011-07-29 Thread Platonides
> A funky merge like this (or a general delete/undelete) can create a new page > id; essentially the revisions from the old page ended up getting migrated > from one page to another, and that other page now has the title of the old > page. > > -- brion Another case is when the old page gets delete

Re: [Wikitech-l] [Semediawiki-user] [SMW] Creation date/time stamp as property

2011-07-29 Thread Jeroen De Dauw
Hey, (You better write such mails to the MW list, which I cc'd now: wikitech-l@lists.wikimedia.org) There indeed is a better way. MW provides a hook that gets fired on page creation. In this hook you can write the current timestamp to the page props table. Then just obtain that value when you nee

[MediaWiki-CodeReview] [MediaWiki r93498]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r93498. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93498#c0 Commit summary: added editor_lifecycle scripts ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r93496]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r93496. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93496#c0 Commit summary: added userinfo file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r93497]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r93497. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93497#c0 Commit summary: set eol-style on my USERINFO file ___ MediaWiki-CodeReview mailing list mediaw

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Mark A. Hershberger
Peter Kaminski writes: > Great reminder, Brion. > > Do any devs have suggestions of what to do instead of checking in broken > code? Or even code you're not sure about? Tips, reminders, places/ways > to ask for help? Last year, I was a new committer and was getting some of the same complaints

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Ashar Voultoiz
On 29/07/11 20:59, Dan Collins wrote: > On Fri, Jul 29, 2011 at 2:52 PM, Ashar Voultoiz wrote: >> They can still commit their broken code but NOT IN TRUNK :) > > Many developers (me) don't understand what there is other than trunk. > I'm aware of tags and branches, and vaguely recall someone being

[Wikitech-l] Software version control 101 (Re: Please don't commit broken code)

2011-07-29 Thread Rob Lanphier
On Fri, Jul 29, 2011 at 12:30 PM, Jay Ashworth wrote: > More pointedly, is there a really *good* "Software Development Version > Management HOWTO" anywhere at all?  I've looked at the git book, and it > just knocked me on my ass from the first chapter.  I *almost* understand > BZR... but I haven't

[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c20294 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields ar

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Jay Ashworth
- Original Message - > From: "Dan Collins" > On Fri, Jul 29, 2011 at 2:52 PM, Ashar Voultoiz > wrote: > > They can still commit their broken code but NOT IN TRUNK :) > > Many developers (me) don't understand what there is other than trunk. > I'm aware of tags and branches, and vaguely r

Re: [Wikitech-l] https via GPU?

2011-07-29 Thread Brion Vibber
On Fri, Jul 29, 2011 at 11:53 AM, Jon Davis wrote: > On Fri, Jul 29, 2011 at 11:29, Platonides wrote: > > Our servers don't have a GPU, so that would need a hardware upgrade. > > > > Yes, but if large scale SSL deployment increased CPU usage to the point > of necessitating new hardware... the co

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Chad
You're correct that Mediawiki tags and release branches (REL1_xx) shouldn't usually be touched. However you are more than welcome to create your own development branches. -Chad On Jul 29, 2011 12:00 PM, "Dan Collins" wrote: > On Fri, Jul 29, 2011 at 2:52 PM, Ashar Voultoiz wrote: >> They can sti

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Dan Collins
On Fri, Jul 29, 2011 at 2:52 PM, Ashar Voultoiz wrote: > They can still commit their broken code but NOT IN TRUNK :) Many developers (me) don't understand what there is other than trunk. I'm aware of tags and branches, and vaguely recall someone being yelled at for changing one of those, and was

[MediaWiki-CodeReview] [MediaWiki r93477]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Inez" changed the status of MediaWiki.r93477. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93477#c0 Commit summary: Fix problem with overwriting selected text, when length of selection is greater then half of block length ___

Re: [Wikitech-l] https via GPU?

2011-07-29 Thread Jon Davis
On Fri, Jul 29, 2011 at 11:29, Platonides wrote: > > > Our servers don't have a GPU, so that would need a hardware upgrade. > > > Yes, but if large scale SSL deployment increased CPU usage to the point of necessitating new hardware... the cost could be reduced by purchased GPU's for servers rather

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Ashar Voultoiz
On 29/07/11 04:23, K. Peachey wrote: > What about for people that want to commit some broken code to get eyes > onto or someone else might want it finish if, how about they commit it > and clearly mark that its broken and its so that people can look/work > at it then immediately revert it? (Which I

[MediaWiki-CodeReview] [MediaWiki r93473]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r93473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93473#c20293 Commit summary: Fixed r93468, made setCachedLastEditTime() public Comment: *sigh* ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r93475]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r93475. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93475#c0 Commit summary: merged changes from r93474 ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [MediaWiki r93474]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r93474. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93474#c0 Commit summary: add call to mb_convert_encoding for UTF-8 issue ___ MediaWiki-CodeReview

Re: [Wikitech-l] https via GPU?

2011-07-29 Thread Platonides
Magnus Manske wrote: > Just saw this: > > http://shader.kaist.edu/sslshader/ > > As we move to offer "real" https access, maybe this could help keeping > the CPU cost down? Our servers don't have a GPU, so that would need a hardware upgrade. ___ Wikite

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Jay Ashworth
- Original Message - > From: "Brion Vibber" > > [MZM:] > > Someone uploads a patch to Bugzilla and doesn't use IRC (and so they > > can't nag for review there). What's your recommendation for that scenario? > > Improve bug & patch review responsiveness so they get our feedback on > bugzil

Re: [Wikitech-l] Strange representation if is in

2011-07-29 Thread Aryeh Gregor
On Fri, Jul 29, 2011 at 1:10 PM, Philip Tzou wrote: > But without Tidy support, the tag would break tag, cause the > unclosed, ruin everything. is a magic tag that's interpreted during parsing and converted to HTML. Tidy only sees the resulting HTML, and that only contains a with some inlin

Re: [Wikitech-l] Strange representation if is in

2011-07-29 Thread Philip Tzou
But without Tidy support, the tag would break tag, cause the unclosed, ruin everything. 2011/7/30 Aryeh Gregor > On Fri, Jul 29, 2011 at 9:36 AM, Philip Tzou wrote: > > Here is the test case: > > > > http://zh.wikipedia.org/wiki/User:PhiLiP/sourcetest > > > > So, is it a bug or a feature? If

[Wikitech-l] It's sysadmin appreciation day!

2011-07-29 Thread Erik Moeller
Hi folks, today is sysadmin appreciation day! ( http://www.sysadminday.com/ ) Many thanks to the Wikimedia operations team for being there at all times of day and night to keep our sites up and our users happy -- and for always working hard to make things faster, more stable, and more secure. For

Re: [Wikitech-l] Strange representation if is in

2011-07-29 Thread Aryeh Gregor
On Fri, Jul 29, 2011 at 9:36 AM, Philip Tzou wrote: > Here is the test case: > > http://zh.wikipedia.org/wiki/User:PhiLiP/sourcetest > > So, is it a bug or a feature? If it's a feature, how can I put > content into in every case? Use explicit , , and . All the list wikimarkup only works for a

[MediaWiki-CodeReview] [MediaWiki r93351]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r93351. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93351#c20292 Commit summary: AjaxCategories rewrite: Solving syntax problems, performance improvements and applying code conventions: * Replaced sprite image with separate images

[MediaWiki-CodeReview] [MediaWiki r93459]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r93459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93459#c20291 Commit summary: Allow fixed session ids for users authenticated via IP. This allows sessions to be used even if the client does not send a session cookie, as is of

[Wikitech-l] https via GPU?

2011-07-29 Thread Magnus Manske
Just saw this: http://shader.kaist.edu/sslshader/ As we move to offer "real" https access, maybe this could help keeping the CPU cost down? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech

[Wikitech-l] Strange representation if is in

2011-07-29 Thread Philip Tzou
Here is the test case: http://zh.wikipedia.org/wiki/User:PhiLiP/sourcetest So, is it a bug or a feature? If it's a feature, how can I put content into in every case? Thank you, Philip Tzou ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org h

[MediaWiki-CodeReview] [MediaWiki r93448]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93448#c0 Commit summary: No need to keep this around anymore (we have a private repo too) ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r93447]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r93447. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93447#c0 Commit summary: Set svn:executable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@l

[MediaWiki-CodeReview] [MediaWiki r93386]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Hashar" posted a comment on MediaWiki.r93386. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93386#c20290 Commit summary: Redo r93284 ( Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title ) in a more simple way and also inc

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Domas Mituzas
Hi! just wanted to point out that there's open-source software for code-review that is designed for this (code reviews before commit), it supports both SVN and Git: http://phabricator.org/ Domas ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.o

[MediaWiki-CodeReview] [MediaWiki r93428]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r93428. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93428#c0 Commit summary: Removed useless $out variable from Skin::getCopyright() ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r93436]: Revision status changed

2011-07-29 Thread MediaWiki Mail
User "Hashar" changed the status of MediaWiki.r93436. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93436#c0 Commit summary: Provisional revert of r93319 -- change to TOC styles without coordinated cache updates. Definitely shows different paddin

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Ashar Voultoiz
On 29/07/11 04:57, Brion Vibber wrote: >> Someone uploads a patch to Bugzilla and doesn't use IRC (and so they can't >> > nag for review there). What's your recommendation for that scenario? > Improve bug& patch review responsiveness so they get our feedback on > bugzilla (and thus in their email

[MediaWiki-CodeReview] [MediaWiki r93386]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Raymond" posted a comment on MediaWiki.r93386. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93386#c20289 Commit summary: Redo r93284 ( Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title ) in a more simple way and also in

Re: [Wikitech-l] Please don't commit broken code

2011-07-29 Thread Ashar Voultoiz
On 29/07/11 02:05, MZMcBride wrote: > Sometimes the only way people can get their code reviewed is to commit it. In a BRANCH! :-) Although, you will have to find out someone to review your changes, but at least it saves you the hassle of being reverted on sight. If you don't have commit access

[MediaWiki-CodeReview] [MediaWiki r93386]: New comment added

2011-07-29 Thread MediaWiki Mail
User "DieBuche" posted a comment on MediaWiki.r93386. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93386#c20288 Commit summary: Redo r93284 ( Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title ) in a more simple way and also i

[MediaWiki-CodeReview] [MediaWiki r93319]: New comment added

2011-07-29 Thread MediaWiki Mail
User "DieBuche" posted a comment on MediaWiki.r93319. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93319#c20287 Commit summary: Recommit r93264 ( Remove semantically incorrect wrapper table from toc and replace it with an inline-blocked diff. Update some skin css, since we don'

[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added

2011-07-29 Thread MediaWiki Mail
User "Schnark" posted a comment on MediaWiki.r93090. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20286 Commit summary: * Ignore any or comment sections * More natural messages * Respect wgCaseSensitiveNamespaces * Regex: Add possible whitespace between "[[Category:" and

Re: [Wikitech-l] Experimental Wikia RTE branch for MediaWiki trunk

2011-07-29 Thread Maciej Jaros
Dmitriy Sintsov (2011-07-29 07:54): > Speaking of server-side (php interface), yes, MediaWiki is largely > backwards compatible (except for static call Linker::link() and few > ancient things, like wfLoadExtensionMessages‎() and so on). Speaking of > client-side (Javascript), it is not so simple. S