[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21736 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: Key 'editinguserpage' should be adder to phase3/languages/messages.inc - the Other key

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21737 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: codeLinker::makeKnownLinkObj()/code is deprecated, please use codeLinker::link()/code

[MediaWiki-CodeReview] [MediaWiki r95931]: New comment added

2011-09-01 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r95931. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95931#c21738 Commit summary: Follow-up r95930, consolidate into one message per CR Comment: If we're going so far that we're using [url text] syntax inside of a system message I

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21739 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: This warning won't show up for User:Foo when editing User:FooBar. I find the comparison

[MediaWiki-CodeReview] [MediaWiki r95931]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95931. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95931#c21740 Commit summary: Follow-up r95930, consolidate into one message per CR Comment: Just use $wgOut-wrapWikiMsg() ___

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21741 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: The edit page is already full of warnings the user doesn't bother to eat. Is this

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21742 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: If you are applying someone else's patch, you should include Patch by X in the commit

[MediaWiki-CodeReview] [MediaWiki r95921]: New comment added, and revision status changed

2011-09-01 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r95921. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r95921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95921#c21743 Commit summary: (bug 4381) Magic quotes cleaning is not

[MediaWiki-CodeReview] [MediaWiki r84610]: New comment added

2011-09-01 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r84610. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84610#c21744 Commit summary: * Put parser output file version tracking to core * Added some ParserOutput accessors * A few cleanups to fetchFile() Comment: What is the reason

[MediaWiki-CodeReview] [MediaWiki r95936]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95936#c21745 Commit summary: Of course, doesn't work in static functions :). Follow up to r95934 Comment: And variables don't work with -m :)

[MediaWiki-CodeReview] [MediaWiki r84591]: New comment added

2011-09-01 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r84591. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84591#c21746 Commit summary: * Made BeforeParserMakeImageLinkObj/BeforeGalleryFindFile let hooks set sha1 parameter * Made FlaggedRevs specify files by sha1,timestamp to handle

[MediaWiki-CodeReview] [MediaWiki r84415]: New comment added

2011-09-01 Thread MediaWiki Mail
User Tim Starling posted a comment on MediaWiki.r84415. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84415#c21747 Commit summary: * Added findFileFromKey() function * Added doc comments to findBySha1() Comment: That was done in r84416.

[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21748 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: How did this ever work before then? Looking at r88111, and as such, this revision, the

[MediaWiki-CodeReview] [MediaWiki r95947]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95947. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95947#c21749 Commit summary: Fix indentation in r95396 Comment: And also removed a method? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added

2011-09-01 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r93758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93758#c21750 Commit summary: * (bug 15558) Allow includable special pages to be parameterized using wiki syntax * Changed SpecialPageFactory::capturePath() to take the same

[MediaWiki-CodeReview] [MediaWiki r95830]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Dantman changed the status of MediaWiki.r95830. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95830 Commit summary: Give Vector a lighter external/interwiki color since monobook-vector changed the basic internal link color lighter

[MediaWiki-CodeReview] [MediaWiki r95954]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95954. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95954 Commit summary: RL2: Hopefully fix bug Timo reported in list=gadgets: names parameter broken

[MediaWiki-CodeReview] [MediaWiki r95956]: New comment added

2011-09-01 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r95956. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95956#c21751 Commit summary: Adding my USERINFO file Comment: Can someone link to User:COGDEN please? ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95958]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95958. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95958 Commit summary: RL2: Fix fatal: add Gadget::getDependencies() ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r95818]: New comment added, and revision status changed

2011-09-01 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95818. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r95818. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95818#c21752 Commit summary: [ResourceLoader2]: Initial go at the GadgetManager. *

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21753 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: +1 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95930]: New comment added

2011-09-01 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r95930. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930#c21754 Commit summary: (bug 5865) Warning on editing other user's userpage Comment: If this commit remains in, the message must be changed. Because this message is written

[MediaWiki-CodeReview] [MediaWiki r95970]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95970. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95970 Commit summary: RL2: Rename getTitleMsg() to getTitleMessageKey(), and introduce getTitleMessage() which returns the contents of the

[MediaWiki-CodeReview] [MediaWiki r95973]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r95973. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95973 Commit summary: Followup r95970, r95972: fix translations for real this time. Calling Message::inLanguage() after exists() doesn't work,

[MediaWiki-CodeReview] [MediaWiki r95932]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r95932. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95932 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95956]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95956. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95956#c21755 Commit summary: Adding my USERINFO file Comment: Already been done. Please set your [[Subversion/auto-props]] if you haven't already

[MediaWiki-CodeReview] [MediaWiki r95959]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95959. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95959#c21756 Commit summary: Followup r95957, add =null to Skin::outputPage too Comment: wants more spaces around =. :) ___

[MediaWiki-CodeReview] [MediaWiki r95959]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95959. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95959 Commit summary: Followup r95957, add =null to Skin::outputPage too ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95960]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95960#c21757 Commit summary: Split up TablePager css class, introduce .mw-datatable * All tables generated with the TablePager PHP class use this css class for their styling.

[MediaWiki-CodeReview] [MediaWiki r95990]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Jack Phoenix changed the status of MediaWiki.r95990. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95990 Commit summary: A d d s p a c e s ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21758 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Class name clashes isn't really a

[Wikitech-l] Wikimedia engineering report for August 2011

2011-09-01 Thread Guillaume Paumier
Hi, The report covering Wikimedia engineering activities in August 2011 is now available. Wiki version: http://www.mediawiki.org/wiki/Wikimedia_engineering_report/2011/August Blog version: http://blog.wikimedia.org/2011/09/01/wikimedia-engineering-august-2011-report/ -- Guillaume Paumier

[MediaWiki-CodeReview] [MediaWiki r95976]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95976#c21759 Commit summary: use id and name in token salt; bug 30644 Comment: No $this-getTitle()? ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r95989]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r95989. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95989 Commit summary: Fix svn:eol-style native for r95956 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95991]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r95991. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95991 Commit summary: Add some full message keys as they originate from these locations. ___

[MediaWiki-CodeReview] [MediaWiki r95994]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r95994. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95994 Commit summary: Add some full message keys as they are used here. ___ MediaWiki-CodeReview

[Wikitech-l] i18n (internationalization) Triage notes

2011-09-01 Thread Mark A. Hershberger
For anyone who has doubts about the efficacy of bug triages, I offer this observation that Siebrand made about the triage in IRC: I loved this triage! Brilliant. And I really liked we didn't get stuck in 164, it allowed us to cover everything we had prepared and more. Anyway, this

Re: [Wikitech-l] i18n (internationalization) Triage notes

2011-09-01 Thread Chad
On Thu, Sep 1, 2011 at 11:29 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Thanks to all who participated in this week's triage.  Next Wednesday: Download Wizard. What's the download wizard? -Chad ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r95959]: New comment added

2011-09-01 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r95959. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95959#c21760 Commit summary: Followup r95957, add =null to Skin::outputPage too Comment: This breaks existing skins Fatal error: Declaration of SkinNAME::outputPage() must be

[MediaWiki-CodeReview] [MediaWiki r95396]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r95396. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time

Re: [Wikitech-l] Wikimedia engineering report for August 2011

2011-09-01 Thread Sumana Harihareswara
On 09/01/2011 10:40 AM, Guillaume Paumier wrote: Hi, The report covering Wikimedia engineering activities in August 2011 is now available. Wiki version: http://www.mediawiki.org/wiki/Wikimedia_engineering_report/2011/August Blog version:

Re: [Wikitech-l] i18n (internationalization) Triage notes

2011-09-01 Thread Mark A. Hershberger
Chad innocentkil...@gmail.com writes: On Thu, Sep 1, 2011 at 11:29 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Thanks to all who participated in this week's triage.  Next Wednesday: Download Wizard. What's the download wizard? It is NeilK's secret skunk works project that he

[MediaWiki-CodeReview] [MediaWiki r96011]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96011. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96011 Commit summary: Tabs to aligned spaces ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95621]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95621 Commit summary: Cleanup after r95620. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95959]: New comment added

2011-09-01 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r95959. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95959#c21761 Commit summary: Followup r95957, add =null to Skin::outputPage too Comment: What kind of skin is declaring a SkinName::outputPage? That's an entrypoint controlling

[MediaWiki-CodeReview] [MediaWiki r95936]: New comment added

2011-09-01 Thread MediaWiki Mail
User Ryan lane posted a comment on MediaWiki.r95936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95936#c21762 Commit summary: Of course, doesn't work in static functions :). Follow up to r95934 Comment: :D ___

[MediaWiki-CodeReview] [MediaWiki r95936]: New comment added

2011-09-01 Thread MediaWiki Mail
User Ryan lane posted a comment on MediaWiki.r95936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95936#c21763 Commit summary: Of course, doesn't work in static functions :). Follow up to r95934 Comment: or: :D ___

[Wikitech-l] Upcoming Triages

2011-09-01 Thread Mark A. Hershberger
In an effort to be make the triage process work better (there is *always* room for improvement), I've set up the next couple of triages already and put them up on http://www.mediawiki.org/wiki/Bug_management/Triage You'll notice that there is nothing scheduled after September 14th -- yet.

Re: [Wikitech-l] i18n (internationalization) Triage notes

2011-09-01 Thread Bryan Tong Minh
On Thu, Sep 1, 2011 at 6:46 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Chad innocentkil...@gmail.com writes: On Thu, Sep 1, 2011 at 11:29 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Thanks to all who participated in this week's triage.  Next Wednesday: Download

[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21764 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Logged as bug 30686, and awaiting

[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21765 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Actually, this to some extent

[MediaWiki-CodeReview] [MediaWiki r96003]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96003. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96003 Commit summary: RL2: Make getExamples() in API modules public, was done in trunk earlier ___

[MediaWiki-CodeReview] [MediaWiki r96005]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96005. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96005 Commit summary: Followup r95496, remove duplicate $fields definition ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96012]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96012#c21767 Commit summary: RL2: Add maintenace script for populating the gadgetpagelist table Comment: No RUN_MAINTENANCE_IF_MAIN?

[MediaWiki-CodeReview] [MediaWiki r96015]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96015. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96015#c21768 Commit summary: Pass OutputPage instance to MakeGlobalVariablesScript. Allows extensions to getTitle()-equals( .. ) and add config vars depending on title Comment:

[MediaWiki-CodeReview] [MediaWiki r96025]: New comment added

2011-09-01 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96025#c21769 Commit summary: Add the position of the text to the messages so that the position can be changed depending on the plural, as requested by Amir in

[MediaWiki-CodeReview] [MediaWiki r96025]: New comment added

2011-09-01 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r96025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96025#c21770 Commit summary: Add the position of the text to the messages so that the position can be changed depending on the plural, as requested by Amir in

[MediaWiki-CodeReview] [MediaWiki r96030]: New comment added

2011-09-01 Thread MediaWiki Mail
User Awjrichards posted a comment on MediaWiki.r96030. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96030#c21771 Commit summary: Changes for tomorrow's US test Comment: Donation privacy policy URLs are wrong - I fixed this in r96035

[MediaWiki-CodeReview] [MediaWiki r96030]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r96030. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96030 Commit summary: Changes for tomorrow's US test ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95933]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r95933. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95933 Commit summary: Adding back the CSS missing from the initial test. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96027]: New comment added, and revision status changed

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96027. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r96027. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96027#c21772 Commit summary: fix the workaround trunk and deployment differences

[MediaWiki-CodeReview] [MediaWiki r96027]: New comment added

2011-09-01 Thread MediaWiki Mail
User Preilly posted a comment on MediaWiki.r96027. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96027#c21773 Commit summary: fix the workaround trunk and deployment differences Comment: Yeah, that's true. ___ MediaWiki-CodeReview

Re: [Wikitech-l] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90092 -- pls. can someone CR and set a status other than new

2011-09-01 Thread John Du Hart
Why is this so urgent that you cannot wait for someone to get around to doing code review? If you think it should be back ported add a 1.18 tag to the revision. On Thu, Sep 1, 2011 at 2:40 PM, Thomas Gries m...@tgries.de wrote: Re:http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90092 Hi,

[MediaWiki-CodeReview] [MediaWiki r93633]: New comment added

2011-09-01 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r93633. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93633#c21774 Commit summary: Fixes Bug #30149 - Handling of parentheses for Korean, Chinese and Japanese Adapts the pipe trick with parens for fullwidth parentheses. Adds

[MediaWiki-CodeReview] [MediaWiki r93633]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r93633. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93633 Commit summary: Fixes Bug #30149 - Handling of parentheses for Korean, Chinese and Japanese Adapts the pipe trick with parens for

[MediaWiki-CodeReview] [MediaWiki r95930]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r95930. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95930 Commit summary: (bug 5865) Warning on editing other user's userpage ___

[MediaWiki-CodeReview] [MediaWiki r95939]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r95939. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95939 Commit summary: f'up r95930: register new message key to maintenance script ___

[MediaWiki-CodeReview] [MediaWiki r95931]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r95931. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95931 Commit summary: Follow-up r95930, consolidate into one message per CR ___

[MediaWiki-CodeReview] [MediaWiki r90588]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90588. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90588 Commit summary: Follow-up r90482: escape some more wikitext ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90588]: New comment added

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r90588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90588#c21775 Commit summary: Follow-up r90482: escape some more wikitext Comment: Blah, I see...I was confusing html wikitext escaping.

[MediaWiki-CodeReview] [MediaWiki r96046]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96046. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96046 Commit summary: Revert r95930, r95931 and r95939. Poorly commited patch ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96045]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96045. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96045 Commit summary: Bring back in old YAML class, the JSON class does not work with UserData in EC2-like systems.

[MediaWiki-CodeReview] [MediaWiki r90482]: New comment added, and revision status changed

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90482. Old Status: fixme New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r90482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90482#c21776 Commit summary: Follow-up r90371, per comment by ^demon Escape

[MediaWiki-CodeReview] [MediaWiki r96045]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96045. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96045 Commit summary: Bring back in old YAML class, the JSON class does not work with UserData in EC2-like systems.

[MediaWiki-CodeReview] [MediaWiki r96044]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96044. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96044 Commit summary: * Remove hack in OpenStackNovaUser.php that searches for user dn's improperly in some cases * Add userInfo search to project

[MediaWiki-CodeReview] [MediaWiki r96047]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96047. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96047 Commit summary: Kill Spyc.php from r96045 Will properly add it momentarily ___

[MediaWiki-CodeReview] [MediaWiki r96049]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96049. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96049 Commit summary: Followup r96045, r96047 At from version at 86301 (before r86302) ___

[MediaWiki-CodeReview] [MediaWiki r96026]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96026. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96026 Commit summary: follow-up to r95940 which was not correctly working because links were not set

[MediaWiki-CodeReview] [MediaWiki r85884]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85884. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85884 Commit summary: Abstract tableName() by adding new function isQuotedIdentifier() to databases. This fixes bug in DatabaseOracle.php

[MediaWiki-CodeReview] [MediaWiki r85884]: New comment added

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r85884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85884#c21777 Commit summary: Abstract tableName() by adding new function isQuotedIdentifier() to databases. This fixes bug in DatabaseOracle.php tableName() on line 671 and

[MediaWiki-CodeReview] [MediaWiki r95773]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95773. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95773 Commit summary: Commit live hack and update version. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95774]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95774. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95774 Commit summary: Follow-up r95769: change more $object to $editpage. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r95948]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95948. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95948 Commit summary: Update whitespace and braces. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95772]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95772. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95772 Commit summary: Fix comments added in r95771. Thanks ialex. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95966]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95966. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95966 Commit summary: Remove MEDIAWIKI constant check. No need, as this file only contains a class. Whitespace updates.

[MediaWiki-CodeReview] [MediaWiki r95995]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95995. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95995 Commit summary: i18n fixes. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95902]: New comment added, and revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95902. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r95902. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95902#c21778 Commit summary: Fix syntax error in r95901. Pre-commit hook? Comment: Grrr,

[MediaWiki-CodeReview] [MediaWiki r95956]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r95956. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95956 Commit summary: Adding my USERINFO file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96039]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96039. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96039 Commit summary: Localisation updates for core and extension messages from translatewiki.net ParserFunctions skipped today.

[MediaWiki-CodeReview] [MediaWiki r96043]: New comment added

2011-09-01 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96043#c21779 Commit summary: Add helper functions Comment: @ is evil, can you use wfSuppressWarnings/wfRestoreWarnings? ___

[MediaWiki-CodeReview] [MediaWiki r88129]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r88129. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88129 Commit summary: (bug 28940) When making a thumb of an SVG, and only specifying the height make the width be the max SVG size, not the

[MediaWiki-CodeReview] [MediaWiki r96007]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96007. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96007 Commit summary: Migrate messages to resource loader ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96052]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User VasilievVV changed the status of MediaWiki.r96052. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96052 Commit summary: WikiScripts native parser: * A lot of optimization * Makefile * Some bugfixes * License

[MediaWiki-CodeReview] [MediaWiki r96054]: Revision status changed

2011-09-01 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96054. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96054 Commit summary: Git-svn work please? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96054]: New comment added

2011-09-01 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96054#c21780 Commit summary: Git-svn work please? Comment: Very complex change here ___ MediaWiki-CodeReview mailing list

[Wikitech-l] Brown bag - Selenium Testing

2011-09-01 Thread Jeremy Postlethwaite
Hi everyone! I would like to hold a brown bag lunch on Selenium Unit Testing for Mediawiki extensions. I have been using phpunit and Selenium for a few years. Selenium Unit Testing in the core has been put on hold until we get our new QA Lead. I have attached an event to this email for

[Wikitech-l] Invitation: Brown bag - Selenium Unit Testing @ Wed Sep 7 12:30pm - 1pm (wikitech-l@lists.wikimedia.org)

2011-09-01 Thread Jeremy Postlethwaite
You have been invited to the following event. Title: Brown bag - Selenium Unit Testing Selenium Unit Testing on Mediawiki When: Wed Sep 7 12:30pm – 1pm Pacific Time - Vancouver Where: SF Office Sixth floor Calendar: wikitech-l@lists.wikimedia.org Who: * jpostlethwa...@wikimedia.org -

[MediaWiki-CodeReview] [MediaWiki r96054]: New comment added

2011-09-01 Thread MediaWiki Mail
User Awjrichards posted a comment on MediaWiki.r96054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96054#c21781 Commit summary: Git-svn work please? Comment: Perhaps we should get additional eyes on this just to be safe? ___

[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added

2011-09-01 Thread MediaWiki Mail
User Dantman posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c21782 Commit summary: Moved printfooter and debug HTML away from bodytext so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook;

[MediaWiki-CodeReview] [MediaWiki r96043]: New comment added

2011-09-01 Thread MediaWiki Mail
User Ryan lane posted a comment on MediaWiki.r96043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96043#c21783 Commit summary: Add helper functions Comment: Yes. This codebase is really old and there are like 1-023485p082354-0823-508243-05 of them in there. I'll take them

  1   2   >