[MediaWiki-CodeReview] [MediaWiki r101505]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r101505. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101505 Commit summary: bug 30771 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101481]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101481#c25318 Commit summary: Adding my USERINFO file. Comment: This commit name is not yet linked to an account. ___

[MediaWiki-CodeReview] [MediaWiki r101490]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101490#c25319 Commit summary: Style fixups Comment: I don't resonate with these changes. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101499]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101499#c25320 Commit summary: * Use WikiPage instead of Article since we only need to call doEdit() * Pass the User object to doEdit() in addition to the override of $wgUser

[Wikitech-l] Getting the first image of a page

2011-11-02 Thread Jeroen De Dauw
Hey, Is there a nice way to obtain the first image on a page? My current solution works, but is not very nice: * get the images on the page via api.php?action=queryprop=imagestitles=pagename * get the page contest via index.php?title=pagenameaction=raw * find the first occurrence of one of the

[MediaWiki-CodeReview] [MediaWiki r101505]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101505. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101505 Commit summary: bug 30771 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101585]: New comment added

2011-11-02 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r101585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101585#c25321 Commit summary: bug 31965 Comment: Two style issues in newly added message: use capital after colon and e-mail instead of email.

[MediaWiki-CodeReview] [MediaWiki r101507]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101507. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101507#c25322 Commit summary: Re-apply Vitaliy Filippov's patch from Bug #29283 with a modification to make it work when no ACCEL cache is available. Comment: I might be

[MediaWiki-CodeReview] [pywikipedia r9722]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Valhallasw changed the status of pywikipedia.r9722. Old Status: new New Status: fixme User Valhallasw also posted a comment on pywikipedia.r9722. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9722#c25323 Commit summary: use abs() function Comment: This is wrong! The

[MediaWiki-CodeReview] [MediaWiki r101518]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101518#c25324 Commit summary: Started 0.4.13 alpha. ParserHook::$frame now always is set in case SFH_OBJECT_ARGS and therewith object style parser function args are enabled.

[MediaWiki-CodeReview] [MediaWiki r101524]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101524. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101524 Commit summary: fixed potential vulnerability and bad code ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] Getting the first image of a page

2011-11-02 Thread Max Semenik
On Wed, Nov 2, 2011 at 11:49 AM, Jeroen De Dauw jeroended...@gmail.comwrote: Hey, Is there a nice way to obtain the first image on a page? My current solution works, but is not very nice: * get the images on the page via api.php?action=queryprop=imagestitles=pagename * get the page

[MediaWiki-CodeReview] [MediaWiki r101529]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101529. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101529#c25325 Commit summary: system for ParserHook class hook registration customization, introducing an options to define a parser function that can be called without leading

[MediaWiki-CodeReview] [MediaWiki r101530]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101530. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101530 Commit summary: kill not needed dies ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101533]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101533. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101533#c25326 Commit summary: followup r101525: next attempt at fixing timing issues when initializing wikieditor Comment: Hmm the indentation for whole module in

Re: [Wikitech-l] Getting the first image of a page

2011-11-02 Thread Jeroen De Dauw
Hey, The first significant image on the page, ie one that can be used to represent the page. I realize you can not do this fully accurate without having some additional s*mantics, but if it works most of the time, such as is the case with my approach, it's good enough. Cheers -- Jeroen De Dauw

Re: [Wikitech-l] Getting the first image of a page

2011-11-02 Thread K. Peachey
Have a look at how the popups gadget does it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r101538]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101538. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101538#c25327 Commit summary: fix fail Comment: This seems to be a followup to r93112. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101538]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101538. Old Status: deferred New Status: ok User Nikerabbit also posted a comment on MediaWiki.r101538. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101538#c25328 Commit summary: fix fail Comment: And from there we can see

[MediaWiki-CodeReview] [MediaWiki r101541]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101541. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101541 Commit summary: Fixed spacing, followup r101236 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101551]: New comment added

2011-11-02 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101551. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101551#c25329 Commit summary: arrray - array Whitespace Other documentation improvements Comment out some unused code (which has a fixme left with it already) Comment: yarr!

[MediaWiki-CodeReview] [MediaWiki r101329]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101329. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101329 Commit summary: Fixing and improvement code of CheckUser API module ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101580]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101580. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101580 Commit summary: Added handling for new 'title=' parameter for #formlink, based on a patch from Van de Bugger; also removed

[MediaWiki-CodeReview] [MediaWiki r101581]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101581. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r101581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101581#c25330 Commit summary: bug 32056 Comment: The mentioned bug is still

[MediaWiki-CodeReview] [MediaWiki r101587]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101587. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101587 Commit summary: Follow up to r101505; typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101602]: New comment added

2011-11-02 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r101602. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101602#c25331 Commit summary: validation of custom license wikitext, including basic parsing, checking that templates exist, and that they are descendants of a particular category

Re: [Wikitech-l] Getting the first image of a page

2011-11-02 Thread Petr Bena
This depends on what you consider a first picture of a page, wheter it's a picture not transluded from a template and also if it's a picture on top of the page (layout) or first picture in wikipage source, in the case that it's first picture in wikisource, what you need to call

[MediaWiki-CodeReview] [MediaWiki r101491]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101491. Old Status: ok New Status: fixme User Catrope also posted a comment on MediaWiki.r101491. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101491#c25332 Commit summary: * Create all items in $nav_urls at the beginning so that

[MediaWiki-CodeReview] [MediaWiki r101491]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User IAlex changed the status of MediaWiki.r101491. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r101491. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101491#c25333 Commit summary: * Create all items in $nav_urls at the beginning so that we

[MediaWiki-CodeReview] [MediaWiki r101581]: New comment added

2011-11-02 Thread MediaWiki Mail
User Cryptocoryne posted a comment on MediaWiki.r101581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101581#c25334 Commit summary: bug 32056 Comment: The mentioned bug contains not only this issue. About other issues/requests I've write to brion, as author of CentralAuth

[MediaWiki-CodeReview] [MediaWiki r101610]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101610. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101610 Commit summary: Followup r101608 - fix syntax error ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101604]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101604. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101604 Commit summary: make top license tag configurable ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101600]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101600. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101600 Commit summary: allow for templates with dashes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101601]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101601. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101601 Commit summary: add method to fetch categories of a title. remove some useless code making sure undefined stuff was undefined.

[MediaWiki-CodeReview] [MediaWiki r101602]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101602. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101602 Commit summary: validation of custom license wikitext, including basic parsing, checking that templates exist, and that they are

[MediaWiki-CodeReview] [MediaWiki r101603]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101603. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101603 Commit summary: validate wikitext only if idle for 2 seconds ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101599]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r101599. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101599 Commit summary: removed debug log messages ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101539]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101539. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101539 Commit summary: Follow-up r101532: email - e-mail address. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101532]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101532. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101532 Commit summary: Updated language as per requests from WMF legal department. ___

[MediaWiki-CodeReview] [MediaWiki r101277]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101277. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101277 Commit summary: Added speechbubble icon to the Moodbar trigger ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r97178]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User ArielGlenn changed the status of MediaWiki.r97178. Old Status: fixme New Status: new User ArielGlenn also posted a comment on MediaWiki.r97178. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97178#c25335 Commit summary: throw exception if rename of output file fails

[MediaWiki-CodeReview] [MediaWiki r96486]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User ArielGlenn changed the status of MediaWiki.r96486. Old Status: fixme New Status: new User ArielGlenn also posted a comment on MediaWiki.r96486. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96486#c25336 Commit summary: get rid of duplication, remove unused function

[MediaWiki-CodeReview] [MediaWiki r101288]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101288. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101288 Commit summary: Modified text box so that character counter actually works and is dynamic. Text box now prevents entering more than

[MediaWiki-CodeReview] [MediaWiki r101404]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101404. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101404 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r101278]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101278. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101278 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r101250]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101250. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101250 Commit summary: Reducing the width of fbd-filters-input, which appears too wide in en.wikipedia.

[MediaWiki-CodeReview] [MediaWiki r101045]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101045. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101045 Commit summary: Fix mime-types ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101610]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101610. Old Status: deferred New Status: new User Nikerabbit also posted a comment on MediaWiki.r101610. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101610#c25337 Commit summary: Followup r101608 - fix syntax error Comment:

[MediaWiki-CodeReview] [MediaWiki r101615]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101615. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101615 Commit summary: Followup r101288: don't try to be clever and use a minifier file, ResourceLoader takes care of minification for you.

[MediaWiki-CodeReview] [MediaWiki r101581]: New comment added

2011-11-02 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r101581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101581#c25338 Commit summary: bug 32056 Comment: pre- parent::__construct( 'GlobalGroupMembership' ); + SpecialPage::__construct( 'GlobalGroupMembership'

[MediaWiki-CodeReview] [MediaWiki r101570]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101570. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101570 Commit summary: Adding IRC to userinfo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101583]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101583. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101583 Commit summary: 0.7.8 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101586]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101586. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101586 Commit summary: Follow up to r101585; message doc ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101589]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101589. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101589 Commit summary: support smw 1.6 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101590]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101590. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101590 Commit summary: support smw 1.6 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101610]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Johnduhart changed the status of MediaWiki.r101610. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101610 Commit summary: Followup r101608 - fix syntax error ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101529]: New comment added

2011-11-02 Thread MediaWiki Mail
User Danwe posted a comment on MediaWiki.r101529. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101529#c25339 Commit summary: system for ParserHook class hook registration customization, introducing an options to define a parser function that can be called without leading hash.

[MediaWiki-CodeReview] [MediaWiki r101518]: New comment added

2011-11-02 Thread MediaWiki Mail
User Danwe posted a comment on MediaWiki.r101518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101518#c25340 Commit summary: Started 0.4.13 alpha. ParserHook::$frame now always is set in case SFH_OBJECT_ARGS and therewith object style parser function args are enabled.

[MediaWiki-CodeReview] [MediaWiki r101502]: New comment added

2011-11-02 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r101502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101502#c25341 Commit summary: Actually fixes the api calls that handle gateway forms with _cache_ set to true, and a utm_source_id set. r101441 Comment: Actually, the reason

[MediaWiki-CodeReview] [MediaWiki r101502]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Khorn (WMF) changed the status of MediaWiki.r101502. Old Status: fixme New Status: new User Khorn (WMF) also posted a comment on MediaWiki.r101502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101502#c25342 Commit summary: Actually fixes the api calls that handle gateway

[MediaWiki-CodeReview] [MediaWiki r101631]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101631. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101631 Commit summary: Defaults utm_source_id to null on a form pull, and checks for not null for caching purposes. r101502

[MediaWiki-CodeReview] [MediaWiki r101502]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101502. Old Status: new New Status: ok User Awjrichards also posted a comment on MediaWiki.r101502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101502#c25343 Commit summary: Actually fixes the api calls that handle gateway

[MediaWiki-CodeReview] [MediaWiki r101118]: New comment added

2011-11-02 Thread MediaWiki Mail
User Jorm (WMF) posted a comment on MediaWiki.r101118. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101118#c25344 Commit summary: Remove functionality: Loading form state from cookies, and clicking on username -- filter by that user Comment: I don't want to keep the username

[Wikitech-l] New permission for moodbar

2011-11-02 Thread Petr Bena
Hey, I spoke with some folks from enwp and they said that it would be cool if moodbar extension had one more permission allowing people to do hide / unhide, so that they could eventually let more people than sysops check the responses and eventually hide them. It's simple tweak, but what do you

Re: [Wikitech-l] New permission for moodbar

2011-11-02 Thread Chad
On Wed, Nov 2, 2011 at 12:28 PM, Petr Bena benap...@gmail.com wrote: Hey, I spoke with some folks from enwp and they said that it would be cool if moodbar extension had one more permission allowing people to do hide / unhide, so that they could eventually let more people than sysops check the

[Wikitech-l] dump titles form other namespaces than 0?

2011-11-02 Thread Ariel T. Glenn
A while back (over 2 years ago, urk!) we had a request for dumps of titles of things other than articles [1]. I haven't seen that request repeated, but I'm wondering how useful that would be to folks and which namespaces we should dump, if we were going to add a few. Article talk pages? Other?

Re: [Wikitech-l] New permission for moodbar

2011-11-02 Thread Petr Bena
Right, I checked only its mediawiki extension wikipage it doesn't tell about this permission, I will inform them about it, cool On Wed, Nov 2, 2011 at 5:35 PM, Chad innocentkil...@gmail.com wrote: On Wed, Nov 2, 2011 at 12:28 PM, Petr Bena benap...@gmail.com wrote: Hey, I spoke with some

Re: [Wikitech-l] dump titles form other namespaces than 0?

2011-11-02 Thread Petr Bena
Probably files could be useful, but most of them are now at commons, so not sure about it On Wed, Nov 2, 2011 at 5:37 PM, Ariel T. Glenn ar...@wikimedia.org wrote: A while back (over 2 years ago, urk!) we had a request for dumps of titles of things other than articles [1]. I haven't seen that

[MediaWiki-CodeReview] [MediaWiki r101118]: New comment added

2011-11-02 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r101118. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101118#c25345 Commit summary: Remove functionality: Loading form state from cookies, and clicking on username -- filter by that user Comment: I'll have to partially revert this

[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added

2011-11-02 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r93758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93758#c25346 Commit summary: * (bug 15558) Allow includable special pages to be parameterized using wiki syntax * Changed SpecialPageFactory::capturePath() to take the same

[MediaWiki-CodeReview] [MediaWiki r101260]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101260. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101260 Commit summary: * (bug 19186) Special:UserLogin's title on Special:SpecialPages now says create account when the user cannot create an

[MediaWiki-CodeReview] [MediaWiki r101629]: New comment added

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r101629. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101629#c25347 Commit summary: Followup r100305, don't try to do a batch query for an empty result (which would cause bug 32134) Comment: Pager should be refactored to only

[MediaWiki-CodeReview] [MediaWiki r101629]: New comment added, and revision status changed

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101629. Old Status: new New Status: resolved User Aaron Schulz also posted a comment on MediaWiki.r101629. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101629#c25348 Commit summary: Followup r100305, don't try to do a batch

[MediaWiki-CodeReview] [MediaWiki r101118]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r101118. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101118 Commit summary: Remove functionality: Loading form state from cookies, and clicking on username -- filter by that user

[MediaWiki-CodeReview] [MediaWiki r101644]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101644. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101644 Commit summary: (bug 31822) Error during upgrade due to output buffer reset in stdout. In various places in Maintenance, we're

[MediaWiki-CodeReview] [MediaWiki r101581]: New comment added

2011-11-02 Thread MediaWiki Mail
User Cryptocoryne posted a comment on MediaWiki.r101581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101581#c25349 Commit summary: bug 32056 Comment: This code used in current trunk and wmf versions of CentralAuth

[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added

2011-11-02 Thread MediaWiki Mail
User G.Hagedorn posted a comment on MediaWiki.r93758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93758#c25350 Commit summary: * (bug 15558) Allow includable special pages to be parameterized using wiki syntax * Changed SpecialPageFactory::capturePath() to take the same

[Wikitech-l] Labs questions (was: MediaWiki unit testing and non-MySQL databases)

2011-11-02 Thread Ryan Lane
On Tue, Oct 25, 2011 at 1:43 PM, Platonides platoni...@gmail.com wrote: Ryan Lane wrote: https://labsconsole.wikimedia.org/wiki/Main_Page Just a suggestion ;) - Ryan 1) This is the first time it is mentioned in this mailing list. It isn't the first time labs has been. I was suggesting

[MediaWiki-CodeReview] [MediaWiki r101636]: New comment added

2011-11-02 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r101636. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101636#c25351 Commit summary: MW fetcher and installer for TestSwarm Designed by Timo and Antoine and for use with MediaWiki software with TestSwarm as a frontend. Really

[MediaWiki-CodeReview] [MediaWiki r101636]: New comment added

2011-11-02 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101636. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101636#c25352 Commit summary: MW fetcher and installer for TestSwarm Designed by Timo and Antoine and for use with MediaWiki software with TestSwarm as a frontend. Really

[MediaWiki-CodeReview] [MediaWiki r101681]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101681. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101681 Commit summary: Create stub extension dir for VisualEditor ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101681]: New comment added

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r101681. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101681#c25353 Commit summary: Create stub extension dir for VisualEditor Comment: I approve this revision. ___

[MediaWiki-CodeReview] [MediaWiki r101681]: New comment added

2011-11-02 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101681. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101681#c25354 Commit summary: Create stub extension dir for VisualEditor Comment: Signing it off you should! ___ MediaWiki-CodeReview

[Wikitech-l] Upcoming VipsScaler deployment

2011-11-02 Thread Rob Lanphier
Hi everyone, Bryan Tong Minh has been doing some great work on VipsScaler extension, but there hasn't been a lot of recent chatter on the mailing list about it. Since we're somewhat close to deploying something on the cluster, it probably warrants at least an email. First, some background.

[MediaWiki-CodeReview] [MediaWiki r101689]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101689. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101689 Commit summary: Remove trailing whitespace in recently added currency messages. ___

[MediaWiki-CodeReview] [MediaWiki r101669]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101669. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101669 Commit summary: The data used for a paypal redirect needs to be our raw, unstaged data: Not the data staged for a specific gateway.

[MediaWiki-CodeReview] [MediaWiki r101679]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101679. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101679 Commit summary: fixing form validation for internet explorer placeholder compatibility ___

Re: [Wikitech-l] Upcoming VipsScaler deployment

2011-11-02 Thread Bryan Tong Minh
On Wed, Nov 2, 2011 at 10:08 PM, Rob Lanphier ro...@wikimedia.org wrote: Step 1: Deploy VipsScaler extension, but only use it for PNGs over 12.5MP and/or TIFFs (which currently generate errors).  Let this sit in production a while, fixing any bugs we find with this configuration. I should

[MediaWiki-CodeReview] [MediaWiki r101700]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101700. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101700 Commit summary: hacking RapidHtml to accept error message via query string if necessary ___

[MediaWiki-CodeReview] [MediaWiki r101477]: New comment added

2011-11-02 Thread MediaWiki Mail
User Amire80 posted a comment on MediaWiki.r101477. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101477#c25355 Commit summary: Table for message group states Internationalization/#173 Comment: If i understand the the coding standards correctly, it should be NOT NULL, in

[MediaWiki-CodeReview] [MediaWiki r101709]: New comment added

2011-11-02 Thread MediaWiki Mail
User Preilly posted a comment on MediaWiki.r101709. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101709#c25356 Commit summary: partial fix for bug 30985 mobile header expanding and menu do not work until page loads Comment: Spacing is now fixed in r101714.

[MediaWiki-CodeReview] [MediaWiki r100413]: New comment added

2011-11-02 Thread MediaWiki Mail
User GICodeWarrior posted a comment on MediaWiki.r100413. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c25357 Commit summary: Added a forgotten file Followup r100345 and Internationalization/#129 Comment: Could be tweaked a bit if you want. This: jQuery( document

[MediaWiki-CodeReview] [MediaWiki r100413]: New comment added

2011-11-02 Thread MediaWiki Mail
User GICodeWarrior posted a comment on MediaWiki.r100413. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c25358 Commit summary: Added a forgotten file Followup r100345 and Internationalization/#129 Comment: sorry, I fail at markup; lets try that again.. Could be

Re: [Wikitech-l] New permission for moodbar

2011-11-02 Thread Risker
I'm already concerned that too many comments are being hidden without any good reason, particularly those associated with sad moods, I don't know that we really need to expand things any further. Is there any information available on the number of pageviews? Pageviews by those who are not logged

Re: [Wikitech-l] New permission for moodbar

2011-11-02 Thread Petr Bena
That's something what I'd like to improve too there should be an option to fill in the reason why it got hidden, anyway, Risker, could you clarify what pageviews you meant? If you meant wikipage views or number of views of moodbar replies? On Wed, Nov 2, 2011 at 10:54 PM, Risker

Re: [Wikitech-l] Upcoming VipsScaler deployment

2011-11-02 Thread Tim Starling
On 03/11/11 08:36, Bryan Tong Minh wrote: On Wed, Nov 2, 2011 at 10:08 PM, Rob Lanphier ro...@wikimedia.org wrote: Step 1: Deploy VipsScaler extension, but only use it for PNGs over 12.5MP and/or TIFFs (which currently generate errors). Let this sit in production a while, fixing any bugs we

[MediaWiki-CodeReview] [MediaWiki r101719]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101719. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101719 Commit summary: follow-up to 101700, better security ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r95921]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r95921. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95921 Commit summary: (bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped

[MediaWiki-CodeReview] [MediaWiki r96370]: Revision status changed

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96370. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96370 Commit summary: Followup r96369: update child classes and a few callers ___

[MediaWiki-CodeReview] [MediaWiki r96517]: New comment added

2011-11-02 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96517. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96517#c25359 Commit summary: Merge r90266 to trunk Fixes fixme on r75341, r75343 Comment: So can this be cleaned up now? ___

  1   2   >