[MediaWiki-CodeReview] [MediaWiki r108087]: New comment added

2012-01-04 Thread MediaWiki Mail
"Nx" posted a comment on MediaWiki.r108087. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108087#c28965 Commit summary for MediaWiki.r108087: * (bug 33525) clearTagHooks doesn't clear function hooks. * (bug 33523) Function tag hooks don't appear on Special:Version. Patches by Nikola

Re: [Wikitech-l] Home stretch of 1.19 code review

2012-01-04 Thread Rob Lanphier
Thanks for sending out this reminder Mark! Comments inline: On Wed, Jan 4, 2012 at 5:23 PM, Mark A. Hershberger wrote: > CRStats (http://toolserver.org/~robla/crstats/) shows that on December > 24th we were had around 500 revisions left for review. > > This wasn't too bad except that we CRStats

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-04 Thread Max Semenik
On 05.01.2012, 4:47 K. wrote: > Commons folk doesn't magically delete anything unless there is a > reason, nor do they instantly delete in most cases. If peoples uploads > are continently getting tagged for deletion, They should look at why > they are getting tagged. I've seen them delete on sigh

[MediaWiki-CodeReview] [MediaWiki r108094]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r108094 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108094 Old status: new > New status: ok Commit summary for MediaWiki.r108094: Fix *.jar svn:mime-type ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r108092]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r108092 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108092 Old status: new > New status: ok Commit summary for MediaWiki.r108092: Only allow project creation if a member of cloudadmin ___

[MediaWiki-CodeReview] [MediaWiki r108090]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r108090 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108090 Old status: new > New status: ok Commit summary for MediaWiki.r108090: Changing word order based on request. ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r108087]: New comment added

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" posted a comment on MediaWiki.r108087. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108087#c28964 Commit summary for MediaWiki.r108087: * (bug 33525) clearTagHooks doesn't clear function hooks. * (bug 33523) Function tag hooks don't appear on Special:Version. Patches by

[MediaWiki-CodeReview] [MediaWiki r108076]: New comment added

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" posted a comment on MediaWiki.r108076. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108076#c28963 Commit summary for MediaWiki.r108076: VoteNY: actually make this work under 1.18+, not just in ResourceLoader's debug mode. Changelist: *removed backwards-compatibility cod

[MediaWiki-CodeReview] [MediaWiki r108071]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" changed the status of MediaWiki.r108071 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108071 Old status: new > New status: ok Commit summary for MediaWiki.r108071: [mediawiki.debug] add implied semi-colon * poke r107610 _

[MediaWiki-CodeReview] [MediaWiki r104399]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"RobLa-WMF" changed the status of MediaWiki.r104399 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104399 Old status: new > New status: deferred Commit summary for MediaWiki.r104399: Reduce the amount of distracting movement seen in the lower right corner of Special:Vi

[Wikitech-l] Documentation for $wgExternalServers outdated?

2012-01-04 Thread Tim Landscheidt
Hi, with regard to bug #24607, I wanted to enable external Stor- age on my local PostgreSQL-backed wiki. The documentation at http://www.mediawiki.org/wiki/Manual:$wgExternalServers> reads: | An array of external MySQL servers. | e.g. | $wgExternalServers = array( 'cluster1' => array( 'srv28',

[MediaWiki-CodeReview] [MediaWiki r108102]: New comment added

2012-01-04 Thread MediaWiki Mail
"Yaron Koren" posted a comment on MediaWiki.r108102. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108102#c28962 Commit summary for MediaWiki.r108102: Removed backwards-compatibility for MediaWiki versions less than 1.16, removed unused local "$skin" field Yaron Koren's comment: I

[MediaWiki-CodeReview] [MediaWiki r108100]: New comment added

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" posted a comment on MediaWiki.r108100. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108100#c28961 Commit summary for MediaWiki.r108100: Removed backwards compatibility for MediaWiki versions less than 1.16, most notably removing the loadMessages() method Jeroen De

[MediaWiki-CodeReview] [MediaWiki r108086]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108086 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108086 Old status: new > New status: ok Commit summary for MediaWiki.r108086: Change json_decode() to MediaWiki's own FormatJson::decode(); removed now-unnecessary 'extern

[MediaWiki-CodeReview] [MediaWiki r108100]: New comment added

2012-01-04 Thread MediaWiki Mail
"Dantman" posted a comment on MediaWiki.r108100. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108100#c28960 Commit summary for MediaWiki.r108100: Removed backwards compatibility for MediaWiki versions less than 1.16, most notably removing the loadMessages() method Dantman's comment

[MediaWiki-CodeReview] [MediaWiki r108085]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108085 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108085 Old status: new > New status: ok Commit summary for MediaWiki.r108085: MediaWiki 1.16 or higher now required - removed support for previous versions of MediaWiki, i

[MediaWiki-CodeReview] [MediaWiki r108098]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108098 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108098 Old status: new > New status: ok Commit summary for MediaWiki.r108098: Formatting improvements, and removed unnecessary 'invalid entry point' checks ___

[MediaWiki-CodeReview] [MediaWiki r108100]: New comment added, and revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108100 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108100#c28959 Old Status: new > New Status: ok Commit summary for MediaWiki.r108100: Removed backwards compatibility for MediaWiki versions less than 1.16

[MediaWiki-CodeReview] [MediaWiki r108103]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108103 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108103 Old status: new > New status: ok Commit summary for MediaWiki.r108103: MediaWiki 1.16+ is now required for all the code

[MediaWiki-CodeReview] [MediaWiki r108102]: New comment added, and revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108102 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108102#c28958 Old Status: new > New Status: ok Commit summary for MediaWiki.r108102: Removed backwards-compatibility for MediaWiki versions less than 1.16

[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added

2012-01-04 Thread MediaWiki Mail
"Bawolff" posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28957 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at http://stack

[MediaWiki-CodeReview] [MediaWiki r108095]: New comment added, and revision status changed

2012-01-04 Thread MediaWiki Mail
"Jeroen De Dauw" changed the status of MediaWiki.r108095 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108095#c28956 Old Status: deferred > New Status: ok Commit summary for MediaWiki.r108095: Fix for bug 31138, 'format' parameter case-insensitive again. J

[Wikitech-l] Home stretch of 1.19 code review

2012-01-04 Thread Mark A. Hershberger
Several of us took off the past few days. But now its time to get back on the Code Review wagon. CRStats (http://toolserver.org/~robla/crstats/) shows that on December 24th we were had around 500 revisions left for review. This wasn't too bad except that we CRStats shows we were supposed to be

[MediaWiki-CodeReview] [MediaWiki r108076]: New comment added

2012-01-04 Thread MediaWiki Mail
"Johnduhart" posted a comment on MediaWiki.r108076. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108076#c28955 Commit summary for MediaWiki.r108076: VoteNY: actually make this work under 1.18+, not just in ResourceLoader's debug mode. Changelist: *removed backwards-compatibility cod

[MediaWiki-CodeReview] [MediaWiki r108088]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Johnduhart" changed the status of MediaWiki.r108088 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108088 Old status: new > New status: ok Commit summary for MediaWiki.r108088: Tidy up/rearrange RELEASE-NOTES-1.19 slightly ___ Med

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-04 Thread K. Peachey
Commons folk doesn't magically delete anything unless there is a reason, nor do they instantly delete in most cases. If peoples uploads are continently getting tagged for deletion, They should look at why they are getting tagged. ___ Wikitech-l mailing l

[MediaWiki-CodeReview] [MediaWiki r105809]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Dantman" changed the status of MediaWiki.r105809 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105809 Old status: fixme > New status: new Commit summary for MediaWiki.r105809: Update wfArrayToCGI and wfCgiToArray: - 'foo' => '' now outputs "&foo=" instead of the key being

[MediaWiki-CodeReview] [MediaWiki r108036]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r108036 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108036 Old status: new > New status: ok Commit summary for MediaWiki.r108036: No need to create an instance of Article to call getLatest() __

Re: [Wikitech-l] Small-ish gadget project: Bug update gadget

2012-01-04 Thread Mark A. Hershberger
Rob Moen writes: > I fiddled with the request parameters for a while trying to get the JSON > RPC to not throw errors. I settled with a URL request for now which is > working nicely. > Feel free to shoot me ideas / thoughts on how this could be improved. This is awesome! I can see this being rea

[MediaWiki-CodeReview] [MediaWiki r107919]: New comment added

2012-01-04 Thread MediaWiki Mail
"Hashar" posted a comment on MediaWiki.r107919. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107919#c28954 Commit summary for MediaWiki.r107919: merge JSTesting branch into trunk Changed written by Timo and reviewed by Hashar. This should be harmless. To enable the feature: $wgEn

[MediaWiki-CodeReview] [MediaWiki r108097]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r108097 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108097 Old status: new > New status: ok Commit summary for MediaWiki.r108097: Remove some unused globals Update some code/documentation a bit __

[MediaWiki-CodeReview] [MediaWiki r107629]: New comment added

2012-01-04 Thread MediaWiki Mail
"Reedy" posted a comment on MediaWiki.r107629. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107629#c28953 Commit summary for MediaWiki.r107629: save article offset into bz2 chunk Reedy's comment: Going to just note this on the newest revision for ease * You've got mixed usages of

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-04 Thread Chad
On Wed, Jan 4, 2012 at 2:53 PM, Gregory Varnum wrote: > I know that's what they're SUPPOSE to do - but I've heard tales of other > issues as well.  It hasn't been my personal experience that the Commons > Admins do a lot of overzealous deletions - but if it helps to prevent even > one overzealo

[MediaWiki-CodeReview] [MediaWiki r108065]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Jack Phoenix" changed the status of MediaWiki.r108065 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108065 Old status: new > New status: ok Commit summary for MediaWiki.r108065: follow-up to r106912 - NULL to null ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r107997]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r107997 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107997 Old status: new > New status: deferred Commit summary for MediaWiki.r107997: * Use getTimestamp() to get the timestamp of the last edit * Removed usage of $wgTit

[MediaWiki-CodeReview] [MediaWiki r102502]: New comment added

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r102502. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102502#c28952 Commit summary for MediaWiki.r102502: More fixes for r102482: the $wouldBlock check doesn't appear to work, also don't use a lock timeout so long that the client times ou

Re: [Wikitech-l] Title objects as value objects; split with WikiPage/Article family?

2012-01-04 Thread Brion Vibber
On Wed, Jan 4, 2012 at 12:10 AM, IAlex wrote: > I added those fields to the Title class to avoid some DB queries and avoid > code > duplication. *nod* they're just not generally applicable to many circumstances, and really are page-data not title-data to begin with. > The problem is that curr

[MediaWiki-CodeReview] [MediaWiki r108093]: New comment added

2012-01-04 Thread MediaWiki Mail
"Rsterbin" posted a comment on MediaWiki.r108093. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108093#c28951 Commit summary for MediaWiki.r108093: Style tweaks for overlay: - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css: - Re-bolded title and

[MediaWiki-CodeReview] [MediaWiki r108083]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Johnduhart" changed the status of MediaWiki.r108083 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108083 Old status: new > New status: deferred Commit summary for MediaWiki.r108083: Localisation updates for core and extension messages from translatewiki.net _

[Wikitech-l] Use of UserMailer::EmailNotifications

2012-01-04 Thread Freek Dijkstra
Hi, I have a question on the UserMailer::EmailNotifications class. Would it be possible to move the settings of the protected variables out of the actuallyNotifyOnPageChange() functions and in the initialisation routine (or some other routine)? If that is not possible, is there another way to com

Re: [Wikitech-l] JavaScript is interesting (was: Mediawiki 2.0)

2012-01-04 Thread Daniel Friesen
On Wed, 04 Jan 2012 09:04:37 -0800, Krinkle wrote: > On Wed, Jan 4, 2012 at 7:42 AM, Daniel Friesen > wrote: > >> On Tue, 03 Jan 2012 06:14:36 -0800, Antoine Musso >> wrote: >> >> > Le Fri, 30 Dec 2011 18:31:30 +0100, Krinkle a >> > écrit: >> >> Since virtually any value other than null and u

[MediaWiki-CodeReview] [MediaWiki r108089]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r108089 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108089 Old status: new > New status: ok Commit summary for MediaWiki.r108089: Tidy up nested assignments ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107939]: New comment added

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" posted a comment on MediaWiki.r107939. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107939#c28950 Commit summary for MediaWiki.r107939: Allow new checkbox on Special::Export to export all pages. See bug 10574. Nikerabbit's comment: if ($exportall) { should be if ( $ex

[MediaWiki-CodeReview] [MediaWiki r106752]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r106752 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752 Old status: fixme > New status: new Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes t

[MediaWiki-CodeReview] [MediaWiki r107939]: New comment added

2012-01-04 Thread MediaWiki Mail
"Turnstep" posted a comment on MediaWiki.r107939. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107939#c28949 Commit summary for MediaWiki.r107939: Allow new checkbox on Special::Export to export all pages. See bug 10574. Turnstep's comment: Happy to oblige, but can you elaborate on

[MediaWiki-CodeReview] [MediaWiki r108081]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108081 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108081 Old status: new > New status: ok Commit summary for MediaWiki.r108081: roll back fbd item background color for now ___ MediaWik

[MediaWiki-CodeReview] [MediaWiki r108080]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108080 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108080 Old status: new > New status: ok Commit summary for MediaWiki.r108080: Add configuration to clicktracking links so that they can be set to on/off _

[MediaWiki-CodeReview] [MediaWiki r107985]: New comment added

2012-01-04 Thread MediaWiki Mail
"Multichill" posted a comment on MediaWiki.r107985. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107985#c28948 Commit summary for MediaWiki.r107985: UDP filter for the GLAM NARA project. Multichill's comment: That's fast! The regular expression can be a bit more precise if you like

[MediaWiki-CodeReview] [MediaWiki r108074]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108074 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108074 Old status: new > New status: ok Commit summary for MediaWiki.r108074: move checkbox for my responses filter to left side ___ M

[MediaWiki-CodeReview] [MediaWiki r108073]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108073 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108073 Old status: fixme > New status: resolved Commit summary for MediaWiki.r108073: Adding mbfr_enotif_sent to track if a response notification email is sent

[MediaWiki-CodeReview] [MediaWiki r108077]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108077 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108077 Old status: new > New status: ok Commit summary for MediaWiki.r108077: followup to -r108073 - Adding Proto_canonical to wfexpandurl() and drop the use of empty() to avoid

[MediaWiki-CodeReview] [MediaWiki r107883]: New comment added

2012-01-04 Thread MediaWiki Mail
"Catrope" posted a comment on MediaWiki.r107883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107883#c28947 Commit summary for MediaWiki.r107883: (bug 26354) Add CSS class to dummy cells containing   . Also change   to   . Applied patch by Erwin Dokter and updated tests. I've also

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-04 Thread Gregory Varnum
I know that's what they're SUPPOSE to do - but I've heard tales of other issues as well. It hasn't been my personal experience that the Commons Admins do a lot of overzealous deletions - but if it helps to prevent even one overzealous deletion - yay. :) I tend to agree it "shouldn't" be neces

[MediaWiki-CodeReview] [MediaWiki r108073]: New comment added, and revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108073 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108073#c28946 Old Status: new > New Status: fixme Commit summary for MediaWiki.r108073: Adding mbfr_enotif_sent to track if a response notification email is se

[MediaWiki-CodeReview] [MediaWiki r107919]: New comment added

2012-01-04 Thread MediaWiki Mail
"Catrope" posted a comment on MediaWiki.r107919. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107919#c28945 Commit summary for MediaWiki.r107919: merge JSTesting branch into trunk Changed written by Timo and reviewed by Hashar. This should be harmless. To enable the feature: $wgE

[MediaWiki-CodeReview] [MediaWiki r108069]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Hashar" changed the status of MediaWiki.r108069 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108069 Old status: new > New status: ok Commit summary for MediaWiki.r108069: [JSTesting] rm redundant comment, there are no more "*" behind any entries __

[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28944 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at htt

[MediaWiki-CodeReview] [MediaWiki r108056]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Krinkle" changed the status of MediaWiki.r108056 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108056 Old status: new > New status: ok Commit summary for MediaWiki.r108056: re r106536 remove !transparent ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108068]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Hashar" changed the status of MediaWiki.r108068 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108068 Old status: new > New status: ok Commit summary for MediaWiki.r108068: [JSTesting] fix case typo in file path * twn: exception 'MWException' with message 'ResourceLoaderFil

[MediaWiki-CodeReview] [MediaWiki r108059]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108059 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108059 Old status: new > New status: ok Commit summary for MediaWiki.r108059: minimize hidden data in fbd item, lighten hover background _

[MediaWiki-CodeReview] [MediaWiki r108058]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108058 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108058 Old status: new > New status: ok Commit summary for MediaWiki.r108058: followup to -r107960 - Add documentation to new messages ___

[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28943 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at htt

[MediaWiki-CodeReview] [MediaWiki r102301]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" changed the status of MediaWiki.r102301 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102301 Old status: fixme > New status: new Commit summary for MediaWiki.r102301: Fix Bug #32047: in table with class="sortable", thead is before caption Apply fomafix's

[MediaWiki-CodeReview] [MediaWiki r107617]: New comment added

2012-01-04 Thread MediaWiki Mail
"Bsitu" posted a comment on MediaWiki.r107617. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107617#c28942 Commit summary for MediaWiki.r107617: Adding ClickTracking to Feedback Response Email links Bsitu's comment: Good to know, thank you! :) __

[MediaWiki-CodeReview] [MediaWiki r108062]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r108062 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108062 Old status: new > New status: ok Commit summary for MediaWiki.r108062: FAIL ___ MediaWiki-CodeReview mailing list mediawiki-coder

[MediaWiki-CodeReview] [MediaWiki r107967]: New comment added

2012-01-04 Thread MediaWiki Mail
"Kaldari" posted a comment on MediaWiki.r107967. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107967#c28941 Commit summary for MediaWiki.r107967: follow-up to r107958 - caching data longer Kaldari's comment: I've never heard that before. What's the down side to using strtotime()? I

[MediaWiki-CodeReview] [MediaWiki r108063]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108063 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108063 Old status: new > New status: ok Commit summary for MediaWiki.r108063: Brought in bottom impression tracking at 100% and init tracking at 1% __

[MediaWiki-CodeReview] [MediaWiki r107960]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r107960 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107960 Old status: ok > New status: resolved Commit summary for MediaWiki.r107960: Format feedback dashbaord time display to have only the largest time block, fix the respo

[MediaWiki-CodeReview] [MediaWiki r107960]: New comment added, and revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r107960 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107960#c28940 Old Status: new > New Status: ok Commit summary for MediaWiki.r107960: Format feedback dashbaord time display to have only the largest time block, f

[MediaWiki-CodeReview] [MediaWiki r108061]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r108061 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108061 Old status: new > New status: ok Commit summary for MediaWiki.r108061: followup to -r107960 - remove unnecessary language function call and update the timestamp to access

[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added

2012-01-04 Thread MediaWiki Mail
"Bawolff" posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28939 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at http://stack

[MediaWiki-CodeReview] [MediaWiki r107919]: New comment added

2012-01-04 Thread MediaWiki Mail
"Nikerabbit" posted a comment on MediaWiki.r107919. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107919#c28938 Commit summary for MediaWiki.r107919: merge JSTesting branch into trunk Changed written by Timo and reviewed by Hashar. This should be harmless. To enable the feature: $

[MediaWiki-CodeReview] [MediaWiki r107960]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Bsitu" changed the status of MediaWiki.r107960 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107960 Old status: fixme > New status: new Commit summary for MediaWiki.r107960: Format feedback dashbaord time display to have only the largest time block, fix the response query

[MediaWiki-CodeReview] [MediaWiki r108044]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r108044 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108044 Old status: new > New status: ok Commit summary for MediaWiki.r108044: Fix Bug 29102 - Upgrade fails "Unknown character set: 'mysql4' Fix suggested by Tremault and tested by

[MediaWiki-CodeReview] [MediaWiki r108057]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r108057 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108057 Old status: new > New status: ok Commit summary for MediaWiki.r108057: w/s ___ MediaWiki-CodeReview mailing list mediawiki-codere

[MediaWiki-CodeReview] [MediaWiki r106025]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" changed the status of MediaWiki.r106025 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106025 Old status: fixme > New status: new Commit summary for MediaWiki.r106025: Bug 16794 - $wgSharedDB PostgreSQL support Updated fix from Luca Fulchir _

[MediaWiki-CodeReview] [MediaWiki r106020]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r106020 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106020 Old status: new > New status: deferred Commit summary for MediaWiki.r106020: some scripts we used for looking at thumbs counts, sizes, etc... in case we need 'em again

[MediaWiki-CodeReview] [MediaWiki r107437]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107437 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107437 Old status: new > New status: ok Commit summary for MediaWiki.r107437: Adding missing schema-changes directory ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r106536]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" changed the status of MediaWiki.r106536 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106536 Old status: fixme > New status: new Commit summary for MediaWiki.r106536: Bug 33113 - Have buttons that are grayed out disabled completely Author: joan.creu...@gm

[MediaWiki-CodeReview] [MediaWiki r107911]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107911 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107911 Old status: new > New status: deferred Commit summary for MediaWiki.r107911: merge trunk in to JSTesting branch ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r108003]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r108003 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108003 Old status: new > New status: ok Commit summary for MediaWiki.r108003: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107411]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107411 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107411 Old status: new > New status: ok Commit summary for MediaWiki.r107411: Fixing static calls to LdapAuthenticationPlugin ___ MediaW

[MediaWiki-CodeReview] [MediaWiki r107438]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107438 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107438 Old status: new > New status: resolved Commit summary for MediaWiki.r107438: Delete userinfo memcache key when modifying the user.

[MediaWiki-CodeReview] [MediaWiki r107794]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107794 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107794 Old status: new > New status: ok Commit summary for MediaWiki.r107794: Protocol relative ___ MediaWiki-CodeReview mailing lis

[MediaWiki-CodeReview] [MediaWiki r107883]: New comment added

2012-01-04 Thread MediaWiki Mail
"Reedy" posted a comment on MediaWiki.r107883. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107883#c28937 Commit summary for MediaWiki.r107883: (bug 26354) Add CSS class to dummy cells containing   . Also change   to   . Applied patch by Erwin Dokter and updated tests. I've also re

[MediaWiki-CodeReview] [MediaWiki r107920]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107920 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107920 Old status: new > New status: ok Commit summary for MediaWiki.r107920: Per request of Reedy, MFT r99942 and r99950 ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r107972]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107972 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107972 Old status: new > New status: ok Commit summary for MediaWiki.r107972: rebranching UploadWizard from 1.18wmf1 UploadWizard at r107942 ___

[MediaWiki-CodeReview] [MediaWiki r107971]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107971 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107971 Old status: new > New status: ok Commit summary for MediaWiki.r107971: remove UploadWizard again, seems to be some issues with mw.Api in 1.18; will revert _

Re: [Wikitech-l] LiquidThreads status

2012-01-04 Thread Happy Melon
On 3 January 2012 23:15, Erik Moeller wrote: > > "Next" though would likely still mean no sooner than March/April. Any > help is as always appreciated. > You say that help is always appreciated, and I think that, *in general*, it is; but with regard to specific projects, particularly where there

[MediaWiki-CodeReview] [MediaWiki r108053]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Hashar" changed the status of MediaWiki.r108053 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108053 Old status: new > New status: ok Commit summary for MediaWiki.r108053: Revert r107066, see CR comments for full rationale. Basically this moves the previewed CSS to the wro

[MediaWiki-CodeReview] [MediaWiki r107066]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Catrope" changed the status of MediaWiki.r107066 to "reverted" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107066 Old status: new > New status: reverted Commit summary for MediaWiki.r107066: apply CSS::Janus when user preview its CSS style follow up r94421 _

[MediaWiki-CodeReview] [MediaWiki r107066]: New comment added

2012-01-04 Thread MediaWiki Mail
"Catrope" posted a comment on MediaWiki.r107066. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107066#c28936 Commit summary for MediaWiki.r107066: apply CSS::Janus when user preview its CSS style follow up r94421 Catrope's comment: This doesn't actually trigger CSSJanus, look at th

[MediaWiki-CodeReview] [MediaWiki r101581]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r101581 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101581 Old status: new > New status: deferred Commit summary for MediaWiki.r101581: bug 32056 ___ MediaWiki-CodeReview mailing lis

[MediaWiki-CodeReview] [MediaWiki r107583]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r107583 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107583 Old status: new > New status: ok Commit summary for MediaWiki.r107583: Parameters are clearly reversed. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28935 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at htt

Re: [Wikitech-l] JavaScript is interesting (was: Mediawiki 2.0)

2012-01-04 Thread Krinkle
On Wed, Jan 4, 2012 at 7:42 AM, Daniel Friesen wrote: > On Tue, 03 Jan 2012 06:14:36 -0800, Antoine Musso > wrote: > > > Le Fri, 30 Dec 2011 18:31:30 +0100, Krinkle a > > écrit: > >> Since virtually any value other than null and undefined is an object, > >> including numbers, strings and functio

[MediaWiki-CodeReview] [MediaWiki r108052]: New comment added

2012-01-04 Thread MediaWiki Mail
"Reedy" posted a comment on MediaWiki.r108052. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108052#c28934 Commit summary for MediaWiki.r108052: API module to search pages by coordinate Reedy's comment: svn:keywords Id ___ MediaWiki-CodeR

[MediaWiki-CodeReview] [MediaWiki r108024]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"MarkAHershberger" changed the status of MediaWiki.r108024 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108024 Old status: new > New status: ok Commit summary for MediaWiki.r108024: XCF format: code style/comment * Saved a level of indentation by returning early on command

[MediaWiki-CodeReview] [MediaWiki r103107]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r103107 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103107 Old status: new > New status: ok Commit summary for MediaWiki.r103107: Removed duplciate function for CheckUserLog ___ MediaWiki-

[MediaWiki-CodeReview] [MediaWiki r102482]: Revision status changed

2012-01-04 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r102482 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102482 Old status: new > New status: resolved Commit summary for MediaWiki.r102482: Added an external locking layer around Subversion access to the repository. Intended as a

  1   2   >