[Wikitech-l] Extension:RSS improved

2012-02-24 Thread Thomas Gries
This mail refers to E:RSS version 2.01 as in r112315 . Improved https://www.mediawiki.org/wiki/Extension:RSS - begin of Namespace handling and ATOM feed handling - E:RSS is compatible with E:WikiArticleFeeds RSS, ATOM feeds - handles basic HTML layout tags in feed items If you think you are an

[Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Johannes Weberhofer
Hi, can someone give me an idea, how I can determine a uploaded file's real path, when I only have the filename? I have written some code but there could also be a API call available. Best regards, Johannes -- Johannes Weberhofer Weberhofer GmbH, Austria, Vienna

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Petr Kadlec
On 24 February 2012 15:09, Johannes Weberhofer jweberho...@weberhofer.at wrote: can someone give me an idea, how I can determine a uploaded file's real path, when I only have the filename? I have written some code but there could also be a API call available. You mean like

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Petr Bena
hello I have made an utility which give you all absolute URL's for a give list / category of files on commons, in case you were interested in that, I could send you a source code, however it just download a wiki page for each file and parse the url from the source On Fri, Feb 24, 2012 at 3:09 PM,

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Schneelocke
On Fri, Feb 24, 2012 at 15:11, Petr Kadlec petr.kad...@gmail.com wrote: On 24 February 2012 15:09, Johannes Weberhofer jweberho...@weberhofer.at wrote: can someone give me an idea, how I can determine a uploaded file's real path, when I only have the filename? I have written some code but

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Johannes Weberhofer
Sorry, my request was a bit unclear, I want to find the file's path in the file system. I know the URL, like http://test.com/wiki/images/test.png , and I like to know, the path which could be /var/www/domains/test.com/wiki/images/test.png . Is there a way to determine this path, even when the

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Petr Bena
Yes, the path is in http://www.mediawiki.org/wiki/Manual:$wgUploadDirectory On Fri, Feb 24, 2012 at 3:42 PM, Johannes Weberhofer jweberho...@weberhofer.at wrote: Sorry, my request was a bit unclear, I want to find the file's path in the file system. I know the URL, like

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Johannes Weberhofer
That's the base path; related to the settings in $wgHashedUploadDirectory (and other settings?) the real path may differ. I'm looking for a functions, that does this calculationfor me...). Johannes Am 24.02.12 16:03, schrieb Petr Bena: Yes, the path is in

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Lists
$image = Image::newFromName($backImage); if(is_object($image)): if($image-exists()==1): $backImage = $image-getUrl(); -Ursprüngliche Nachricht- Von: wikitech-l-boun...@lists.wikimedia.org

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Chad
On Fri, Feb 24, 2012 at 10:40 AM, Lists li...@psycholutions.com wrote:  $image = Image::newFromName($backImage);                if(is_object($image)):                    if($image-exists()==1):                        $backImage = $image-getUrl(); The Image class has been deprecated and

Re: [Wikitech-l] How to get a uploaded files path

2012-02-24 Thread Johannes Weberhofer
Thanks for your information. I'll give it a try next week. Johannes Am 24.02.12 16:51, schrieb Chad: On Fri, Feb 24, 2012 at 10:40 AM, Listsli...@psycholutions.com wrote: $image = Image::newFromName($backImage); if(is_object($image)):

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112215 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31416 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Nikerabbit's

[MediaWiki-CodeReview] [MediaWiki r112199]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r112199 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112199 Old status: new New status: ok Commit summary for MediaWiki.r112199: Added Ahirani support. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112186]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112186 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112186 Old status: new New status: ok Commit summary for MediaWiki.r112186: Fix Bug 34596. Use . for . instead of Danda. Map \. to Danda

[MediaWiki-CodeReview] [MediaWiki r112216]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112216. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112216#c31417 Commit summary for MediaWiki.r112216: use params field, not m_params Nikerabbit's comment: What's the difference anyway? do Both work?

[MediaWiki-CodeReview] [MediaWiki r112259]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r112259 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112259 Old status: new New status: ok Commit summary for MediaWiki.r112259: Improved profiling of a few functions a bit ___

[MediaWiki-CodeReview] [MediaWiki r112257]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r112257 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112257 Old status: new New status: ok Commit summary for MediaWiki.r112257: fix doc, this is not an array ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112066]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r112066 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112066#c31418 Old Status: ok New Status: fixme Commit summary for MediaWiki.r112066: Move parameters were backwards Ping r112061 Krinkle's comment: Hm.. really

[MediaWiki-CodeReview] [MediaWiki r112066]: New comment added

2012-02-24 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r112066. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112066#c31419 Commit summary for MediaWiki.r112066: Move parameters were backwards Ping r112061 Krinkle's comment: Oh, I guess it's just a bad variable name. Keeping fixme for now, if

[MediaWiki-CodeReview] [MediaWiki r111918]: New comment added

2012-02-24 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r111918. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111918#c31420 Commit summary for MediaWiki.r111918: Remove obsolete and broken lang2po.php. Krinkle's comment: Release-notes maybe? ___

[MediaWiki-CodeReview] [MediaWiki r111897]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r111897 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111897 Old status: new New status: ok Commit summary for MediaWiki.r111897: * Marked some FileBackendMultiWrite functions as protected as they should be * Broke up a few variable

[MediaWiki-CodeReview] [MediaWiki r99250]: New comment added

2012-02-24 Thread MediaWiki Mail
VitaliyFilippov posted a comment on MediaWiki.r99250. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99250#c31421 Commit summary for MediaWiki.r99250: Bug 31445: Section edit links do not show Always generate the mw:editsection placeholders. Remove them if not used. Update the

[MediaWiki-CodeReview] [MediaWiki r104689]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r104689 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104689#c31422 Old Status: ok New Status: fixme Commit summary for MediaWiki.r104689: Followup r104688, reintroduce the full PathRouter code now that the bug with

[MediaWiki-CodeReview] [MediaWiki r104689]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r104689 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104689#c31423 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r104689: Followup r104688, reintroduce the full PathRouter code now that the

[MediaWiki-CodeReview] [MediaWiki r111983]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r111983 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111983#c31424 Old Status: ok New Status: fixme Commit summary for MediaWiki.r111983: * Fixed failure of the edit toolbar to load when

[MediaWiki-CodeReview] [MediaWiki r112213]: New comment added

2012-02-24 Thread MediaWiki Mail
Jdlrobson posted a comment on MediaWiki.r112213. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112213#c31425 Commit summary for MediaWiki.r112213: add file missing from r112210 this file was overlooked. adding now. Jdlrobson's comment: This is now fixed in r112321

[MediaWiki-CodeReview] [MediaWiki r112283]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112283 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112283 Old status: new New status: ok Commit summary for MediaWiki.r112283: Change url to point at mw.org ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112321]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112321. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112321#c31426 Commit summary for MediaWiki.r112321: i18n the clear search button this references c31415 on r112213 Nikerabbit's comment: I don't see any escaping here. Looks like any

[MediaWiki-CodeReview] [MediaWiki r112066]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r112066 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112066#c31427 Old Status: fixme New Status: new Commit summary for MediaWiki.r112066: Move parameters were backwards Ping r112061 Reedy's comment: Indeed, I tested

[MediaWiki-CodeReview] [MediaWiki r111991]: New comment added

2012-02-24 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r111991. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991#c31428 Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. Reedy's comment: Not sure. Try

[MediaWiki-CodeReview] [MediaWiki r112321]: New comment added

2012-02-24 Thread MediaWiki Mail
Jdlrobson posted a comment on MediaWiki.r112321. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112321#c31429 Commit summary for MediaWiki.r112321: i18n the clear search button this references c31415 on r112213 Jdlrobson's comment: Escaped as of r112324

[MediaWiki-CodeReview] [MediaWiki r112139]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r112139 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112139 Old status: deferred New status: ok Commit summary for MediaWiki.r112139: Removed comment - 'substr' parameter is no longer mandatory in all cases

[MediaWiki-CodeReview] [MediaWiki r100315]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
RobLa-WMF changed the status of MediaWiki.r100315 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100315#c31430 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r100315: * Made ?contribs=user actually show the results for the *user* if

[MediaWiki-CodeReview] [MediaWiki r112323]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112323 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112323 Old status: new New status: ok Commit summary for MediaWiki.r112323: Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback()

[MediaWiki-CodeReview] [MediaWiki r112290]: New comment added

2012-02-24 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r112290. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112290#c31431 Commit summary for MediaWiki.r112290: Examples can just be a string So if it's not false, it can be string|array, if it's a string, just put it in an array MaxSem's comment:

[MediaWiki-CodeReview] [MediaWiki r112291]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112291 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112291 Old status: new New status: ok Commit summary for MediaWiki.r112291: MFT r112290 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r112299]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112299 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112299 Old status: new New status: ok Commit summary for MediaWiki.r112299: MFT r112298: mysql_real_escape_string() warning ___

[MediaWiki-CodeReview] [MediaWiki r112326]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112326 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112326 Old status: new New status: ok Commit summary for MediaWiki.r112326: move wfRecursiveRemoveDir to global functions That useful method was hidden in SeleniumWebSettings. I need

[MediaWiki-CodeReview] [MediaWiki r112301]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112301 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112301 Old status: new New status: ok Commit summary for MediaWiki.r112301: MFT r112300: fallback infinite loops ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112285]: New comment added

2012-02-24 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r112285. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112285#c31432 Commit summary for MediaWiki.r112285: Added support and corresponding test for creating mobile URLs where the mobile-ness of the URL is denoted in its path. This just adds the

[MediaWiki-CodeReview] [MediaWiki r112286]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112286 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112286 Old status: new New status: ok Commit summary for MediaWiki.r112286: Updating comments to reflect addition of URL path templating support

[MediaWiki-CodeReview] [MediaWiki r112216]: New comment added

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r112216. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112216#c31433 Commit summary for MediaWiki.r112216: use params field, not m_params Jeroen De Dauw's comment: Both work. m_params is the old one, and is now deprecated.

[MediaWiki-CodeReview] [MediaWiki r112332]: Revision status changed

2012-02-24 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r112332 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112332 Old status: new New status: ok Commit summary for MediaWiki.r112332: More __METHOD__ into db related methods ___

[MediaWiki-CodeReview] [MediaWiki r112285]: New comment added

2012-02-24 Thread MediaWiki Mail
Awjrichards posted a comment on MediaWiki.r112285. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112285#c31434 Commit summary for MediaWiki.r112285: Added support and corresponding test for creating mobile URLs where the mobile-ness of the URL is denoted in its path. This just adds

[Wikitech-l] Triage of 1.19 problems

2012-02-24 Thread Mark A. Hershberger
What: 1.19 bug triage When: Friday, February, 21:00UTC Time zone conversion: http://hexm.de/f2 Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev if you don't have an IRC client Etherpad:

[MediaWiki-CodeReview] [MediaWiki r112339]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112339 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112339 Old status: new New status: ok Commit summary for MediaWiki.r112339: More __METHOD__ in our madness ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r112331]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112331 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112331 Old status: new New status: ok Commit summary for MediaWiki.r112331: better structure filename error output When dumping an array, PHPUnit limit the number of characters

[MediaWiki-CodeReview] [MediaWiki r112178]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112178 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112178 Old status: new New status: ok Commit summary for MediaWiki.r112178: Swap Fran Rogers to Fran McCrory per request ___

[MediaWiki-CodeReview] [MediaWiki r112257]: New comment added

2012-02-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r112257. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112257#c31435 Commit summary for MediaWiki.r112257: fix doc, this is not an array Aaron Schulz's comment: MySQL uses stdclass, do the others? I've seen such objects documented as Row

[MediaWiki-CodeReview] [MediaWiki r112318]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112318 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112318 Old status: new New status: ok Commit summary for MediaWiki.r112318: Use local context to get message ___

[MediaWiki-CodeReview] [MediaWiki r112338]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112338 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112338 Old status: new New status: ok Commit summary for MediaWiki.r112338: Improve documentation ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r110725]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r110725 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110725#c31436 Old Status: fixme New Status: reverted Commit summary for MediaWiki.r110725: Makes the feedback textarea work correctly in an RTL environment.

[MediaWiki-CodeReview] [MediaWiki r112257]: New comment added

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r112257. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112257#c31437 Commit summary for MediaWiki.r112257: fix doc, this is not an array Jeroen De Dauw's comment: I'm not sure and am fine with documenting it as object. Row could also be

[MediaWiki-CodeReview] [MediaWiki r112300]: New comment added

2012-02-24 Thread MediaWiki Mail
MZMcBride posted a comment on MediaWiki.r112300. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112300#c31438 Commit summary for MediaWiki.r112300: Fixes for r94907/r94908: change in fallback behaviour allowing infinite loops. Tested SecurePoll and LandingCheck, not

[MediaWiki-CodeReview] [MediaWiki r112300]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112300. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112300#c31439 Commit summary for MediaWiki.r112300: Fixes for r94907/r94908: change in fallback behaviour allowing infinite loops. Tested SecurePoll and LandingCheck, not

[MediaWiki-CodeReview] [MediaWiki r111861]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111861 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111861 Old status: new New status: ok Commit summary for MediaWiki.r111861: Bug 27619: Remove the option to show broken links as: link? Being bold here, but otherwise it will still

[MediaWiki-CodeReview] [MediaWiki r112340]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112340 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112340 Old status: new New status: ok Commit summary for MediaWiki.r112340: Test that verifies uniqueness of query module prefixes

[MediaWiki-CodeReview] [MediaWiki r111861]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111861 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111861#c31440 Old Status: ok New Status: fixme Commit summary for MediaWiki.r111861: Bug 27619: Remove the option to show broken links as: link? Being bold here,

[MediaWiki-CodeReview] [MediaWiki r111861]: New comment added

2012-02-24 Thread MediaWiki Mail
Kaldari posted a comment on MediaWiki.r111861. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111861#c31441 Commit summary for MediaWiki.r111861: Bug 27619: Remove the option to show broken links as: link? Being bold here, but otherwise it will still be there in 2016 Kaldari's

[MediaWiki-CodeReview] [MediaWiki r112250]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r112250 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112250 Old status: new New status: ok Commit summary for MediaWiki.r112250: Follow-up r85935: Add key for JavaScript customisation page. Some spaces to tabs.

[MediaWiki-CodeReview] [MediaWiki r111861]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111861 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111861 Old status: fixme New status: resolved Commit summary for MediaWiki.r111861: Bug 27619: Remove the option to show broken links as: link? Being bold here, but otherwise

[MediaWiki-CodeReview] [MediaWiki r112327]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112327 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112327 Old status: new New status: ok Commit summary for MediaWiki.r112327: avoid exif tests file leakage Exif test are leaking files heavily on our test server. This quick

[MediaWiki-CodeReview] [MediaWiki r111562]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r111562 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111562 Old status: fixme New status: new Commit summary for MediaWiki.r111562: AFTv5: activity feature - another sync-up commit ___

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31442 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Jeroen De Dauw's comment: Stuff not remarked upon below taken care off in follow up.

[MediaWiki-CodeReview] [MediaWiki r112128]: New comment added

2012-02-24 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r112128. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112128#c31443 Commit summary for MediaWiki.r112128: r112045/bug 34508: Make upload/upload and overwrite match old IRC format Raymond's comment: Message keys commented out for the moment

[MediaWiki-CodeReview] [MediaWiki r112352]: New comment added

2012-02-24 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r112352. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112352#c31444 Commit summary for MediaWiki.r112352: avoid test suite file leaks Aaron Schulz's comment: Why not just move that filesToPrune[] code to the doConcatenate and doStore

[MediaWiki-CodeReview] [MediaWiki r112313]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112313 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112313 Old status: new New status: ok Commit summary for MediaWiki.r112313: Fix bug 34684 in my PathRouter code: - Update the tests to test extra characters and patterns like

[MediaWiki-CodeReview] [MediaWiki r111861]: New comment added

2012-02-24 Thread MediaWiki Mail
Kaldari posted a comment on MediaWiki.r111861. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111861#c31445 Commit summary for MediaWiki.r111861: Bug 27619: Remove the option to show broken links as: link? Being bold here, but otherwise it will still be there in 2016 Kaldari's

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31446 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Nikerabbit's comment: Maybe you could use data- attributes from html5. It's basically

[MediaWiki-CodeReview] [MediaWiki r112358]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r112358 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112358 Old status: new New status: ok Commit summary for MediaWiki.r112358: suppressed feedback comment in log per bug 34097 ___

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31447 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Jeroen De Dauw's comment: Maybe you could use data- attributes from html5 Right,

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31448 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Nikerabbit's comment: Yes you are correct. I hate the colon vs. semicolon difference

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31449 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Jeroen De Dauw's comment: jslint goes mad at you when you repeat the var stuff, and

[MediaWiki-CodeReview] [MediaWiki r112215]: New comment added

2012-02-24 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31450 Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Nikerabbit's comment: Not so much about the practice but about the design of the

[MediaWiki-CodeReview] [MediaWiki r112215]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r112215 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215 Old status: fixme New status: new Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified ___

[MediaWiki-CodeReview] [MediaWiki r112280]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112280 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112280 Old status: new New status: ok Commit summary for MediaWiki.r112280: minor fixes: removed whitespace, added semicolon ___

[MediaWiki-CodeReview] [MediaWiki r112336]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r112336 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112336 Old status: new New status: ok Commit summary for MediaWiki.r112336: AFTv5: fix r111562 again, misclosed comment ___

[MediaWiki-CodeReview] [MediaWiki r111791]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r111791 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111791#c31451 Old Status: ok New Status: fixme Commit summary for MediaWiki.r111791: r111786: extension moved Nikerabbit's comment: Messages are not in the

Re: [Wikitech-l] Git, Gerrit, and You! or, Gerrit training available starting Monday 27 February

2012-02-24 Thread Sumana Harihareswara
On 02/22/2012 08:53 PM, Sumana Harihareswara wrote: Before the March 3rd migration of MediaWiki core + WMF-deployed extensions to git, we want all MediaWiki developers to feel comfortable with Git, git-review, and Gerrit. So I'm scheduling the first in some one-hour interactive training

[MediaWiki-CodeReview] [MediaWiki r112356]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112356 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112356 Old status: new New status: ok Commit summary for MediaWiki.r112356: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r112352]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112352 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112352 Old status: new New status: ok Commit summary for MediaWiki.r112352: avoid test suite file leaks ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r111710]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r111710 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111710 Old status: new New status: ok Commit summary for MediaWiki.r111710: changing jquery.ui buttons to match assets from brandon, also adding separate graphics for large

[MediaWiki-CodeReview] [MediaWiki r112368]: New comment added

2012-02-24 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r112368. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112368#c31452 Commit summary for MediaWiki.r112368: [JSTesting] Add more mw.loader tests * Follows-up r12279, r112281 * Follows-up r110988: Adds test for @import (currently failing: bug

[MediaWiki-CodeReview] [MediaWiki r112369]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r112369 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112369 Old status: new New status: ok Commit summary for MediaWiki.r112369: [JSTesting] actually commit the file (follows-up r112368) ___

[MediaWiki-CodeReview] [MediaWiki r110988]: New comment added

2012-02-24 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r110988. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110988#c31453 Commit summary for MediaWiki.r110988: (bug 31676) Group dynamically inserted CSS into a single style tag, because IE limits the number of styles it'll apply to 32

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-24 Thread Roan Kattouw
On Thu, Feb 23, 2012 at 1:43 PM, Antoine Musso hashar+...@free.fr wrote: 2) newbie spamming gerrit This happen when you first play with Gerrit. In subversion world, whenever you submit a new patch (svn commit) it is going to be written down in the central repository. You will not be able to

[MediaWiki-CodeReview] [MediaWiki r110988]: New comment added

2012-02-24 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r110988. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110988#c31454 Commit summary for MediaWiki.r110988: (bug 31676) Group dynamically inserted CSS into a single style tag, because IE limits the number of styles it'll apply to 32

[MediaWiki-CodeReview] [MediaWiki r112372]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Awjrichards changed the status of MediaWiki.r112372 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112372 Old status: new New status: reverted Commit summary for MediaWiki.r112372: Attempting to address bug 34653; It seems ApiQueryLogEvents has not kept up with changes

[MediaWiki-CodeReview] [MediaWiki r112373]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112373 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112373 Old status: new New status: ok Commit summary for MediaWiki.r112373: Revert r112372, should have made the change in trunk rather than in the wmf branch

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-24 Thread Platonides
On 25/02/12 00:27, Roan Kattouw wrote: You're right that this is the biggest problem with stacked commits: if you have a dependency chain A-B-C and B is amended or abandoned, you have to rebase C somehow. A lesser problem is that if A and C are approved, but B hasn't been reviewed yet, A will

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-24 Thread Chad
On Fri, Feb 24, 2012 at 6:48 PM, Platonides platoni...@gmail.com wrote: There's no way to treat a set of commits as a bundle? What happens if a developer wants to merge his extension on which he has been working (in Git) for months? I am assuming: * The extension will get a full review. *

[MediaWiki-CodeReview] [MediaWiki r112374]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r112374 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112374 Old status: new New status: ok Commit summary for MediaWiki.r112374: Attempting to address bug 34653; It seems ApiQueryLogEvents has not kept up with changes to the

[MediaWiki-CodeReview] [MediaWiki r105471]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r105471 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105471 Old status: new New status: resolved Commit summary for MediaWiki.r105471: AFTv5 - JS fixes on feedback page - I think there was an issue with wikiScript being called

[MediaWiki-CodeReview] [MediaWiki r111776]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Raindrift changed the status of MediaWiki.r111776 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111776 Old status: new New status: ok Commit summary for MediaWiki.r111776: Removed use warnings and use Data::Dumper - needed only for debugging. Cleaned up a lot of obsolete

[MediaWiki-CodeReview] [MediaWiki r111647]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r111647 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111647 Old status: new New status: ok Commit summary for MediaWiki.r111647: (Bug 31417) Content-holding div needs an ID. Since the introduction of the class mw-content-ltr/rtl,

[MediaWiki-CodeReview] [MediaWiki r100315]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r100315 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100315 Old status: fixme New status: new Commit summary for MediaWiki.r100315: * Made ?contribs=user actually show the results for the *user* if 'newbies' was given as the

[MediaWiki-CodeReview] [MediaWiki r109666]: New comment added, and revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r109666 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109666#c31455 Old Status: new New Status: fixme Commit summary for MediaWiki.r109666: added checkoutResult() for generating more informative user-facing errors

[MediaWiki-CodeReview] [MediaWiki r111037]: Revision status changed

2012-02-24 Thread MediaWiki Mail
Kaldari changed the status of MediaWiki.r111037 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111037 Old status: new New status: ok Commit summary for MediaWiki.r111037: Comments: fix bug #34281 -- don't show reply links to unprivileged users. Patch by Van de Bugger.

[Wikitech-l] call graphs on our class doc pages take forever to load

2012-02-24 Thread Ryan Kaldari
Some time last year Zak Greant added call and caller graphs to our MediaWiki Class doc pages (e.g. http://svn.wikimedia.org/doc/classUser.html). While these are nifty to look at, and might even occasionally be useful, they make the pages take ages to load and frequently turn my browser into

Re: [Wikitech-l] [ANN] MediaWiki Short URL Builder configuration tool

2012-02-24 Thread jidanni
http://shorturls.redwerks.org/ should link to http://www.mediawiki.org/wiki/Manual:Short_URL#Advantages_.26_disadvantages . for a balanced view. I'll stick with my long URLs. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

  1   2   >