Re: [Wikitech-l] Pretty Timestamps

2012-10-26 Thread Tyler Romeo
So basically instead of passing Language to MWTimestamp you want to pass MWTimestamp to Language. IMHO it's fine with me, so long as the logic is properly separated. In the end, all this would require is the addition of MWTimestamp::diff (or since) and MWTimstamp::userAdjust, which Language would c

Re: [Wikitech-l] Pretty Timestamps

2012-10-26 Thread Chad
On Fri, Oct 26, 2012 at 6:07 PM, Tyler Romeo wrote: > The proper implementation would be to separate the timestamp logic > (calculating how long ago, adjusting based on user timezone preferences, > etc.) and the language logic (getting messages for the day of the week, > formatting the date and ti

Re: [Wikitech-l] Problems with adding a new toolbar element (probably due to recent deployments)

2012-10-26 Thread Strainu
2012/10/27 Platonides : > The image is shown here now. Indeed. Then the 404 must have been a transitory error. Thanks Platonides! Strainu ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Pretty Timestamps

2012-10-26 Thread Tyler Romeo
The proper implementation would be to separate the timestamp logic (calculating how long ago, adjusting based on user timezone preferences, etc.) and the language logic (getting messages for the day of the week, formatting the date and time, actually making the message). Then, have MWTimestamp pro

Re: [Wikitech-l] Problems with adding a new toolbar element (probably due to recent deployments)

2012-10-26 Thread Platonides
On 26/10/12 12:12, Strainu wrote: > Hi, > > Some time ago, I've added a new toolbar button on ro.wp for the > Romanian quotation sign. The code is at [1] (the part below > //ghilimele ). It hasn't changed in 2012. However, today I noticed > that the picture is not displayed any more. On FF I see t

Re: [Wikitech-l] Pretty Timestamps

2012-10-26 Thread Terry Chay
I approved the reversion of the patch since I was the original person who approved it. As I see it there are the following problems with the change I approved: 1. Typo in weekday cutoff [Timo] 2. iAlex points out that the optional parameter fix variable ordering is wrong [Harsha

Re: [Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Niklas Laxström
On 26 October 2012 15:57, Tim Landscheidt wrote: > Niklas Laxström wrote: > >> [...] >>> All of this shouldn't be necessary, as PHPUnit 3.6.12's >>> package.xml clearly declares a dependency on PHP_Timer = 1.0.1 and <= 1.0.3. In other words: Whatever Niklas used >>> for update seems to be br

Re: [Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Tim Landscheidt
Niklas Laxström wrote: > [...] >> All of this shouldn't be necessary, as PHPUnit 3.6.12's >> package.xml clearly declares a dependency on PHP_Timer >>>= 1.0.1 and <= 1.0.3. In other words: Whatever Niklas used >> for update seems to be broken and should be fixed. > Not too clearly apparently, I

Re: [Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Niklas Laxström
On 26 October 2012 15:02, Tim Landscheidt wrote: > Antoine Musso wrote: > >>> I recently updated packages via PEAR. I don't remember what exactly, >>> but right now I have >>> PHPUnit-3.6.12 >>> PHP_Invoker-1.1.1 > >>> When I try to run tests for Translate I get: >>> 1) SpecialPagesTest::testSpec

Re: [Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Tim Landscheidt
Antoine Musso wrote: >> I recently updated packages via PEAR. I don't remember what exactly, >> but right now I have >> PHPUnit-3.6.12 >> PHP_Invoker-1.1.1 >> When I try to run tests for Translate I get: >> 1) SpecialPagesTest::testSpecialPage with data set #3 ('LanguageStats') >> Fatal error:

Re: [Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Antoine Musso
Le 26/10/12 11:29, Niklas Laxström a écrit : > I recently updated packages via PEAR. I don't remember what exactly, > but right now I have > PHPUnit-3.6.12 > PHP_Invoker-1.1.1 > > When I try to run tests for Translate I get: > 1) SpecialPagesTest::testSpecialPage with data set #3 ('LanguageStats')

[Wikitech-l] Problems with adding a new toolbar element (probably due to recent deployments)

2012-10-26 Thread Strainu
Hi, Some time ago, I've added a new toolbar button on ro.wp for the Romanian quotation sign. The code is at [1] (the part below //ghilimele ). It hasn't changed in 2012. However, today I noticed that the picture is not displayed any more. On FF I see the alt text and IE complains about "unsafe con

[Wikitech-l] Problems with PHPUnit

2012-10-26 Thread Niklas Laxström
I recently updated packages via PEAR. I don't remember what exactly, but right now I have PHPUnit-3.6.12 PHP_Invoker-1.1.1 When I try to run tests for Translate I get: 1) SpecialPagesTest::testSpecialPage with data set #3 ('LanguageStats') Fatal error: Call to undefined function php_timer_autoloa