Re: [Wikitech-l] New git-review lets you configure 'origin' as the gerrit remote

2013-06-07 Thread S Page
This is great! Origin and gerrit remotes disagreeing could potentially cause havoc. saper and I went through some tutorials telling people to use `git clone -o gerrit` when starting development, but this is much cleaner. I added it to https://www.mediawiki.org/wiki/Gerrit/Tutorial#Prepare_to_work_

[Wikitech-l] Last weekend for proposal work! (was Re: Request for proposals: MediaWiki release management)

2013-06-07 Thread Greg Grossmeier
And, your Friday before it's due ping. This is your last weekend to work on it! > Hello all, > > I'm excited to share that we just opened an RFP for the Release > Management of MediaWiki! More information below. > > > The announcement blog post: > https://blog.wikimedia.org/2013/05/21/request

[Wikitech-l] WMF Engineering Roadmap update - 2013-06-07

2013-06-07 Thread Greg Grossmeier
Hello all, == Preamble == Thanks to Robla, We now have a reliable way of creating a wikipage from the Google Spreadsheet we actually edit. Because of that, you can now see diffs! Eg: this is the one from today's meeting: http://www.mediawiki.org/w/index.php?title=Roadmap&diff=706771&oldid=70364

Re: [Wikitech-l] Separation of Concerns

2013-06-07 Thread Chris Steipp
On Fri, Jun 7, 2013 at 12:02 AM, Tyler Romeo wrote: > On Fri, Jun 7, 2013 at 2:58 AM, Tim Starling wrote: > >> I'm recommending making these "groups" of rights be both a UI concept >> and a storage concept, very similar to the existing group feature, >> rather than storing right grants and somehow

Re: [Wikitech-l] Architecture Guidelines: Writing Testable Code

2013-06-07 Thread Aaron Schulz
I generally agree with 2-8, and 10. I think points 2 and 10 are pretty subjective and must be applied very pragmatically. -- View this message in context: http://wikimedia.7.x6.nabble.com/Architecture-Guidelines-Writing-Testable-Code-tp5006129p5006712.html Sent from the Wikipedia Developers ma

[Wikitech-l] Deployment highlights - week of June 10th

2013-06-07 Thread Greg Grossmeier
Hello and welcome to the latest installment of your friendly deployment highlights! The full calendar for next week is available at: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_June_10th Here are the highlights: == Overall == * The week of June 10th is the first "clean" one-week cyc

Re: [Wikitech-l] Strange PHPUnit behaviour

2013-06-07 Thread Tyler Romeo
What Brad said. In this case, I believe the assertSame function should be used instead, which emulates ===. On Jun 7, 2013 1:55 PM, "Brad Jorsch" wrote: > On Fri, Jun 7, 2013 at 12:36 PM, Paul Selitskas > wrote: > > What is wrong here? Wrong test case + issue in PHPUnit or what? > > Fun with PH

Re: [Wikitech-l] Strange PHPUnit behaviour

2013-06-07 Thread Brad Jorsch
On Fri, Jun 7, 2013 at 12:36 PM, Paul Selitskas wrote: > What is wrong here? Wrong test case + issue in PHPUnit or what? Fun with PHP comparison. With the "==" and "!=" operators (which are what PHPUnit's assertEquals is probably using), PHP notices that "1" and "01" are both "numeric strings" so

Re: [Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread Marc A. Pelletier
On 06/07/2013 11:43 AM, Asher Feldman wrote: > Why not - would the patrol cost really be too high? I can only speak for enwp, of course, but with my experience as a checkuser and arb there (and a couple years as an admin before that) I can say without a doubt that I would strenuously oppose relaxi

[Wikitech-l] Strange PHPUnit behaviour

2013-06-07 Thread Paul Selitskas
Hola! I noticed something very strange in unit tests for /languages/Language.php (/tests/phpunit/languages/LanguageTest.php): Language::sprintfDate() is tested to conform with expected formatted date strings. In the test file method 'provideSprintfDateSamples' provides a test case for the format

Re: [Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread Chris Steipp
On Fri, Jun 7, 2013 at 8:43 AM, Asher Feldman wrote: > https://twitter.com/ioerror/status/342922052841377793 > > Why not - would the patrol cost really be too high? What I've heard is that the edits from tor were over 90% spam/vandalism, so the IPs get blocked pretty quickly. Torblock (the tool)

Re: [Wikitech-l] Welcome to Ken Snider, Wikimedia Operations

2013-06-07 Thread Sumana Harihareswara
On 06/06/2013 09:17 AM, Erik Moeller wrote: > Ken got involved in one of Cory’s pet projects, BoingBoing.net which > some of you may have heard of ;-), and has been their sysadmin since > 2003. I continue to marvel at the cool experience my colleagues bring to their work. OpenCOLA and Boing Boin

Re: [Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread Asher Feldman
Ah, thanks Sumana! On Friday, June 7, 2013, Sumana Harihareswara wrote: > On 06/07/2013 08:43 AM, Asher Feldman wrote: > > https://twitter.com/ioerror/status/342922052841377793 > > > > Why not - would the patrol cost really be too high? > > Discussion from December: > http://www.gossamer-threads.

Re: [Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread Sumana Harihareswara
On 06/07/2013 08:43 AM, Asher Feldman wrote: > https://twitter.com/ioerror/status/342922052841377793 > > Why not - would the patrol cost really be too high? Discussion from December: http://www.gossamer-threads.com/lists/wiki/wikitech/323006 "Can we help Tor users make legitimate edits?" -- Sum

Re: [Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread David Gerard
On 7 June 2013 16:43, Asher Feldman wrote: > https://twitter.com/ioerror/status/342922052841377793 > Why not - would the patrol cost really be too high? Are you asking that question as a patroller? If not, then you should probably ask on the wikis first. - d.

[Wikitech-l] Relaxing our TorBlock

2013-06-07 Thread Asher Feldman
https://twitter.com/ioerror/status/342922052841377793 Why not - would the patrol cost really be too high? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] ???!!! ResourceLoader loading extension CSS DYNAMICALLY?!!

2013-06-07 Thread vitalif
Hi! Sorry for not answering via normal Reply, it's because I'm getting messages in digests. But I want to say thanks for clarification and for position=top advice - it's OK with position=top. Thanks :) ___ Wikitech-l mailing list Wikitech-l@lists

Re: [Wikitech-l] Bugzilla: Separate bug report status when patch is in Gerrit?

2013-06-07 Thread Željko Filipin
On Fri, Jun 7, 2013 at 6:24 AM, Matthew Flaschen wrote: > > Also I'm not sure 'Verified' is completely unused... > > I don't generally use it, but I've seen the QA/browser testing team do so. That would probably be only me. :) I can live without "verified". Željko __

Re: [Wikitech-l] Separation of Concerns

2013-06-07 Thread Tyler Romeo
On Fri, Jun 7, 2013 at 2:58 AM, Tim Starling wrote: > I'm recommending making these "groups" of rights be both a UI concept > and a storage concept, very similar to the existing group feature, > rather than storing right grants and somehow bidirectionally mapping > them to group grants in the UI l