Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

Le 13/06/2017 à 07:11, Subramanya Sastry a écrit : > I noticed that core files have @author annotations. > > My take on this is as follows: Any active codebase (such as mediawiki) > sees constant change and code is refactored, rewritten, renamed, files > moved around, split up, etc. that the only

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

On Tue, Jun 13, 2017 at 10:33 AM, Antoine Musso wrote: > Hello, > > Jon Robson opened a task about it a year or so ago: > > "Remove @author lines from code" > https://phabricator.wikimedia.org/T139301 > > MY understanding is that removing the @author @copyright tags in > MediaWiki code represe

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

On Tue, Jun 13, 2017 at 7:11 AM, Subramanya Sastry wrote: > I find these annotations misleading and wonder why they exist and what > purpose they serve. It can sometimes tell you whom to ask for advice or reviews. (git log would too but it's more effort.) ___

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

I am inclined to agree with Subbu, but of course there are legal implications. Zhou said it would be fine to move all these tags to a centralised CREDITS file and point to that file, and that doing so wouldn't breach the licence. He is a lawyer and is therefore qualified to make such determinations

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

There are also some newer initiatives for having a list of contributors that is more prominently featured on the readme or docs, and that also includes other kinds of contributions, not just code creation (docs, design, review, funding, tutorials...). I find the idea very appealing to recognize an

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

Whether moving CREDITS to a centralised file actually solves the problem, rather than just shifting it around, is debatable. I think a centralized credits / contributors file is far better since it recognizes contributions even if those changes have since been all edited / rewritten / deleted.

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

On Jun 13, 2017 6:24 AM, "Gergo Tisza" wrote: On Tue, Jun 13, 2017 at 7:11 AM, Subramanya Sastry wrote: > I find these annotations misleading and wonder why they exist and what > purpose they serve. It can sometimes tell you whom to ask for advice or reviews. (git log would too but it's more

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

On 06/13/2017 10:14 AM, C. Scott Ananian wrote: On Jun 13, 2017 6:24 AM, "Gergo Tisza" wrote: On Tue, Jun 13, 2017 at 7:11 AM, Subramanya Sastry wrote: I find these annotations misleading and wonder why they exist and what purpose they serve. > It can sometimes tell you whom to ask for ad

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

On 06/13/2017 03:33 AM, Antoine Musso wrote: Jon Robson opened a task about it a year or so ago: "Remove @author lines from code" https://phabricator.wikimedia.org/T139301 Aha .. thanks! I was looking at a 2016 code review y'day and noticed my comment about @author there ( https://ger

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

It's the internet, nobody ever really goes away. ;) I will say, this convention makes more sense for a large project like mediawiki core with many contributors; even more so if some of those contributors are volunteers or short-term, since the @author tag can help to track them down absent any lon

[Wikitech-l] ORES service is having trouble

Hey, We are currently having problem with ORES service which sends out time out errors intermittently. More information can be found in https://phabricator.wikimedia.org/T167819 We will let you know when the service is back to full capacity. Best -- Amir Sarabadani Tafreshi Software Engineer (co

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

Hi! > MY understanding is that removing the @author @copyright tags in > MediaWiki code represent ownership of the original code placed under the > GPL. Subsequent modifications being derivative products. But there's no way to verify that the code is indeed an original creation of whoever is list

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

I agree @author tags should be removed and replaced with a mention (or maybe even a new section) in CREDIT file Zppix Volunteer developer for WMF enwp.org/User:Zppix On Jun 13, 2017 3:02 PM, "Stas Malyshev" wrote: > Hi! > > > MY understanding is that removing the @author @copyright tags in > >

Re: [Wikitech-l] @author annotations in files in the mediawiki codebase

Hi! >> > It can sometimes tell you whom to ask for advice or reviews. (git >> log would too but it's more effort.) I feel @author is a bit misleading in this case - if code is refactored/amended, original author that wrote it, possibly 10 years ago, may not be the best person to ask what's going

Re: [Wikitech-l] ORES service is having trouble

Update, Everything is normal now. See the ticket for more details. Sorry for any inconvenience caused by this incident. Best On Jun 13, 2017 11:25 PM, "Amir Tafreshi" wrote: > Hey, > We are currently having problem with ORES service which sends out time out > errors intermittently. More inform

Re: [Wikitech-l] Slower responses with multiple app servers

Some more data, in case anyone can help me figure this out... When running multiple app servers the request for `load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector` often was very long (10-30 seconds). So I did several requests for just this (not as part of a page request) on bo

Re: [Wikitech-l] [AI] ORES service is having trouble

FYI: https://wikitech.wikimedia.org/wiki/Incident_documentation/20170613-ORES On Tue, Jun 13, 2017 at 3:19 PM, Amir Tafreshi < amir.tafreshi_...@wikimedia.de> wrote: > Update, > Everything is normal now. See the ticket for more details. > > Sorry for any inconvenience cause

[Wikitech-l] Update on Discovery Projects

Hi everybody, (With apologies for cross-posting...) You may have seen the recent communication [1 ] about the product and tech tune-up which went live the week of June 5th, 2017. In that communication, we promised an update o

Re: [Wikitech-l] Update on Discovery Projects

Thanks Deb! One question: Does "As needed, assist with individual language Wikipedia’s implementation of mapframe" mean just help support the implementation on the wikis where mapframe is already deployed, or does it mean potentially deploying mapframe to additional wikis? On Tue, Jun 13, 2017 at

Re: [Wikitech-l] [AI] ORES service is having trouble

- 19:24 mutante: scb1001 - killed process 10971 (pdfrendering/electron) This apparently fixed it. I see there is already this https://gerrit.wikimedia.org/r/35 now ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia

Re: [Wikitech-l] [AI] ORES service is having trouble

I checked the pdfrender instances on the other SCB nodes, and some used 7G and 15G respectively. My patch limits this to 2G, which should be enough for normal operation. Memory on the SCB nodes has been tight for a while. I think there are plans to move OCG (which uses the vast bulk of memory) to

Re: [Wikitech-l] Update on Discovery Projects

Hi Ryan, One question: Does "As needed, assist with individual language > Wikipedia’s implementation of mapframe" mean just help support the > implementation on the wikis where mapframe is already deployed, or does it > mean potentially deploying mapframe to additional wikis? ​We don't have the

Re: [Wikitech-l] [AI] ORES service is having trouble

Also ORES is moving to its dedicated nodes: https://phabricator.wikimedia.org/T165171 Best On 14 June 2017 at 03:18, Gabriel Wicke wrote: > I checked the pdfrender instances on the other SCB nodes, and some used 7G > and 15G respectively. My patch limits this to 2G, which should be enough > for