Re: [Wikitech-l] Revoking +2 (Re: who can merge into core/master?)

2012-06-15 Thread Roan Kattouw
On Fri, Jun 15, 2012 at 1:53 PM, Rob Lanphier wrote: > It would also be nice if we didn't have to resort to the nuclear > option to get the point across.  One low-stakes way we can use to make > sure people are more careful is to have some sort of rotating "oops" > award.  At one former job I had,

Re: [Wikitech-l] who can merge into core/master?

2012-06-15 Thread Roan Kattouw
On Fri, Jun 15, 2012 at 8:48 AM, Sumana Harihareswara wrote: >> If i want to be able to commit to extension X. i first have to file a > request on the "developer access" page, and then another request for > "project membership"? on a page that is named "project ownership"? > Membership != ownershi

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On May 25, 2012 10:11 PM, "Derric Atzrott" wrote: > > Ah. That would do it. I had forgotten to mention this, but in > SpecialMasterPlanForm.php I have a line "$wgOut->addModules( > 'ext.MasterPlanForm.core');" but if I need put that in a BeforePageDisplay > hook, that would explain it. > No, the

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 12:47 PM, Derric Atzrott wrote: > I have read the Migration Guide for Extension Developers; I actually still > have it open right now.  It lead me to believe that if I were to do the > following, I could expect to see some sort of result. > > Add the following to the end of

Re: [Wikitech-l] ResourceManager and Javascript in Mediawiki

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 12:32 PM, Derric Atzrott wrote: > I've been doing some reading recently on the MediaWiki wiki about > ResourceManager and how to use it to use JavaScript in MediaWiki extensions. > Perhaps because it is new the documentation is not complete, or perhaps I > just didn't quite

Re: [Wikitech-l] about bots

2012-05-25 Thread Roan Kattouw
On Fri, May 25, 2012 at 11:40 AM, Ryan Kaldari wrote: > The bot flag is rather confusing since edits can be marked as bot edits or > non-bot edits regardless of whether they are actually coming from a bot. The > edit API accepts a 'bot' or 'notbot' parameter and I believe this is what > actually g

Re: [Wikitech-l] Gerrit question: pushing to another branch

2012-05-24 Thread Roan Kattouw
On Wed, May 23, 2012 at 7:06 AM, Antoine Musso wrote: > I think the branch is given as an argument to git-review, aka: > >  git review [BRANCH] > That's right. You can submit to a different branch by running 'git review branchname'. Also, if you create a branch that's gonna stick around for longer

Re: [Wikitech-l] The bugtracker problem, again

2012-05-21 Thread Roan Kattouw
On Mon, May 21, 2012 at 3:17 PM, Tomasz Finc wrote: > On Mon, May 21, 2012 at 2:25 PM, Mark A. Hershberger > wrote: >> The Developer works with the Director to help the Director develop >> reasonable timelines.  Bugzilla's Milestones and the priority within a >> Milestone are especially suited f

Re: [Wikitech-l] [Wmfall] Announcement: Subramanya Sastry joins Wikimedia as Senior Features Software Engineer

2012-05-17 Thread Roan Kattouw
On Thu, May 17, 2012 at 4:25 PM, Terry Chay wrote: > Hello everyone, > > It’s with great pleasure that I’m announcing that Subramanya Sastry is > joining the Wikimedia Foundation as a Senior Features Software Engineer. Our second new team member of the day, yay! Welcome Subbu and James, looking f

Re: [Wikitech-l] reasons for api json callback restrictions

2012-05-16 Thread Roan Kattouw
On Wed, May 16, 2012 at 7:32 PM, Terry Chay wrote: > I thought http://www.mediawiki.org/wiki/Manual:Edit_token protects against > this as it is required for an edit: http://www.mediawiki.org/wiki/API:Edit > Not if you can read the data using the Object/Array constructor hacks you described. The p

Re: [Wikitech-l] reasons for api json callback restrictions

2012-05-16 Thread Roan Kattouw
On Wed, May 16, 2012 at 4:37 PM, Terry Chay wrote: > - jsonp for state changing should be allowed (if it isn't already) since they > require an edit token (shared secret) [QUESTION: is this prevented or is the > API documentation in error? It should be allowed. The edittoken blocks XSSI > and C

Re: [Wikitech-l] Making only some of the pages editable by all

2012-05-15 Thread Roan Kattouw
On May 15, 2012 9:52 PM, "CherianTinu Abraham" wrote: > > I did try to create a new namespace & used $wgNamespaceProtection > > $wgNamespaceProtection[NS_WIKIMEETUPS] = array( '*' ); > > but it is not allowing *anyone* to edit the new namespace, not even the > sysops. > $wgNamespaceProtection work

Re: [Wikitech-l] Howto: Git rebase interactive

2012-05-10 Thread Roan Kattouw
On Thu, May 10, 2012 at 12:19 PM, Jeremy Postlethwaite wrote: > Thanks Roan, > > I updated the documentation. > > Does it matter which Change-Id you pick of your commits? > - Is it best to pick the last over the first or vice-versa? > If they're new commits, it doesn't matter. However, if you're s

Re: [Wikitech-l] Howto: Git rebase interactive

2012-05-10 Thread Roan Kattouw
On Thu, May 10, 2012 at 11:51 AM, Jeremy Postlethwaite wrote: > I added a howto for doing an interactive rebase with git and gerrit: > > https://www.mediawiki.org/wiki/Git/rebase > > If there is anything wrong with this please let me know! > Additionally, you really shouldn't leave multiple Change

Re: [Wikitech-l] Howto: Git rebase interactive

2012-05-10 Thread Roan Kattouw
On Thu, May 10, 2012 at 11:51 AM, Jeremy Postlethwaite wrote: > I added a howto for doing an interactive rebase with git and gerrit: > > https://www.mediawiki.org/wiki/Git/rebase > > If there is anything wrong with this please let me know! > I don't see why you'd run 'git pull origin master' after

Re: [Wikitech-l] Language codes vs site codes

2012-05-08 Thread Roan Kattouw
On Tue, May 8, 2012 at 6:36 PM, Denny Vrandečić wrote: > P.S.: There is one thing I do not understand though. According to > https://simple.wikipedia.org/w/api.php?action=query&meta=siteinfo the > language of simple.wp is "en", but MessagesSimple.php seems to be taken > into account (instead of "e

Re: [Wikitech-l] Guidelines for db schema changes

2012-04-24 Thread Roan Kattouw
On Tue, Apr 24, 2012 at 5:52 PM, Rob Lanphier wrote: > I don't have a strong opinion about whether we need to follow rule #1 > above through an iteration of our six month tarball release cycle, but > we at least need to follow it through the two week deployment cycle. > I think rule #1 is unnecess

[Wikitech-l] Direct pushes to wmf/* branches disabled

2012-04-24 Thread Roan Kattouw
While we were still getting set up with deployments from git/Gerrit, we have allowed deployers to push directly to the wmf/* branches using 'git push origin wmf/1.20wmf1'. This bypasses Gerrit completely, so there is no review (which is usually what we want), but also no e-mail notification, no IRC

Re: [Wikitech-l] git-review wanting to submit lot of changes

2012-04-23 Thread Roan Kattouw
On Fri, Apr 13, 2012 at 1:33 PM, Antoine Musso wrote: > The issue is because your last commit has been done based on a remote > named 'origin' whereas git-review use the remote named 'gerrit'. Since > most people update only the origin remote with git pull, the gerrit > remote is lagging behind.  

Re: [Wikitech-l] [[How to deploy code]] updated

2012-04-18 Thread Roan Kattouw
On Wed, Apr 18, 2012 at 3:57 PM, Platonides wrote: > Release early, release often. It can be committed in ugly format, and be > prettified later (maybe with community help, as I pointed). > Sure, but there will be some effort required to 1) disentangle the private files (even though we can easily

Re: [Wikitech-l] [[How to deploy code]] updated

2012-04-18 Thread Roan Kattouw
On Wed, Apr 18, 2012 at 3:40 PM, Platonides wrote: > Well, "two months" was a random timeframe. I'm not that you had other > things to do. Deployment changes was a good time to include this > wmf-config thing. I also know that there was some block because it > "contains sensitive stuff", I'm a bit

Re: [Wikitech-l] [[How to deploy code]] updated

2012-04-18 Thread Roan Kattouw
On Wed, Apr 18, 2012 at 10:40 AM, Platonides wrote: > What about making (and publishing) a git repo of wikipedia/common? > That would allow > a) Easily reproduce the configuration on wmflabs > b) Distribute cleanup of that messy folder tree. > > Yes, passwords should not be committed. No, waiting

Re: [Wikitech-l] Policy for one ore more new database tables for extensions

2012-04-18 Thread Roan Kattouw
On Tue, Apr 17, 2012 at 8:58 PM, Krinkle wrote: > Who said anything about denormalization[1]? Maybe I'm missing something > here, > but I think we're saying the same thing. > Now that you've elaborated I can tell that we are. It's just that "If you could merge the tables and make it still perform

Re: [Wikitech-l] [[How to deploy code]] updated

2012-04-18 Thread Roan Kattouw
On Apr 17, 2012 10:54 PM, "K. Peachey" wrote: > > Why is this there and not on http://www.mediawiki.org ? > > Because its about the WMF cluster admin and/or documentation and not > MW in general. > And because the documentation for "I just broke mediawiki.org, how do I fix this" shouldn't be on me

[Wikitech-l] [[How to deploy code]] updated

2012-04-17 Thread Roan Kattouw
I have gone through https://wikitech.wikimedia.org/view/How_to_deploy_code and updated it to describe the Magical Git Universe. Specifically, there is a lot of documentation surrounding the submodules that we now use for deploying extensions, and surrounding the process and mechanics of extension d

Re: [Wikitech-l] Policy for one ore more new database tables for extensions

2012-04-17 Thread Roan Kattouw
On Tue, Apr 17, 2012 at 2:37 PM, Martijn Hoekstra wrote: > Am I reading this right as suggesting and encouragement of database > denormalisation in extensions? > Ignore what Krinkle said. We DO NOT encourage denormalization, except where necessary for performance reasons. Your extension should ha

Re: [Wikitech-l] Wikimedia skins directory

2012-04-17 Thread Roan Kattouw
On Mon, Apr 16, 2012 at 9:13 PM, K. Peachey wrote: > I believe "//bits.wikimedia.org/skins/{monobook/main.css}" is setup to > always point to the latest version so that should be alright, but > someone else will need to confirm. > In the Magical World of Continuous Deployments, it'll usually point

Re: [Wikitech-l] When are new Interwiki links rendered ?

2012-04-15 Thread Roan Kattouw
On Sun, Apr 15, 2012 at 11:59 AM, Thomas Gries wrote: > On my MediaWiki 1.20alpha (r114161) I added some new Interwiki > definitions such as geocache = > http://www.geocaching.com/seek/cache_details.aspx?wp=$1 > How did you add these interwiki definitions exactly? Roan __

Re: [Wikitech-l] Patch for gallery tag, review questions.

2012-04-11 Thread Roan Kattouw
On Apr 11, 2012 11:01 PM, "Antoine Musso" wrote: > const EXT_URL_REGEX = > '/^(([\w]+:)?\/\/)?(([\d\w]|%[a-fA-f\d]{2,2})+(:([\d\w]|%[a-fA-f\d]{2,2})+ > )?@)?([\d\w][-\d\w]{0,253}[\d\w]\.)+[\w]{2,4}(:[\d]+)?(\/([-+_~.\d\w]|%[a-fA-f\d]{2,2})*)*(\?(&? > ([-+_~.\d\w]|%[a-fA-f\d]{2,2})=?)*)?(#([-+_~.\d

[Wikitech-l] SyntaxHighlight_GeSHi broken out of the box

2012-04-10 Thread Roan Kattouw
In SVN, SyntaxHighlight had an external for geshi/geshi.php and friends. This is gone in git, so out of the box I now get: Warning: require(geshi/geshi.php): failed to open stream: No such file or directory in /home/catrope/mediawiki/git/extensions/SyntaxHighlight_GeSHi/SyntaxHighlight_GeSHi.class

Re: [Wikitech-l] Interwiki talk page posting

2012-04-10 Thread Roan Kattouw
On Tue, Apr 10, 2012 at 7:24 AM, Niklas Laxström wrote: > Solution 1: > Use the LoadBalancer to open connection to the other wiki. > * Does WikiPage support editing pages on another databases like this? > * This way we culd bypass things like blocked user/protected page > unless we check for those

Re: [Wikitech-l] Daring to consider replacing gerrit (help write gareth)

2012-04-09 Thread Roan Kattouw
On Sun, Apr 8, 2012 at 5:44 AM, Daniel Friesen wrote: > -- tl;dr start -- > We're using gerrit now. And as we use it we all keep running into issues > stemming fundamentally from how gerrit is designed. > > I had an irc discussion with Roan[1] awhile ago tossing around ideas on > how we would writ

Re: [Wikitech-l] Updated 1.20wmf1 deployment schedule - starting April 10

2012-04-06 Thread Roan Kattouw
On Fri, Apr 6, 2012 at 2:16 PM, Chad wrote: > > * We still need to audit the scap/sync scripts to make sure that .git > > folder is being excluded on scap. Roan has started looking at that > > now. > > > > Awesome. > > Done in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114777 , filed

Re: [Wikitech-l] Changes status in Gerrit

2012-04-05 Thread Roan Kattouw
On Thu, Apr 5, 2012 at 11:37 AM, Platonides wrote: > On 05/04/12 20:23, Roan Kattouw wrote: > > This only happens if you click "Publish and Submit", which means "publish > > my comments and attempt to merge the commit". This fails because there is > > no

Re: [Wikitech-l] Changes status in Gerrit

2012-04-05 Thread Roan Kattouw
On Thu, Apr 5, 2012 at 11:20 AM, Platonides wrote: > If you submit a code review for a changeset and not a verification > status (only if it is not verified?), it throws you an error: > > Application Error > > Server Error > > Requires Verified > > I suspect it's a bug and we should ignore it but

Re: [Wikitech-l] Changes status in Gerrit

2012-04-05 Thread Roan Kattouw
On Thu, Apr 5, 2012 at 4:04 AM, Happy Melon wrote: > So basically, in Gerrit, (1 + 1 != 2)...?? :-) > > ...and that's exactly why I said that "+2" is a confusingly named concept in my previous message. Roan ___ Wikitech-l mailing list Wikitech-l@lists.

Re: [Wikitech-l] Changes status in Gerrit

2012-04-04 Thread Roan Kattouw
On Wed, Apr 4, 2012 at 11:55 AM, Antoine Musso wrote: > Dear Gerrit users, > > Gerrit let us flag changes with two fields: > > - Code Review > - Verified > > Anyone is allowed to +1/-1 the Code Review field but only a few people > are allowed to mark a change as Verified. > I have bring back Je

Re: [Wikitech-l] I'd prefer that you didn't submit this

2012-03-29 Thread Roan Kattouw
On Thu, Mar 29, 2012 at 7:07 AM, Chad wrote: > On Thu, Mar 29, 2012 at 9:42 AM, Jon Robson wrote: >> +1 for There is a problem with this patchset, please improve. >> > > Alright, sounds good to me. Thanks for the input everyone. > I'll get this fixed soon. > This was done about an hour ago. Chad

Re: [Wikitech-l] Hackathon Berlin 2012

2012-03-29 Thread Roan Kattouw
On Thu, Mar 29, 2012 at 2:05 PM, Chad wrote: > On Thu, Mar 29, 2012 at 4:57 PM, Thomas Gries wrote: >> Suggestion: git workshop and tutorial @ Hackathon Berlin 2012 >> > > Anyone volunteering to run it? > I'm willing to run it. I'm assuming Antoine and Brion will be there and Ryan Lane might be,

Re: [Wikitech-l] Email addresses for wikimedians

2012-03-29 Thread Roan Kattouw
On Thu, Mar 29, 2012 at 12:45 PM, Michael Movchin wrote: > I think @wikimedia.org should only have staff of wikimedia. So > @wikipedia.org is a great idea. > @wikipedia.org is similarly official-looking, I'm not sure that'll fly. In the SVN days, Chad and I were toying with the idea of giving com

Re: [Wikitech-l] Bits is slow

2012-03-29 Thread Roan Kattouw
On Thu, Mar 29, 2012 at 6:38 AM, Max Semenik wrote: > Significantly slower today from Europe, graphs show a drastic drop at esams > http://is.gd/fKnluM and a raise on pmtpa http://is.gd/sowDb4 > > Can this be fixed? > Peter restarted cp3001, things look much better now. Roan

Re: [Wikitech-l] A very nice error message

2012-03-28 Thread Roan Kattouw
2012/3/28 Roan Kattouw : > That's very weird. Looks like that was an intermittent error while I > was in the middle of deploying a change? > I only see 3 of these in exception.log , so I think it's fine. If this were happening on every page save, we'd be seeing a

Re: [Wikitech-l] A very nice error message

2012-03-28 Thread Roan Kattouw
2012/3/28 Bináris : > Folks, I have never had such an error... > > The page is: > http://hu.wikipedia.org/w/index.php?title=Lyserg_Diethel_%28s%C3%A1m%C3%A1nkir%C3%A1ly%29&action=submit > (It occured during saving.) > > The message (belső hiba means internal error): > Belső hiba > A Wikipédiából, a

Re: [Wikitech-l] Replying to gerrit comments

2012-03-28 Thread Roan Kattouw
On Wed, Mar 28, 2012 at 8:54 AM, Greg Sabino Mullane wrote: > What's the standard way to reply to a comment someone has made > to one of your commits? Nothing was obvious in the interface, so > I just did a "Review" with a score of 0 (obviously :). Drawbacks > to this way: > > * It really shouldn'

Re: [Wikitech-l] Wikimedia and IPv6

2012-03-28 Thread Roan Kattouw
On Wed, Mar 28, 2012 at 8:55 AM, Petr Bena wrote: > Yes I would like to help as well, but it would be nice if you told us, > how. My suggestion is to enable ipv6 on wikimedia labs, and on beta > cluster, so that we can test the mediawiki support for ipv6 there and > let the community of wikimedia

Re: [Wikitech-l] Creating naming conventions for git branches?

2012-03-28 Thread Roan Kattouw
On Wed, Mar 28, 2012 at 1:58 AM, Amir E. Aharoni wrote: > When i use `git review -d' on a change that was in the aforementioned > branch, another branch called "review/amire80/bug/31817" is created, > so i suppose that Gerrit identified the bug number (or maybe somebody > did it manually and i mis

Re: [Wikitech-l] Committing followups: please no --amend

2012-03-27 Thread Roan Kattouw
On Mon, Mar 26, 2012 at 9:50 PM, Tim Starling wrote: > For commits with lots of files, Gerrit's diff interface is too broken > to be useful. It does not provide a compact overview of the change > which is essential for effective review. > > Luckily, there are alternatives, specifically local git c

Re: [Wikitech-l] Caveat: git merge and git cherry-pick don't add "Change-Id" by default

2012-03-26 Thread Roan Kattouw
On Sat, Mar 24, 2012 at 9:21 PM, Marcin Cieslak wrote: > This is normally not a problem for people who are allowed changes > without "Change-Id" to the repository (i.e. trunk gatekeepers), > but this may add some problems for committers at large. > Let me debunk that myth right there: NO ONE is al

Re: [Wikitech-l] MediaWiki core deployments starting in April, and how that might work

2012-03-25 Thread Roan Kattouw
On Mar 22, 2012 3:44 PM, "Rob Lanphier" wrote: > Another possible plan would be to have something *somewhat* closer to > what we have today, with new branches off of trunk for each > deployment, and deployments happening as frequently as weekly. > > master > ├── 1.20wmf01 > ├── 1.20wmf02 > ├── 1.2

Re: [Wikitech-l] Caveat: git merge and git cherry-pick don't add "Change-Id" by default

2012-03-25 Thread Roan Kattouw
On Sat, Mar 24, 2012 at 9:21 PM, Marcin Cieslak wrote: > When playing with moving (cherry picking) commits from master to one > of the release branches (REL1_19) I noticed that "git cherry-pick" > and "git merge" do not invoke "commit-msg" hook and therefore don't > add Change-Id to the commits. >

Re: [Wikitech-l] Code freeze and temporary reverts for Gerrit migration

2012-03-22 Thread Roan Kattouw
On Thu, Mar 22, 2012 at 1:22 AM, Max Semenik wrote: > Well done, Roan! Is there a way to join several related recommits in > Gerrit for easier review? > Not really, unless you do what Antoine said (squash them together and resubmit). Also note that some of the changes I submitted depend on each o

Re: [Wikitech-l] Code freeze and temporary reverts for Gerrit migration

2012-03-21 Thread Roan Kattouw
Now that the Git switchover is complete, this code freeze is lifted. SVN is now locked as far as core and WMF-deployed extensions go, so you can't commit there anymore. New commits for core and deployed extensions are welcome in Gerrit, see also Chad's message. As for the reverts: I ended up rever

Re: [Wikitech-l] Code freeze and temporary reverts for Gerrit migration

2012-03-20 Thread Roan Kattouw
On Tue, Mar 20, 2012 at 4:08 PM, Jeroen De Dauw wrote: > Hey, > >> WMF-deployed extensions > > Does this include extension worked on by WMF people and to be deployed on > WMF wikis? In particular, should I quit committing to Education Program or > can I happily carry on? > This includes extensions

[Wikitech-l] Code freeze and temporary reverts for Gerrit migration

2012-03-20 Thread Roan Kattouw
As you all probably know, the Gerrit migration is going to happen in a little over 24 hours. For the SVN repositories being migrated (core and all WMF-deployed extensions), I am doing three special things today. First, I am identifying all unreviewed revisions and reviewing those that 1) I am capa

Re: [Wikitech-l] enwiki revision schema migration in progress

2012-03-20 Thread Roan Kattouw
On Tue, Mar 20, 2012 at 11:35 AM, Asher Feldman wrote: > How do you feel about a switch to change that behavior (maxlag - 1)? It > would be nice to be continue guiding developers towards throttling API > requests around maxlag without complicating schema migrations by requiring > config deployment

Re: [Wikitech-l] enwiki revision schema migration in progress

2012-03-20 Thread Roan Kattouw
On Tue, Mar 20, 2012 at 7:12 AM, MZMcBride wrote: > Some people have suggested that the current API behavior is intentional. > That is, that having different servers return the same error code is better > than having different servers return an error code or not. I think this is > flawed logic due

Re: [Wikitech-l] StripState question / advice?

2012-03-13 Thread Roan Kattouw
On Tue, Mar 13, 2012 at 1:47 PM, Daniel Barrett wrote: > Any advice on how to structure this? It sounds to me like stripState should have a way to change what a given strip marker's value is after you've already inserted it. That in combination with a hook that runs at the right time (after all th

Re: [Wikitech-l] We need to use git-review - need help packaging for Win/Mac (Gerrit)

2012-03-10 Thread Roan Kattouw
On Sat, Mar 10, 2012 at 7:20 PM, Sumana Harihareswara wrote: > I believe the lack of arbitrary labels/tags on changes is a big workflow > problem.[0]  The current workaround is to use "topic branches" (Gerrit > calls them topics; Git calls them branches).  To do that, you have to > use git-review.

Re: [Wikitech-l] Weird API behavior when getting img thumb url

2012-03-08 Thread Roan Kattouw
On Thu, Mar 8, 2012 at 12:58 PM, Chad wrote: > On Thu, Mar 8, 2012 at 3:51 PM, Roan Kattouw wrote: >> I don't know why this happens, but you really don't need internal API >> requests to get thumbnail URLs. This is much simpler: >> >> $file = wfFindFi

Re: [Wikitech-l] Weird API behavior when getting img thumb url

2012-03-08 Thread Roan Kattouw
On Thu, Mar 8, 2012 at 12:39 PM, Jeroen De Dauw wrote: > Hey, > > I'm seeing some weird behavior and can't figure out what's going on. > > I have some code making a request to the API to obtain the thumb url of an > image: http://dpaste.org/nuOfX/ > > This code is used here, and right now the firs

Re: [Wikitech-l] Git, Gerrit and the coming migration

2012-03-07 Thread Roan Kattouw
On Wed, Mar 7, 2012 at 6:01 AM, Chad wrote: > git-review helps lower some of these barriers since it automatically > rebases against origin/* for you so you get a clean merge on push. > Cherry picking's not that hard, and gerrit actually gives you the command > from the UI to pull the specific pat

Re: [Wikitech-l] Git, Gerrit and the coming migration

2012-03-06 Thread Roan Kattouw
On Tue, Mar 6, 2012 at 3:42 PM, K. Peachey wrote: > One of the major sticking points (that from my understanding is what > the WMF people are hateing on) is the diff views in comparison of CR > to Gerrit, For example we used to have them all display on one page > where as with Gerrit you need to o

Re: [Wikitech-l] Breaking change in 1.18 regarding namespaces and redirects?

2012-03-06 Thread Roan Kattouw
On Tue, Mar 6, 2012 at 12:59 PM, Daniel Barrett wrote: > Since moving to MediaWiki 1.18, several of our extensions that use namespaces > have broken in the following way. Any advice/explanation would be very much > appreciated! (I don't see anything in the release notes.) > > Some of our extensi

Re: [Wikitech-l] Bugzilla Weekly Report

2012-03-06 Thread Roan Kattouw
On Mon, Mar 5, 2012 at 9:24 PM, K. Peachey wrote: > On Tue, Mar 6, 2012 at 10:19 AM, Roan Kattouw wrote: >> Well it's not *still* running, it's been broken plenty of times in the >> meantime :) > > > Wasn't that just the email address becoming unsub'

Re: [Wikitech-l] Bugzilla Weekly Report

2012-03-05 Thread Roan Kattouw
On Mon, Mar 5, 2012 at 1:09 PM, Tomasz Finc wrote: > Given that i wrote it 4 years ago and haven't touched it since. I'm > amazed that its still running ;) > Well it's not *still* running, it's been broken plenty of times in the meantime :) Roan ___ Wi

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-25 Thread Roan Kattouw
On Sat, Feb 25, 2012 at 1:20 AM, Antoine Musso wrote: > Le 25/02/12 00:48, Platonides a écrit : > >> There's no way to treat a set of commits as a bundle? > > > Not really. Each commit is considered by Gerrit as a new change. If you have > a bundle of commits, you either: > >  1) squash them in a

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-24 Thread Roan Kattouw
On Thu, Feb 23, 2012 at 1:43 PM, Antoine Musso wrote: > 2) newbie spamming gerrit > > This happen when you first play with Gerrit. > > In subversion world, whenever you submit a new patch (svn commit) it is > going to be written down in the central repository. You will not be able to > change it,

Re: [Wikitech-l] Caching of pages with time sensitive magic words

2012-02-23 Thread Roan Kattouw
On Thu, Feb 23, 2012 at 1:38 PM, Platonides wrote: > The parser cache expires much earlier in that case. Although we don't > reduce it to lower than one hour due to the presence of such words. > > http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/MagicWord.php?view=markup#l134 > This

Re: [Wikitech-l] Question: Hook:LinkEnd and Title::getNamespace method for internal page ( such as User or User_talk page ) where the target page does not exist

2012-02-22 Thread Roan Kattouw
On Wed, Feb 22, 2012 at 12:28 AM, Thomas Gries wrote: > Basically: > a link on a page like [[Benutzer:Alice]] is not necessarily the same as > [[User:Alice]] (even when the latter exists). > > It depends on the current setting of > > $wgLanguageCode = "en" ; > $wgLanguageCode = "de" ; > (during te

Re: [Wikitech-l] Bugzilla Weekly Report

2012-02-21 Thread Roan Kattouw
On Sun, Feb 19, 2012 at 7:00 PM, reporter wrote: > MediaWiki Bugzilla Report for February 13, 2012 - February 20, 2012 > > Status changes this week > > Bugs NEW               :  304 > Bugs ASSIGNED          :  67 > Bugs REOPENED          :  36 > Bugs RESOLVED          :  428 > 304+67+36 < 428 . I'

Re: [Wikitech-l] Question: Hook:LinkEnd and Title::getNamespace method for internal page ( such as User or User_talk page ) where the target page does not exist

2012-02-21 Thread Roan Kattouw
On Sun, Feb 19, 2012 at 4:05 AM, Thomas Gries wrote: > I suppose that the getNamespace fails in this case, > Perhaps a patch in Linker.php is required to set Namespace already if > the page is non-existent. > I don't think so. Even non-existent Title object must have their namespace set. It's poss

Re: [Wikitech-l] GSoC 2012 Ideas/Projects

2012-02-21 Thread Roan Kattouw
On Mon, Feb 13, 2012 at 5:28 PM, Daniel Friesen wrote: > The idea that login is secure because it's on a separate page than the rest > of the site is actually an old mistake. > If a script is included ANYWHERE on the site on the same domain then it's > possible to inject in some code that will fak

Re: [Wikitech-l] Git + Gerrit is a toughy

2012-02-18 Thread Roan Kattouw
On Sat, Feb 18, 2012 at 2:47 AM, Andrew Otto wrote: > 2. Do I need to rebase every time I push for review? > > I don't quite understand what is going on here.  I've installed git-review > and am using this to push to git.  It does a rebase by default.  I'm not sure > if I should be turning that

Re: [Wikitech-l] Welcome, Jon Robson - Software Developer (Mobile)

2012-02-14 Thread Roan Kattouw
On Mon, Feb 13, 2012 at 8:46 PM, Tomasz Finc wrote: > Greetings all, > > I'm pleased to announce that the mobile team has a new team member. > Jon Robson joins Yuvi, Patrick, Arthur, Phil, and Andre as a core > member of the mobile team. In this role he'll provide the team with > the strong front

Re: [Wikitech-l] Git migration - updated schedule & workflow descriptions

2012-02-12 Thread Roan Kattouw
On Sun, Feb 12, 2012 at 11:36 PM, Roan Kattouw wrote: > LocalisationUpdate has SVN support built-in, but WMF stopped using > that a long time ago due to performance issues. Instead, the wrapper > script that we use to run the LU update on the cluster updates a local > checkou

Re: [Wikitech-l] Git migration - updated schedule & workflow descriptions

2012-02-12 Thread Roan Kattouw
On Sun, Feb 12, 2012 at 7:40 AM, Rob Lanphier wrote: >> Which reminds me, does LocalisationUpdate support git? > > Not yet: > https://bugzilla.wikimedia.org/show_bug.cgi?id=34137 > That bug is not about LocalisationUpdate. LU is not a TranslateWiki tool, it's a WMF-side extension for pulling in up

Re: [Wikitech-l] Git migration - updated schedule & workflow descriptions

2012-02-12 Thread Roan Kattouw
On Sat, Feb 11, 2012 at 5:11 AM, Arthur Richards wrote: > The Wikimedia repository is used by others besides just fundraising, > although the fundraising team is probably its heaviest user. I know that > some folks from Wikimedia Sweden are using it, as is Ryan Faulkner for > community analytics,

Re: [Wikitech-l] MediaWiki 1.19, Resource Loader, Gadgets, and User Scripts

2012-02-09 Thread Roan Kattouw
On Wed, Jan 25, 2012 at 7:35 AM, Rob Lanphier wrote: > A couple of relevant bugs: > Bug 33711 - mw.util.$content is undefined in MediaWiki:Common.js > https://bugzilla.wikimedia.org/show_bug.cgi?id=33711 > > Bug 33746 - Resource Loader should pre-depend on mw.util > https://bugzilla.wikimedia.org/

Re: [Wikitech-l] Proposed removal of some API output formats

2012-02-08 Thread Roan Kattouw
On Wed, Feb 8, 2012 at 11:42 PM, Tim Starling wrote: > What are the other problems? > I'm not sure what Max is referring to, other than the fact that I hate XML (or at least using XML for this API) and generally don't like the fact that we have to support so many formats. As I said on Bugzilla ear

Re: [Wikitech-l] Proposed removal of some API output formats

2012-02-08 Thread Roan Kattouw
On Thu, Feb 9, 2012 at 12:01 AM, bawolff wrote: > If json becomes the new recommended format, does that mean that not > passing a format parameter would result in jsonfm instead of xmlfm? > (Probably not since the jsonfm pretty printer isn't all that pretty at > the moment). > One major problem is

Re: [Wikitech-l] ResourceLoader and IE's stylesheet limits

2012-02-08 Thread Roan Kattouw
On Thu, Oct 13, 2011 at 9:55 PM, Roan Kattouw wrote: >> Our MediaWiki 1.17.0 site recently installed a bunch of extensions that use >> ResourceLoader, such as Extension:WikiEditor. To our surprise, some of our >> site's unrelated CSS styles stopped working. Thi

Re: [Wikitech-l] How to avoid a post-branch code slush (Re: Branch 1.19 on Tuesday, February 6?)

2012-02-08 Thread Roan Kattouw
On Wed, Feb 8, 2012 at 9:17 PM, Rob Lanphier wrote: > We're migrating to Git very soon after this release.  It would really > suck to have a huge pile of unreviewed commits going into trunk.  So, > I'm going to suggest a Git migration strategy that will avoid having a > monsterous backlog.  Instea

Re: [Wikitech-l] Production configs (to ops)

2012-02-01 Thread Roan Kattouw
On Wed, Feb 1, 2012 at 6:49 PM, Ryan Lane wrote: > I still haven't gotten a chance to get to it. There's more involved > than simply sanitizing the files. There's also some puppet work > involved in this, and it isn't really simple to do right. I'll try to > do it on the plane ride to FOSDEM. > I

Re: [Wikitech-l] Production configs (to ops)

2012-02-01 Thread Roan Kattouw
On Wed, Feb 1, 2012 at 3:59 PM, Petr Bena wrote: > Hi folks, > > I requested a configuration file for squid weeks ago, but it seems to be a > bit complicated to remove confidential data from it. I suppose we should > split it to multiple files, having some public and private, and keep the > public

Re: [Wikitech-l] Recommended way to register resources for skins

2012-02-01 Thread Roan Kattouw
On Wed, Feb 1, 2012 at 5:51 AM, Freek Dijkstra wrote: > Hi all, > > I've created a copy of the Vector skin. > What is the recommended way to register resources (for the resource > loader) for a custom skin? > > Vector registers the resources in resources/Resources.php > This is not really well tho

Re: [Wikitech-l] Arbitrary data structures via API

2012-01-31 Thread Roan Kattouw
On Tue, Jan 31, 2012 at 6:10 PM, Neil Kandalgaonkar wrote: > On 1/31/12 8:06 AM, Roan Kattouw wrote: >>  I hate having to continue >> support for XML because it limits the keys you can use in all sorts of >> ways. > > Right. I'm assuming here that the XML serialize

Re: [Wikitech-l] JavaScript profiling

2012-01-31 Thread Roan Kattouw
On Tue, Jan 31, 2012 at 6:09 PM, Daniel Friesen wrote: > On Tue, 31 Jan 2012 08:36:02 -0800, Tei wrote: > >> *Cough* some random article about making js that is not abusing the >> slower parts of the language >> http://www.bcherry.net/talks/js-better-faster  *Cough* >> > Bah, that frankly looks w

Re: [Wikitech-l] Arbitrary data structures via API

2012-01-31 Thread Roan Kattouw
On Tue, Jan 31, 2012 at 5:01 PM, Neil Kandalgaonkar wrote: > Is it supposed to be possible to transmit arbitrary nested data > structures in the API? Or do the format serializers make some > assumptions that limit what we can do? > > I added a change yesterday which returns a complex parse tree vi

Re: [Wikitech-l] JavaScript profiling

2012-01-31 Thread Roan Kattouw
On Tue, Jan 31, 2012 at 2:18 PM, Markus Glaser wrote: > Hi all, > > I am trying to profile the JavaScript bit of an extension I maintain. Is > there any recommended method similar to wfProfileIn/Out in MediaWiki? How do > you do profiling on ResourceLoader? > There is no MediaWiki-side support f

Re: [Wikitech-l] Some questions about #switch

2012-01-30 Thread Roan Kattouw
On Mon, Jan 30, 2012 at 8:13 PM, Helder wrote: > What about ptwikibooks' usage of > https://pt.wikibooks.org/wiki/Template:Lista_de_capítulos/Posterior?action=edit It looks like that finds the current page name in a list of pages, then returns the next one in the list. I can see how that makes sen

Re: [Wikitech-l] Some questions about #switch

2012-01-30 Thread Roan Kattouw
On Mon, Jan 30, 2012 at 3:11 PM, Alex Brollo wrote: > I'm using more and more #switch into templates, it's surprising how many > issues it can solve, and how much large arrays it can manage.  My questions > are: > 1. Is there a reasonable upper limit for the number of #switch options? > 2. Is ther

Re: [Wikitech-l] Private methods in API module(s)

2012-01-26 Thread Roan Kattouw
On Thu, Jan 26, 2012 at 11:00 PM, Daniel Renfro wrote: > I am working on an extension and would like to add some functionality to the > 'usercontribs' api module (api/ApiQueryUserContributions.) I cannot subclass > the ApiQueryUserContributions class and get the functionality I want because > t

Re: [Wikitech-l] Magic word for user language?

2012-01-26 Thread Roan Kattouw
On Thu, Jan 26, 2012 at 10:29 PM, Max Semenik wrote: > Does anyone mind if I create a magic word for current user's language? > It will not fragment parser cache further than it is already because > we already support {{int:}}. Note that this functionality is already > emulatable with perversions

Re: [Wikitech-l] Congratulations and thanks

2012-01-22 Thread Roan Kattouw
On Thu, Jan 19, 2012 at 4:46 AM, William Allen Simpson wrote: > I'm a Firefox HTTPS-Everywhere and NoScript kinda guy, and had no > problems switching back and forth by turning scripts on and off. > Both wikipedia and wikimedia js had to be turned on, though  Why? > Probably because most of th

Re: [Wikitech-l] Escaping messages

2012-01-22 Thread Roan Kattouw
On Mon, Jan 16, 2012 at 7:22 PM, Jeroen De Dauw wrote: > Hey, > > Do we trust that messages do not have evil (XSS) stuff in them? The reason > why I ask is that I was just using .msg from mediawiki.jqueryMsg, and > realized that things in the message do not get escaped. Since the function > can ta

Re: [Wikitech-l] SOPA banner implementation

2012-01-16 Thread Roan Kattouw
On Tue, Jan 17, 2012 at 7:20 AM, Dan Collins wrote: > So, is anything interesting going to happen when Google suddenly > realizes that all of our pages are nothing but a SOPA banner? > When the Italians did their blackout, Google asked us to block them (!) from bits.wm.o (our JS/CSS domain), which

Re: [Wikitech-l] Please Welcome Andre Engels

2012-01-12 Thread Roan Kattouw
On 1/12/12, Tomasz Finc wrote: > Greetings all, > > I'm pleased to announce that Andre Engles has decided to join the Mobile > team as our data analyst contractor. In this role he'll provide the mobile > team with key metrics to guide our software development efforts. He'll be > working closely wi

Re: [Wikitech-l] JS load order, or: how to load a gadget before all others.

2012-01-11 Thread Roan Kattouw
On Wed, Jan 11, 2012 at 12:19 PM, Daniel Kinzler wrote: >  $.holdReady(true); >  mediaWiki.loader.load("https://toolserver.org/~netaction/wikitrust.js";); > > Note that this will disable all gadgets and custom scripts: $.holdReady(true) > is > a hack to prevent other user scripts from running. Th

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-04 Thread Roan Kattouw
On Wed, Jan 4, 2012 at 6:44 AM, John Vandenberg wrote: > On Wed, Jan 4, 2012 at 10:51 AM, Platonides wrote: >> Thanks Roan. It's also interesting to learn about that clause. > > I agree.  I asked whether WMF had something like this > http://lists.wikimedia.org/pipermail/foundation-l/2011-August/0

Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki

2012-01-03 Thread Roan Kattouw
On Tue, Jan 3, 2012 at 11:49 PM, K. Peachey wrote: > I'm pretty sure we can't assume anything with licensing, The uploader > must state the license they want it to be under. > If something is uploaded by a WMF employee or contractor and was produced in the course of their work for WMF, you can pro

<    1   2   3   4   5   6   7   8   9   >