[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added, and revision status changed

2011-11-05 Thread MediaWiki Mail
User Jpostlethwaite changed the status of MediaWiki.r100942. Old Status: fixme New Status: new User Jpostlethwaite also posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c2 Commit summary: Added GlobalCollectTestAdapter for testing

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-11-05 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25556 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: This maps to the test adapter.

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c24998 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Awesome. You may want to consider adding back in some of the

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c24999 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Also: Is this object being used anywhere yet? I see the last time

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25003 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Yes it is being used to signal which adapter to test.

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25004 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: I agree with you that we need to keep that separate for

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25008 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Yeah, I see that, but I also see predefine(

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Khorn (WMF) posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25009 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: I am totally going to argue with you on this one, particularly if

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25013 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: The way I am doing it now, it is not hitting there servers. We

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25014 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: i do not attempt to connect to GlobalCollect. We only run:

[MediaWiki-CodeReview] [MediaWiki r100942]: New comment added

2011-10-27 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25015 Commit summary: Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: This is safe and necessary to test. I have no intention of