User "Yuvipanda" posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19427
Commit summary:
Added Global statistics support
Comment:
Dammit, whining doesn't seem to get me anywhere. Will fix.
___
User "^demon" posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19425
Commit summary:
Added Global statistics support
Comment:
No, it's the way we format our code :)
___
MediaWiki-CodeReview m
User "Yuvipanda" posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19424
Commit summary:
Added Global statistics support
Comment:
Ow, isn't !$ kinda weird? Is there any particular reasoning for this? Doesn't
the ! get lost with the $?
User "Reedy" posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19423
Commit summary:
Added Global statistics support
Comment:
1 very minor issue is
if(! $is_new_rating ) {
Should really be
if( !$is_new_rating ) {
The other is the
