Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-28 Thread Gergo Tisza
On Sat, Apr 28, 2018 at 2:19 AM, Tyler Cipriani wrote: > Looking at this info maybe 6 is the magic number? > Other options would be to have more windows (an EU morning SWAT maybe?), and/or make it less of an expectation to have your patches deployed in the window you

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-28 Thread Martin Urbanec
so 28. 4. 2018 v 0:05 odesílatel Greg Grossmeier napsal: > > > ie. if the new policy was introduced at the start of the year, it would > > have caused at least a two-week delay in all three SWAT windows at one > > point at least, and it would have caused an ever-growing

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Tyler Cipriani
On 18-04-27 21:00:35, Gergo Tisza wrote: On Fri, Apr 27, 2018 at 7:05 PM, Niharika Kohli wrote: Also, I think dropping the limit to 4 patches per window is extreme, especially if we are asking people to start splitting their patches now. Very often we can +2 multiple

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Greg Grossmeier
> ie. if the new policy was introduced at the start of the year, it would > have caused at least a two-week delay in all three SWAT windows at one > point at least, and it would have caused an ever-growing backlog of patches > for EU mid-day. 2 week delays aren't possible as all SWATs are

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Chad
On Fri, Apr 27, 2018 at 12:42 PM Stas Malyshev wrote: > Hi! > > > The new policy asks the folks submitting patches to split up patches to > > avoid bad intermediate states ahead of time. > > Thank you Tyler for the explanation! Which means this patch needs to be > split

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Stas Malyshev
Hi! > The new policy asks the folks submitting patches to split up patches to > avoid bad intermediate states ahead of time. Thank you Tyler for the explanation! Which means this patch needs to be split into several patches? Giving the lower limit of the patches, this becomes kinda challenging -

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Tyler Cipriani
On 18-04-27 10:49:28, Stas Malyshev wrote: Hi! First, we now disallow multi-sync patch deployments. See T187761[0]. This means that the sync order of files is determined by git commit parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT deployers from accidentally syncing

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Gergo Tisza
On Fri, Apr 27, 2018 at 7:05 PM, Niharika Kohli wrote: > Also, I think dropping the limit to 4 patches per window is extreme, > especially if we are asking people to start splitting their patches now. > Very often we can +2 multiple patches in one go if they don't affect

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Stas Malyshev
Hi! > First, we now disallow multi-sync patch deployments. See T187761[0]. > This means that the sync order of files is determined by git commit > parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT > deployers from accidentally syncing two patches in the wrong order.

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Niharika Kohli
On Fri, Apr 27, 2018 at 8:51 AM, Roan Kattouw wrote: > Will multi-file, single-directory syncs still be allowed? In other words, > can I deploy a change to the Foo extension that touches many files with > scap sync-dir extension/Foo ? > According to the task description,

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Roan Kattouw
Will multi-file, single-directory syncs still be allowed? In other words, can I deploy a change to the Foo extension that touches many files with scap sync-dir extension/Foo ? On Thu, Apr 26, 2018, 15:15 Greg Grossmeier wrote: > Hello, > > I have made two changes to SWAT

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Brad Jorsch (Anomie)
On Thu, Apr 26, 2018 at 6:14 PM, Greg Grossmeier wrote: > First, we now disallow multi-sync patch deployments. See T187761[0]. > This means that the sync order of files is determined by git commit > parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT >