[Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Victor Vasiliev
On 10/11/2012 09:56 AM, Daniel Kinzler wrote: On 10.10.2012 23:37, Rob Lanphier wrote: I'm very worried about converting all of the extensions to use new APIs now. If it turns out we need to revert ContentHandler, this will make the revert that much more difficult. I'd rather we remove

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Rob Lanphier
On Thu, Oct 11, 2012 at 10:03 AM, Victor Vasiliev vasi...@gmail.com wrote: I think instead of using individual constant, we should finally introduce a Capabilities class. It should have a single static method, has(), which indicates whether a certain capability is registered within the

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Chad
On Thu, Oct 11, 2012 at 1:25 PM, Rob Lanphier ro...@wikimedia.org wrote: Some bikeshedding: I'm a little concerned with using the term Capabilities, since I generally hear that term more frequently in designing software security models: http://en.wikipedia.org/wiki/Capability-based_security

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Jeroen De Dauw
Hey, Interesting idea. A few suggestions: * Having static methods to access this is nice and convenient, but perhaps we can make a singleton with instance methods such as hasFeature and static methods such as has that then just do return self::singleton()-hasFeature() * Having an array with

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Tim Starling
On 12/10/12 04:03, Victor Vasiliev wrote: I think instead of using individual constant, we should finally introduce a Capabilities class. It should have a single static method, has(), which indicates whether a certain capability is registered within the system. At the beginning,

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Tyler Romeo
I do not think, design-wise, this is a good idea. In addition to what Tim said, extensions would become needlessly complex if we started accounting for every possible MediaWiki feature that's added in a given release. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Victor Vasiliev
On 10/11/2012 08:33 PM, Tim Starling wrote: Then you would have to load a capability map with potentially hundreds of entries at registration time, despite the fact that on most requests, most of the hooks will never be called. It seems inefficient to me. At least with the current system, the

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Victor Vasiliev
On 10/11/2012 10:30 PM, Tyler Romeo wrote: I do not think, design-wise, this is a good idea. In addition to what Tim said, extensions would become needlessly complex if we started accounting for every possible MediaWiki feature that's added in a given release. Not every possible, only those of

Re: [Wikitech-l] Capabilities class (was Re: Make Extensions Aware of the ContentHandler)

2012-10-11 Thread Dmitriy Sintsov
12 Октябрь 2012 г. 7:23:19 пользователь Victor Vasiliev (vasi...@gmail.com) написал: On 10/11/2012 08:33 PM, Tim Starling wrote: Then you would have to load a capability map with potentially hundreds of entries at registration time, despite the fact that on most requests, most of the