> Good point. Rather than simply simplifying that kind of case we could add
> to the $wgProfiler array a callback functionality that can return a
> boolean on whether to start the profiler.
Or which one to start, because, um, we start different ones.
Domas
___
On Tue, 27 Dec 2011 23:36:53 -0800, Domas Mituzas
wrote:
>> We could try to simplify those kind of common cases.
>
> Yet there are cases that are not so common - "start profiler for this
> page", "for this ip", "for this wiki", "for this query string", etc.
> Where would that belong?
>
> Doma
> We could try to simplify those kind of common cases.
Yet there are cases that are not so common - "start profiler for this page",
"for this ip", "for this wiki", "for this query string", etc.
Where would that belong?
Domas
___
Wikitech-l mailing lis
On 28/12/11 14:52, Daniel Friesen wrote:
> So, we're not actually running the profiler within LocalSettings.php or
> anywhere before it.
>
> ((And if we really wanted to do that, I'd almost argue for a setup where
> wfProfilerIn will queue up a deferred list of profiling entries and then
> w
On Tue, 27 Dec 2011 19:02:29 -0800, Tim Starling
wrote:
> On 28/12/11 13:53, Daniel Friesen wrote:
>> The typical thing to go into StartProfiler.php for someone who wants to
>> use it is:
>> $wgProfiler['class'] = 'Profiler';
>>
>> ;) ie: It's pure config, it's not even php code.
>
> That's bec
On 28/12/11 13:53, Daniel Friesen wrote:
> The typical thing to go into StartProfiler.php for someone who wants to
> use it is:
> $wgProfiler['class'] = 'Profiler';
>
> ;) ie: It's pure config, it's not even php code.
That's because the actual starting of the profiler happens after
StartProfile
On Tue, 27 Dec 2011 18:06:41 -0800, Tim Starling
wrote:
> On 26/12/11 09:20, Daniel Friesen wrote:
>> The support requests for users with "PHP Fatal error: Cannot redeclare
>> wfProfileIn()" continue in #mediawiki.
>>
>> My idea on how to fix the issue previously was to include in 1.18.1
>> (w
On 26/12/11 09:20, Daniel Friesen wrote:
> The support requests for users with "PHP Fatal error: Cannot redeclare
> wfProfileIn()" continue in #mediawiki.
>
> My idea on how to fix the issue previously was to include in 1.18.1
> (whenever we release it) an includes/ProfilerStub.php with something
The support requests for users with "PHP Fatal error: Cannot redeclare
wfProfileIn()" continue in #mediawiki.
My idea on how to fix the issue previously was to include in 1.18.1
(whenever we release it) an includes/ProfilerStub.php with something like:
http://daniel.friesen.name]
___
