Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-30 Thread James Forrester
As a note, this has been merged and will go out with wmf2; I've added it to Tech/News 41. J. On 29 September 2014 23:37, dan entous wrote: > +1 > > On Sep 29, 2014, at 19:38 , James Forrester > wrote: > > > On 28 September 2014 20:17, Jackmcbarn wrote: > > > >> Scribunto has an option to allo

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread dan entous
+1 On Sep 29, 2014, at 19:38 , James Forrester wrote: > On 28 September 2014 20:17, Jackmcbarn wrote: > >> Scribunto has an option to allow code to be saved even if it contains >> syntax errors that prevent it from ever working. The original reason for >> this feature was to make it more conve

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread MZMcBride
Jackmcbarn wrote: >There are no false positives at all, since it tests it by actually loading >it into Lua. Does the checkbox currently only allow overriding the type of error that would completely prevent execution of a module? I encounter a lot of code linters and syntax highlighters that mess u

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread Jackmcbarn
There are no false positives at all, since it tests it by actually loading it into Lua. I think a total disallow is warranted because letting the page be saved with such an error means that the entire module is 100% useless (and will break every page that uses it) until someone fixes it. Jackmcba

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread MZMcBride
Jackmcbarn wrote: >Scribunto has an option to allow code to be saved even if it contains >syntax errors that prevent it from ever working. The original reason for >this feature was to make it more convenient to save incomplete code. >However, in practice, this has never been used for its intended p

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread Jackmcbarn
Very little. Currently, enwiki has one broken module [ https://en.wikipedia.org/wiki/Category:Scribunto_modules_with_errors] and dewiki has none [ https://de.wikipedia.org/wiki/Kategorie:Wikipedia:Modul_mit_Syntaxfehler]. On Mon, Sep 29, 2014 at 2:16 PM, David Gerard wrote: > So how much broken

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread David Gerard
So how much broken Lua is out there in the wild on WMF wikis? On 29 September 2014 01:17, Jackmcbarn wrote: > Scribunto has an option to allow code to be saved even if it contains > syntax errors that prevent it from ever working. The original reason for > this feature was to make it more conveni

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread Florian Schmidt
. September 2014 19:38 An: Wikimedia developers Betreff: Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option On 28 September 2014 20:17, Jackmcbarn wrote: > Scribunto has an option to allow code to be saved even if it contains > syntax errors that

Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-29 Thread James Forrester
On 28 September 2014 20:17, Jackmcbarn wrote: > Scribunto has an option to allow code to be saved even if it contains > syntax errors that prevent it from ever working. The original reason for > this feature was to make it more convenient to save incomplete code. > However, in practice, this has

[Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option

2014-09-28 Thread Jackmcbarn
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who