Re: [Wikitech-l] Request for checking two patches on Gerrit

2020-08-06 Thread Zoran Dori
Hello everyone, > With all due respect but i believe it does not scale to use this > mailing list to ping for individual code reviews. > Some peoples have done this in the past, and I wanted to do this also, because of reasons which I've already provided. Yes, we really need to fix the issue

Re: [Wikitech-l] Request for checking two patches on Gerrit

2020-08-04 Thread Gergo Tisza
On Mon, Aug 3, 2020 at 7:40 PM Daniel Zahn wrote: > With all due respect but i believe it does not scale to use this > mailing list to ping for individual code reviews. Yes, we really need > to fix the issue that getting reviews is too hard and too many users > seem to filter Gerrit mail but

Re: [Wikitech-l] Request for checking two patches on Gerrit

2020-08-03 Thread Daniel Zahn
With all due respect but i believe it does not scale to use this mailing list to ping for individual code reviews. Yes, we really need to fix the issue that getting reviews is too hard and too many users seem to filter Gerrit mail but moving that to "everyone gets mail about all changes" does not

Re: [Wikitech-l] Request for checking two patches on Gerrit

2020-08-02 Thread Zoran Dori
Hello again, I mean on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaFunctions/+/588778 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NaturalLanguageList/+/589902 . I personally think that these patches can (should) get +2, because the objections have been resolved and I

Re: [Wikitech-l] Request for checking two patches on Gerrit

2020-08-02 Thread Andre Klapper
Heja, On Sun, 2020-08-02 at 01:05 +0200, Zoran Dori wrote: > can you check last two patches from this URL: > https://gerrit.wikimedia.org/r/q/status:open+owner:zorandori%2540gmail.com+extension+registration That URL lists 17 patches and sorting might be different (what's "last"?). Please be

[Wikitech-l] Request for checking two patches on Gerrit

2020-08-01 Thread Zoran Dori
Hello, can you check last two patches from this URL: https://gerrit.wikimedia.org/r/q/status:open+owner:zorandori%2540gmail.com+extension+registration ? As tests pass now, I believe that they are good to get +2 now. Best regards, Zoran Dori volunteer, Wikimedia Serbia s: kizule.xyz e: