Re: [Wikitech-l] Skin system rewrite

2010-02-12 Thread Tim Starling
Dmitriy Sintsov wrote: > If I understand correctly, current js2-work branch will be a base for > 1.17? No, not really. > Is there any way to make old MonoBook derived skins to be > compatible with js2 code? The js2-work branch doesn't delete anything, it's just a ton of new code. > I have l

Re: [Wikitech-l] Skin system rewrite

2010-02-12 Thread Dmitriy Sintsov
* Siebrand Mazeland [Thu, 11 Feb 2010 16:04:56 +0100]: > If this is merged after the 1.16 branching, and support for old skins > would be dropped from 1.17 on, you'll be able to use the old skinning > system up to EOL of 1.16 as a supported version, expected somewhere > around March 2011 or a few

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Conrad Irwin
On 02/11/2010 03:28 PM, Jack Phoenix wrote: > Skin system rewrite currently supports old, SkinTemplate/QuickTemplate-based > skins. For example, Vector uses SkinTemplate and QuickTemplate and it works > well -- but as noted earlier, it won't support some of the new features > (SkinAfterSidebar hook

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Jack Phoenix
Skin system rewrite currently supports old, SkinTemplate/QuickTemplate-based skins. For example, Vector uses SkinTemplate and QuickTemplate and it works well -- but as noted earlier, it won't support some of the new features (SkinAfterSidebar hook and whatever else we may add in the future) until i

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Aryeh Gregor
On Thu, Feb 11, 2010 at 9:51 AM, Conrad Irwin wrote: > This is great, just one question though - will "old-style" skins still > be supported (for a few versions at least)? I have a dozen or so skins > that currently work, it would be an absolute nightmare if I have to > upgrade them all when Media

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Siebrand Mazeland
bject: Re: [Wikitech-l] Skin system rewrite This is great, just one question though - will "old-style" skins still be supported (for a few versions at least)? I have a dozen or so skins that currently work, it would be an absolute nightmare if I have to upgrade them all when MediaWiki swa

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Conrad Irwin
On 02/11/2010 02:31 PM, Jack Phoenix wrote: > Wow, this sparked quite a discussion -- I'm pleased to hear that so many > people are interested in reworking MW's skin system to make it better! :-) > > As per Tim's request, I've created a branch for this in r62304 and applied > the initial patch in

Re: [Wikitech-l] Skin system rewrite

2010-02-11 Thread Jack Phoenix
Wow, this sparked quite a discussion -- I'm pleased to hear that so many people are interested in reworking MW's skin system to make it better! :-) As per Tim's request, I've created a branch for this in r62304 and applied the initial patch in r62306. Feel free to check out the branch[1] and submi

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Siebrand Mazeland
6:36 AM To: Wikimedia developers Subject: Re: [Wikitech-l] Skin system rewrite jack, I would suggest if you don't already have SVN access then to request it on wiki(1), Then if/when you get it create a (or ask someone to do it for you) branch and start working on and then more people can hel

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread K. Peachey
On Tue, Feb 9, 2010 at 6:58 AM, Jack Phoenix wrote: > Hi all, ... > Jack Phoenix jack, I would suggest if you don't already have SVN access then to request it on wiki(1), Then if/when you get it create a (or ask someone to do it for you) branch and start working on and then more people can help an

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Aryeh Gregor
On Wed, Feb 10, 2010 at 8:03 PM, Trevor Parscal wrote: > Not all changes made in the HTML output of Vector were made arbitrarily > or gratuitously as is being assumed here. No one was assuming that. I pointed out several differences that *are* gratuitous, in that they do not provide any function

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Trevor Parscal
On 2/10/10 3:50 PM, Platonides wrote: > Aryeh Gregor wrote: > >> On Tue, Feb 9, 2010 at 8:35 PM, Trevor Parscal >> wrote: >> >>> Merging Monobook and Modern is actually a good point for one of my other >>> ideas, which is to have themes for skins. In other words, same HTML >>> generatio

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Platonides
Aryeh Gregor wrote: > On Tue, Feb 9, 2010 at 8:35 PM, Trevor Parscal wrote: >> Merging Monobook and Modern is actually a good point for one of my other >> ideas, which is to have themes for skins. In other words, same HTML >> generation, different CSS. Then Monobook and Modern could naturally be >

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Trevor Parscal
On 2/10/10 6:55 AM, Roan Kattouw wrote: > 2010/2/10 Aryeh Gregor: > >> I'm also concerned by the fact that at least some (I haven't looked >> closely) of the Usability Initiative stuff seems to work only in >> Vector. For instance, apparently EditWarning doesn't work at all in >> non-Vector sk

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread David Gerard
On 10 February 2010 14:45, Aryeh Gregor wrote: > That means 6% aren't, i.e., ~700,000 users.  That's actually much > higher than I expected.  It would be particularly silly to throw out > Chick, Simple, and MySkin, since those differ from Monobook only in > CSS. > I don't think we should get rid

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Roan Kattouw
2010/2/10 Aryeh Gregor : > I'm also concerned by the fact that at least some (I haven't looked > closely) of the Usability Initiative stuff seems to work only in > Vector.  For instance, apparently EditWarning doesn't work at all in > non-Vector skins, although it's surely just as applicable.  Skin

Re: [Wikitech-l] Skin system rewrite

2010-02-10 Thread Aryeh Gregor
On Tue, Feb 9, 2010 at 7:30 PM, Trevor Parscal wrote: > Why only Monobook and Vector? 94%[1] of users on English Wikipedia are > currently using one of them. That means 6% aren't, i.e., ~700,000 users. That's actually much higher than I expected. It would be particularly silly to throw out Chic

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Tim Starling
Jack Phoenix wrote: > I haven't ported Vector skin to use this new system because it's currently > under development. Because this change is quite a big one, I thought that > I'll commit it to SVN once MediaWiki 1.16 has been released so that it'll > make into the 1.17 release. Commit it to a bran

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Trevor Parscal
On 2/9/10 4:54 PM, Chad wrote: > On Tue, Feb 9, 2010 at 7:30 PM, Trevor Parscal wrote: > >> On 2/9/10 4:07 PM, Aryeh Gregor wrote: >> >>> On Tue, Feb 9, 2010 at 4:56 PM, Platonideswrote: >>> >>> We will be glad to have you on it, Trevor. Rewriting the skin system is

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Chad
On Tue, Feb 9, 2010 at 7:30 PM, Trevor Parscal wrote: > On 2/9/10 4:07 PM, Aryeh Gregor wrote: >> On Tue, Feb 9, 2010 at 4:56 PM, Platonides  wrote: >> >>> We will be glad to have you on it, Trevor. Rewriting the skin system is >>> not urgent, although I would like to have a newskin compatible vec

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Trevor Parscal
On 2/9/10 4:07 PM, Aryeh Gregor wrote: > On Tue, Feb 9, 2010 at 4:56 PM, Platonides wrote: > >> We will be glad to have you on it, Trevor. Rewriting the skin system is >> not urgent, although I would like to have a newskin compatible vector >> skin before releasing 1.16. This way, we wouldn't

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Aryeh Gregor
On Tue, Feb 9, 2010 at 4:56 PM, Platonides wrote: > We will be glad to have you on it, Trevor. Rewriting the skin system is > not urgent, although I would like to have a newskin compatible vector > skin before releasing 1.16. This way, we wouldn't be forced to support > an old vector design. Sinc

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Platonides
Trevor Parscal wrote: > I've been very busy with deployments, so I've been waiting to talk here, > but I think that there are allot of considerations for a skinning system > that I could help shed some light on when I get some time (maybe next > week?). The Usability Initiative's last hard deadl

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Aryeh Gregor
On Tue, Feb 9, 2010 at 1:58 PM, Jack Phoenix wrote: > Not yet at least, the indentation/newlines aren't consistent yet. Then > again, Brion removed some unnecessary whitespace in r55496 for JavaScript > variables in , so I dunno how important it is to have everything > indented properly in the HTM

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Trevor Parscal
On 2/9/10 10:58 AM, Jack Phoenix wrote: > On Mon, Feb 8, 2010 at 11:16 PM, Roan Kattouwwrote: > > >> Not any more, the Vector skin itself has been stable for months. All >> the usability work is currently done in the UsabilityInitiative >> extension. >> > > Ah, good to know. I must admit

Re: [Wikitech-l] Skin system rewrite

2010-02-09 Thread Jack Phoenix
On Mon, Feb 8, 2010 at 11:16 PM, Roan Kattouw wrote: > Not any more, the Vector skin itself has been stable for months. All > the usability work is currently done in the UsabilityInitiative > extension. Ah, good to know. I must admit that Vector's code is a bit more complicated than your average

Re: [Wikitech-l] Skin system rewrite

2010-02-08 Thread Aryeh Gregor
On Mon, Feb 8, 2010 at 3:58 PM, Jack Phoenix wrote: > MediaWiki's skin system has been quite a mess for some while. I decided to > try rewriting it and you can see the end result on [1]. It's quite a big > patch, which is why I want to encourage all developers to test it and report > (or maybe eve

Re: [Wikitech-l] Skin system rewrite

2010-02-08 Thread Platonides
Roan Kattouw wrote: > 2010/2/8 Jack Phoenix: >> Hi all, >> >> MediaWiki's skin system has been quite a mess for some while. I decided to >> try rewriting it > AWESOME! Someone finally took up this task :D > >> and you can see the end result on [1]. It's quite a big >> patch, which is why I want to

Re: [Wikitech-l] Skin system rewrite

2010-02-08 Thread Roan Kattouw
2010/2/8 Jack Phoenix : > Hi all, > > MediaWiki's skin system has been quite a mess for some while. I decided to > try rewriting it AWESOME! Someone finally took up this task :D > and you can see the end result on [1]. It's quite a big > patch, which is why I want to encourage all developers to te

[Wikitech-l] Skin system rewrite

2010-02-08 Thread Jack Phoenix
Hi all, MediaWiki's skin system has been quite a mess for some while. I decided to try rewriting it and you can see the end result on [1]. It's quite a big patch, which is why I want to encourage all developers to test it and report (or maybe even fix? :) any and all issues they stumble across. Th